sock: struct proto hash function may error
In order to support fast reuseport lookups in TCP, the hash function defined in struct proto must be capable of returning an error code. This patch changes the function signature of all related hash functions to return an integer and handles or propagates this return value at all call sites. Signed-off-by: Craig Gallek <kraig@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
30c1de08dd
commit
086c653f58
@@ -182,12 +182,14 @@ static int ieee802154_sock_ioctl(struct socket *sock, unsigned int cmd,
|
||||
static HLIST_HEAD(raw_head);
|
||||
static DEFINE_RWLOCK(raw_lock);
|
||||
|
||||
static void raw_hash(struct sock *sk)
|
||||
static int raw_hash(struct sock *sk)
|
||||
{
|
||||
write_lock_bh(&raw_lock);
|
||||
sk_add_node(sk, &raw_head);
|
||||
sock_prot_inuse_add(sock_net(sk), sk->sk_prot, 1);
|
||||
write_unlock_bh(&raw_lock);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static void raw_unhash(struct sock *sk)
|
||||
@@ -462,12 +464,14 @@ static inline struct dgram_sock *dgram_sk(const struct sock *sk)
|
||||
return container_of(sk, struct dgram_sock, sk);
|
||||
}
|
||||
|
||||
static void dgram_hash(struct sock *sk)
|
||||
static int dgram_hash(struct sock *sk)
|
||||
{
|
||||
write_lock_bh(&dgram_lock);
|
||||
sk_add_node(sk, &dgram_head);
|
||||
sock_prot_inuse_add(sock_net(sk), sk->sk_prot, 1);
|
||||
write_unlock_bh(&dgram_lock);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static void dgram_unhash(struct sock *sk)
|
||||
@@ -1026,8 +1030,13 @@ static int ieee802154_create(struct net *net, struct socket *sock,
|
||||
/* Checksums on by default */
|
||||
sock_set_flag(sk, SOCK_ZAPPED);
|
||||
|
||||
if (sk->sk_prot->hash)
|
||||
sk->sk_prot->hash(sk);
|
||||
if (sk->sk_prot->hash) {
|
||||
rc = sk->sk_prot->hash(sk);
|
||||
if (rc) {
|
||||
sk_common_release(sk);
|
||||
goto out;
|
||||
}
|
||||
}
|
||||
|
||||
if (sk->sk_prot->init) {
|
||||
rc = sk->sk_prot->init(sk);
|
||||
|
Reference in New Issue
Block a user