nfs4: renewd renew operations should take/put a client reference
renewd sends RENEW requests to the NFS server in order to renew state. As the request is asynchronous, renewd should take a reference to the nfs_client to prevent concurrent umounts from freeing the client Signed-off-by: Alexandros Batsakis <batsakis@netapp.com> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
This commit is contained in:

committed by
Trond Myklebust

parent
7135840fc7
commit
0851de0617
@@ -3152,7 +3152,9 @@ static void nfs4_renew_release(void *data)
|
|||||||
{
|
{
|
||||||
struct nfs_client *clp = data;
|
struct nfs_client *clp = data;
|
||||||
|
|
||||||
|
if (atomic_read(&clp->cl_count) > 1)
|
||||||
nfs4_schedule_state_renewal(clp);
|
nfs4_schedule_state_renewal(clp);
|
||||||
|
nfs_put_client(clp);
|
||||||
}
|
}
|
||||||
|
|
||||||
static void nfs4_renew_done(struct rpc_task *task, void *data)
|
static void nfs4_renew_done(struct rpc_task *task, void *data)
|
||||||
@@ -3185,6 +3187,8 @@ int nfs4_proc_async_renew(struct nfs_client *clp, struct rpc_cred *cred)
|
|||||||
.rpc_cred = cred,
|
.rpc_cred = cred,
|
||||||
};
|
};
|
||||||
|
|
||||||
|
if (!atomic_inc_not_zero(&clp->cl_count))
|
||||||
|
return -EIO;
|
||||||
return rpc_call_async(clp->cl_rpcclient, &msg, RPC_TASK_SOFT,
|
return rpc_call_async(clp->cl_rpcclient, &msg, RPC_TASK_SOFT,
|
||||||
&nfs4_renew_ops, clp);
|
&nfs4_renew_ops, clp);
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user