[CRYPTO] Use standard byte order macros wherever possible
A lot of crypto code needs to read/write a 32-bit/64-bit words in a specific gender. Many of them open code them by reading/writing one byte at a time. This patch converts all the applicable usages over to use the standard byte order macros. This is based on a previous patch by Denis Vlasenko. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:

committed by
David S. Miller

parent
2df15fffc6
commit
06ace7a9ba
@@ -22,8 +22,10 @@
|
||||
#include <linux/init.h>
|
||||
#include <linux/module.h>
|
||||
#include <linux/mm.h>
|
||||
#include <asm/byteorder.h>
|
||||
#include <asm/scatterlist.h>
|
||||
#include <linux/crypto.h>
|
||||
#include <linux/types.h>
|
||||
|
||||
#define KHAZAD_KEY_SIZE 16
|
||||
#define KHAZAD_BLOCK_SIZE 8
|
||||
@@ -755,8 +757,8 @@ static const u64 c[KHAZAD_ROUNDS + 1] = {
|
||||
static int khazad_setkey(void *ctx_arg, const u8 *in_key,
|
||||
unsigned int key_len, u32 *flags)
|
||||
{
|
||||
|
||||
struct khazad_ctx *ctx = ctx_arg;
|
||||
const __be64 *key = (const __be64 *)in_key;
|
||||
int r;
|
||||
const u64 *S = T7;
|
||||
u64 K2, K1;
|
||||
@@ -767,22 +769,8 @@ static int khazad_setkey(void *ctx_arg, const u8 *in_key,
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
K2 = ((u64)in_key[ 0] << 56) ^
|
||||
((u64)in_key[ 1] << 48) ^
|
||||
((u64)in_key[ 2] << 40) ^
|
||||
((u64)in_key[ 3] << 32) ^
|
||||
((u64)in_key[ 4] << 24) ^
|
||||
((u64)in_key[ 5] << 16) ^
|
||||
((u64)in_key[ 6] << 8) ^
|
||||
((u64)in_key[ 7] );
|
||||
K1 = ((u64)in_key[ 8] << 56) ^
|
||||
((u64)in_key[ 9] << 48) ^
|
||||
((u64)in_key[10] << 40) ^
|
||||
((u64)in_key[11] << 32) ^
|
||||
((u64)in_key[12] << 24) ^
|
||||
((u64)in_key[13] << 16) ^
|
||||
((u64)in_key[14] << 8) ^
|
||||
((u64)in_key[15] );
|
||||
K2 = be64_to_cpu(key[0]);
|
||||
K1 = be64_to_cpu(key[1]);
|
||||
|
||||
/* setup the encrypt key */
|
||||
for (r = 0; r <= KHAZAD_ROUNDS; r++) {
|
||||
@@ -820,19 +808,12 @@ static int khazad_setkey(void *ctx_arg, const u8 *in_key,
|
||||
static void khazad_crypt(const u64 roundKey[KHAZAD_ROUNDS + 1],
|
||||
u8 *ciphertext, const u8 *plaintext)
|
||||
{
|
||||
|
||||
const __be64 *src = (const __be64 *)plaintext;
|
||||
__be64 *dst = (__be64 *)ciphertext;
|
||||
int r;
|
||||
u64 state;
|
||||
|
||||
state = ((u64)plaintext[0] << 56) ^
|
||||
((u64)plaintext[1] << 48) ^
|
||||
((u64)plaintext[2] << 40) ^
|
||||
((u64)plaintext[3] << 32) ^
|
||||
((u64)plaintext[4] << 24) ^
|
||||
((u64)plaintext[5] << 16) ^
|
||||
((u64)plaintext[6] << 8) ^
|
||||
((u64)plaintext[7] ) ^
|
||||
roundKey[0];
|
||||
state = be64_to_cpu(*src) ^ roundKey[0];
|
||||
|
||||
for (r = 1; r < KHAZAD_ROUNDS; r++) {
|
||||
state = T0[(int)(state >> 56) ] ^
|
||||
@@ -856,15 +837,7 @@ static void khazad_crypt(const u64 roundKey[KHAZAD_ROUNDS + 1],
|
||||
(T7[(int)(state ) & 0xff] & 0x00000000000000ffULL) ^
|
||||
roundKey[KHAZAD_ROUNDS];
|
||||
|
||||
ciphertext[0] = (u8)(state >> 56);
|
||||
ciphertext[1] = (u8)(state >> 48);
|
||||
ciphertext[2] = (u8)(state >> 40);
|
||||
ciphertext[3] = (u8)(state >> 32);
|
||||
ciphertext[4] = (u8)(state >> 24);
|
||||
ciphertext[5] = (u8)(state >> 16);
|
||||
ciphertext[6] = (u8)(state >> 8);
|
||||
ciphertext[7] = (u8)(state );
|
||||
|
||||
*dst = cpu_to_be64(state);
|
||||
}
|
||||
|
||||
static void khazad_encrypt(void *ctx_arg, u8 *dst, const u8 *src)
|
||||
|
Reference in New Issue
Block a user