ath10k: implement diag data container event
Some firmware revisions may report this event as part of their diagnostics. This avoids `unknown event` warnings and adds tracing for the event. Signed-off-by: Michal Kazior <michal.kazior@tieto.com> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
このコミットが含まれているのは:
@@ -60,6 +60,8 @@ static const struct wmi_tlv_policy wmi_tlv_policies[] = {
|
||||
= { .min_len = sizeof(struct wmi_tlv_rdy_ev) },
|
||||
[WMI_TLV_TAG_STRUCT_OFFLOAD_BCN_TX_STATUS_EVENT]
|
||||
= { .min_len = sizeof(struct wmi_tlv_bcn_tx_status_ev) },
|
||||
[WMI_TLV_TAG_STRUCT_DIAG_DATA_CONTAINER_EVENT]
|
||||
= { .min_len = sizeof(struct wmi_tlv_diag_data_ev) },
|
||||
};
|
||||
|
||||
static int
|
||||
@@ -203,6 +205,69 @@ static int ath10k_wmi_tlv_event_bcn_tx_status(struct ath10k *ar,
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int ath10k_wmi_tlv_event_diag_data(struct ath10k *ar,
|
||||
struct sk_buff *skb)
|
||||
{
|
||||
const void **tb;
|
||||
const struct wmi_tlv_diag_data_ev *ev;
|
||||
const struct wmi_tlv_diag_item *item;
|
||||
const void *data;
|
||||
int ret, num_items, len;
|
||||
|
||||
tb = ath10k_wmi_tlv_parse_alloc(ar, skb->data, skb->len, GFP_ATOMIC);
|
||||
if (IS_ERR(tb)) {
|
||||
ret = PTR_ERR(tb);
|
||||
ath10k_warn(ar, "failed to parse tlv: %d\n", ret);
|
||||
return ret;
|
||||
}
|
||||
|
||||
ev = tb[WMI_TLV_TAG_STRUCT_DIAG_DATA_CONTAINER_EVENT];
|
||||
data = tb[WMI_TLV_TAG_ARRAY_BYTE];
|
||||
if (!ev || !data) {
|
||||
kfree(tb);
|
||||
return -EPROTO;
|
||||
}
|
||||
|
||||
num_items = __le32_to_cpu(ev->num_items);
|
||||
len = ath10k_wmi_tlv_len(data);
|
||||
|
||||
while (num_items--) {
|
||||
if (len == 0)
|
||||
break;
|
||||
if (len < sizeof(*item)) {
|
||||
ath10k_warn(ar, "failed to parse diag data: can't fit item header\n");
|
||||
break;
|
||||
}
|
||||
|
||||
item = data;
|
||||
|
||||
if (len < sizeof(*item) + __le16_to_cpu(item->len)) {
|
||||
ath10k_warn(ar, "failed to parse diag data: item is too long\n");
|
||||
break;
|
||||
}
|
||||
|
||||
trace_ath10k_wmi_diag_container(ar,
|
||||
item->type,
|
||||
__le32_to_cpu(item->timestamp),
|
||||
__le32_to_cpu(item->code),
|
||||
__le16_to_cpu(item->len),
|
||||
item->payload);
|
||||
|
||||
len -= sizeof(*item);
|
||||
len -= roundup(__le16_to_cpu(item->len), 4);
|
||||
|
||||
data += sizeof(*item);
|
||||
data += roundup(__le16_to_cpu(item->len), 4);
|
||||
}
|
||||
|
||||
if (num_items != -1 || len != 0)
|
||||
ath10k_warn(ar, "failed to parse diag data event: num_items %d len %d\n",
|
||||
num_items, len);
|
||||
|
||||
kfree(tb);
|
||||
return 0;
|
||||
}
|
||||
|
||||
/***********/
|
||||
/* TLV ops */
|
||||
/***********/
|
||||
@@ -318,6 +383,9 @@ static void ath10k_wmi_tlv_op_rx(struct ath10k *ar, struct sk_buff *skb)
|
||||
case WMI_TLV_OFFLOAD_BCN_TX_STATUS_EVENTID:
|
||||
ath10k_wmi_tlv_event_bcn_tx_status(ar, skb);
|
||||
break;
|
||||
case WMI_TLV_DIAG_DATA_CONTAINER_EVENTID:
|
||||
ath10k_wmi_tlv_event_diag_data(ar, skb);
|
||||
break;
|
||||
default:
|
||||
ath10k_warn(ar, "Unknown eventid: %d\n", id);
|
||||
break;
|
||||
|
新しいイシューから参照
ユーザーをブロックする