perf tools: Introduce zfree
For the frequent idiom of: free(ptr); ptr = NULL; Make it expect a pointer to the pointer being freed, so that it becomes clear at first sight that the variable being freed is being modified. Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: David Ahern <dsahern@gmail.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Link: http://lkml.kernel.org/n/tip-pfw02ezuab37kha18wlut7ir@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
@@ -185,8 +185,7 @@ static int lock__parse(struct ins_operands *ops)
|
||||
return 0;
|
||||
|
||||
out_free_ops:
|
||||
free(ops->locked.ops);
|
||||
ops->locked.ops = NULL;
|
||||
zfree(&ops->locked.ops);
|
||||
return 0;
|
||||
}
|
||||
|
||||
@@ -256,8 +255,7 @@ static int mov__parse(struct ins_operands *ops)
|
||||
return 0;
|
||||
|
||||
out_free_source:
|
||||
free(ops->source.raw);
|
||||
ops->source.raw = NULL;
|
||||
zfree(&ops->source.raw);
|
||||
return -1;
|
||||
}
|
||||
|
||||
@@ -560,8 +558,7 @@ static int disasm_line__parse(char *line, char **namep, char **rawp)
|
||||
return 0;
|
||||
|
||||
out_free_name:
|
||||
free(*namep);
|
||||
*namep = NULL;
|
||||
zfree(namep);
|
||||
return -1;
|
||||
}
|
||||
|
||||
@@ -1113,8 +1110,7 @@ static void symbol__free_source_line(struct symbol *sym, int len)
|
||||
src_line = (void *)src_line + sizeof_src_line;
|
||||
}
|
||||
|
||||
free(notes->src->lines);
|
||||
notes->src->lines = NULL;
|
||||
zfree(¬es->src->lines);
|
||||
}
|
||||
|
||||
/* Get the filename:line for the colored entries */
|
||||
|
Reference in New Issue
Block a user