Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
Fun set of conflict resolutions here... For the mac80211 stuff, these were fortunately just parallel adds. Trivially resolved. In drivers/net/phy/phy.c we had a bug fix in 'net' that moved the function phy_disable_interrupts() earlier in the file, whilst in 'net-next' the phy_error() call from this function was removed. In net/ipv4/xfrm4_policy.c, David Ahern's changes to remove the 'rt_table_id' member of rtable collided with a bug fix in 'net' that added a new struct member "rt_mtu_locked" which needs to be copied over here. The mlxsw driver conflict consisted of net-next separating the span code and definitions into separate files, whilst a 'net' bug fix made some changes to that moved code. The mlx5 infiniband conflict resolution was quite non-trivial, the RDMA tree's merge commit was used as a guide here, and here are their notes: ==================== Due to bug fixes found by the syzkaller bot and taken into the for-rc branch after development for the 4.17 merge window had already started being taken into the for-next branch, there were fairly non-trivial merge issues that would need to be resolved between the for-rc branch and the for-next branch. This merge resolves those conflicts and provides a unified base upon which ongoing development for 4.17 can be based. Conflicts: drivers/infiniband/hw/mlx5/main.c - Commit42cea83f95
(IB/mlx5: Fix cleanup order on unload) added to for-rc and commitb5ca15ad7e
(IB/mlx5: Add proper representors support) add as part of the devel cycle both needed to modify the init/de-init functions used by mlx5. To support the new representors, the new functions added by the cleanup patch needed to be made non-static, and the init/de-init list added by the representors patch needed to be modified to match the init/de-init list changes made by the cleanup patch. Updates: drivers/infiniband/hw/mlx5/mlx5_ib.h - Update function prototypes added by representors patch to reflect new function names as changed by cleanup patch drivers/infiniband/hw/mlx5/ib_rep.c - Update init/de-init stage list to match new order from cleanup patch ==================== Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
@@ -106,6 +106,7 @@ int sctp_rcv(struct sk_buff *skb)
|
||||
int family;
|
||||
struct sctp_af *af;
|
||||
struct net *net = dev_net(skb->dev);
|
||||
bool is_gso = skb_is_gso(skb) && skb_is_gso_sctp(skb);
|
||||
|
||||
if (skb->pkt_type != PACKET_HOST)
|
||||
goto discard_it;
|
||||
@@ -123,8 +124,7 @@ int sctp_rcv(struct sk_buff *skb)
|
||||
* it's better to just linearize it otherwise crc computing
|
||||
* takes longer.
|
||||
*/
|
||||
if ((!(skb_shinfo(skb)->gso_type & SKB_GSO_SCTP) &&
|
||||
skb_linearize(skb)) ||
|
||||
if ((!is_gso && skb_linearize(skb)) ||
|
||||
!pskb_may_pull(skb, sizeof(struct sctphdr)))
|
||||
goto discard_it;
|
||||
|
||||
@@ -135,7 +135,7 @@ int sctp_rcv(struct sk_buff *skb)
|
||||
if (skb_csum_unnecessary(skb))
|
||||
__skb_decr_checksum_unnecessary(skb);
|
||||
else if (!sctp_checksum_disable &&
|
||||
!(skb_shinfo(skb)->gso_type & SKB_GSO_SCTP) &&
|
||||
!is_gso &&
|
||||
sctp_rcv_checksum(net, skb) < 0)
|
||||
goto discard_it;
|
||||
skb->csum_valid = 1;
|
||||
@@ -1218,7 +1218,7 @@ static struct sctp_association *__sctp_rcv_lookup_harder(struct net *net,
|
||||
* issue as packets hitting this are mostly INIT or INIT-ACK and
|
||||
* those cannot be on GSO-style anyway.
|
||||
*/
|
||||
if ((skb_shinfo(skb)->gso_type & SKB_GSO_SCTP) == SKB_GSO_SCTP)
|
||||
if (skb_is_gso(skb) && skb_is_gso_sctp(skb))
|
||||
return NULL;
|
||||
|
||||
ch = (struct sctp_chunkhdr *)skb->data;
|
||||
|
@@ -170,7 +170,7 @@ next_chunk:
|
||||
|
||||
chunk = list_entry(entry, struct sctp_chunk, list);
|
||||
|
||||
if ((skb_shinfo(chunk->skb)->gso_type & SKB_GSO_SCTP) == SKB_GSO_SCTP) {
|
||||
if (skb_is_gso(chunk->skb) && skb_is_gso_sctp(chunk->skb)) {
|
||||
/* GSO-marked skbs but without frags, handle
|
||||
* them normally
|
||||
*/
|
||||
|
@@ -45,7 +45,7 @@ static struct sk_buff *sctp_gso_segment(struct sk_buff *skb,
|
||||
struct sk_buff *segs = ERR_PTR(-EINVAL);
|
||||
struct sctphdr *sh;
|
||||
|
||||
if (!(skb_shinfo(skb)->gso_type & SKB_GSO_SCTP))
|
||||
if (!skb_is_gso_sctp(skb))
|
||||
goto out;
|
||||
|
||||
sh = sctp_hdr(skb);
|
||||
|
Reference in New Issue
Block a user