Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
Fun set of conflict resolutions here...
For the mac80211 stuff, these were fortunately just parallel
adds. Trivially resolved.
In drivers/net/phy/phy.c we had a bug fix in 'net' that moved the
function phy_disable_interrupts() earlier in the file, whilst in
'net-next' the phy_error() call from this function was removed.
In net/ipv4/xfrm4_policy.c, David Ahern's changes to remove the
'rt_table_id' member of rtable collided with a bug fix in 'net' that
added a new struct member "rt_mtu_locked" which needs to be copied
over here.
The mlxsw driver conflict consisted of net-next separating
the span code and definitions into separate files, whilst
a 'net' bug fix made some changes to that moved code.
The mlx5 infiniband conflict resolution was quite non-trivial,
the RDMA tree's merge commit was used as a guide here, and
here are their notes:
====================
Due to bug fixes found by the syzkaller bot and taken into the for-rc
branch after development for the 4.17 merge window had already started
being taken into the for-next branch, there were fairly non-trivial
merge issues that would need to be resolved between the for-rc branch
and the for-next branch. This merge resolves those conflicts and
provides a unified base upon which ongoing development for 4.17 can
be based.
Conflicts:
drivers/infiniband/hw/mlx5/main.c - Commit 42cea83f95
(IB/mlx5: Fix cleanup order on unload) added to for-rc and
commit b5ca15ad7e (IB/mlx5: Add proper representors support)
add as part of the devel cycle both needed to modify the
init/de-init functions used by mlx5. To support the new
representors, the new functions added by the cleanup patch
needed to be made non-static, and the init/de-init list
added by the representors patch needed to be modified to
match the init/de-init list changes made by the cleanup
patch.
Updates:
drivers/infiniband/hw/mlx5/mlx5_ib.h - Update function
prototypes added by representors patch to reflect new function
names as changed by cleanup patch
drivers/infiniband/hw/mlx5/ib_rep.c - Update init/de-init
stage list to match new order from cleanup patch
====================
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
@@ -3278,15 +3278,23 @@ static inline int __dev_xmit_skb(struct sk_buff *skb, struct Qdisc *q,
|
||||
#if IS_ENABLED(CONFIG_CGROUP_NET_PRIO)
|
||||
static void skb_update_prio(struct sk_buff *skb)
|
||||
{
|
||||
struct netprio_map *map = rcu_dereference_bh(skb->dev->priomap);
|
||||
const struct netprio_map *map;
|
||||
const struct sock *sk;
|
||||
unsigned int prioidx;
|
||||
|
||||
if (!skb->priority && skb->sk && map) {
|
||||
unsigned int prioidx =
|
||||
sock_cgroup_prioidx(&skb->sk->sk_cgrp_data);
|
||||
if (skb->priority)
|
||||
return;
|
||||
map = rcu_dereference_bh(skb->dev->priomap);
|
||||
if (!map)
|
||||
return;
|
||||
sk = skb_to_full_sk(skb);
|
||||
if (!sk)
|
||||
return;
|
||||
|
||||
if (prioidx < map->priomap_len)
|
||||
skb->priority = map->priomap[prioidx];
|
||||
}
|
||||
prioidx = sock_cgroup_prioidx(&sk->sk_cgrp_data);
|
||||
|
||||
if (prioidx < map->priomap_len)
|
||||
skb->priority = map->priomap[prioidx];
|
||||
}
|
||||
#else
|
||||
#define skb_update_prio(skb)
|
||||
|
||||
@@ -402,8 +402,6 @@ int dev_ioctl(struct net *net, unsigned int cmd, struct ifreq *ifr, bool *need_c
|
||||
if (colon)
|
||||
*colon = 0;
|
||||
|
||||
dev_load(net, ifr->ifr_name);
|
||||
|
||||
/*
|
||||
* See which interface the caller is talking about.
|
||||
*/
|
||||
@@ -423,6 +421,7 @@ int dev_ioctl(struct net *net, unsigned int cmd, struct ifreq *ifr, bool *need_c
|
||||
case SIOCGIFMAP:
|
||||
case SIOCGIFINDEX:
|
||||
case SIOCGIFTXQLEN:
|
||||
dev_load(net, ifr->ifr_name);
|
||||
rcu_read_lock();
|
||||
ret = dev_ifsioc_locked(net, ifr, cmd);
|
||||
rcu_read_unlock();
|
||||
@@ -431,6 +430,7 @@ int dev_ioctl(struct net *net, unsigned int cmd, struct ifreq *ifr, bool *need_c
|
||||
return ret;
|
||||
|
||||
case SIOCETHTOOL:
|
||||
dev_load(net, ifr->ifr_name);
|
||||
rtnl_lock();
|
||||
ret = dev_ethtool(net, ifr);
|
||||
rtnl_unlock();
|
||||
@@ -447,6 +447,7 @@ int dev_ioctl(struct net *net, unsigned int cmd, struct ifreq *ifr, bool *need_c
|
||||
case SIOCGMIIPHY:
|
||||
case SIOCGMIIREG:
|
||||
case SIOCSIFNAME:
|
||||
dev_load(net, ifr->ifr_name);
|
||||
if (!ns_capable(net->user_ns, CAP_NET_ADMIN))
|
||||
return -EPERM;
|
||||
rtnl_lock();
|
||||
@@ -494,6 +495,7 @@ int dev_ioctl(struct net *net, unsigned int cmd, struct ifreq *ifr, bool *need_c
|
||||
/* fall through */
|
||||
case SIOCBONDSLAVEINFOQUERY:
|
||||
case SIOCBONDINFOQUERY:
|
||||
dev_load(net, ifr->ifr_name);
|
||||
rtnl_lock();
|
||||
ret = dev_ifsioc(net, ifr, cmd);
|
||||
rtnl_unlock();
|
||||
@@ -518,6 +520,7 @@ int dev_ioctl(struct net *net, unsigned int cmd, struct ifreq *ifr, bool *need_c
|
||||
cmd == SIOCGHWTSTAMP ||
|
||||
(cmd >= SIOCDEVPRIVATE &&
|
||||
cmd <= SIOCDEVPRIVATE + 15)) {
|
||||
dev_load(net, ifr->ifr_name);
|
||||
rtnl_lock();
|
||||
ret = dev_ifsioc(net, ifr, cmd);
|
||||
rtnl_unlock();
|
||||
|
||||
@@ -1798,7 +1798,7 @@ send_done:
|
||||
if (!nlh) {
|
||||
err = devlink_dpipe_send_and_alloc_skb(&skb, info);
|
||||
if (err)
|
||||
goto err_skb_send_alloc;
|
||||
return err;
|
||||
goto send_done;
|
||||
}
|
||||
|
||||
@@ -1807,7 +1807,6 @@ send_done:
|
||||
nla_put_failure:
|
||||
err = -EMSGSIZE;
|
||||
err_table_put:
|
||||
err_skb_send_alloc:
|
||||
genlmsg_cancel(skb, hdr);
|
||||
nlmsg_free(skb);
|
||||
return err;
|
||||
@@ -2073,7 +2072,7 @@ static int devlink_dpipe_entries_fill(struct genl_info *info,
|
||||
table->counters_enabled,
|
||||
&dump_ctx);
|
||||
if (err)
|
||||
goto err_entries_dump;
|
||||
return err;
|
||||
|
||||
send_done:
|
||||
nlh = nlmsg_put(dump_ctx.skb, info->snd_portid, info->snd_seq,
|
||||
@@ -2081,16 +2080,10 @@ send_done:
|
||||
if (!nlh) {
|
||||
err = devlink_dpipe_send_and_alloc_skb(&dump_ctx.skb, info);
|
||||
if (err)
|
||||
goto err_skb_send_alloc;
|
||||
return err;
|
||||
goto send_done;
|
||||
}
|
||||
return genlmsg_reply(dump_ctx.skb, info);
|
||||
|
||||
err_entries_dump:
|
||||
err_skb_send_alloc:
|
||||
genlmsg_cancel(dump_ctx.skb, dump_ctx.hdr);
|
||||
nlmsg_free(dump_ctx.skb);
|
||||
return err;
|
||||
}
|
||||
|
||||
static int devlink_nl_cmd_dpipe_entries_get(struct sk_buff *skb,
|
||||
@@ -2229,7 +2222,7 @@ send_done:
|
||||
if (!nlh) {
|
||||
err = devlink_dpipe_send_and_alloc_skb(&skb, info);
|
||||
if (err)
|
||||
goto err_skb_send_alloc;
|
||||
return err;
|
||||
goto send_done;
|
||||
}
|
||||
return genlmsg_reply(skb, info);
|
||||
@@ -2237,7 +2230,6 @@ send_done:
|
||||
nla_put_failure:
|
||||
err = -EMSGSIZE;
|
||||
err_table_put:
|
||||
err_skb_send_alloc:
|
||||
genlmsg_cancel(skb, hdr);
|
||||
nlmsg_free(skb);
|
||||
return err;
|
||||
|
||||
@@ -2283,6 +2283,10 @@ static int bpf_skb_proto_4_to_6(struct sk_buff *skb)
|
||||
u32 off = skb_mac_header_len(skb);
|
||||
int ret;
|
||||
|
||||
/* SCTP uses GSO_BY_FRAGS, thus cannot adjust it. */
|
||||
if (skb_is_gso(skb) && unlikely(skb_is_gso_sctp(skb)))
|
||||
return -ENOTSUPP;
|
||||
|
||||
ret = skb_cow(skb, len_diff);
|
||||
if (unlikely(ret < 0))
|
||||
return ret;
|
||||
@@ -2292,19 +2296,21 @@ static int bpf_skb_proto_4_to_6(struct sk_buff *skb)
|
||||
return ret;
|
||||
|
||||
if (skb_is_gso(skb)) {
|
||||
struct skb_shared_info *shinfo = skb_shinfo(skb);
|
||||
|
||||
/* SKB_GSO_TCPV4 needs to be changed into
|
||||
* SKB_GSO_TCPV6.
|
||||
*/
|
||||
if (skb_shinfo(skb)->gso_type & SKB_GSO_TCPV4) {
|
||||
skb_shinfo(skb)->gso_type &= ~SKB_GSO_TCPV4;
|
||||
skb_shinfo(skb)->gso_type |= SKB_GSO_TCPV6;
|
||||
if (shinfo->gso_type & SKB_GSO_TCPV4) {
|
||||
shinfo->gso_type &= ~SKB_GSO_TCPV4;
|
||||
shinfo->gso_type |= SKB_GSO_TCPV6;
|
||||
}
|
||||
|
||||
/* Due to IPv6 header, MSS needs to be downgraded. */
|
||||
skb_shinfo(skb)->gso_size -= len_diff;
|
||||
skb_decrease_gso_size(shinfo, len_diff);
|
||||
/* Header must be checked, and gso_segs recomputed. */
|
||||
skb_shinfo(skb)->gso_type |= SKB_GSO_DODGY;
|
||||
skb_shinfo(skb)->gso_segs = 0;
|
||||
shinfo->gso_type |= SKB_GSO_DODGY;
|
||||
shinfo->gso_segs = 0;
|
||||
}
|
||||
|
||||
skb->protocol = htons(ETH_P_IPV6);
|
||||
@@ -2319,6 +2325,10 @@ static int bpf_skb_proto_6_to_4(struct sk_buff *skb)
|
||||
u32 off = skb_mac_header_len(skb);
|
||||
int ret;
|
||||
|
||||
/* SCTP uses GSO_BY_FRAGS, thus cannot adjust it. */
|
||||
if (skb_is_gso(skb) && unlikely(skb_is_gso_sctp(skb)))
|
||||
return -ENOTSUPP;
|
||||
|
||||
ret = skb_unclone(skb, GFP_ATOMIC);
|
||||
if (unlikely(ret < 0))
|
||||
return ret;
|
||||
@@ -2328,19 +2338,21 @@ static int bpf_skb_proto_6_to_4(struct sk_buff *skb)
|
||||
return ret;
|
||||
|
||||
if (skb_is_gso(skb)) {
|
||||
struct skb_shared_info *shinfo = skb_shinfo(skb);
|
||||
|
||||
/* SKB_GSO_TCPV6 needs to be changed into
|
||||
* SKB_GSO_TCPV4.
|
||||
*/
|
||||
if (skb_shinfo(skb)->gso_type & SKB_GSO_TCPV6) {
|
||||
skb_shinfo(skb)->gso_type &= ~SKB_GSO_TCPV6;
|
||||
skb_shinfo(skb)->gso_type |= SKB_GSO_TCPV4;
|
||||
if (shinfo->gso_type & SKB_GSO_TCPV6) {
|
||||
shinfo->gso_type &= ~SKB_GSO_TCPV6;
|
||||
shinfo->gso_type |= SKB_GSO_TCPV4;
|
||||
}
|
||||
|
||||
/* Due to IPv4 header, MSS can be upgraded. */
|
||||
skb_shinfo(skb)->gso_size += len_diff;
|
||||
skb_increase_gso_size(shinfo, len_diff);
|
||||
/* Header must be checked, and gso_segs recomputed. */
|
||||
skb_shinfo(skb)->gso_type |= SKB_GSO_DODGY;
|
||||
skb_shinfo(skb)->gso_segs = 0;
|
||||
shinfo->gso_type |= SKB_GSO_DODGY;
|
||||
shinfo->gso_segs = 0;
|
||||
}
|
||||
|
||||
skb->protocol = htons(ETH_P_IP);
|
||||
@@ -2439,6 +2451,10 @@ static int bpf_skb_net_grow(struct sk_buff *skb, u32 len_diff)
|
||||
u32 off = skb_mac_header_len(skb) + bpf_skb_net_base_len(skb);
|
||||
int ret;
|
||||
|
||||
/* SCTP uses GSO_BY_FRAGS, thus cannot adjust it. */
|
||||
if (skb_is_gso(skb) && unlikely(skb_is_gso_sctp(skb)))
|
||||
return -ENOTSUPP;
|
||||
|
||||
ret = skb_cow(skb, len_diff);
|
||||
if (unlikely(ret < 0))
|
||||
return ret;
|
||||
@@ -2448,11 +2464,13 @@ static int bpf_skb_net_grow(struct sk_buff *skb, u32 len_diff)
|
||||
return ret;
|
||||
|
||||
if (skb_is_gso(skb)) {
|
||||
struct skb_shared_info *shinfo = skb_shinfo(skb);
|
||||
|
||||
/* Due to header grow, MSS needs to be downgraded. */
|
||||
skb_shinfo(skb)->gso_size -= len_diff;
|
||||
skb_decrease_gso_size(shinfo, len_diff);
|
||||
/* Header must be checked, and gso_segs recomputed. */
|
||||
skb_shinfo(skb)->gso_type |= SKB_GSO_DODGY;
|
||||
skb_shinfo(skb)->gso_segs = 0;
|
||||
shinfo->gso_type |= SKB_GSO_DODGY;
|
||||
shinfo->gso_segs = 0;
|
||||
}
|
||||
|
||||
return 0;
|
||||
@@ -2463,6 +2481,10 @@ static int bpf_skb_net_shrink(struct sk_buff *skb, u32 len_diff)
|
||||
u32 off = skb_mac_header_len(skb) + bpf_skb_net_base_len(skb);
|
||||
int ret;
|
||||
|
||||
/* SCTP uses GSO_BY_FRAGS, thus cannot adjust it. */
|
||||
if (skb_is_gso(skb) && unlikely(skb_is_gso_sctp(skb)))
|
||||
return -ENOTSUPP;
|
||||
|
||||
ret = skb_unclone(skb, GFP_ATOMIC);
|
||||
if (unlikely(ret < 0))
|
||||
return ret;
|
||||
@@ -2472,11 +2494,13 @@ static int bpf_skb_net_shrink(struct sk_buff *skb, u32 len_diff)
|
||||
return ret;
|
||||
|
||||
if (skb_is_gso(skb)) {
|
||||
struct skb_shared_info *shinfo = skb_shinfo(skb);
|
||||
|
||||
/* Due to header shrink, MSS can be upgraded. */
|
||||
skb_shinfo(skb)->gso_size += len_diff;
|
||||
skb_increase_gso_size(shinfo, len_diff);
|
||||
/* Header must be checked, and gso_segs recomputed. */
|
||||
skb_shinfo(skb)->gso_type |= SKB_GSO_DODGY;
|
||||
skb_shinfo(skb)->gso_segs = 0;
|
||||
shinfo->gso_type |= SKB_GSO_DODGY;
|
||||
shinfo->gso_segs = 0;
|
||||
}
|
||||
|
||||
return 0;
|
||||
|
||||
@@ -4181,7 +4181,7 @@ int sock_queue_err_skb(struct sock *sk, struct sk_buff *skb)
|
||||
|
||||
skb_queue_tail(&sk->sk_error_queue, skb);
|
||||
if (!sock_flag(sk, SOCK_DEAD))
|
||||
sk->sk_data_ready(sk);
|
||||
sk->sk_error_report(sk);
|
||||
return 0;
|
||||
}
|
||||
EXPORT_SYMBOL(sock_queue_err_skb);
|
||||
@@ -4906,7 +4906,7 @@ static unsigned int skb_gso_transport_seglen(const struct sk_buff *skb)
|
||||
thlen += inner_tcp_hdrlen(skb);
|
||||
} else if (likely(shinfo->gso_type & (SKB_GSO_TCPV4 | SKB_GSO_TCPV6))) {
|
||||
thlen = tcp_hdrlen(skb);
|
||||
} else if (unlikely(shinfo->gso_type & SKB_GSO_SCTP)) {
|
||||
} else if (unlikely(skb_is_gso_sctp(skb))) {
|
||||
thlen = sizeof(struct sctphdr);
|
||||
}
|
||||
/* UFO sets gso_size to the size of the fragmentation
|
||||
@@ -5022,13 +5022,16 @@ EXPORT_SYMBOL_GPL(skb_gso_validate_mac_len);
|
||||
|
||||
static struct sk_buff *skb_reorder_vlan_header(struct sk_buff *skb)
|
||||
{
|
||||
int mac_len;
|
||||
|
||||
if (skb_cow(skb, skb_headroom(skb)) < 0) {
|
||||
kfree_skb(skb);
|
||||
return NULL;
|
||||
}
|
||||
|
||||
memmove(skb->data - ETH_HLEN, skb->data - skb->mac_len - VLAN_HLEN,
|
||||
2 * ETH_ALEN);
|
||||
mac_len = skb->data - skb_mac_header(skb);
|
||||
memmove(skb_mac_header(skb) + VLAN_HLEN, skb_mac_header(skb),
|
||||
mac_len - VLAN_HLEN - ETH_TLEN);
|
||||
skb->mac_header += VLAN_HLEN;
|
||||
return skb;
|
||||
}
|
||||
|
||||
@@ -3326,6 +3326,27 @@ void proto_unregister(struct proto *prot)
|
||||
}
|
||||
EXPORT_SYMBOL(proto_unregister);
|
||||
|
||||
int sock_load_diag_module(int family, int protocol)
|
||||
{
|
||||
if (!protocol) {
|
||||
if (!sock_is_registered(family))
|
||||
return -ENOENT;
|
||||
|
||||
return request_module("net-pf-%d-proto-%d-type-%d", PF_NETLINK,
|
||||
NETLINK_SOCK_DIAG, family);
|
||||
}
|
||||
|
||||
#ifdef CONFIG_INET
|
||||
if (family == AF_INET &&
|
||||
!rcu_access_pointer(inet_protos[protocol]))
|
||||
return -ENOENT;
|
||||
#endif
|
||||
|
||||
return request_module("net-pf-%d-proto-%d-type-%d-%d", PF_NETLINK,
|
||||
NETLINK_SOCK_DIAG, family, protocol);
|
||||
}
|
||||
EXPORT_SYMBOL(sock_load_diag_module);
|
||||
|
||||
#ifdef CONFIG_PROC_FS
|
||||
static void *proto_seq_start(struct seq_file *seq, loff_t *pos)
|
||||
__acquires(proto_list_mutex)
|
||||
|
||||
@@ -220,8 +220,7 @@ static int __sock_diag_cmd(struct sk_buff *skb, struct nlmsghdr *nlh)
|
||||
return -EINVAL;
|
||||
|
||||
if (sock_diag_handlers[req->sdiag_family] == NULL)
|
||||
request_module("net-pf-%d-proto-%d-type-%d", PF_NETLINK,
|
||||
NETLINK_SOCK_DIAG, req->sdiag_family);
|
||||
sock_load_diag_module(req->sdiag_family, 0);
|
||||
|
||||
mutex_lock(&sock_diag_table_mutex);
|
||||
hndl = sock_diag_handlers[req->sdiag_family];
|
||||
@@ -247,8 +246,7 @@ static int sock_diag_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh,
|
||||
case TCPDIAG_GETSOCK:
|
||||
case DCCPDIAG_GETSOCK:
|
||||
if (inet_rcv_compat == NULL)
|
||||
request_module("net-pf-%d-proto-%d-type-%d", PF_NETLINK,
|
||||
NETLINK_SOCK_DIAG, AF_INET);
|
||||
sock_load_diag_module(AF_INET, 0);
|
||||
|
||||
mutex_lock(&sock_diag_table_mutex);
|
||||
if (inet_rcv_compat != NULL)
|
||||
@@ -281,14 +279,12 @@ static int sock_diag_bind(struct net *net, int group)
|
||||
case SKNLGRP_INET_TCP_DESTROY:
|
||||
case SKNLGRP_INET_UDP_DESTROY:
|
||||
if (!sock_diag_handlers[AF_INET])
|
||||
request_module("net-pf-%d-proto-%d-type-%d", PF_NETLINK,
|
||||
NETLINK_SOCK_DIAG, AF_INET);
|
||||
sock_load_diag_module(AF_INET, 0);
|
||||
break;
|
||||
case SKNLGRP_INET6_TCP_DESTROY:
|
||||
case SKNLGRP_INET6_UDP_DESTROY:
|
||||
if (!sock_diag_handlers[AF_INET6])
|
||||
request_module("net-pf-%d-proto-%d-type-%d", PF_NETLINK,
|
||||
NETLINK_SOCK_DIAG, AF_INET6);
|
||||
sock_load_diag_module(AF_INET6, 0);
|
||||
break;
|
||||
}
|
||||
return 0;
|
||||
|
||||
Reference in New Issue
Block a user