ixgb: format all if( to be if (
this patch is trivial but because I want to have everything be nice and tidy I'm updating it. Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
This commit is contained in:

committed by
Jeff Garzik

parent
7490d71a92
commit
03f83041d8
@@ -95,7 +95,7 @@ ixgb_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
|
||||
ecmd->port = PORT_FIBRE;
|
||||
ecmd->transceiver = XCVR_EXTERNAL;
|
||||
|
||||
if(netif_carrier_ok(adapter->netdev)) {
|
||||
if (netif_carrier_ok(adapter->netdev)) {
|
||||
ecmd->speed = SPEED_10000;
|
||||
ecmd->duplex = DUPLEX_FULL;
|
||||
} else {
|
||||
@@ -122,11 +122,11 @@ ixgb_set_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
|
||||
{
|
||||
struct ixgb_adapter *adapter = netdev_priv(netdev);
|
||||
|
||||
if(ecmd->autoneg == AUTONEG_ENABLE ||
|
||||
if (ecmd->autoneg == AUTONEG_ENABLE ||
|
||||
ecmd->speed + ecmd->duplex != SPEED_10000 + DUPLEX_FULL)
|
||||
return -EINVAL;
|
||||
|
||||
if(netif_running(adapter->netdev)) {
|
||||
if (netif_running(adapter->netdev)) {
|
||||
ixgb_down(adapter, true);
|
||||
ixgb_reset(adapter);
|
||||
ixgb_up(adapter);
|
||||
@@ -146,11 +146,11 @@ ixgb_get_pauseparam(struct net_device *netdev,
|
||||
|
||||
pause->autoneg = AUTONEG_DISABLE;
|
||||
|
||||
if(hw->fc.type == ixgb_fc_rx_pause)
|
||||
if (hw->fc.type == ixgb_fc_rx_pause)
|
||||
pause->rx_pause = 1;
|
||||
else if(hw->fc.type == ixgb_fc_tx_pause)
|
||||
else if (hw->fc.type == ixgb_fc_tx_pause)
|
||||
pause->tx_pause = 1;
|
||||
else if(hw->fc.type == ixgb_fc_full) {
|
||||
else if (hw->fc.type == ixgb_fc_full) {
|
||||
pause->rx_pause = 1;
|
||||
pause->tx_pause = 1;
|
||||
}
|
||||
@@ -163,19 +163,19 @@ ixgb_set_pauseparam(struct net_device *netdev,
|
||||
struct ixgb_adapter *adapter = netdev_priv(netdev);
|
||||
struct ixgb_hw *hw = &adapter->hw;
|
||||
|
||||
if(pause->autoneg == AUTONEG_ENABLE)
|
||||
if (pause->autoneg == AUTONEG_ENABLE)
|
||||
return -EINVAL;
|
||||
|
||||
if(pause->rx_pause && pause->tx_pause)
|
||||
if (pause->rx_pause && pause->tx_pause)
|
||||
hw->fc.type = ixgb_fc_full;
|
||||
else if(pause->rx_pause && !pause->tx_pause)
|
||||
else if (pause->rx_pause && !pause->tx_pause)
|
||||
hw->fc.type = ixgb_fc_rx_pause;
|
||||
else if(!pause->rx_pause && pause->tx_pause)
|
||||
else if (!pause->rx_pause && pause->tx_pause)
|
||||
hw->fc.type = ixgb_fc_tx_pause;
|
||||
else if(!pause->rx_pause && !pause->tx_pause)
|
||||
else if (!pause->rx_pause && !pause->tx_pause)
|
||||
hw->fc.type = ixgb_fc_none;
|
||||
|
||||
if(netif_running(adapter->netdev)) {
|
||||
if (netif_running(adapter->netdev)) {
|
||||
ixgb_down(adapter, true);
|
||||
ixgb_up(adapter);
|
||||
ixgb_set_speed_duplex(netdev);
|
||||
@@ -200,7 +200,7 @@ ixgb_set_rx_csum(struct net_device *netdev, u32 data)
|
||||
|
||||
adapter->rx_csum = data;
|
||||
|
||||
if(netif_running(netdev)) {
|
||||
if (netif_running(netdev)) {
|
||||
ixgb_down(adapter, true);
|
||||
ixgb_up(adapter);
|
||||
ixgb_set_speed_duplex(netdev);
|
||||
@@ -229,7 +229,7 @@ ixgb_set_tx_csum(struct net_device *netdev, u32 data)
|
||||
static int
|
||||
ixgb_set_tso(struct net_device *netdev, u32 data)
|
||||
{
|
||||
if(data)
|
||||
if (data)
|
||||
netdev->features |= NETIF_F_TSO;
|
||||
else
|
||||
netdev->features &= ~NETIF_F_TSO;
|
||||
@@ -415,7 +415,7 @@ ixgb_get_eeprom(struct net_device *netdev,
|
||||
int i, max_len, first_word, last_word;
|
||||
int ret_val = 0;
|
||||
|
||||
if(eeprom->len == 0) {
|
||||
if (eeprom->len == 0) {
|
||||
ret_val = -EINVAL;
|
||||
goto geeprom_error;
|
||||
}
|
||||
@@ -424,12 +424,12 @@ ixgb_get_eeprom(struct net_device *netdev,
|
||||
|
||||
max_len = ixgb_get_eeprom_len(netdev);
|
||||
|
||||
if(eeprom->offset > eeprom->offset + eeprom->len) {
|
||||
if (eeprom->offset > eeprom->offset + eeprom->len) {
|
||||
ret_val = -EINVAL;
|
||||
goto geeprom_error;
|
||||
}
|
||||
|
||||
if((eeprom->offset + eeprom->len) > max_len)
|
||||
if ((eeprom->offset + eeprom->len) > max_len)
|
||||
eeprom->len = (max_len - eeprom->offset);
|
||||
|
||||
first_word = eeprom->offset >> 1;
|
||||
@@ -437,7 +437,7 @@ ixgb_get_eeprom(struct net_device *netdev,
|
||||
|
||||
eeprom_buff = kmalloc(sizeof(__le16) *
|
||||
(last_word - first_word + 1), GFP_KERNEL);
|
||||
if(!eeprom_buff)
|
||||
if (!eeprom_buff)
|
||||
return -ENOMEM;
|
||||
|
||||
/* note the eeprom was good because the driver loaded */
|
||||
@@ -464,35 +464,35 @@ ixgb_set_eeprom(struct net_device *netdev,
|
||||
int max_len, first_word, last_word;
|
||||
u16 i;
|
||||
|
||||
if(eeprom->len == 0)
|
||||
if (eeprom->len == 0)
|
||||
return -EINVAL;
|
||||
|
||||
if(eeprom->magic != (hw->vendor_id | (hw->device_id << 16)))
|
||||
if (eeprom->magic != (hw->vendor_id | (hw->device_id << 16)))
|
||||
return -EFAULT;
|
||||
|
||||
max_len = ixgb_get_eeprom_len(netdev);
|
||||
|
||||
if(eeprom->offset > eeprom->offset + eeprom->len)
|
||||
if (eeprom->offset > eeprom->offset + eeprom->len)
|
||||
return -EINVAL;
|
||||
|
||||
if((eeprom->offset + eeprom->len) > max_len)
|
||||
if ((eeprom->offset + eeprom->len) > max_len)
|
||||
eeprom->len = (max_len - eeprom->offset);
|
||||
|
||||
first_word = eeprom->offset >> 1;
|
||||
last_word = (eeprom->offset + eeprom->len - 1) >> 1;
|
||||
eeprom_buff = kmalloc(max_len, GFP_KERNEL);
|
||||
if(!eeprom_buff)
|
||||
if (!eeprom_buff)
|
||||
return -ENOMEM;
|
||||
|
||||
ptr = (void *)eeprom_buff;
|
||||
|
||||
if(eeprom->offset & 1) {
|
||||
if (eeprom->offset & 1) {
|
||||
/* need read/modify/write of first changed EEPROM word */
|
||||
/* only the second byte of the word is being modified */
|
||||
eeprom_buff[0] = ixgb_read_eeprom(hw, first_word);
|
||||
ptr++;
|
||||
}
|
||||
if((eeprom->offset + eeprom->len) & 1) {
|
||||
if ((eeprom->offset + eeprom->len) & 1) {
|
||||
/* need read/modify/write of last changed EEPROM word */
|
||||
/* only the first byte of the word is being modified */
|
||||
eeprom_buff[last_word - first_word]
|
||||
@@ -504,7 +504,7 @@ ixgb_set_eeprom(struct net_device *netdev,
|
||||
ixgb_write_eeprom(hw, first_word + i, eeprom_buff[i]);
|
||||
|
||||
/* Update the checksum over the first part of the EEPROM if needed */
|
||||
if(first_word <= EEPROM_CHECKSUM_REG)
|
||||
if (first_word <= EEPROM_CHECKSUM_REG)
|
||||
ixgb_update_eeprom_checksum(hw);
|
||||
|
||||
kfree(eeprom_buff);
|
||||
@@ -557,10 +557,10 @@ ixgb_set_ringparam(struct net_device *netdev,
|
||||
tx_old = adapter->tx_ring;
|
||||
rx_old = adapter->rx_ring;
|
||||
|
||||
if((ring->rx_mini_pending) || (ring->rx_jumbo_pending))
|
||||
if ((ring->rx_mini_pending) || (ring->rx_jumbo_pending))
|
||||
return -EINVAL;
|
||||
|
||||
if(netif_running(adapter->netdev))
|
||||
if (netif_running(adapter->netdev))
|
||||
ixgb_down(adapter, true);
|
||||
|
||||
rxdr->count = max(ring->rx_pending,(u32)MIN_RXD);
|
||||
@@ -571,11 +571,11 @@ ixgb_set_ringparam(struct net_device *netdev,
|
||||
txdr->count = min(txdr->count,(u32)MAX_TXD);
|
||||
txdr->count = ALIGN(txdr->count, IXGB_REQ_TX_DESCRIPTOR_MULTIPLE);
|
||||
|
||||
if(netif_running(adapter->netdev)) {
|
||||
if (netif_running(adapter->netdev)) {
|
||||
/* Try to get new resources before deleting old */
|
||||
if((err = ixgb_setup_rx_resources(adapter)))
|
||||
if ((err = ixgb_setup_rx_resources(adapter)))
|
||||
goto err_setup_rx;
|
||||
if((err = ixgb_setup_tx_resources(adapter)))
|
||||
if ((err = ixgb_setup_tx_resources(adapter)))
|
||||
goto err_setup_tx;
|
||||
|
||||
/* save the new, restore the old in order to free it,
|
||||
@@ -589,7 +589,7 @@ ixgb_set_ringparam(struct net_device *netdev,
|
||||
ixgb_free_tx_resources(adapter);
|
||||
adapter->rx_ring = rx_new;
|
||||
adapter->tx_ring = tx_new;
|
||||
if((err = ixgb_up(adapter)))
|
||||
if ((err = ixgb_up(adapter)))
|
||||
return err;
|
||||
ixgb_set_speed_duplex(netdev);
|
||||
}
|
||||
@@ -615,7 +615,7 @@ ixgb_led_blink_callback(unsigned long data)
|
||||
{
|
||||
struct ixgb_adapter *adapter = (struct ixgb_adapter *)data;
|
||||
|
||||
if(test_and_change_bit(IXGB_LED_ON, &adapter->led_status))
|
||||
if (test_and_change_bit(IXGB_LED_ON, &adapter->led_status))
|
||||
ixgb_led_off(&adapter->hw);
|
||||
else
|
||||
ixgb_led_on(&adapter->hw);
|
||||
@@ -631,7 +631,7 @@ ixgb_phys_id(struct net_device *netdev, u32 data)
|
||||
if (!data)
|
||||
data = INT_MAX;
|
||||
|
||||
if(!adapter->blink_timer.function) {
|
||||
if (!adapter->blink_timer.function) {
|
||||
init_timer(&adapter->blink_timer);
|
||||
adapter->blink_timer.function = ixgb_led_blink_callback;
|
||||
adapter->blink_timer.data = (unsigned long)adapter;
|
||||
|
Reference in New Issue
Block a user