drivers: avoid format string in dev_set_name
Calling dev_set_name with a single paramter causes it to be handled as a format string. Many callers are passing potentially dynamic string content, so use "%s" in those cases to avoid any potential accidents, including wrappers like device_create*() and bdi_register(). Signed-off-by: Kees Cook <keescook@chromium.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:

committed by
Linus Torvalds

parent
096a8aac6b
commit
02aa2a3763
@@ -447,7 +447,7 @@ int xenbus_probe_node(struct xen_bus_type *bus,
|
||||
if (err)
|
||||
goto fail;
|
||||
|
||||
dev_set_name(&xendev->dev, devname);
|
||||
dev_set_name(&xendev->dev, "%s", devname);
|
||||
|
||||
/* Register with generic device framework. */
|
||||
err = device_register(&xendev->dev);
|
||||
|
Reference in New Issue
Block a user