drivers: avoid format string in dev_set_name
Calling dev_set_name with a single paramter causes it to be handled as a format string. Many callers are passing potentially dynamic string content, so use "%s" in those cases to avoid any potential accidents, including wrappers like device_create*() and bdi_register(). Signed-off-by: Kees Cook <keescook@chromium.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:

committed by
Linus Torvalds

parent
096a8aac6b
commit
02aa2a3763
@@ -602,7 +602,7 @@ int extcon_dev_register(struct extcon_dev *edev, struct device *dev)
|
||||
edev->dev->class = extcon_class;
|
||||
edev->dev->release = extcon_dev_release;
|
||||
|
||||
dev_set_name(edev->dev, edev->name ? edev->name : dev_name(dev));
|
||||
dev_set_name(edev->dev, "%s", edev->name ? edev->name : dev_name(dev));
|
||||
|
||||
if (edev->max_supported) {
|
||||
char buf[10];
|
||||
|
Reference in New Issue
Block a user