xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi: lpfc: Fix NULL pointer access in lpfc_nvme_info_show

Browse Source 
After making remoteport unregister requests, the ndlp nrport pointer was
stale.

Track when waiting for waiting for unregister completion callback and
adjust nldp pointer assignment.  Add a few safety checks for NULL
pointer values.

Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
James Smart
2018-04-09 14:24:27 -07:00
committed by Martin K. Petersen
parent 0cdb84ec26
commit 01466024d2
4 changed files with 31 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/scsi/lpfc/lpfc_debugfs.c
View File

@@ -552,6 +552,7 @@ lpfc_debugfs_nodelist_data(struct lpfc_vport *vport, char *buf, int size)
struct nvme_fc_local_port *localport;
struct lpfc_nvmet_tgtport *tgtp;
struct nvme_fc_remote_port *nrport;
struct lpfc_nvme_rport *rport;
cnt = (LPFC_NODELIST_SIZE / LPFC_NODELIST_ENTRY_SIZE);
outio = 0;
@@ -695,10 +696,13 @@ lpfc_debugfs_nodelist_data(struct lpfc_vport *vport, char *buf, int size)
len += snprintf(buf + len, size - len, "\tRport List:\n");
list_for_each_entry(ndlp, &vport->fc_nodes, nlp_listp) {
/* local short-hand pointer. */
if (!ndlp->nrport)
rport = lpfc_ndlp_get_nrport(ndlp);
if (!rport)
continue;
nrport = ndlp->nrport->remoteport;
nrport = rport->remoteport;
if (!nrport)
continue;
/* Port state is only one of two values for now. */
switch (nrport->port_state) {