ifnulldev_put.cocci 1.1 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455
  1. // SPDX-License-Identifier: GPL-2.0-only
  2. /// Since commit b37a46683739 ("netdevice: add the case if dev is NULL"),
  3. /// NULL check before dev_{put, hold} functions is not needed.
  4. ///
  5. /// Based on ifnullfree.cocci by Fabian Frederick.
  6. ///
  7. // Copyright: (C) 2022 Ziyang Xuan.
  8. // Comments: -
  9. // Options: --no-includes --include-headers
  10. // Version min: 5.15
  11. virtual patch
  12. virtual org
  13. virtual report
  14. virtual context
  15. @r2 depends on patch@
  16. expression E;
  17. @@
  18. - if (E != NULL)
  19. (
  20. __dev_put(E);
  21. |
  22. dev_put(E);
  23. |
  24. dev_put_track(E, ...);
  25. |
  26. __dev_hold(E);
  27. |
  28. dev_hold(E);
  29. |
  30. dev_hold_track(E, ...);
  31. )
  32. @r depends on context || report || org @
  33. expression E;
  34. position p;
  35. @@
  36. * if (E != NULL)
  37. * \(__dev_put@p\|dev_put@p\|dev_put_track@p\|__dev_hold@p\|dev_hold@p\|
  38. * dev_hold_track@p\)(E, ...);
  39. @script:python depends on org@
  40. p << r.p;
  41. @@
  42. cocci.print_main("NULL check before dev_{put, hold} functions is not needed", p)
  43. @script:python depends on report@
  44. p << r.p;
  45. @@
  46. msg = "WARNING: NULL check before dev_{put, hold} functions is not needed."
  47. coccilib.report.print_report(p[0], msg)