check_bq27xxx_data.cocci 3.5 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162
  1. // SPDX-License-Identifier: GPL-2.0-only
  2. /// Detect BQ27XXX_DATA structures with identical registers, dm registers or
  3. /// properties.
  4. //# Doesn't unfold macros used in register or property fields.
  5. //# Requires OCaml scripting
  6. ///
  7. // Confidence: High
  8. // Copyright: (C) 2017 Julia Lawall, Inria/LIP6,
  9. // URL: https://coccinelle.gitlabpages.inria.fr/website
  10. // Requires: 1.0.7
  11. // Keywords: BQ27XXX_DATA
  12. virtual report
  13. @initialize:ocaml@
  14. @@
  15. let print_report p msg =
  16. let p = List.hd p in
  17. Printf.printf "%s:%d:%d-%d: %s" p.file p.line p.col p.col_end msg
  18. @str depends on report@
  19. type t;
  20. identifier i,i1,i2;
  21. expression e1,e2;
  22. @@
  23. t i[] = {
  24. ...,
  25. [e1] = BQ27XXX_DATA(i1,...),
  26. ...,
  27. [e2] = BQ27XXX_DATA(i2,...),
  28. ...,
  29. };
  30. @script:ocaml tocheck@
  31. i1 << str.i1;
  32. i2 << str.i2;
  33. i1regs; i2regs;
  34. i1dmregs; i2dmregs;
  35. i1props; i2props;
  36. @@
  37. if not(i1 = i2)
  38. then
  39. begin
  40. i1regs := make_ident (i1 ^ "_regs");
  41. i2regs := make_ident (i2 ^ "_regs");
  42. i1dmregs := make_ident (i1 ^ "_dm_regs");
  43. i2dmregs := make_ident (i2 ^ "_dm_regs");
  44. i1props := make_ident (i1 ^ "_props");
  45. i2props := make_ident (i2 ^ "_props")
  46. end
  47. (* ---------------------------------------------------------------- *)
  48. @getregs1@
  49. typedef u8;
  50. identifier tocheck.i1regs;
  51. initializer list i1regs_vals;
  52. position p1;
  53. @@
  54. u8 i1regs@p1[...] = { i1regs_vals, };
  55. @getregs2@
  56. identifier tocheck.i2regs;
  57. initializer list i2regs_vals;
  58. position p2;
  59. @@
  60. u8 i2regs@p2[...] = { i2regs_vals, };
  61. @script:ocaml@
  62. (_,i1regs_vals) << getregs1.i1regs_vals;
  63. (_,i2regs_vals) << getregs2.i2regs_vals;
  64. i1regs << tocheck.i1regs;
  65. i2regs << tocheck.i2regs;
  66. p1 << getregs1.p1;
  67. p2 << getregs2.p2;
  68. @@
  69. if i1regs < i2regs &&
  70. List.sort compare i1regs_vals = List.sort compare i2regs_vals
  71. then
  72. let msg =
  73. Printf.sprintf
  74. "WARNING %s and %s (line %d) are identical\n"
  75. i1regs i2regs (List.hd p2).line in
  76. print_report p1 msg
  77. (* ---------------------------------------------------------------- *)
  78. @getdmregs1@
  79. identifier tocheck.i1dmregs;
  80. initializer list i1dmregs_vals;
  81. position p1;
  82. @@
  83. struct bq27xxx_dm_reg i1dmregs@p1[] = { i1dmregs_vals, };
  84. @getdmregs2@
  85. identifier tocheck.i2dmregs;
  86. initializer list i2dmregs_vals;
  87. position p2;
  88. @@
  89. struct bq27xxx_dm_reg i2dmregs@p2[] = { i2dmregs_vals, };
  90. @script:ocaml@
  91. (_,i1dmregs_vals) << getdmregs1.i1dmregs_vals;
  92. (_,i2dmregs_vals) << getdmregs2.i2dmregs_vals;
  93. i1dmregs << tocheck.i1dmregs;
  94. i2dmregs << tocheck.i2dmregs;
  95. p1 << getdmregs1.p1;
  96. p2 << getdmregs2.p2;
  97. @@
  98. if i1dmregs < i2dmregs &&
  99. List.sort compare i1dmregs_vals = List.sort compare i2dmregs_vals
  100. then
  101. let msg =
  102. Printf.sprintf
  103. "WARNING %s and %s (line %d) are identical\n"
  104. i1dmregs i2dmregs (List.hd p2).line in
  105. print_report p1 msg
  106. (* ---------------------------------------------------------------- *)
  107. @getprops1@
  108. identifier tocheck.i1props;
  109. initializer list[n1] i1props_vals;
  110. position p1;
  111. @@
  112. enum power_supply_property i1props@p1[] = { i1props_vals, };
  113. @getprops2@
  114. identifier tocheck.i2props;
  115. initializer list[n2] i2props_vals;
  116. position p2;
  117. @@
  118. enum power_supply_property i2props@p2[] = { i2props_vals, };
  119. @script:ocaml@
  120. (_,i1props_vals) << getprops1.i1props_vals;
  121. (_,i2props_vals) << getprops2.i2props_vals;
  122. i1props << tocheck.i1props;
  123. i2props << tocheck.i2props;
  124. p1 << getprops1.p1;
  125. p2 << getprops2.p2;
  126. @@
  127. if i1props < i2props &&
  128. List.sort compare i1props_vals = List.sort compare i2props_vals
  129. then
  130. let msg =
  131. Printf.sprintf
  132. "WARNING %s and %s (line %d) are identical\n"
  133. i1props i2props (List.hd p2).line in
  134. print_report p1 msg