sysctl-test.c 11 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391
  1. // SPDX-License-Identifier: GPL-2.0
  2. /*
  3. * KUnit test of proc sysctl.
  4. */
  5. #include <kunit/test.h>
  6. #include <linux/sysctl.h>
  7. #define KUNIT_PROC_READ 0
  8. #define KUNIT_PROC_WRITE 1
  9. /*
  10. * Test that proc_dointvec will not try to use a NULL .data field even when the
  11. * length is non-zero.
  12. */
  13. static void sysctl_test_api_dointvec_null_tbl_data(struct kunit *test)
  14. {
  15. struct ctl_table null_data_table = {
  16. .procname = "foo",
  17. /*
  18. * Here we are testing that proc_dointvec behaves correctly when
  19. * we give it a NULL .data field. Normally this would point to a
  20. * piece of memory where the value would be stored.
  21. */
  22. .data = NULL,
  23. .maxlen = sizeof(int),
  24. .mode = 0644,
  25. .proc_handler = proc_dointvec,
  26. .extra1 = SYSCTL_ZERO,
  27. .extra2 = SYSCTL_ONE_HUNDRED,
  28. };
  29. /*
  30. * proc_dointvec expects a buffer in user space, so we allocate one. We
  31. * also need to cast it to __user so sparse doesn't get mad.
  32. */
  33. void __user *buffer = (void __user *)kunit_kzalloc(test, sizeof(int),
  34. GFP_USER);
  35. size_t len;
  36. loff_t pos;
  37. /*
  38. * We don't care what the starting length is since proc_dointvec should
  39. * not try to read because .data is NULL.
  40. */
  41. len = 1234;
  42. KUNIT_EXPECT_EQ(test, 0, proc_dointvec(&null_data_table,
  43. KUNIT_PROC_READ, buffer, &len,
  44. &pos));
  45. KUNIT_EXPECT_EQ(test, 0, len);
  46. /*
  47. * See above.
  48. */
  49. len = 1234;
  50. KUNIT_EXPECT_EQ(test, 0, proc_dointvec(&null_data_table,
  51. KUNIT_PROC_WRITE, buffer, &len,
  52. &pos));
  53. KUNIT_EXPECT_EQ(test, 0, len);
  54. }
  55. /*
  56. * Similar to the previous test, we create a struct ctrl_table that has a .data
  57. * field that proc_dointvec cannot do anything with; however, this time it is
  58. * because we tell proc_dointvec that the size is 0.
  59. */
  60. static void sysctl_test_api_dointvec_table_maxlen_unset(struct kunit *test)
  61. {
  62. int data = 0;
  63. struct ctl_table data_maxlen_unset_table = {
  64. .procname = "foo",
  65. .data = &data,
  66. /*
  67. * So .data is no longer NULL, but we tell proc_dointvec its
  68. * length is 0, so it still shouldn't try to use it.
  69. */
  70. .maxlen = 0,
  71. .mode = 0644,
  72. .proc_handler = proc_dointvec,
  73. .extra1 = SYSCTL_ZERO,
  74. .extra2 = SYSCTL_ONE_HUNDRED,
  75. };
  76. void __user *buffer = (void __user *)kunit_kzalloc(test, sizeof(int),
  77. GFP_USER);
  78. size_t len;
  79. loff_t pos;
  80. /*
  81. * As before, we don't care what buffer length is because proc_dointvec
  82. * cannot do anything because its internal .data buffer has zero length.
  83. */
  84. len = 1234;
  85. KUNIT_EXPECT_EQ(test, 0, proc_dointvec(&data_maxlen_unset_table,
  86. KUNIT_PROC_READ, buffer, &len,
  87. &pos));
  88. KUNIT_EXPECT_EQ(test, 0, len);
  89. /*
  90. * See previous comment.
  91. */
  92. len = 1234;
  93. KUNIT_EXPECT_EQ(test, 0, proc_dointvec(&data_maxlen_unset_table,
  94. KUNIT_PROC_WRITE, buffer, &len,
  95. &pos));
  96. KUNIT_EXPECT_EQ(test, 0, len);
  97. }
  98. /*
  99. * Here we provide a valid struct ctl_table, but we try to read and write from
  100. * it using a buffer of zero length, so it should still fail in a similar way as
  101. * before.
  102. */
  103. static void sysctl_test_api_dointvec_table_len_is_zero(struct kunit *test)
  104. {
  105. int data = 0;
  106. /* Good table. */
  107. struct ctl_table table = {
  108. .procname = "foo",
  109. .data = &data,
  110. .maxlen = sizeof(int),
  111. .mode = 0644,
  112. .proc_handler = proc_dointvec,
  113. .extra1 = SYSCTL_ZERO,
  114. .extra2 = SYSCTL_ONE_HUNDRED,
  115. };
  116. void __user *buffer = (void __user *)kunit_kzalloc(test, sizeof(int),
  117. GFP_USER);
  118. /*
  119. * However, now our read/write buffer has zero length.
  120. */
  121. size_t len = 0;
  122. loff_t pos;
  123. KUNIT_EXPECT_EQ(test, 0, proc_dointvec(&table, KUNIT_PROC_READ, buffer,
  124. &len, &pos));
  125. KUNIT_EXPECT_EQ(test, 0, len);
  126. KUNIT_EXPECT_EQ(test, 0, proc_dointvec(&table, KUNIT_PROC_WRITE, buffer,
  127. &len, &pos));
  128. KUNIT_EXPECT_EQ(test, 0, len);
  129. }
  130. /*
  131. * Test that proc_dointvec refuses to read when the file position is non-zero.
  132. */
  133. static void sysctl_test_api_dointvec_table_read_but_position_set(
  134. struct kunit *test)
  135. {
  136. int data = 0;
  137. /* Good table. */
  138. struct ctl_table table = {
  139. .procname = "foo",
  140. .data = &data,
  141. .maxlen = sizeof(int),
  142. .mode = 0644,
  143. .proc_handler = proc_dointvec,
  144. .extra1 = SYSCTL_ZERO,
  145. .extra2 = SYSCTL_ONE_HUNDRED,
  146. };
  147. void __user *buffer = (void __user *)kunit_kzalloc(test, sizeof(int),
  148. GFP_USER);
  149. /*
  150. * We don't care about our buffer length because we start off with a
  151. * non-zero file position.
  152. */
  153. size_t len = 1234;
  154. /*
  155. * proc_dointvec should refuse to read into the buffer since the file
  156. * pos is non-zero.
  157. */
  158. loff_t pos = 1;
  159. KUNIT_EXPECT_EQ(test, 0, proc_dointvec(&table, KUNIT_PROC_READ, buffer,
  160. &len, &pos));
  161. KUNIT_EXPECT_EQ(test, 0, len);
  162. }
  163. /*
  164. * Test that we can read a two digit number in a sufficiently size buffer.
  165. * Nothing fancy.
  166. */
  167. static void sysctl_test_dointvec_read_happy_single_positive(struct kunit *test)
  168. {
  169. int data = 0;
  170. /* Good table. */
  171. struct ctl_table table = {
  172. .procname = "foo",
  173. .data = &data,
  174. .maxlen = sizeof(int),
  175. .mode = 0644,
  176. .proc_handler = proc_dointvec,
  177. .extra1 = SYSCTL_ZERO,
  178. .extra2 = SYSCTL_ONE_HUNDRED,
  179. };
  180. size_t len = 4;
  181. loff_t pos = 0;
  182. char *buffer = kunit_kzalloc(test, len, GFP_USER);
  183. char __user *user_buffer = (char __user *)buffer;
  184. /* Store 13 in the data field. */
  185. *((int *)table.data) = 13;
  186. KUNIT_EXPECT_EQ(test, 0, proc_dointvec(&table, KUNIT_PROC_READ,
  187. user_buffer, &len, &pos));
  188. KUNIT_ASSERT_EQ(test, 3, len);
  189. buffer[len] = '\0';
  190. /* And we read 13 back out. */
  191. KUNIT_EXPECT_STREQ(test, "13\n", buffer);
  192. }
  193. /*
  194. * Same as previous test, just now with negative numbers.
  195. */
  196. static void sysctl_test_dointvec_read_happy_single_negative(struct kunit *test)
  197. {
  198. int data = 0;
  199. /* Good table. */
  200. struct ctl_table table = {
  201. .procname = "foo",
  202. .data = &data,
  203. .maxlen = sizeof(int),
  204. .mode = 0644,
  205. .proc_handler = proc_dointvec,
  206. .extra1 = SYSCTL_ZERO,
  207. .extra2 = SYSCTL_ONE_HUNDRED,
  208. };
  209. size_t len = 5;
  210. loff_t pos = 0;
  211. char *buffer = kunit_kzalloc(test, len, GFP_USER);
  212. char __user *user_buffer = (char __user *)buffer;
  213. *((int *)table.data) = -16;
  214. KUNIT_EXPECT_EQ(test, 0, proc_dointvec(&table, KUNIT_PROC_READ,
  215. user_buffer, &len, &pos));
  216. KUNIT_ASSERT_EQ(test, 4, len);
  217. buffer[len] = '\0';
  218. KUNIT_EXPECT_STREQ(test, "-16\n", buffer);
  219. }
  220. /*
  221. * Test that a simple positive write works.
  222. */
  223. static void sysctl_test_dointvec_write_happy_single_positive(struct kunit *test)
  224. {
  225. int data = 0;
  226. /* Good table. */
  227. struct ctl_table table = {
  228. .procname = "foo",
  229. .data = &data,
  230. .maxlen = sizeof(int),
  231. .mode = 0644,
  232. .proc_handler = proc_dointvec,
  233. .extra1 = SYSCTL_ZERO,
  234. .extra2 = SYSCTL_ONE_HUNDRED,
  235. };
  236. char input[] = "9";
  237. size_t len = sizeof(input) - 1;
  238. loff_t pos = 0;
  239. char *buffer = kunit_kzalloc(test, len, GFP_USER);
  240. char __user *user_buffer = (char __user *)buffer;
  241. memcpy(buffer, input, len);
  242. KUNIT_EXPECT_EQ(test, 0, proc_dointvec(&table, KUNIT_PROC_WRITE,
  243. user_buffer, &len, &pos));
  244. KUNIT_EXPECT_EQ(test, sizeof(input) - 1, len);
  245. KUNIT_EXPECT_EQ(test, sizeof(input) - 1, pos);
  246. KUNIT_EXPECT_EQ(test, 9, *((int *)table.data));
  247. }
  248. /*
  249. * Same as previous test, but now with negative numbers.
  250. */
  251. static void sysctl_test_dointvec_write_happy_single_negative(struct kunit *test)
  252. {
  253. int data = 0;
  254. struct ctl_table table = {
  255. .procname = "foo",
  256. .data = &data,
  257. .maxlen = sizeof(int),
  258. .mode = 0644,
  259. .proc_handler = proc_dointvec,
  260. .extra1 = SYSCTL_ZERO,
  261. .extra2 = SYSCTL_ONE_HUNDRED,
  262. };
  263. char input[] = "-9";
  264. size_t len = sizeof(input) - 1;
  265. loff_t pos = 0;
  266. char *buffer = kunit_kzalloc(test, len, GFP_USER);
  267. char __user *user_buffer = (char __user *)buffer;
  268. memcpy(buffer, input, len);
  269. KUNIT_EXPECT_EQ(test, 0, proc_dointvec(&table, KUNIT_PROC_WRITE,
  270. user_buffer, &len, &pos));
  271. KUNIT_EXPECT_EQ(test, sizeof(input) - 1, len);
  272. KUNIT_EXPECT_EQ(test, sizeof(input) - 1, pos);
  273. KUNIT_EXPECT_EQ(test, -9, *((int *)table.data));
  274. }
  275. /*
  276. * Test that writing a value smaller than the minimum possible value is not
  277. * allowed.
  278. */
  279. static void sysctl_test_api_dointvec_write_single_less_int_min(
  280. struct kunit *test)
  281. {
  282. int data = 0;
  283. struct ctl_table table = {
  284. .procname = "foo",
  285. .data = &data,
  286. .maxlen = sizeof(int),
  287. .mode = 0644,
  288. .proc_handler = proc_dointvec,
  289. .extra1 = SYSCTL_ZERO,
  290. .extra2 = SYSCTL_ONE_HUNDRED,
  291. };
  292. size_t max_len = 32, len = max_len;
  293. loff_t pos = 0;
  294. char *buffer = kunit_kzalloc(test, max_len, GFP_USER);
  295. char __user *user_buffer = (char __user *)buffer;
  296. unsigned long abs_of_less_than_min = (unsigned long)INT_MAX
  297. - (INT_MAX + INT_MIN) + 1;
  298. /*
  299. * We use this rigmarole to create a string that contains a value one
  300. * less than the minimum accepted value.
  301. */
  302. KUNIT_ASSERT_LT(test,
  303. (size_t)snprintf(buffer, max_len, "-%lu",
  304. abs_of_less_than_min),
  305. max_len);
  306. KUNIT_EXPECT_EQ(test, -EINVAL, proc_dointvec(&table, KUNIT_PROC_WRITE,
  307. user_buffer, &len, &pos));
  308. KUNIT_EXPECT_EQ(test, max_len, len);
  309. KUNIT_EXPECT_EQ(test, 0, *((int *)table.data));
  310. }
  311. /*
  312. * Test that writing the maximum possible value works.
  313. */
  314. static void sysctl_test_api_dointvec_write_single_greater_int_max(
  315. struct kunit *test)
  316. {
  317. int data = 0;
  318. struct ctl_table table = {
  319. .procname = "foo",
  320. .data = &data,
  321. .maxlen = sizeof(int),
  322. .mode = 0644,
  323. .proc_handler = proc_dointvec,
  324. .extra1 = SYSCTL_ZERO,
  325. .extra2 = SYSCTL_ONE_HUNDRED,
  326. };
  327. size_t max_len = 32, len = max_len;
  328. loff_t pos = 0;
  329. char *buffer = kunit_kzalloc(test, max_len, GFP_USER);
  330. char __user *user_buffer = (char __user *)buffer;
  331. unsigned long greater_than_max = (unsigned long)INT_MAX + 1;
  332. KUNIT_ASSERT_GT(test, greater_than_max, (unsigned long)INT_MAX);
  333. KUNIT_ASSERT_LT(test, (size_t)snprintf(buffer, max_len, "%lu",
  334. greater_than_max),
  335. max_len);
  336. KUNIT_EXPECT_EQ(test, -EINVAL, proc_dointvec(&table, KUNIT_PROC_WRITE,
  337. user_buffer, &len, &pos));
  338. KUNIT_ASSERT_EQ(test, max_len, len);
  339. KUNIT_EXPECT_EQ(test, 0, *((int *)table.data));
  340. }
  341. static struct kunit_case sysctl_test_cases[] = {
  342. KUNIT_CASE(sysctl_test_api_dointvec_null_tbl_data),
  343. KUNIT_CASE(sysctl_test_api_dointvec_table_maxlen_unset),
  344. KUNIT_CASE(sysctl_test_api_dointvec_table_len_is_zero),
  345. KUNIT_CASE(sysctl_test_api_dointvec_table_read_but_position_set),
  346. KUNIT_CASE(sysctl_test_dointvec_read_happy_single_positive),
  347. KUNIT_CASE(sysctl_test_dointvec_read_happy_single_negative),
  348. KUNIT_CASE(sysctl_test_dointvec_write_happy_single_positive),
  349. KUNIT_CASE(sysctl_test_dointvec_write_happy_single_negative),
  350. KUNIT_CASE(sysctl_test_api_dointvec_write_single_less_int_min),
  351. KUNIT_CASE(sysctl_test_api_dointvec_write_single_greater_int_max),
  352. {}
  353. };
  354. static struct kunit_suite sysctl_test_suite = {
  355. .name = "sysctl_test",
  356. .test_cases = sysctl_test_cases,
  357. };
  358. kunit_test_suites(&sysctl_test_suite);
  359. MODULE_LICENSE("GPL v2");