mae.c 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511
  1. // SPDX-License-Identifier: GPL-2.0-only
  2. /****************************************************************************
  3. * Driver for Solarflare network controllers and boards
  4. * Copyright 2019 Solarflare Communications Inc.
  5. * Copyright 2020-2022 Xilinx Inc.
  6. *
  7. * This program is free software; you can redistribute it and/or modify it
  8. * under the terms of the GNU General Public License version 2 as published
  9. * by the Free Software Foundation, incorporated herein by reference.
  10. */
  11. #include "mae.h"
  12. #include "mcdi.h"
  13. #include "mcdi_pcol_mae.h"
  14. int efx_mae_allocate_mport(struct efx_nic *efx, u32 *id, u32 *label)
  15. {
  16. MCDI_DECLARE_BUF(outbuf, MC_CMD_MAE_MPORT_ALLOC_ALIAS_OUT_LEN);
  17. MCDI_DECLARE_BUF(inbuf, MC_CMD_MAE_MPORT_ALLOC_ALIAS_IN_LEN);
  18. size_t outlen;
  19. int rc;
  20. if (WARN_ON_ONCE(!id))
  21. return -EINVAL;
  22. if (WARN_ON_ONCE(!label))
  23. return -EINVAL;
  24. MCDI_SET_DWORD(inbuf, MAE_MPORT_ALLOC_ALIAS_IN_TYPE,
  25. MC_CMD_MAE_MPORT_ALLOC_ALIAS_IN_MPORT_TYPE_ALIAS);
  26. MCDI_SET_DWORD(inbuf, MAE_MPORT_ALLOC_ALIAS_IN_DELIVER_MPORT,
  27. MAE_MPORT_SELECTOR_ASSIGNED);
  28. rc = efx_mcdi_rpc(efx, MC_CMD_MAE_MPORT_ALLOC, inbuf, sizeof(inbuf),
  29. outbuf, sizeof(outbuf), &outlen);
  30. if (rc)
  31. return rc;
  32. if (outlen < sizeof(outbuf))
  33. return -EIO;
  34. *id = MCDI_DWORD(outbuf, MAE_MPORT_ALLOC_ALIAS_OUT_MPORT_ID);
  35. *label = MCDI_DWORD(outbuf, MAE_MPORT_ALLOC_ALIAS_OUT_LABEL);
  36. return 0;
  37. }
  38. int efx_mae_free_mport(struct efx_nic *efx, u32 id)
  39. {
  40. MCDI_DECLARE_BUF(inbuf, MC_CMD_MAE_MPORT_FREE_IN_LEN);
  41. BUILD_BUG_ON(MC_CMD_MAE_MPORT_FREE_OUT_LEN);
  42. MCDI_SET_DWORD(inbuf, MAE_MPORT_FREE_IN_MPORT_ID, id);
  43. return efx_mcdi_rpc(efx, MC_CMD_MAE_MPORT_FREE, inbuf, sizeof(inbuf),
  44. NULL, 0, NULL);
  45. }
  46. void efx_mae_mport_wire(struct efx_nic *efx, u32 *out)
  47. {
  48. efx_dword_t mport;
  49. EFX_POPULATE_DWORD_2(mport,
  50. MAE_MPORT_SELECTOR_TYPE, MAE_MPORT_SELECTOR_TYPE_PPORT,
  51. MAE_MPORT_SELECTOR_PPORT_ID, efx->port_num);
  52. *out = EFX_DWORD_VAL(mport);
  53. }
  54. void efx_mae_mport_uplink(struct efx_nic *efx __always_unused, u32 *out)
  55. {
  56. efx_dword_t mport;
  57. EFX_POPULATE_DWORD_3(mport,
  58. MAE_MPORT_SELECTOR_TYPE, MAE_MPORT_SELECTOR_TYPE_FUNC,
  59. MAE_MPORT_SELECTOR_FUNC_PF_ID, MAE_MPORT_SELECTOR_FUNC_PF_ID_CALLER,
  60. MAE_MPORT_SELECTOR_FUNC_VF_ID, MAE_MPORT_SELECTOR_FUNC_VF_ID_NULL);
  61. *out = EFX_DWORD_VAL(mport);
  62. }
  63. void efx_mae_mport_vf(struct efx_nic *efx __always_unused, u32 vf_id, u32 *out)
  64. {
  65. efx_dword_t mport;
  66. EFX_POPULATE_DWORD_3(mport,
  67. MAE_MPORT_SELECTOR_TYPE, MAE_MPORT_SELECTOR_TYPE_FUNC,
  68. MAE_MPORT_SELECTOR_FUNC_PF_ID, MAE_MPORT_SELECTOR_FUNC_PF_ID_CALLER,
  69. MAE_MPORT_SELECTOR_FUNC_VF_ID, vf_id);
  70. *out = EFX_DWORD_VAL(mport);
  71. }
  72. /* Constructs an mport selector from an mport ID, because they're not the same */
  73. void efx_mae_mport_mport(struct efx_nic *efx __always_unused, u32 mport_id, u32 *out)
  74. {
  75. efx_dword_t mport;
  76. EFX_POPULATE_DWORD_2(mport,
  77. MAE_MPORT_SELECTOR_TYPE, MAE_MPORT_SELECTOR_TYPE_MPORT_ID,
  78. MAE_MPORT_SELECTOR_MPORT_ID, mport_id);
  79. *out = EFX_DWORD_VAL(mport);
  80. }
  81. /* id is really only 24 bits wide */
  82. int efx_mae_lookup_mport(struct efx_nic *efx, u32 selector, u32 *id)
  83. {
  84. MCDI_DECLARE_BUF(outbuf, MC_CMD_MAE_MPORT_LOOKUP_OUT_LEN);
  85. MCDI_DECLARE_BUF(inbuf, MC_CMD_MAE_MPORT_LOOKUP_IN_LEN);
  86. size_t outlen;
  87. int rc;
  88. MCDI_SET_DWORD(inbuf, MAE_MPORT_LOOKUP_IN_MPORT_SELECTOR, selector);
  89. rc = efx_mcdi_rpc(efx, MC_CMD_MAE_MPORT_LOOKUP, inbuf, sizeof(inbuf),
  90. outbuf, sizeof(outbuf), &outlen);
  91. if (rc)
  92. return rc;
  93. if (outlen < sizeof(outbuf))
  94. return -EIO;
  95. *id = MCDI_DWORD(outbuf, MAE_MPORT_LOOKUP_OUT_MPORT_ID);
  96. return 0;
  97. }
  98. static int efx_mae_get_basic_caps(struct efx_nic *efx, struct mae_caps *caps)
  99. {
  100. MCDI_DECLARE_BUF(outbuf, MC_CMD_MAE_GET_CAPS_OUT_LEN);
  101. size_t outlen;
  102. int rc;
  103. BUILD_BUG_ON(MC_CMD_MAE_GET_CAPS_IN_LEN);
  104. rc = efx_mcdi_rpc(efx, MC_CMD_MAE_GET_CAPS, NULL, 0, outbuf,
  105. sizeof(outbuf), &outlen);
  106. if (rc)
  107. return rc;
  108. if (outlen < sizeof(outbuf))
  109. return -EIO;
  110. caps->match_field_count = MCDI_DWORD(outbuf, MAE_GET_CAPS_OUT_MATCH_FIELD_COUNT);
  111. caps->action_prios = MCDI_DWORD(outbuf, MAE_GET_CAPS_OUT_ACTION_PRIOS);
  112. return 0;
  113. }
  114. static int efx_mae_get_rule_fields(struct efx_nic *efx, u32 cmd,
  115. u8 *field_support)
  116. {
  117. MCDI_DECLARE_BUF(outbuf, MC_CMD_MAE_GET_AR_CAPS_OUT_LEN(MAE_NUM_FIELDS));
  118. MCDI_DECLARE_STRUCT_PTR(caps);
  119. unsigned int count;
  120. size_t outlen;
  121. int rc, i;
  122. BUILD_BUG_ON(MC_CMD_MAE_GET_AR_CAPS_IN_LEN);
  123. rc = efx_mcdi_rpc(efx, cmd, NULL, 0, outbuf, sizeof(outbuf), &outlen);
  124. if (rc)
  125. return rc;
  126. count = MCDI_DWORD(outbuf, MAE_GET_AR_CAPS_OUT_COUNT);
  127. memset(field_support, MAE_FIELD_UNSUPPORTED, MAE_NUM_FIELDS);
  128. caps = _MCDI_DWORD(outbuf, MAE_GET_AR_CAPS_OUT_FIELD_FLAGS);
  129. /* We're only interested in the support status enum, not any other
  130. * flags, so just extract that from each entry.
  131. */
  132. for (i = 0; i < count; i++)
  133. if (i * sizeof(*outbuf) + MC_CMD_MAE_GET_AR_CAPS_OUT_FIELD_FLAGS_OFST < outlen)
  134. field_support[i] = EFX_DWORD_FIELD(caps[i], MAE_FIELD_FLAGS_SUPPORT_STATUS);
  135. return 0;
  136. }
  137. int efx_mae_get_caps(struct efx_nic *efx, struct mae_caps *caps)
  138. {
  139. int rc;
  140. rc = efx_mae_get_basic_caps(efx, caps);
  141. if (rc)
  142. return rc;
  143. return efx_mae_get_rule_fields(efx, MC_CMD_MAE_GET_AR_CAPS,
  144. caps->action_rule_fields);
  145. }
  146. /* Bit twiddling:
  147. * Prefix: 1...110...0
  148. * ~: 0...001...1
  149. * + 1: 0...010...0 is power of two
  150. * so (~x) & ((~x) + 1) == 0. Converse holds also.
  151. */
  152. #define is_prefix_byte(_x) !(((_x) ^ 0xff) & (((_x) ^ 0xff) + 1))
  153. enum mask_type { MASK_ONES, MASK_ZEROES, MASK_PREFIX, MASK_OTHER };
  154. static const char *mask_type_name(enum mask_type typ)
  155. {
  156. switch (typ) {
  157. case MASK_ONES:
  158. return "all-1s";
  159. case MASK_ZEROES:
  160. return "all-0s";
  161. case MASK_PREFIX:
  162. return "prefix";
  163. case MASK_OTHER:
  164. return "arbitrary";
  165. default: /* can't happen */
  166. return "unknown";
  167. }
  168. }
  169. /* Checks a (big-endian) bytestring is a bit prefix */
  170. static enum mask_type classify_mask(const u8 *mask, size_t len)
  171. {
  172. bool zeroes = true; /* All bits seen so far are zeroes */
  173. bool ones = true; /* All bits seen so far are ones */
  174. bool prefix = true; /* Valid prefix so far */
  175. size_t i;
  176. for (i = 0; i < len; i++) {
  177. if (ones) {
  178. if (!is_prefix_byte(mask[i]))
  179. prefix = false;
  180. } else if (mask[i]) {
  181. prefix = false;
  182. }
  183. if (mask[i] != 0xff)
  184. ones = false;
  185. if (mask[i])
  186. zeroes = false;
  187. }
  188. if (ones)
  189. return MASK_ONES;
  190. if (zeroes)
  191. return MASK_ZEROES;
  192. if (prefix)
  193. return MASK_PREFIX;
  194. return MASK_OTHER;
  195. }
  196. static int efx_mae_match_check_cap_typ(u8 support, enum mask_type typ)
  197. {
  198. switch (support) {
  199. case MAE_FIELD_UNSUPPORTED:
  200. case MAE_FIELD_SUPPORTED_MATCH_NEVER:
  201. if (typ == MASK_ZEROES)
  202. return 0;
  203. return -EOPNOTSUPP;
  204. case MAE_FIELD_SUPPORTED_MATCH_OPTIONAL:
  205. if (typ == MASK_ZEROES)
  206. return 0;
  207. fallthrough;
  208. case MAE_FIELD_SUPPORTED_MATCH_ALWAYS:
  209. if (typ == MASK_ONES)
  210. return 0;
  211. return -EINVAL;
  212. case MAE_FIELD_SUPPORTED_MATCH_PREFIX:
  213. if (typ == MASK_OTHER)
  214. return -EOPNOTSUPP;
  215. return 0;
  216. case MAE_FIELD_SUPPORTED_MATCH_MASK:
  217. return 0;
  218. default:
  219. return -EIO;
  220. }
  221. }
  222. int efx_mae_match_check_caps(struct efx_nic *efx,
  223. const struct efx_tc_match_fields *mask,
  224. struct netlink_ext_ack *extack)
  225. {
  226. const u8 *supported_fields = efx->tc->caps->action_rule_fields;
  227. __be32 ingress_port = cpu_to_be32(mask->ingress_port);
  228. enum mask_type ingress_port_mask_type;
  229. int rc;
  230. /* Check for _PREFIX assumes big-endian, so we need to convert */
  231. ingress_port_mask_type = classify_mask((const u8 *)&ingress_port,
  232. sizeof(ingress_port));
  233. rc = efx_mae_match_check_cap_typ(supported_fields[MAE_FIELD_INGRESS_PORT],
  234. ingress_port_mask_type);
  235. if (rc) {
  236. efx_tc_err(efx, "No support for %s mask in field ingress_port\n",
  237. mask_type_name(ingress_port_mask_type));
  238. NL_SET_ERR_MSG_MOD(extack, "Unsupported mask type for ingress_port");
  239. return rc;
  240. }
  241. return 0;
  242. }
  243. static bool efx_mae_asl_id(u32 id)
  244. {
  245. return !!(id & BIT(31));
  246. }
  247. int efx_mae_alloc_action_set(struct efx_nic *efx, struct efx_tc_action_set *act)
  248. {
  249. MCDI_DECLARE_BUF(outbuf, MC_CMD_MAE_ACTION_SET_ALLOC_OUT_LEN);
  250. MCDI_DECLARE_BUF(inbuf, MC_CMD_MAE_ACTION_SET_ALLOC_IN_LEN);
  251. size_t outlen;
  252. int rc;
  253. MCDI_SET_DWORD(inbuf, MAE_ACTION_SET_ALLOC_IN_SRC_MAC_ID,
  254. MC_CMD_MAE_MAC_ADDR_ALLOC_OUT_MAC_ID_NULL);
  255. MCDI_SET_DWORD(inbuf, MAE_ACTION_SET_ALLOC_IN_DST_MAC_ID,
  256. MC_CMD_MAE_MAC_ADDR_ALLOC_OUT_MAC_ID_NULL);
  257. MCDI_SET_DWORD(inbuf, MAE_ACTION_SET_ALLOC_IN_COUNTER_ID,
  258. MC_CMD_MAE_COUNTER_ALLOC_OUT_COUNTER_ID_NULL);
  259. MCDI_SET_DWORD(inbuf, MAE_ACTION_SET_ALLOC_IN_COUNTER_LIST_ID,
  260. MC_CMD_MAE_COUNTER_LIST_ALLOC_OUT_COUNTER_LIST_ID_NULL);
  261. MCDI_SET_DWORD(inbuf, MAE_ACTION_SET_ALLOC_IN_ENCAP_HEADER_ID,
  262. MC_CMD_MAE_ENCAP_HEADER_ALLOC_OUT_ENCAP_HEADER_ID_NULL);
  263. if (act->deliver)
  264. MCDI_SET_DWORD(inbuf, MAE_ACTION_SET_ALLOC_IN_DELIVER,
  265. act->dest_mport);
  266. BUILD_BUG_ON(MAE_MPORT_SELECTOR_NULL);
  267. rc = efx_mcdi_rpc(efx, MC_CMD_MAE_ACTION_SET_ALLOC, inbuf, sizeof(inbuf),
  268. outbuf, sizeof(outbuf), &outlen);
  269. if (rc)
  270. return rc;
  271. if (outlen < sizeof(outbuf))
  272. return -EIO;
  273. act->fw_id = MCDI_DWORD(outbuf, MAE_ACTION_SET_ALLOC_OUT_AS_ID);
  274. /* We rely on the high bit of AS IDs always being clear.
  275. * The firmware API guarantees this, but let's check it ourselves.
  276. */
  277. if (WARN_ON_ONCE(efx_mae_asl_id(act->fw_id))) {
  278. efx_mae_free_action_set(efx, act->fw_id);
  279. return -EIO;
  280. }
  281. return 0;
  282. }
  283. int efx_mae_free_action_set(struct efx_nic *efx, u32 fw_id)
  284. {
  285. MCDI_DECLARE_BUF(outbuf, MC_CMD_MAE_ACTION_SET_FREE_OUT_LEN(1));
  286. MCDI_DECLARE_BUF(inbuf, MC_CMD_MAE_ACTION_SET_FREE_IN_LEN(1));
  287. size_t outlen;
  288. int rc;
  289. MCDI_SET_DWORD(inbuf, MAE_ACTION_SET_FREE_IN_AS_ID, fw_id);
  290. rc = efx_mcdi_rpc(efx, MC_CMD_MAE_ACTION_SET_FREE, inbuf, sizeof(inbuf),
  291. outbuf, sizeof(outbuf), &outlen);
  292. if (rc)
  293. return rc;
  294. if (outlen < sizeof(outbuf))
  295. return -EIO;
  296. /* FW freed a different ID than we asked for, should never happen.
  297. * Warn because it means we've now got a different idea to the FW of
  298. * what action-sets exist, which could cause mayhem later.
  299. */
  300. if (WARN_ON(MCDI_DWORD(outbuf, MAE_ACTION_SET_FREE_OUT_FREED_AS_ID) != fw_id))
  301. return -EIO;
  302. return 0;
  303. }
  304. int efx_mae_alloc_action_set_list(struct efx_nic *efx,
  305. struct efx_tc_action_set_list *acts)
  306. {
  307. MCDI_DECLARE_BUF(outbuf, MC_CMD_MAE_ACTION_SET_LIST_ALLOC_OUT_LEN);
  308. struct efx_tc_action_set *act;
  309. size_t inlen, outlen, i = 0;
  310. efx_dword_t *inbuf;
  311. int rc;
  312. list_for_each_entry(act, &acts->list, list)
  313. i++;
  314. if (i == 0)
  315. return -EINVAL;
  316. if (i == 1) {
  317. /* Don't wrap an ASL around a single AS, just use the AS_ID
  318. * directly. ASLs are a more limited resource.
  319. */
  320. act = list_first_entry(&acts->list, struct efx_tc_action_set, list);
  321. acts->fw_id = act->fw_id;
  322. return 0;
  323. }
  324. if (i > MC_CMD_MAE_ACTION_SET_LIST_ALLOC_IN_AS_IDS_MAXNUM_MCDI2)
  325. return -EOPNOTSUPP; /* Too many actions */
  326. inlen = MC_CMD_MAE_ACTION_SET_LIST_ALLOC_IN_LEN(i);
  327. inbuf = kzalloc(inlen, GFP_KERNEL);
  328. if (!inbuf)
  329. return -ENOMEM;
  330. i = 0;
  331. list_for_each_entry(act, &acts->list, list) {
  332. MCDI_SET_ARRAY_DWORD(inbuf, MAE_ACTION_SET_LIST_ALLOC_IN_AS_IDS,
  333. i, act->fw_id);
  334. i++;
  335. }
  336. MCDI_SET_DWORD(inbuf, MAE_ACTION_SET_LIST_ALLOC_IN_COUNT, i);
  337. rc = efx_mcdi_rpc(efx, MC_CMD_MAE_ACTION_SET_LIST_ALLOC, inbuf, inlen,
  338. outbuf, sizeof(outbuf), &outlen);
  339. if (rc)
  340. goto out_free;
  341. if (outlen < sizeof(outbuf)) {
  342. rc = -EIO;
  343. goto out_free;
  344. }
  345. acts->fw_id = MCDI_DWORD(outbuf, MAE_ACTION_SET_LIST_ALLOC_OUT_ASL_ID);
  346. /* We rely on the high bit of ASL IDs always being set.
  347. * The firmware API guarantees this, but let's check it ourselves.
  348. */
  349. if (WARN_ON_ONCE(!efx_mae_asl_id(acts->fw_id))) {
  350. efx_mae_free_action_set_list(efx, acts);
  351. rc = -EIO;
  352. }
  353. out_free:
  354. kfree(inbuf);
  355. return rc;
  356. }
  357. int efx_mae_free_action_set_list(struct efx_nic *efx,
  358. struct efx_tc_action_set_list *acts)
  359. {
  360. MCDI_DECLARE_BUF(outbuf, MC_CMD_MAE_ACTION_SET_LIST_FREE_OUT_LEN(1));
  361. MCDI_DECLARE_BUF(inbuf, MC_CMD_MAE_ACTION_SET_LIST_FREE_IN_LEN(1));
  362. size_t outlen;
  363. int rc;
  364. /* If this is just an AS_ID with no ASL wrapper, then there is
  365. * nothing for us to free. (The AS will be freed later.)
  366. */
  367. if (efx_mae_asl_id(acts->fw_id)) {
  368. MCDI_SET_DWORD(inbuf, MAE_ACTION_SET_LIST_FREE_IN_ASL_ID,
  369. acts->fw_id);
  370. rc = efx_mcdi_rpc(efx, MC_CMD_MAE_ACTION_SET_LIST_FREE, inbuf,
  371. sizeof(inbuf), outbuf, sizeof(outbuf), &outlen);
  372. if (rc)
  373. return rc;
  374. if (outlen < sizeof(outbuf))
  375. return -EIO;
  376. /* FW freed a different ID than we asked for, should never happen.
  377. * Warn because it means we've now got a different idea to the FW of
  378. * what action-set-lists exist, which could cause mayhem later.
  379. */
  380. if (WARN_ON(MCDI_DWORD(outbuf, MAE_ACTION_SET_LIST_FREE_OUT_FREED_ASL_ID) != acts->fw_id))
  381. return -EIO;
  382. }
  383. /* We're probably about to free @acts, but let's just make sure its
  384. * fw_id is blatted so that it won't look valid if it leaks out.
  385. */
  386. acts->fw_id = MC_CMD_MAE_ACTION_SET_LIST_ALLOC_OUT_ACTION_SET_LIST_ID_NULL;
  387. return 0;
  388. }
  389. static int efx_mae_populate_match_criteria(MCDI_DECLARE_STRUCT_PTR(match_crit),
  390. const struct efx_tc_match *match)
  391. {
  392. if (match->mask.ingress_port) {
  393. if (~match->mask.ingress_port)
  394. return -EOPNOTSUPP;
  395. MCDI_STRUCT_SET_DWORD(match_crit,
  396. MAE_FIELD_MASK_VALUE_PAIRS_V2_INGRESS_MPORT_SELECTOR,
  397. match->value.ingress_port);
  398. }
  399. MCDI_STRUCT_SET_DWORD(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_INGRESS_MPORT_SELECTOR_MASK,
  400. match->mask.ingress_port);
  401. MCDI_STRUCT_SET_BYTE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_RECIRC_ID,
  402. match->value.recirc_id);
  403. MCDI_STRUCT_SET_BYTE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_RECIRC_ID_MASK,
  404. match->mask.recirc_id);
  405. return 0;
  406. }
  407. int efx_mae_insert_rule(struct efx_nic *efx, const struct efx_tc_match *match,
  408. u32 prio, u32 acts_id, u32 *id)
  409. {
  410. MCDI_DECLARE_BUF(inbuf, MC_CMD_MAE_ACTION_RULE_INSERT_IN_LEN(MAE_FIELD_MASK_VALUE_PAIRS_V2_LEN));
  411. MCDI_DECLARE_BUF(outbuf, MC_CMD_MAE_ACTION_RULE_INSERT_OUT_LEN);
  412. MCDI_DECLARE_STRUCT_PTR(match_crit);
  413. MCDI_DECLARE_STRUCT_PTR(response);
  414. size_t outlen;
  415. int rc;
  416. if (!id)
  417. return -EINVAL;
  418. match_crit = _MCDI_DWORD(inbuf, MAE_ACTION_RULE_INSERT_IN_MATCH_CRITERIA);
  419. response = _MCDI_DWORD(inbuf, MAE_ACTION_RULE_INSERT_IN_RESPONSE);
  420. if (efx_mae_asl_id(acts_id)) {
  421. MCDI_STRUCT_SET_DWORD(response, MAE_ACTION_RULE_RESPONSE_ASL_ID, acts_id);
  422. MCDI_STRUCT_SET_DWORD(response, MAE_ACTION_RULE_RESPONSE_AS_ID,
  423. MC_CMD_MAE_ACTION_SET_ALLOC_OUT_ACTION_SET_ID_NULL);
  424. } else {
  425. /* We only had one AS, so we didn't wrap it in an ASL */
  426. MCDI_STRUCT_SET_DWORD(response, MAE_ACTION_RULE_RESPONSE_ASL_ID,
  427. MC_CMD_MAE_ACTION_SET_LIST_ALLOC_OUT_ACTION_SET_LIST_ID_NULL);
  428. MCDI_STRUCT_SET_DWORD(response, MAE_ACTION_RULE_RESPONSE_AS_ID, acts_id);
  429. }
  430. MCDI_SET_DWORD(inbuf, MAE_ACTION_RULE_INSERT_IN_PRIO, prio);
  431. rc = efx_mae_populate_match_criteria(match_crit, match);
  432. if (rc)
  433. return rc;
  434. rc = efx_mcdi_rpc(efx, MC_CMD_MAE_ACTION_RULE_INSERT, inbuf, sizeof(inbuf),
  435. outbuf, sizeof(outbuf), &outlen);
  436. if (rc)
  437. return rc;
  438. if (outlen < sizeof(outbuf))
  439. return -EIO;
  440. *id = MCDI_DWORD(outbuf, MAE_ACTION_RULE_INSERT_OUT_AR_ID);
  441. return 0;
  442. }
  443. int efx_mae_delete_rule(struct efx_nic *efx, u32 id)
  444. {
  445. MCDI_DECLARE_BUF(outbuf, MC_CMD_MAE_ACTION_RULE_DELETE_OUT_LEN(1));
  446. MCDI_DECLARE_BUF(inbuf, MC_CMD_MAE_ACTION_RULE_DELETE_IN_LEN(1));
  447. size_t outlen;
  448. int rc;
  449. MCDI_SET_DWORD(inbuf, MAE_ACTION_RULE_DELETE_IN_AR_ID, id);
  450. rc = efx_mcdi_rpc(efx, MC_CMD_MAE_ACTION_RULE_DELETE, inbuf, sizeof(inbuf),
  451. outbuf, sizeof(outbuf), &outlen);
  452. if (rc)
  453. return rc;
  454. if (outlen < sizeof(outbuf))
  455. return -EIO;
  456. /* FW freed a different ID than we asked for, should also never happen.
  457. * Warn because it means we've now got a different idea to the FW of
  458. * what rules exist, which could cause mayhem later.
  459. */
  460. if (WARN_ON(MCDI_DWORD(outbuf, MAE_ACTION_RULE_DELETE_OUT_DELETED_AR_ID) != id))
  461. return -EIO;
  462. return 0;
  463. }