savage_state.c 30 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169
  1. /* savage_state.c -- State and drawing support for Savage
  2. *
  3. * Copyright 2004 Felix Kuehling
  4. * All Rights Reserved.
  5. *
  6. * Permission is hereby granted, free of charge, to any person obtaining a
  7. * copy of this software and associated documentation files (the "Software"),
  8. * to deal in the Software without restriction, including without limitation
  9. * the rights to use, copy, modify, merge, publish, distribute, sub license,
  10. * and/or sell copies of the Software, and to permit persons to whom the
  11. * Software is furnished to do so, subject to the following conditions:
  12. *
  13. * The above copyright notice and this permission notice (including the
  14. * next paragraph) shall be included in all copies or substantial portions
  15. * of the Software.
  16. *
  17. * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
  18. * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
  19. * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
  20. * NON-INFRINGEMENT. IN NO EVENT SHALL FELIX KUEHLING BE LIABLE FOR
  21. * ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF
  22. * CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
  23. * WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  24. */
  25. #include <linux/slab.h>
  26. #include <linux/uaccess.h>
  27. #include <drm/drm_device.h>
  28. #include <drm/drm_file.h>
  29. #include <drm/drm_print.h>
  30. #include <drm/savage_drm.h>
  31. #include "savage_drv.h"
  32. void savage_emit_clip_rect_s3d(drm_savage_private_t * dev_priv,
  33. const struct drm_clip_rect * pbox)
  34. {
  35. uint32_t scstart = dev_priv->state.s3d.new_scstart;
  36. uint32_t scend = dev_priv->state.s3d.new_scend;
  37. scstart = (scstart & ~SAVAGE_SCISSOR_MASK_S3D) |
  38. ((uint32_t) pbox->x1 & 0x000007ff) |
  39. (((uint32_t) pbox->y1 << 16) & 0x07ff0000);
  40. scend = (scend & ~SAVAGE_SCISSOR_MASK_S3D) |
  41. (((uint32_t) pbox->x2 - 1) & 0x000007ff) |
  42. ((((uint32_t) pbox->y2 - 1) << 16) & 0x07ff0000);
  43. if (scstart != dev_priv->state.s3d.scstart ||
  44. scend != dev_priv->state.s3d.scend) {
  45. DMA_LOCALS;
  46. BEGIN_DMA(4);
  47. DMA_WRITE(BCI_CMD_WAIT | BCI_CMD_WAIT_3D);
  48. DMA_SET_REGISTERS(SAVAGE_SCSTART_S3D, 2);
  49. DMA_WRITE(scstart);
  50. DMA_WRITE(scend);
  51. dev_priv->state.s3d.scstart = scstart;
  52. dev_priv->state.s3d.scend = scend;
  53. dev_priv->waiting = 1;
  54. DMA_COMMIT();
  55. }
  56. }
  57. void savage_emit_clip_rect_s4(drm_savage_private_t * dev_priv,
  58. const struct drm_clip_rect * pbox)
  59. {
  60. uint32_t drawctrl0 = dev_priv->state.s4.new_drawctrl0;
  61. uint32_t drawctrl1 = dev_priv->state.s4.new_drawctrl1;
  62. drawctrl0 = (drawctrl0 & ~SAVAGE_SCISSOR_MASK_S4) |
  63. ((uint32_t) pbox->x1 & 0x000007ff) |
  64. (((uint32_t) pbox->y1 << 12) & 0x00fff000);
  65. drawctrl1 = (drawctrl1 & ~SAVAGE_SCISSOR_MASK_S4) |
  66. (((uint32_t) pbox->x2 - 1) & 0x000007ff) |
  67. ((((uint32_t) pbox->y2 - 1) << 12) & 0x00fff000);
  68. if (drawctrl0 != dev_priv->state.s4.drawctrl0 ||
  69. drawctrl1 != dev_priv->state.s4.drawctrl1) {
  70. DMA_LOCALS;
  71. BEGIN_DMA(4);
  72. DMA_WRITE(BCI_CMD_WAIT | BCI_CMD_WAIT_3D);
  73. DMA_SET_REGISTERS(SAVAGE_DRAWCTRL0_S4, 2);
  74. DMA_WRITE(drawctrl0);
  75. DMA_WRITE(drawctrl1);
  76. dev_priv->state.s4.drawctrl0 = drawctrl0;
  77. dev_priv->state.s4.drawctrl1 = drawctrl1;
  78. dev_priv->waiting = 1;
  79. DMA_COMMIT();
  80. }
  81. }
  82. static int savage_verify_texaddr(drm_savage_private_t * dev_priv, int unit,
  83. uint32_t addr)
  84. {
  85. if ((addr & 6) != 2) { /* reserved bits */
  86. DRM_ERROR("bad texAddr%d %08x (reserved bits)\n", unit, addr);
  87. return -EINVAL;
  88. }
  89. if (!(addr & 1)) { /* local */
  90. addr &= ~7;
  91. if (addr < dev_priv->texture_offset ||
  92. addr >= dev_priv->texture_offset + dev_priv->texture_size) {
  93. DRM_ERROR
  94. ("bad texAddr%d %08x (local addr out of range)\n",
  95. unit, addr);
  96. return -EINVAL;
  97. }
  98. } else { /* AGP */
  99. if (!dev_priv->agp_textures) {
  100. DRM_ERROR("bad texAddr%d %08x (AGP not available)\n",
  101. unit, addr);
  102. return -EINVAL;
  103. }
  104. addr &= ~7;
  105. if (addr < dev_priv->agp_textures->offset ||
  106. addr >= (dev_priv->agp_textures->offset +
  107. dev_priv->agp_textures->size)) {
  108. DRM_ERROR
  109. ("bad texAddr%d %08x (AGP addr out of range)\n",
  110. unit, addr);
  111. return -EINVAL;
  112. }
  113. }
  114. return 0;
  115. }
  116. #define SAVE_STATE(reg,where) \
  117. if(start <= reg && start+count > reg) \
  118. dev_priv->state.where = regs[reg - start]
  119. #define SAVE_STATE_MASK(reg,where,mask) do { \
  120. if(start <= reg && start+count > reg) { \
  121. uint32_t tmp; \
  122. tmp = regs[reg - start]; \
  123. dev_priv->state.where = (tmp & (mask)) | \
  124. (dev_priv->state.where & ~(mask)); \
  125. } \
  126. } while (0)
  127. static int savage_verify_state_s3d(drm_savage_private_t * dev_priv,
  128. unsigned int start, unsigned int count,
  129. const uint32_t *regs)
  130. {
  131. if (start < SAVAGE_TEXPALADDR_S3D ||
  132. start + count - 1 > SAVAGE_DESTTEXRWWATERMARK_S3D) {
  133. DRM_ERROR("invalid register range (0x%04x-0x%04x)\n",
  134. start, start + count - 1);
  135. return -EINVAL;
  136. }
  137. SAVE_STATE_MASK(SAVAGE_SCSTART_S3D, s3d.new_scstart,
  138. ~SAVAGE_SCISSOR_MASK_S3D);
  139. SAVE_STATE_MASK(SAVAGE_SCEND_S3D, s3d.new_scend,
  140. ~SAVAGE_SCISSOR_MASK_S3D);
  141. /* if any texture regs were changed ... */
  142. if (start <= SAVAGE_TEXCTRL_S3D &&
  143. start + count > SAVAGE_TEXPALADDR_S3D) {
  144. /* ... check texture state */
  145. SAVE_STATE(SAVAGE_TEXCTRL_S3D, s3d.texctrl);
  146. SAVE_STATE(SAVAGE_TEXADDR_S3D, s3d.texaddr);
  147. if (dev_priv->state.s3d.texctrl & SAVAGE_TEXCTRL_TEXEN_MASK)
  148. return savage_verify_texaddr(dev_priv, 0,
  149. dev_priv->state.s3d.texaddr);
  150. }
  151. return 0;
  152. }
  153. static int savage_verify_state_s4(drm_savage_private_t * dev_priv,
  154. unsigned int start, unsigned int count,
  155. const uint32_t *regs)
  156. {
  157. int ret = 0;
  158. if (start < SAVAGE_DRAWLOCALCTRL_S4 ||
  159. start + count - 1 > SAVAGE_TEXBLENDCOLOR_S4) {
  160. DRM_ERROR("invalid register range (0x%04x-0x%04x)\n",
  161. start, start + count - 1);
  162. return -EINVAL;
  163. }
  164. SAVE_STATE_MASK(SAVAGE_DRAWCTRL0_S4, s4.new_drawctrl0,
  165. ~SAVAGE_SCISSOR_MASK_S4);
  166. SAVE_STATE_MASK(SAVAGE_DRAWCTRL1_S4, s4.new_drawctrl1,
  167. ~SAVAGE_SCISSOR_MASK_S4);
  168. /* if any texture regs were changed ... */
  169. if (start <= SAVAGE_TEXDESCR_S4 &&
  170. start + count > SAVAGE_TEXPALADDR_S4) {
  171. /* ... check texture state */
  172. SAVE_STATE(SAVAGE_TEXDESCR_S4, s4.texdescr);
  173. SAVE_STATE(SAVAGE_TEXADDR0_S4, s4.texaddr0);
  174. SAVE_STATE(SAVAGE_TEXADDR1_S4, s4.texaddr1);
  175. if (dev_priv->state.s4.texdescr & SAVAGE_TEXDESCR_TEX0EN_MASK)
  176. ret |= savage_verify_texaddr(dev_priv, 0,
  177. dev_priv->state.s4.texaddr0);
  178. if (dev_priv->state.s4.texdescr & SAVAGE_TEXDESCR_TEX1EN_MASK)
  179. ret |= savage_verify_texaddr(dev_priv, 1,
  180. dev_priv->state.s4.texaddr1);
  181. }
  182. return ret;
  183. }
  184. #undef SAVE_STATE
  185. #undef SAVE_STATE_MASK
  186. static int savage_dispatch_state(drm_savage_private_t * dev_priv,
  187. const drm_savage_cmd_header_t * cmd_header,
  188. const uint32_t *regs)
  189. {
  190. unsigned int count = cmd_header->state.count;
  191. unsigned int start = cmd_header->state.start;
  192. unsigned int count2 = 0;
  193. unsigned int bci_size;
  194. int ret;
  195. DMA_LOCALS;
  196. if (!count)
  197. return 0;
  198. if (S3_SAVAGE3D_SERIES(dev_priv->chipset)) {
  199. ret = savage_verify_state_s3d(dev_priv, start, count, regs);
  200. if (ret != 0)
  201. return ret;
  202. /* scissor regs are emitted in savage_dispatch_draw */
  203. if (start < SAVAGE_SCSTART_S3D) {
  204. if (start + count > SAVAGE_SCEND_S3D + 1)
  205. count2 = count - (SAVAGE_SCEND_S3D + 1 - start);
  206. if (start + count > SAVAGE_SCSTART_S3D)
  207. count = SAVAGE_SCSTART_S3D - start;
  208. } else if (start <= SAVAGE_SCEND_S3D) {
  209. if (start + count > SAVAGE_SCEND_S3D + 1) {
  210. count -= SAVAGE_SCEND_S3D + 1 - start;
  211. start = SAVAGE_SCEND_S3D + 1;
  212. } else
  213. return 0;
  214. }
  215. } else {
  216. ret = savage_verify_state_s4(dev_priv, start, count, regs);
  217. if (ret != 0)
  218. return ret;
  219. /* scissor regs are emitted in savage_dispatch_draw */
  220. if (start < SAVAGE_DRAWCTRL0_S4) {
  221. if (start + count > SAVAGE_DRAWCTRL1_S4 + 1)
  222. count2 = count -
  223. (SAVAGE_DRAWCTRL1_S4 + 1 - start);
  224. if (start + count > SAVAGE_DRAWCTRL0_S4)
  225. count = SAVAGE_DRAWCTRL0_S4 - start;
  226. } else if (start <= SAVAGE_DRAWCTRL1_S4) {
  227. if (start + count > SAVAGE_DRAWCTRL1_S4 + 1) {
  228. count -= SAVAGE_DRAWCTRL1_S4 + 1 - start;
  229. start = SAVAGE_DRAWCTRL1_S4 + 1;
  230. } else
  231. return 0;
  232. }
  233. }
  234. bci_size = count + (count + 254) / 255 + count2 + (count2 + 254) / 255;
  235. if (cmd_header->state.global) {
  236. BEGIN_DMA(bci_size + 1);
  237. DMA_WRITE(BCI_CMD_WAIT | BCI_CMD_WAIT_3D);
  238. dev_priv->waiting = 1;
  239. } else {
  240. BEGIN_DMA(bci_size);
  241. }
  242. do {
  243. while (count > 0) {
  244. unsigned int n = count < 255 ? count : 255;
  245. DMA_SET_REGISTERS(start, n);
  246. DMA_COPY(regs, n);
  247. count -= n;
  248. start += n;
  249. regs += n;
  250. }
  251. start += 2;
  252. regs += 2;
  253. count = count2;
  254. count2 = 0;
  255. } while (count);
  256. DMA_COMMIT();
  257. return 0;
  258. }
  259. static int savage_dispatch_dma_prim(drm_savage_private_t * dev_priv,
  260. const drm_savage_cmd_header_t * cmd_header,
  261. const struct drm_buf * dmabuf)
  262. {
  263. unsigned char reorder = 0;
  264. unsigned int prim = cmd_header->prim.prim;
  265. unsigned int skip = cmd_header->prim.skip;
  266. unsigned int n = cmd_header->prim.count;
  267. unsigned int start = cmd_header->prim.start;
  268. unsigned int i;
  269. BCI_LOCALS;
  270. if (!dmabuf) {
  271. DRM_ERROR("called without dma buffers!\n");
  272. return -EINVAL;
  273. }
  274. if (!n)
  275. return 0;
  276. switch (prim) {
  277. case SAVAGE_PRIM_TRILIST_201:
  278. reorder = 1;
  279. prim = SAVAGE_PRIM_TRILIST;
  280. fallthrough;
  281. case SAVAGE_PRIM_TRILIST:
  282. if (n % 3 != 0) {
  283. DRM_ERROR("wrong number of vertices %u in TRILIST\n",
  284. n);
  285. return -EINVAL;
  286. }
  287. break;
  288. case SAVAGE_PRIM_TRISTRIP:
  289. case SAVAGE_PRIM_TRIFAN:
  290. if (n < 3) {
  291. DRM_ERROR
  292. ("wrong number of vertices %u in TRIFAN/STRIP\n",
  293. n);
  294. return -EINVAL;
  295. }
  296. break;
  297. default:
  298. DRM_ERROR("invalid primitive type %u\n", prim);
  299. return -EINVAL;
  300. }
  301. if (S3_SAVAGE3D_SERIES(dev_priv->chipset)) {
  302. if (skip != 0) {
  303. DRM_ERROR("invalid skip flags 0x%04x for DMA\n", skip);
  304. return -EINVAL;
  305. }
  306. } else {
  307. unsigned int size = 10 - (skip & 1) - (skip >> 1 & 1) -
  308. (skip >> 2 & 1) - (skip >> 3 & 1) - (skip >> 4 & 1) -
  309. (skip >> 5 & 1) - (skip >> 6 & 1) - (skip >> 7 & 1);
  310. if (skip > SAVAGE_SKIP_ALL_S4 || size != 8) {
  311. DRM_ERROR("invalid skip flags 0x%04x for DMA\n", skip);
  312. return -EINVAL;
  313. }
  314. if (reorder) {
  315. DRM_ERROR("TRILIST_201 used on Savage4 hardware\n");
  316. return -EINVAL;
  317. }
  318. }
  319. if (start + n > dmabuf->total / 32) {
  320. DRM_ERROR("vertex indices (%u-%u) out of range (0-%u)\n",
  321. start, start + n - 1, dmabuf->total / 32);
  322. return -EINVAL;
  323. }
  324. /* Vertex DMA doesn't work with command DMA at the same time,
  325. * so we use BCI_... to submit commands here. Flush buffered
  326. * faked DMA first. */
  327. DMA_FLUSH();
  328. if (dmabuf->bus_address != dev_priv->state.common.vbaddr) {
  329. BEGIN_BCI(2);
  330. BCI_SET_REGISTERS(SAVAGE_VERTBUFADDR, 1);
  331. BCI_WRITE(dmabuf->bus_address | dev_priv->dma_type);
  332. dev_priv->state.common.vbaddr = dmabuf->bus_address;
  333. }
  334. if (S3_SAVAGE3D_SERIES(dev_priv->chipset) && dev_priv->waiting) {
  335. /* Workaround for what looks like a hardware bug. If a
  336. * WAIT_3D_IDLE was emitted some time before the
  337. * indexed drawing command then the engine will lock
  338. * up. There are two known workarounds:
  339. * WAIT_IDLE_EMPTY or emit at least 63 NOPs. */
  340. BEGIN_BCI(63);
  341. for (i = 0; i < 63; ++i)
  342. BCI_WRITE(BCI_CMD_WAIT);
  343. dev_priv->waiting = 0;
  344. }
  345. prim <<= 25;
  346. while (n != 0) {
  347. /* Can emit up to 255 indices (85 triangles) at once. */
  348. unsigned int count = n > 255 ? 255 : n;
  349. if (reorder) {
  350. /* Need to reorder indices for correct flat
  351. * shading while preserving the clock sense
  352. * for correct culling. Only on Savage3D. */
  353. int reorder[3] = { -1, -1, -1 };
  354. reorder[start % 3] = 2;
  355. BEGIN_BCI((count + 1 + 1) / 2);
  356. BCI_DRAW_INDICES_S3D(count, prim, start + 2);
  357. for (i = start + 1; i + 1 < start + count; i += 2)
  358. BCI_WRITE((i + reorder[i % 3]) |
  359. ((i + 1 +
  360. reorder[(i + 1) % 3]) << 16));
  361. if (i < start + count)
  362. BCI_WRITE(i + reorder[i % 3]);
  363. } else if (S3_SAVAGE3D_SERIES(dev_priv->chipset)) {
  364. BEGIN_BCI((count + 1 + 1) / 2);
  365. BCI_DRAW_INDICES_S3D(count, prim, start);
  366. for (i = start + 1; i + 1 < start + count; i += 2)
  367. BCI_WRITE(i | ((i + 1) << 16));
  368. if (i < start + count)
  369. BCI_WRITE(i);
  370. } else {
  371. BEGIN_BCI((count + 2 + 1) / 2);
  372. BCI_DRAW_INDICES_S4(count, prim, skip);
  373. for (i = start; i + 1 < start + count; i += 2)
  374. BCI_WRITE(i | ((i + 1) << 16));
  375. if (i < start + count)
  376. BCI_WRITE(i);
  377. }
  378. start += count;
  379. n -= count;
  380. prim |= BCI_CMD_DRAW_CONT;
  381. }
  382. return 0;
  383. }
  384. static int savage_dispatch_vb_prim(drm_savage_private_t * dev_priv,
  385. const drm_savage_cmd_header_t * cmd_header,
  386. const uint32_t *vtxbuf, unsigned int vb_size,
  387. unsigned int vb_stride)
  388. {
  389. unsigned char reorder = 0;
  390. unsigned int prim = cmd_header->prim.prim;
  391. unsigned int skip = cmd_header->prim.skip;
  392. unsigned int n = cmd_header->prim.count;
  393. unsigned int start = cmd_header->prim.start;
  394. unsigned int vtx_size;
  395. unsigned int i;
  396. DMA_LOCALS;
  397. if (!n)
  398. return 0;
  399. switch (prim) {
  400. case SAVAGE_PRIM_TRILIST_201:
  401. reorder = 1;
  402. prim = SAVAGE_PRIM_TRILIST;
  403. fallthrough;
  404. case SAVAGE_PRIM_TRILIST:
  405. if (n % 3 != 0) {
  406. DRM_ERROR("wrong number of vertices %u in TRILIST\n",
  407. n);
  408. return -EINVAL;
  409. }
  410. break;
  411. case SAVAGE_PRIM_TRISTRIP:
  412. case SAVAGE_PRIM_TRIFAN:
  413. if (n < 3) {
  414. DRM_ERROR
  415. ("wrong number of vertices %u in TRIFAN/STRIP\n",
  416. n);
  417. return -EINVAL;
  418. }
  419. break;
  420. default:
  421. DRM_ERROR("invalid primitive type %u\n", prim);
  422. return -EINVAL;
  423. }
  424. if (S3_SAVAGE3D_SERIES(dev_priv->chipset)) {
  425. if (skip > SAVAGE_SKIP_ALL_S3D) {
  426. DRM_ERROR("invalid skip flags 0x%04x\n", skip);
  427. return -EINVAL;
  428. }
  429. vtx_size = 8; /* full vertex */
  430. } else {
  431. if (skip > SAVAGE_SKIP_ALL_S4) {
  432. DRM_ERROR("invalid skip flags 0x%04x\n", skip);
  433. return -EINVAL;
  434. }
  435. vtx_size = 10; /* full vertex */
  436. }
  437. vtx_size -= (skip & 1) + (skip >> 1 & 1) +
  438. (skip >> 2 & 1) + (skip >> 3 & 1) + (skip >> 4 & 1) +
  439. (skip >> 5 & 1) + (skip >> 6 & 1) + (skip >> 7 & 1);
  440. if (vtx_size > vb_stride) {
  441. DRM_ERROR("vertex size greater than vb stride (%u > %u)\n",
  442. vtx_size, vb_stride);
  443. return -EINVAL;
  444. }
  445. if (start + n > vb_size / (vb_stride * 4)) {
  446. DRM_ERROR("vertex indices (%u-%u) out of range (0-%u)\n",
  447. start, start + n - 1, vb_size / (vb_stride * 4));
  448. return -EINVAL;
  449. }
  450. prim <<= 25;
  451. while (n != 0) {
  452. /* Can emit up to 255 vertices (85 triangles) at once. */
  453. unsigned int count = n > 255 ? 255 : n;
  454. if (reorder) {
  455. /* Need to reorder vertices for correct flat
  456. * shading while preserving the clock sense
  457. * for correct culling. Only on Savage3D. */
  458. int reorder[3] = { -1, -1, -1 };
  459. reorder[start % 3] = 2;
  460. BEGIN_DMA(count * vtx_size + 1);
  461. DMA_DRAW_PRIMITIVE(count, prim, skip);
  462. for (i = start; i < start + count; ++i) {
  463. unsigned int j = i + reorder[i % 3];
  464. DMA_COPY(&vtxbuf[vb_stride * j], vtx_size);
  465. }
  466. DMA_COMMIT();
  467. } else {
  468. BEGIN_DMA(count * vtx_size + 1);
  469. DMA_DRAW_PRIMITIVE(count, prim, skip);
  470. if (vb_stride == vtx_size) {
  471. DMA_COPY(&vtxbuf[vb_stride * start],
  472. vtx_size * count);
  473. } else {
  474. for (i = start; i < start + count; ++i) {
  475. DMA_COPY(&vtxbuf [vb_stride * i],
  476. vtx_size);
  477. }
  478. }
  479. DMA_COMMIT();
  480. }
  481. start += count;
  482. n -= count;
  483. prim |= BCI_CMD_DRAW_CONT;
  484. }
  485. return 0;
  486. }
  487. static int savage_dispatch_dma_idx(drm_savage_private_t * dev_priv,
  488. const drm_savage_cmd_header_t * cmd_header,
  489. const uint16_t *idx,
  490. const struct drm_buf * dmabuf)
  491. {
  492. unsigned char reorder = 0;
  493. unsigned int prim = cmd_header->idx.prim;
  494. unsigned int skip = cmd_header->idx.skip;
  495. unsigned int n = cmd_header->idx.count;
  496. unsigned int i;
  497. BCI_LOCALS;
  498. if (!dmabuf) {
  499. DRM_ERROR("called without dma buffers!\n");
  500. return -EINVAL;
  501. }
  502. if (!n)
  503. return 0;
  504. switch (prim) {
  505. case SAVAGE_PRIM_TRILIST_201:
  506. reorder = 1;
  507. prim = SAVAGE_PRIM_TRILIST;
  508. fallthrough;
  509. case SAVAGE_PRIM_TRILIST:
  510. if (n % 3 != 0) {
  511. DRM_ERROR("wrong number of indices %u in TRILIST\n", n);
  512. return -EINVAL;
  513. }
  514. break;
  515. case SAVAGE_PRIM_TRISTRIP:
  516. case SAVAGE_PRIM_TRIFAN:
  517. if (n < 3) {
  518. DRM_ERROR
  519. ("wrong number of indices %u in TRIFAN/STRIP\n", n);
  520. return -EINVAL;
  521. }
  522. break;
  523. default:
  524. DRM_ERROR("invalid primitive type %u\n", prim);
  525. return -EINVAL;
  526. }
  527. if (S3_SAVAGE3D_SERIES(dev_priv->chipset)) {
  528. if (skip != 0) {
  529. DRM_ERROR("invalid skip flags 0x%04x for DMA\n", skip);
  530. return -EINVAL;
  531. }
  532. } else {
  533. unsigned int size = 10 - (skip & 1) - (skip >> 1 & 1) -
  534. (skip >> 2 & 1) - (skip >> 3 & 1) - (skip >> 4 & 1) -
  535. (skip >> 5 & 1) - (skip >> 6 & 1) - (skip >> 7 & 1);
  536. if (skip > SAVAGE_SKIP_ALL_S4 || size != 8) {
  537. DRM_ERROR("invalid skip flags 0x%04x for DMA\n", skip);
  538. return -EINVAL;
  539. }
  540. if (reorder) {
  541. DRM_ERROR("TRILIST_201 used on Savage4 hardware\n");
  542. return -EINVAL;
  543. }
  544. }
  545. /* Vertex DMA doesn't work with command DMA at the same time,
  546. * so we use BCI_... to submit commands here. Flush buffered
  547. * faked DMA first. */
  548. DMA_FLUSH();
  549. if (dmabuf->bus_address != dev_priv->state.common.vbaddr) {
  550. BEGIN_BCI(2);
  551. BCI_SET_REGISTERS(SAVAGE_VERTBUFADDR, 1);
  552. BCI_WRITE(dmabuf->bus_address | dev_priv->dma_type);
  553. dev_priv->state.common.vbaddr = dmabuf->bus_address;
  554. }
  555. if (S3_SAVAGE3D_SERIES(dev_priv->chipset) && dev_priv->waiting) {
  556. /* Workaround for what looks like a hardware bug. If a
  557. * WAIT_3D_IDLE was emitted some time before the
  558. * indexed drawing command then the engine will lock
  559. * up. There are two known workarounds:
  560. * WAIT_IDLE_EMPTY or emit at least 63 NOPs. */
  561. BEGIN_BCI(63);
  562. for (i = 0; i < 63; ++i)
  563. BCI_WRITE(BCI_CMD_WAIT);
  564. dev_priv->waiting = 0;
  565. }
  566. prim <<= 25;
  567. while (n != 0) {
  568. /* Can emit up to 255 indices (85 triangles) at once. */
  569. unsigned int count = n > 255 ? 255 : n;
  570. /* check indices */
  571. for (i = 0; i < count; ++i) {
  572. if (idx[i] > dmabuf->total / 32) {
  573. DRM_ERROR("idx[%u]=%u out of range (0-%u)\n",
  574. i, idx[i], dmabuf->total / 32);
  575. return -EINVAL;
  576. }
  577. }
  578. if (reorder) {
  579. /* Need to reorder indices for correct flat
  580. * shading while preserving the clock sense
  581. * for correct culling. Only on Savage3D. */
  582. int reorder[3] = { 2, -1, -1 };
  583. BEGIN_BCI((count + 1 + 1) / 2);
  584. BCI_DRAW_INDICES_S3D(count, prim, idx[2]);
  585. for (i = 1; i + 1 < count; i += 2)
  586. BCI_WRITE(idx[i + reorder[i % 3]] |
  587. (idx[i + 1 +
  588. reorder[(i + 1) % 3]] << 16));
  589. if (i < count)
  590. BCI_WRITE(idx[i + reorder[i % 3]]);
  591. } else if (S3_SAVAGE3D_SERIES(dev_priv->chipset)) {
  592. BEGIN_BCI((count + 1 + 1) / 2);
  593. BCI_DRAW_INDICES_S3D(count, prim, idx[0]);
  594. for (i = 1; i + 1 < count; i += 2)
  595. BCI_WRITE(idx[i] | (idx[i + 1] << 16));
  596. if (i < count)
  597. BCI_WRITE(idx[i]);
  598. } else {
  599. BEGIN_BCI((count + 2 + 1) / 2);
  600. BCI_DRAW_INDICES_S4(count, prim, skip);
  601. for (i = 0; i + 1 < count; i += 2)
  602. BCI_WRITE(idx[i] | (idx[i + 1] << 16));
  603. if (i < count)
  604. BCI_WRITE(idx[i]);
  605. }
  606. idx += count;
  607. n -= count;
  608. prim |= BCI_CMD_DRAW_CONT;
  609. }
  610. return 0;
  611. }
  612. static int savage_dispatch_vb_idx(drm_savage_private_t * dev_priv,
  613. const drm_savage_cmd_header_t * cmd_header,
  614. const uint16_t *idx,
  615. const uint32_t *vtxbuf,
  616. unsigned int vb_size, unsigned int vb_stride)
  617. {
  618. unsigned char reorder = 0;
  619. unsigned int prim = cmd_header->idx.prim;
  620. unsigned int skip = cmd_header->idx.skip;
  621. unsigned int n = cmd_header->idx.count;
  622. unsigned int vtx_size;
  623. unsigned int i;
  624. DMA_LOCALS;
  625. if (!n)
  626. return 0;
  627. switch (prim) {
  628. case SAVAGE_PRIM_TRILIST_201:
  629. reorder = 1;
  630. prim = SAVAGE_PRIM_TRILIST;
  631. fallthrough;
  632. case SAVAGE_PRIM_TRILIST:
  633. if (n % 3 != 0) {
  634. DRM_ERROR("wrong number of indices %u in TRILIST\n", n);
  635. return -EINVAL;
  636. }
  637. break;
  638. case SAVAGE_PRIM_TRISTRIP:
  639. case SAVAGE_PRIM_TRIFAN:
  640. if (n < 3) {
  641. DRM_ERROR
  642. ("wrong number of indices %u in TRIFAN/STRIP\n", n);
  643. return -EINVAL;
  644. }
  645. break;
  646. default:
  647. DRM_ERROR("invalid primitive type %u\n", prim);
  648. return -EINVAL;
  649. }
  650. if (S3_SAVAGE3D_SERIES(dev_priv->chipset)) {
  651. if (skip > SAVAGE_SKIP_ALL_S3D) {
  652. DRM_ERROR("invalid skip flags 0x%04x\n", skip);
  653. return -EINVAL;
  654. }
  655. vtx_size = 8; /* full vertex */
  656. } else {
  657. if (skip > SAVAGE_SKIP_ALL_S4) {
  658. DRM_ERROR("invalid skip flags 0x%04x\n", skip);
  659. return -EINVAL;
  660. }
  661. vtx_size = 10; /* full vertex */
  662. }
  663. vtx_size -= (skip & 1) + (skip >> 1 & 1) +
  664. (skip >> 2 & 1) + (skip >> 3 & 1) + (skip >> 4 & 1) +
  665. (skip >> 5 & 1) + (skip >> 6 & 1) + (skip >> 7 & 1);
  666. if (vtx_size > vb_stride) {
  667. DRM_ERROR("vertex size greater than vb stride (%u > %u)\n",
  668. vtx_size, vb_stride);
  669. return -EINVAL;
  670. }
  671. prim <<= 25;
  672. while (n != 0) {
  673. /* Can emit up to 255 vertices (85 triangles) at once. */
  674. unsigned int count = n > 255 ? 255 : n;
  675. /* Check indices */
  676. for (i = 0; i < count; ++i) {
  677. if (idx[i] > vb_size / (vb_stride * 4)) {
  678. DRM_ERROR("idx[%u]=%u out of range (0-%u)\n",
  679. i, idx[i], vb_size / (vb_stride * 4));
  680. return -EINVAL;
  681. }
  682. }
  683. if (reorder) {
  684. /* Need to reorder vertices for correct flat
  685. * shading while preserving the clock sense
  686. * for correct culling. Only on Savage3D. */
  687. int reorder[3] = { 2, -1, -1 };
  688. BEGIN_DMA(count * vtx_size + 1);
  689. DMA_DRAW_PRIMITIVE(count, prim, skip);
  690. for (i = 0; i < count; ++i) {
  691. unsigned int j = idx[i + reorder[i % 3]];
  692. DMA_COPY(&vtxbuf[vb_stride * j], vtx_size);
  693. }
  694. DMA_COMMIT();
  695. } else {
  696. BEGIN_DMA(count * vtx_size + 1);
  697. DMA_DRAW_PRIMITIVE(count, prim, skip);
  698. for (i = 0; i < count; ++i) {
  699. unsigned int j = idx[i];
  700. DMA_COPY(&vtxbuf[vb_stride * j], vtx_size);
  701. }
  702. DMA_COMMIT();
  703. }
  704. idx += count;
  705. n -= count;
  706. prim |= BCI_CMD_DRAW_CONT;
  707. }
  708. return 0;
  709. }
  710. static int savage_dispatch_clear(drm_savage_private_t * dev_priv,
  711. const drm_savage_cmd_header_t * cmd_header,
  712. const drm_savage_cmd_header_t *data,
  713. unsigned int nbox,
  714. const struct drm_clip_rect *boxes)
  715. {
  716. unsigned int flags = cmd_header->clear0.flags;
  717. unsigned int clear_cmd;
  718. unsigned int i, nbufs;
  719. DMA_LOCALS;
  720. if (nbox == 0)
  721. return 0;
  722. clear_cmd = BCI_CMD_RECT | BCI_CMD_RECT_XP | BCI_CMD_RECT_YP |
  723. BCI_CMD_SEND_COLOR | BCI_CMD_DEST_PBD_NEW;
  724. BCI_CMD_SET_ROP(clear_cmd, 0xCC);
  725. nbufs = ((flags & SAVAGE_FRONT) ? 1 : 0) +
  726. ((flags & SAVAGE_BACK) ? 1 : 0) + ((flags & SAVAGE_DEPTH) ? 1 : 0);
  727. if (nbufs == 0)
  728. return 0;
  729. if (data->clear1.mask != 0xffffffff) {
  730. /* set mask */
  731. BEGIN_DMA(2);
  732. DMA_SET_REGISTERS(SAVAGE_BITPLANEWTMASK, 1);
  733. DMA_WRITE(data->clear1.mask);
  734. DMA_COMMIT();
  735. }
  736. for (i = 0; i < nbox; ++i) {
  737. unsigned int x, y, w, h;
  738. unsigned int buf;
  739. x = boxes[i].x1, y = boxes[i].y1;
  740. w = boxes[i].x2 - boxes[i].x1;
  741. h = boxes[i].y2 - boxes[i].y1;
  742. BEGIN_DMA(nbufs * 6);
  743. for (buf = SAVAGE_FRONT; buf <= SAVAGE_DEPTH; buf <<= 1) {
  744. if (!(flags & buf))
  745. continue;
  746. DMA_WRITE(clear_cmd);
  747. switch (buf) {
  748. case SAVAGE_FRONT:
  749. DMA_WRITE(dev_priv->front_offset);
  750. DMA_WRITE(dev_priv->front_bd);
  751. break;
  752. case SAVAGE_BACK:
  753. DMA_WRITE(dev_priv->back_offset);
  754. DMA_WRITE(dev_priv->back_bd);
  755. break;
  756. case SAVAGE_DEPTH:
  757. DMA_WRITE(dev_priv->depth_offset);
  758. DMA_WRITE(dev_priv->depth_bd);
  759. break;
  760. }
  761. DMA_WRITE(data->clear1.value);
  762. DMA_WRITE(BCI_X_Y(x, y));
  763. DMA_WRITE(BCI_W_H(w, h));
  764. }
  765. DMA_COMMIT();
  766. }
  767. if (data->clear1.mask != 0xffffffff) {
  768. /* reset mask */
  769. BEGIN_DMA(2);
  770. DMA_SET_REGISTERS(SAVAGE_BITPLANEWTMASK, 1);
  771. DMA_WRITE(0xffffffff);
  772. DMA_COMMIT();
  773. }
  774. return 0;
  775. }
  776. static int savage_dispatch_swap(drm_savage_private_t * dev_priv,
  777. unsigned int nbox, const struct drm_clip_rect *boxes)
  778. {
  779. unsigned int swap_cmd;
  780. unsigned int i;
  781. DMA_LOCALS;
  782. if (nbox == 0)
  783. return 0;
  784. swap_cmd = BCI_CMD_RECT | BCI_CMD_RECT_XP | BCI_CMD_RECT_YP |
  785. BCI_CMD_SRC_PBD_COLOR_NEW | BCI_CMD_DEST_GBD;
  786. BCI_CMD_SET_ROP(swap_cmd, 0xCC);
  787. for (i = 0; i < nbox; ++i) {
  788. BEGIN_DMA(6);
  789. DMA_WRITE(swap_cmd);
  790. DMA_WRITE(dev_priv->back_offset);
  791. DMA_WRITE(dev_priv->back_bd);
  792. DMA_WRITE(BCI_X_Y(boxes[i].x1, boxes[i].y1));
  793. DMA_WRITE(BCI_X_Y(boxes[i].x1, boxes[i].y1));
  794. DMA_WRITE(BCI_W_H(boxes[i].x2 - boxes[i].x1,
  795. boxes[i].y2 - boxes[i].y1));
  796. DMA_COMMIT();
  797. }
  798. return 0;
  799. }
  800. static int savage_dispatch_draw(drm_savage_private_t * dev_priv,
  801. const drm_savage_cmd_header_t *start,
  802. const drm_savage_cmd_header_t *end,
  803. const struct drm_buf * dmabuf,
  804. const unsigned int *vtxbuf,
  805. unsigned int vb_size, unsigned int vb_stride,
  806. unsigned int nbox,
  807. const struct drm_clip_rect *boxes)
  808. {
  809. unsigned int i, j;
  810. int ret;
  811. for (i = 0; i < nbox; ++i) {
  812. const drm_savage_cmd_header_t *cmdbuf;
  813. dev_priv->emit_clip_rect(dev_priv, &boxes[i]);
  814. cmdbuf = start;
  815. while (cmdbuf < end) {
  816. drm_savage_cmd_header_t cmd_header;
  817. cmd_header = *cmdbuf;
  818. cmdbuf++;
  819. switch (cmd_header.cmd.cmd) {
  820. case SAVAGE_CMD_DMA_PRIM:
  821. ret = savage_dispatch_dma_prim(
  822. dev_priv, &cmd_header, dmabuf);
  823. break;
  824. case SAVAGE_CMD_VB_PRIM:
  825. ret = savage_dispatch_vb_prim(
  826. dev_priv, &cmd_header,
  827. vtxbuf, vb_size, vb_stride);
  828. break;
  829. case SAVAGE_CMD_DMA_IDX:
  830. j = (cmd_header.idx.count + 3) / 4;
  831. /* j was check in savage_bci_cmdbuf */
  832. ret = savage_dispatch_dma_idx(dev_priv,
  833. &cmd_header, (const uint16_t *)cmdbuf,
  834. dmabuf);
  835. cmdbuf += j;
  836. break;
  837. case SAVAGE_CMD_VB_IDX:
  838. j = (cmd_header.idx.count + 3) / 4;
  839. /* j was check in savage_bci_cmdbuf */
  840. ret = savage_dispatch_vb_idx(dev_priv,
  841. &cmd_header, (const uint16_t *)cmdbuf,
  842. (const uint32_t *)vtxbuf, vb_size,
  843. vb_stride);
  844. cmdbuf += j;
  845. break;
  846. default:
  847. /* What's the best return code? EFAULT? */
  848. DRM_ERROR("IMPLEMENTATION ERROR: "
  849. "non-drawing-command %d\n",
  850. cmd_header.cmd.cmd);
  851. return -EINVAL;
  852. }
  853. if (ret != 0)
  854. return ret;
  855. }
  856. }
  857. return 0;
  858. }
  859. int savage_bci_cmdbuf(struct drm_device *dev, void *data, struct drm_file *file_priv)
  860. {
  861. drm_savage_private_t *dev_priv = dev->dev_private;
  862. struct drm_device_dma *dma = dev->dma;
  863. struct drm_buf *dmabuf;
  864. drm_savage_cmdbuf_t *cmdbuf = data;
  865. drm_savage_cmd_header_t *kcmd_addr = NULL;
  866. drm_savage_cmd_header_t *first_draw_cmd;
  867. unsigned int *kvb_addr = NULL;
  868. struct drm_clip_rect *kbox_addr = NULL;
  869. unsigned int i, j;
  870. int ret = 0;
  871. DRM_DEBUG("\n");
  872. LOCK_TEST_WITH_RETURN(dev, file_priv);
  873. if (dma && dma->buflist) {
  874. if (cmdbuf->dma_idx >= dma->buf_count) {
  875. DRM_ERROR
  876. ("vertex buffer index %u out of range (0-%u)\n",
  877. cmdbuf->dma_idx, dma->buf_count - 1);
  878. return -EINVAL;
  879. }
  880. dmabuf = dma->buflist[cmdbuf->dma_idx];
  881. } else {
  882. dmabuf = NULL;
  883. }
  884. /* Copy the user buffers into kernel temporary areas. This hasn't been
  885. * a performance loss compared to VERIFYAREA_READ/
  886. * COPY_FROM_USER_UNCHECKED when done in other drivers, and is correct
  887. * for locking on FreeBSD.
  888. */
  889. if (cmdbuf->size) {
  890. kcmd_addr = kmalloc_array(cmdbuf->size, 8, GFP_KERNEL);
  891. if (kcmd_addr == NULL)
  892. return -ENOMEM;
  893. if (copy_from_user(kcmd_addr, cmdbuf->cmd_addr,
  894. cmdbuf->size * 8))
  895. {
  896. kfree(kcmd_addr);
  897. return -EFAULT;
  898. }
  899. cmdbuf->cmd_addr = kcmd_addr;
  900. }
  901. if (cmdbuf->vb_size) {
  902. kvb_addr = memdup_user(cmdbuf->vb_addr, cmdbuf->vb_size);
  903. if (IS_ERR(kvb_addr)) {
  904. ret = PTR_ERR(kvb_addr);
  905. kvb_addr = NULL;
  906. goto done;
  907. }
  908. cmdbuf->vb_addr = kvb_addr;
  909. }
  910. if (cmdbuf->nbox) {
  911. kbox_addr = kmalloc_array(cmdbuf->nbox, sizeof(struct drm_clip_rect),
  912. GFP_KERNEL);
  913. if (kbox_addr == NULL) {
  914. ret = -ENOMEM;
  915. goto done;
  916. }
  917. if (copy_from_user(kbox_addr, cmdbuf->box_addr,
  918. cmdbuf->nbox * sizeof(struct drm_clip_rect))) {
  919. ret = -EFAULT;
  920. goto done;
  921. }
  922. cmdbuf->box_addr = kbox_addr;
  923. }
  924. /* Make sure writes to DMA buffers are finished before sending
  925. * DMA commands to the graphics hardware. */
  926. mb();
  927. /* Coming from user space. Don't know if the Xserver has
  928. * emitted wait commands. Assuming the worst. */
  929. dev_priv->waiting = 1;
  930. i = 0;
  931. first_draw_cmd = NULL;
  932. while (i < cmdbuf->size) {
  933. drm_savage_cmd_header_t cmd_header;
  934. cmd_header = *(drm_savage_cmd_header_t *)cmdbuf->cmd_addr;
  935. cmdbuf->cmd_addr++;
  936. i++;
  937. /* Group drawing commands with same state to minimize
  938. * iterations over clip rects. */
  939. j = 0;
  940. switch (cmd_header.cmd.cmd) {
  941. case SAVAGE_CMD_DMA_IDX:
  942. case SAVAGE_CMD_VB_IDX:
  943. j = (cmd_header.idx.count + 3) / 4;
  944. if (i + j > cmdbuf->size) {
  945. DRM_ERROR("indexed drawing command extends "
  946. "beyond end of command buffer\n");
  947. DMA_FLUSH();
  948. ret = -EINVAL;
  949. goto done;
  950. }
  951. fallthrough;
  952. case SAVAGE_CMD_DMA_PRIM:
  953. case SAVAGE_CMD_VB_PRIM:
  954. if (!first_draw_cmd)
  955. first_draw_cmd = cmdbuf->cmd_addr - 1;
  956. cmdbuf->cmd_addr += j;
  957. i += j;
  958. break;
  959. default:
  960. if (first_draw_cmd) {
  961. ret = savage_dispatch_draw(
  962. dev_priv, first_draw_cmd,
  963. cmdbuf->cmd_addr - 1,
  964. dmabuf, cmdbuf->vb_addr, cmdbuf->vb_size,
  965. cmdbuf->vb_stride,
  966. cmdbuf->nbox, cmdbuf->box_addr);
  967. if (ret != 0)
  968. goto done;
  969. first_draw_cmd = NULL;
  970. }
  971. }
  972. if (first_draw_cmd)
  973. continue;
  974. switch (cmd_header.cmd.cmd) {
  975. case SAVAGE_CMD_STATE:
  976. j = (cmd_header.state.count + 1) / 2;
  977. if (i + j > cmdbuf->size) {
  978. DRM_ERROR("command SAVAGE_CMD_STATE extends "
  979. "beyond end of command buffer\n");
  980. DMA_FLUSH();
  981. ret = -EINVAL;
  982. goto done;
  983. }
  984. ret = savage_dispatch_state(dev_priv, &cmd_header,
  985. (const uint32_t *)cmdbuf->cmd_addr);
  986. cmdbuf->cmd_addr += j;
  987. i += j;
  988. break;
  989. case SAVAGE_CMD_CLEAR:
  990. if (i + 1 > cmdbuf->size) {
  991. DRM_ERROR("command SAVAGE_CMD_CLEAR extends "
  992. "beyond end of command buffer\n");
  993. DMA_FLUSH();
  994. ret = -EINVAL;
  995. goto done;
  996. }
  997. ret = savage_dispatch_clear(dev_priv, &cmd_header,
  998. cmdbuf->cmd_addr,
  999. cmdbuf->nbox,
  1000. cmdbuf->box_addr);
  1001. cmdbuf->cmd_addr++;
  1002. i++;
  1003. break;
  1004. case SAVAGE_CMD_SWAP:
  1005. ret = savage_dispatch_swap(dev_priv, cmdbuf->nbox,
  1006. cmdbuf->box_addr);
  1007. break;
  1008. default:
  1009. DRM_ERROR("invalid command 0x%x\n",
  1010. cmd_header.cmd.cmd);
  1011. DMA_FLUSH();
  1012. ret = -EINVAL;
  1013. goto done;
  1014. }
  1015. if (ret != 0) {
  1016. DMA_FLUSH();
  1017. goto done;
  1018. }
  1019. }
  1020. if (first_draw_cmd) {
  1021. ret = savage_dispatch_draw (
  1022. dev_priv, first_draw_cmd, cmdbuf->cmd_addr, dmabuf,
  1023. cmdbuf->vb_addr, cmdbuf->vb_size, cmdbuf->vb_stride,
  1024. cmdbuf->nbox, cmdbuf->box_addr);
  1025. if (ret != 0) {
  1026. DMA_FLUSH();
  1027. goto done;
  1028. }
  1029. }
  1030. DMA_FLUSH();
  1031. if (dmabuf && cmdbuf->discard) {
  1032. drm_savage_buf_priv_t *buf_priv = dmabuf->dev_private;
  1033. uint16_t event;
  1034. event = savage_bci_emit_event(dev_priv, SAVAGE_WAIT_3D);
  1035. SET_AGE(&buf_priv->age, event, dev_priv->event_wrap);
  1036. savage_freelist_put(dev, dmabuf);
  1037. }
  1038. done:
  1039. /* If we didn't need to allocate them, these'll be NULL */
  1040. kfree(kcmd_addr);
  1041. kfree(kvb_addr);
  1042. kfree(kbox_addr);
  1043. return ret;
  1044. }