ifcol.cocci 1.2 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849
  1. // SPDX-License-Identifier: GPL-2.0-only
  2. /// Find confusingly indented code in or after an if. An if branch should
  3. /// be indented. The code following an if should not be indented.
  4. /// Sometimes, code after an if that is indented is actually intended to be
  5. /// part of the if branch.
  6. ///
  7. //# This has a high rate of false positives, because Coccinelle's column
  8. //# calculation does not distinguish between spaces and tabs, so code that
  9. //# is not visually aligned may be considered to be in the same column.
  10. //
  11. // Confidence: Low
  12. // Copyright: (C) 2010 Nicolas Palix, DIKU.
  13. // Copyright: (C) 2010 Julia Lawall, DIKU.
  14. // Copyright: (C) 2010 Gilles Muller, INRIA/LiP6.
  15. // URL: https://coccinelle.gitlabpages.inria.fr/website
  16. // Comments:
  17. // Options: --no-includes --include-headers
  18. virtual org
  19. virtual report
  20. @r disable braces4@
  21. position p1,p2;
  22. statement S1,S2;
  23. @@
  24. (
  25. if (...) { ... }
  26. |
  27. if (...) S1@p1 S2@p2
  28. )
  29. @script:python depends on org@
  30. p1 << r.p1;
  31. p2 << r.p2;
  32. @@
  33. if (p1[0].column == p2[0].column):
  34. cocci.print_main("branch",p1)
  35. cocci.print_secs("after",p2)
  36. @script:python depends on report@
  37. p1 << r.p1;
  38. p2 << r.p2;
  39. @@
  40. if (p1[0].column == p2[0].column):
  41. msg = "code aligned with following code on line %s" % (p2[0].line)
  42. coccilib.report.print_report(p1[0],msg)