member.c 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731
  1. // SPDX-License-Identifier: GPL-2.0-only
  2. /******************************************************************************
  3. *******************************************************************************
  4. **
  5. ** Copyright (C) 2005-2011 Red Hat, Inc. All rights reserved.
  6. **
  7. **
  8. *******************************************************************************
  9. ******************************************************************************/
  10. #include "dlm_internal.h"
  11. #include "lockspace.h"
  12. #include "member.h"
  13. #include "recoverd.h"
  14. #include "recover.h"
  15. #include "rcom.h"
  16. #include "config.h"
  17. #include "midcomms.h"
  18. #include "lowcomms.h"
  19. int dlm_slots_version(struct dlm_header *h)
  20. {
  21. if ((le32_to_cpu(h->h_version) & 0x0000FFFF) < DLM_HEADER_SLOTS)
  22. return 0;
  23. return 1;
  24. }
  25. void dlm_slot_save(struct dlm_ls *ls, struct dlm_rcom *rc,
  26. struct dlm_member *memb)
  27. {
  28. struct rcom_config *rf = (struct rcom_config *)rc->rc_buf;
  29. if (!dlm_slots_version(&rc->rc_header))
  30. return;
  31. memb->slot = le16_to_cpu(rf->rf_our_slot);
  32. memb->generation = le32_to_cpu(rf->rf_generation);
  33. }
  34. void dlm_slots_copy_out(struct dlm_ls *ls, struct dlm_rcom *rc)
  35. {
  36. struct dlm_slot *slot;
  37. struct rcom_slot *ro;
  38. int i;
  39. ro = (struct rcom_slot *)(rc->rc_buf + sizeof(struct rcom_config));
  40. /* ls_slots array is sparse, but not rcom_slots */
  41. for (i = 0; i < ls->ls_slots_size; i++) {
  42. slot = &ls->ls_slots[i];
  43. if (!slot->nodeid)
  44. continue;
  45. ro->ro_nodeid = cpu_to_le32(slot->nodeid);
  46. ro->ro_slot = cpu_to_le16(slot->slot);
  47. ro++;
  48. }
  49. }
  50. #define SLOT_DEBUG_LINE 128
  51. static void log_slots(struct dlm_ls *ls, uint32_t gen, int num_slots,
  52. struct rcom_slot *ro0, struct dlm_slot *array,
  53. int array_size)
  54. {
  55. char line[SLOT_DEBUG_LINE];
  56. int len = SLOT_DEBUG_LINE - 1;
  57. int pos = 0;
  58. int ret, i;
  59. memset(line, 0, sizeof(line));
  60. if (array) {
  61. for (i = 0; i < array_size; i++) {
  62. if (!array[i].nodeid)
  63. continue;
  64. ret = snprintf(line + pos, len - pos, " %d:%d",
  65. array[i].slot, array[i].nodeid);
  66. if (ret >= len - pos)
  67. break;
  68. pos += ret;
  69. }
  70. } else if (ro0) {
  71. for (i = 0; i < num_slots; i++) {
  72. ret = snprintf(line + pos, len - pos, " %d:%d",
  73. ro0[i].ro_slot, ro0[i].ro_nodeid);
  74. if (ret >= len - pos)
  75. break;
  76. pos += ret;
  77. }
  78. }
  79. log_rinfo(ls, "generation %u slots %d%s", gen, num_slots, line);
  80. }
  81. int dlm_slots_copy_in(struct dlm_ls *ls)
  82. {
  83. struct dlm_member *memb;
  84. struct dlm_rcom *rc = ls->ls_recover_buf;
  85. struct rcom_config *rf = (struct rcom_config *)rc->rc_buf;
  86. struct rcom_slot *ro0, *ro;
  87. int our_nodeid = dlm_our_nodeid();
  88. int i, num_slots;
  89. uint32_t gen;
  90. if (!dlm_slots_version(&rc->rc_header))
  91. return -1;
  92. gen = le32_to_cpu(rf->rf_generation);
  93. if (gen <= ls->ls_generation) {
  94. log_error(ls, "dlm_slots_copy_in gen %u old %u",
  95. gen, ls->ls_generation);
  96. }
  97. ls->ls_generation = gen;
  98. num_slots = le16_to_cpu(rf->rf_num_slots);
  99. if (!num_slots)
  100. return -1;
  101. ro0 = (struct rcom_slot *)(rc->rc_buf + sizeof(struct rcom_config));
  102. log_slots(ls, gen, num_slots, ro0, NULL, 0);
  103. list_for_each_entry(memb, &ls->ls_nodes, list) {
  104. for (i = 0, ro = ro0; i < num_slots; i++, ro++) {
  105. if (le32_to_cpu(ro->ro_nodeid) != memb->nodeid)
  106. continue;
  107. memb->slot = le16_to_cpu(ro->ro_slot);
  108. memb->slot_prev = memb->slot;
  109. break;
  110. }
  111. if (memb->nodeid == our_nodeid) {
  112. if (ls->ls_slot && ls->ls_slot != memb->slot) {
  113. log_error(ls, "dlm_slots_copy_in our slot "
  114. "changed %d %d", ls->ls_slot,
  115. memb->slot);
  116. return -1;
  117. }
  118. if (!ls->ls_slot)
  119. ls->ls_slot = memb->slot;
  120. }
  121. if (!memb->slot) {
  122. log_error(ls, "dlm_slots_copy_in nodeid %d no slot",
  123. memb->nodeid);
  124. return -1;
  125. }
  126. }
  127. return 0;
  128. }
  129. /* for any nodes that do not support slots, we will not have set memb->slot
  130. in wait_status_all(), so memb->slot will remain -1, and we will not
  131. assign slots or set ls_num_slots here */
  132. int dlm_slots_assign(struct dlm_ls *ls, int *num_slots, int *slots_size,
  133. struct dlm_slot **slots_out, uint32_t *gen_out)
  134. {
  135. struct dlm_member *memb;
  136. struct dlm_slot *array;
  137. int our_nodeid = dlm_our_nodeid();
  138. int array_size, max_slots, i;
  139. int need = 0;
  140. int max = 0;
  141. int num = 0;
  142. uint32_t gen = 0;
  143. /* our own memb struct will have slot -1 gen 0 */
  144. list_for_each_entry(memb, &ls->ls_nodes, list) {
  145. if (memb->nodeid == our_nodeid) {
  146. memb->slot = ls->ls_slot;
  147. memb->generation = ls->ls_generation;
  148. break;
  149. }
  150. }
  151. list_for_each_entry(memb, &ls->ls_nodes, list) {
  152. if (memb->generation > gen)
  153. gen = memb->generation;
  154. /* node doesn't support slots */
  155. if (memb->slot == -1)
  156. return -1;
  157. /* node needs a slot assigned */
  158. if (!memb->slot)
  159. need++;
  160. /* node has a slot assigned */
  161. num++;
  162. if (!max || max < memb->slot)
  163. max = memb->slot;
  164. /* sanity check, once slot is assigned it shouldn't change */
  165. if (memb->slot_prev && memb->slot && memb->slot_prev != memb->slot) {
  166. log_error(ls, "nodeid %d slot changed %d %d",
  167. memb->nodeid, memb->slot_prev, memb->slot);
  168. return -1;
  169. }
  170. memb->slot_prev = memb->slot;
  171. }
  172. array_size = max + need;
  173. array = kcalloc(array_size, sizeof(*array), GFP_NOFS);
  174. if (!array)
  175. return -ENOMEM;
  176. num = 0;
  177. /* fill in slots (offsets) that are used */
  178. list_for_each_entry(memb, &ls->ls_nodes, list) {
  179. if (!memb->slot)
  180. continue;
  181. if (memb->slot > array_size) {
  182. log_error(ls, "invalid slot number %d", memb->slot);
  183. kfree(array);
  184. return -1;
  185. }
  186. array[memb->slot - 1].nodeid = memb->nodeid;
  187. array[memb->slot - 1].slot = memb->slot;
  188. num++;
  189. }
  190. /* assign new slots from unused offsets */
  191. list_for_each_entry(memb, &ls->ls_nodes, list) {
  192. if (memb->slot)
  193. continue;
  194. for (i = 0; i < array_size; i++) {
  195. if (array[i].nodeid)
  196. continue;
  197. memb->slot = i + 1;
  198. memb->slot_prev = memb->slot;
  199. array[i].nodeid = memb->nodeid;
  200. array[i].slot = memb->slot;
  201. num++;
  202. if (!ls->ls_slot && memb->nodeid == our_nodeid)
  203. ls->ls_slot = memb->slot;
  204. break;
  205. }
  206. if (!memb->slot) {
  207. log_error(ls, "no free slot found");
  208. kfree(array);
  209. return -1;
  210. }
  211. }
  212. gen++;
  213. log_slots(ls, gen, num, NULL, array, array_size);
  214. max_slots = (DLM_MAX_APP_BUFSIZE - sizeof(struct dlm_rcom) -
  215. sizeof(struct rcom_config)) / sizeof(struct rcom_slot);
  216. if (num > max_slots) {
  217. log_error(ls, "num_slots %d exceeds max_slots %d",
  218. num, max_slots);
  219. kfree(array);
  220. return -1;
  221. }
  222. *gen_out = gen;
  223. *slots_out = array;
  224. *slots_size = array_size;
  225. *num_slots = num;
  226. return 0;
  227. }
  228. static void add_ordered_member(struct dlm_ls *ls, struct dlm_member *new)
  229. {
  230. struct dlm_member *memb = NULL;
  231. struct list_head *tmp;
  232. struct list_head *newlist = &new->list;
  233. struct list_head *head = &ls->ls_nodes;
  234. list_for_each(tmp, head) {
  235. memb = list_entry(tmp, struct dlm_member, list);
  236. if (new->nodeid < memb->nodeid)
  237. break;
  238. }
  239. if (!memb)
  240. list_add_tail(newlist, head);
  241. else {
  242. /* FIXME: can use list macro here */
  243. newlist->prev = tmp->prev;
  244. newlist->next = tmp;
  245. tmp->prev->next = newlist;
  246. tmp->prev = newlist;
  247. }
  248. }
  249. static int dlm_add_member(struct dlm_ls *ls, struct dlm_config_node *node)
  250. {
  251. struct dlm_member *memb;
  252. int error;
  253. memb = kzalloc(sizeof(*memb), GFP_NOFS);
  254. if (!memb)
  255. return -ENOMEM;
  256. error = dlm_lowcomms_connect_node(node->nodeid);
  257. if (error < 0) {
  258. kfree(memb);
  259. return error;
  260. }
  261. memb->nodeid = node->nodeid;
  262. memb->weight = node->weight;
  263. memb->comm_seq = node->comm_seq;
  264. dlm_midcomms_add_member(node->nodeid);
  265. add_ordered_member(ls, memb);
  266. ls->ls_num_nodes++;
  267. return 0;
  268. }
  269. static struct dlm_member *find_memb(struct list_head *head, int nodeid)
  270. {
  271. struct dlm_member *memb;
  272. list_for_each_entry(memb, head, list) {
  273. if (memb->nodeid == nodeid)
  274. return memb;
  275. }
  276. return NULL;
  277. }
  278. int dlm_is_member(struct dlm_ls *ls, int nodeid)
  279. {
  280. if (find_memb(&ls->ls_nodes, nodeid))
  281. return 1;
  282. return 0;
  283. }
  284. int dlm_is_removed(struct dlm_ls *ls, int nodeid)
  285. {
  286. if (find_memb(&ls->ls_nodes_gone, nodeid))
  287. return 1;
  288. return 0;
  289. }
  290. static void clear_memb_list(struct list_head *head,
  291. void (*after_del)(int nodeid))
  292. {
  293. struct dlm_member *memb;
  294. while (!list_empty(head)) {
  295. memb = list_entry(head->next, struct dlm_member, list);
  296. list_del(&memb->list);
  297. if (after_del)
  298. after_del(memb->nodeid);
  299. kfree(memb);
  300. }
  301. }
  302. static void clear_members_cb(int nodeid)
  303. {
  304. dlm_midcomms_remove_member(nodeid);
  305. }
  306. void dlm_clear_members(struct dlm_ls *ls)
  307. {
  308. clear_memb_list(&ls->ls_nodes, clear_members_cb);
  309. ls->ls_num_nodes = 0;
  310. }
  311. void dlm_clear_members_gone(struct dlm_ls *ls)
  312. {
  313. clear_memb_list(&ls->ls_nodes_gone, NULL);
  314. }
  315. static void make_member_array(struct dlm_ls *ls)
  316. {
  317. struct dlm_member *memb;
  318. int i, w, x = 0, total = 0, all_zero = 0, *array;
  319. kfree(ls->ls_node_array);
  320. ls->ls_node_array = NULL;
  321. list_for_each_entry(memb, &ls->ls_nodes, list) {
  322. if (memb->weight)
  323. total += memb->weight;
  324. }
  325. /* all nodes revert to weight of 1 if all have weight 0 */
  326. if (!total) {
  327. total = ls->ls_num_nodes;
  328. all_zero = 1;
  329. }
  330. ls->ls_total_weight = total;
  331. array = kmalloc_array(total, sizeof(*array), GFP_NOFS);
  332. if (!array)
  333. return;
  334. list_for_each_entry(memb, &ls->ls_nodes, list) {
  335. if (!all_zero && !memb->weight)
  336. continue;
  337. if (all_zero)
  338. w = 1;
  339. else
  340. w = memb->weight;
  341. DLM_ASSERT(x < total, printk("total %d x %d\n", total, x););
  342. for (i = 0; i < w; i++)
  343. array[x++] = memb->nodeid;
  344. }
  345. ls->ls_node_array = array;
  346. }
  347. /* send a status request to all members just to establish comms connections */
  348. static int ping_members(struct dlm_ls *ls)
  349. {
  350. struct dlm_member *memb;
  351. int error = 0;
  352. list_for_each_entry(memb, &ls->ls_nodes, list) {
  353. if (dlm_recovery_stopped(ls)) {
  354. error = -EINTR;
  355. break;
  356. }
  357. error = dlm_rcom_status(ls, memb->nodeid, 0);
  358. if (error)
  359. break;
  360. }
  361. if (error)
  362. log_rinfo(ls, "ping_members aborted %d last nodeid %d",
  363. error, ls->ls_recover_nodeid);
  364. return error;
  365. }
  366. static void dlm_lsop_recover_prep(struct dlm_ls *ls)
  367. {
  368. if (!ls->ls_ops || !ls->ls_ops->recover_prep)
  369. return;
  370. ls->ls_ops->recover_prep(ls->ls_ops_arg);
  371. }
  372. static void dlm_lsop_recover_slot(struct dlm_ls *ls, struct dlm_member *memb)
  373. {
  374. struct dlm_slot slot;
  375. uint32_t seq;
  376. int error;
  377. if (!ls->ls_ops || !ls->ls_ops->recover_slot)
  378. return;
  379. /* if there is no comms connection with this node
  380. or the present comms connection is newer
  381. than the one when this member was added, then
  382. we consider the node to have failed (versus
  383. being removed due to dlm_release_lockspace) */
  384. error = dlm_comm_seq(memb->nodeid, &seq);
  385. if (!error && seq == memb->comm_seq)
  386. return;
  387. slot.nodeid = memb->nodeid;
  388. slot.slot = memb->slot;
  389. ls->ls_ops->recover_slot(ls->ls_ops_arg, &slot);
  390. }
  391. void dlm_lsop_recover_done(struct dlm_ls *ls)
  392. {
  393. struct dlm_member *memb;
  394. struct dlm_slot *slots;
  395. int i, num;
  396. if (!ls->ls_ops || !ls->ls_ops->recover_done)
  397. return;
  398. num = ls->ls_num_nodes;
  399. slots = kcalloc(num, sizeof(*slots), GFP_KERNEL);
  400. if (!slots)
  401. return;
  402. i = 0;
  403. list_for_each_entry(memb, &ls->ls_nodes, list) {
  404. if (i == num) {
  405. log_error(ls, "dlm_lsop_recover_done bad num %d", num);
  406. goto out;
  407. }
  408. slots[i].nodeid = memb->nodeid;
  409. slots[i].slot = memb->slot;
  410. i++;
  411. }
  412. ls->ls_ops->recover_done(ls->ls_ops_arg, slots, num,
  413. ls->ls_slot, ls->ls_generation);
  414. out:
  415. kfree(slots);
  416. }
  417. static struct dlm_config_node *find_config_node(struct dlm_recover *rv,
  418. int nodeid)
  419. {
  420. int i;
  421. for (i = 0; i < rv->nodes_count; i++) {
  422. if (rv->nodes[i].nodeid == nodeid)
  423. return &rv->nodes[i];
  424. }
  425. return NULL;
  426. }
  427. int dlm_recover_members(struct dlm_ls *ls, struct dlm_recover *rv, int *neg_out)
  428. {
  429. struct dlm_member *memb, *safe;
  430. struct dlm_config_node *node;
  431. int i, error, neg = 0, low = -1;
  432. /* previously removed members that we've not finished removing need to
  433. * count as a negative change so the "neg" recovery steps will happen
  434. *
  435. * This functionality must report all member changes to lsops or
  436. * midcomms layer and must never return before.
  437. */
  438. list_for_each_entry(memb, &ls->ls_nodes_gone, list) {
  439. log_rinfo(ls, "prev removed member %d", memb->nodeid);
  440. neg++;
  441. }
  442. /* move departed members from ls_nodes to ls_nodes_gone */
  443. list_for_each_entry_safe(memb, safe, &ls->ls_nodes, list) {
  444. node = find_config_node(rv, memb->nodeid);
  445. if (node && !node->new)
  446. continue;
  447. if (!node) {
  448. log_rinfo(ls, "remove member %d", memb->nodeid);
  449. } else {
  450. /* removed and re-added */
  451. log_rinfo(ls, "remove member %d comm_seq %u %u",
  452. memb->nodeid, memb->comm_seq, node->comm_seq);
  453. }
  454. neg++;
  455. list_move(&memb->list, &ls->ls_nodes_gone);
  456. dlm_midcomms_remove_member(memb->nodeid);
  457. ls->ls_num_nodes--;
  458. dlm_lsop_recover_slot(ls, memb);
  459. }
  460. /* add new members to ls_nodes */
  461. for (i = 0; i < rv->nodes_count; i++) {
  462. node = &rv->nodes[i];
  463. if (dlm_is_member(ls, node->nodeid))
  464. continue;
  465. dlm_add_member(ls, node);
  466. log_rinfo(ls, "add member %d", node->nodeid);
  467. }
  468. list_for_each_entry(memb, &ls->ls_nodes, list) {
  469. if (low == -1 || memb->nodeid < low)
  470. low = memb->nodeid;
  471. }
  472. ls->ls_low_nodeid = low;
  473. make_member_array(ls);
  474. *neg_out = neg;
  475. error = ping_members(ls);
  476. log_rinfo(ls, "dlm_recover_members %d nodes", ls->ls_num_nodes);
  477. return error;
  478. }
  479. /* Userspace guarantees that dlm_ls_stop() has completed on all nodes before
  480. dlm_ls_start() is called on any of them to start the new recovery. */
  481. int dlm_ls_stop(struct dlm_ls *ls)
  482. {
  483. int new;
  484. /*
  485. * Prevent dlm_recv from being in the middle of something when we do
  486. * the stop. This includes ensuring dlm_recv isn't processing a
  487. * recovery message (rcom), while dlm_recoverd is aborting and
  488. * resetting things from an in-progress recovery. i.e. we want
  489. * dlm_recoverd to abort its recovery without worrying about dlm_recv
  490. * processing an rcom at the same time. Stopping dlm_recv also makes
  491. * it easy for dlm_receive_message() to check locking stopped and add a
  492. * message to the requestqueue without races.
  493. */
  494. down_write(&ls->ls_recv_active);
  495. /*
  496. * Abort any recovery that's in progress (see RECOVER_STOP,
  497. * dlm_recovery_stopped()) and tell any other threads running in the
  498. * dlm to quit any processing (see RUNNING, dlm_locking_stopped()).
  499. */
  500. spin_lock(&ls->ls_recover_lock);
  501. set_bit(LSFL_RECOVER_STOP, &ls->ls_flags);
  502. new = test_and_clear_bit(LSFL_RUNNING, &ls->ls_flags);
  503. ls->ls_recover_seq++;
  504. spin_unlock(&ls->ls_recover_lock);
  505. /*
  506. * Let dlm_recv run again, now any normal messages will be saved on the
  507. * requestqueue for later.
  508. */
  509. up_write(&ls->ls_recv_active);
  510. /*
  511. * This in_recovery lock does two things:
  512. * 1) Keeps this function from returning until all threads are out
  513. * of locking routines and locking is truly stopped.
  514. * 2) Keeps any new requests from being processed until it's unlocked
  515. * when recovery is complete.
  516. */
  517. if (new) {
  518. set_bit(LSFL_RECOVER_DOWN, &ls->ls_flags);
  519. wake_up_process(ls->ls_recoverd_task);
  520. wait_event(ls->ls_recover_lock_wait,
  521. test_bit(LSFL_RECOVER_LOCK, &ls->ls_flags));
  522. }
  523. /*
  524. * The recoverd suspend/resume makes sure that dlm_recoverd (if
  525. * running) has noticed RECOVER_STOP above and quit processing the
  526. * previous recovery.
  527. */
  528. dlm_recoverd_suspend(ls);
  529. spin_lock(&ls->ls_recover_lock);
  530. kfree(ls->ls_slots);
  531. ls->ls_slots = NULL;
  532. ls->ls_num_slots = 0;
  533. ls->ls_slots_size = 0;
  534. ls->ls_recover_status = 0;
  535. spin_unlock(&ls->ls_recover_lock);
  536. dlm_recoverd_resume(ls);
  537. if (!ls->ls_recover_begin)
  538. ls->ls_recover_begin = jiffies;
  539. /* call recover_prep ops only once and not multiple times
  540. * for each possible dlm_ls_stop() when recovery is already
  541. * stopped.
  542. *
  543. * If we successful was able to clear LSFL_RUNNING bit and
  544. * it was set we know it is the first dlm_ls_stop() call.
  545. */
  546. if (new)
  547. dlm_lsop_recover_prep(ls);
  548. return 0;
  549. }
  550. int dlm_ls_start(struct dlm_ls *ls)
  551. {
  552. struct dlm_recover *rv, *rv_old;
  553. struct dlm_config_node *nodes = NULL;
  554. int error, count;
  555. rv = kzalloc(sizeof(*rv), GFP_NOFS);
  556. if (!rv)
  557. return -ENOMEM;
  558. error = dlm_config_nodes(ls->ls_name, &nodes, &count);
  559. if (error < 0)
  560. goto fail_rv;
  561. spin_lock(&ls->ls_recover_lock);
  562. /* the lockspace needs to be stopped before it can be started */
  563. if (!dlm_locking_stopped(ls)) {
  564. spin_unlock(&ls->ls_recover_lock);
  565. log_error(ls, "start ignored: lockspace running");
  566. error = -EINVAL;
  567. goto fail;
  568. }
  569. rv->nodes = nodes;
  570. rv->nodes_count = count;
  571. rv->seq = ++ls->ls_recover_seq;
  572. rv_old = ls->ls_recover_args;
  573. ls->ls_recover_args = rv;
  574. spin_unlock(&ls->ls_recover_lock);
  575. if (rv_old) {
  576. log_error(ls, "unused recovery %llx %d",
  577. (unsigned long long)rv_old->seq, rv_old->nodes_count);
  578. kfree(rv_old->nodes);
  579. kfree(rv_old);
  580. }
  581. set_bit(LSFL_RECOVER_WORK, &ls->ls_flags);
  582. wake_up_process(ls->ls_recoverd_task);
  583. return 0;
  584. fail:
  585. kfree(nodes);
  586. fail_rv:
  587. kfree(rv);
  588. return error;
  589. }