
Shared memory is initialized by CRM and used by other drivers; with CRM not active other drivers would fail to access the shared memory if memory manager is deinit. Reader Writer locks can prevent the open/close/ioctl calls from other drivers if CRM open/close is already being processed. Issue observed with the below sequence if drivers are opened from UMD directly without this change. CRM Open successful,ICP open successful, CRM close in progress, ICP open successful, mem mgr deinit and CRM close successful, ICP tries to access HFI memory and result in crash. This change helps to serialze the calls and prevents issue. CRs-Fixed: 3019488 Change-Id: I84d50918713686a067c0e3deb64c9c6ae9edfcb5 Signed-off-by: Tejas Prajapati <quic_tpraja@quicinc.com>
257 lines
5.9 KiB
C
257 lines
5.9 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (c) 2017-2021, The Linux Foundation. All rights reserved.
|
|
* Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
|
|
*/
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/module.h>
|
|
#include <linux/kernel.h>
|
|
|
|
#include "cam_subdev.h"
|
|
#include "cam_node.h"
|
|
#include "cam_fd_context.h"
|
|
#include "cam_fd_hw_mgr.h"
|
|
#include "cam_fd_hw_mgr_intf.h"
|
|
#include "camera_main.h"
|
|
|
|
#define CAM_FD_DEV_NAME "cam-fd"
|
|
|
|
/**
|
|
* struct cam_fd_dev - FD device information
|
|
*
|
|
* @sd: Subdev information
|
|
* @base_ctx: List of base contexts
|
|
* @fd_ctx: List of FD contexts
|
|
* @lock: Mutex handle
|
|
* @open_cnt: FD subdev open count
|
|
* @probe_done: Whether FD probe is completed
|
|
*/
|
|
struct cam_fd_dev {
|
|
struct cam_subdev sd;
|
|
struct cam_context base_ctx[CAM_CTX_MAX];
|
|
struct cam_fd_context fd_ctx[CAM_CTX_MAX];
|
|
struct mutex lock;
|
|
uint32_t open_cnt;
|
|
bool probe_done;
|
|
};
|
|
|
|
static struct cam_fd_dev g_fd_dev;
|
|
|
|
static int cam_fd_dev_open(struct v4l2_subdev *sd,
|
|
struct v4l2_subdev_fh *fh)
|
|
{
|
|
struct cam_fd_dev *fd_dev = &g_fd_dev;
|
|
|
|
cam_req_mgr_rwsem_read_op(CAM_SUBDEV_LOCK);
|
|
|
|
if (!fd_dev->probe_done) {
|
|
CAM_ERR(CAM_FD, "FD Dev not initialized, fd_dev=%pK", fd_dev);
|
|
cam_req_mgr_rwsem_read_op(CAM_SUBDEV_UNLOCK);
|
|
return -ENODEV;
|
|
}
|
|
|
|
mutex_lock(&fd_dev->lock);
|
|
fd_dev->open_cnt++;
|
|
CAM_DBG(CAM_FD, "FD Subdev open count %d", fd_dev->open_cnt);
|
|
mutex_unlock(&fd_dev->lock);
|
|
|
|
cam_req_mgr_rwsem_read_op(CAM_SUBDEV_UNLOCK);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int cam_fd_dev_close_internal(struct v4l2_subdev *sd,
|
|
struct v4l2_subdev_fh *fh)
|
|
{
|
|
struct cam_fd_dev *fd_dev = &g_fd_dev;
|
|
struct cam_node *node = v4l2_get_subdevdata(sd);
|
|
|
|
if (!fd_dev->probe_done) {
|
|
CAM_ERR(CAM_FD, "FD Dev not initialized, fd_dev=%pK", fd_dev);
|
|
return -ENODEV;
|
|
}
|
|
|
|
mutex_lock(&fd_dev->lock);
|
|
if (fd_dev->open_cnt == 0) {
|
|
CAM_WARN(CAM_FD, "device already closed");
|
|
mutex_unlock(&fd_dev->lock);
|
|
return 0;
|
|
}
|
|
fd_dev->open_cnt--;
|
|
CAM_DBG(CAM_FD, "FD Subdev open count %d", fd_dev->open_cnt);
|
|
mutex_unlock(&fd_dev->lock);
|
|
|
|
if (!node) {
|
|
CAM_ERR(CAM_FD, "Node ptr is NULL");
|
|
return -EINVAL;
|
|
}
|
|
|
|
cam_node_shutdown(node);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int cam_fd_dev_close(struct v4l2_subdev *sd,
|
|
struct v4l2_subdev_fh *fh)
|
|
{
|
|
bool crm_active = cam_req_mgr_is_open();
|
|
|
|
if (crm_active) {
|
|
CAM_DBG(CAM_FD, "CRM is ACTIVE, close should be from CRM");
|
|
return 0;
|
|
}
|
|
|
|
return cam_fd_dev_close_internal(sd, fh);
|
|
}
|
|
|
|
static const struct v4l2_subdev_internal_ops cam_fd_subdev_internal_ops = {
|
|
.open = cam_fd_dev_open,
|
|
.close = cam_fd_dev_close,
|
|
};
|
|
|
|
static int cam_fd_dev_component_bind(struct device *dev,
|
|
struct device *master_dev, void *data)
|
|
{
|
|
int rc;
|
|
int i;
|
|
struct cam_hw_mgr_intf hw_mgr_intf;
|
|
struct cam_node *node;
|
|
struct platform_device *pdev = to_platform_device(dev);
|
|
|
|
g_fd_dev.sd.internal_ops = &cam_fd_subdev_internal_ops;
|
|
g_fd_dev.sd.close_seq_prior = CAM_SD_CLOSE_MEDIUM_PRIORITY;
|
|
|
|
/* Initialize the v4l2 subdevice first. (create cam_node) */
|
|
rc = cam_subdev_probe(&g_fd_dev.sd, pdev, CAM_FD_DEV_NAME,
|
|
CAM_FD_DEVICE_TYPE);
|
|
if (rc) {
|
|
CAM_ERR(CAM_FD, "FD cam_subdev_probe failed, rc=%d", rc);
|
|
return rc;
|
|
}
|
|
node = (struct cam_node *) g_fd_dev.sd.token;
|
|
|
|
rc = cam_fd_hw_mgr_init(pdev->dev.of_node, &hw_mgr_intf);
|
|
if (rc) {
|
|
CAM_ERR(CAM_FD, "Failed in initializing FD HW manager, rc=%d",
|
|
rc);
|
|
goto unregister_subdev;
|
|
}
|
|
|
|
for (i = 0; i < CAM_CTX_MAX; i++) {
|
|
rc = cam_fd_context_init(&g_fd_dev.fd_ctx[i],
|
|
&g_fd_dev.base_ctx[i], &node->hw_mgr_intf, i, -1);
|
|
if (rc) {
|
|
CAM_ERR(CAM_FD, "FD context init failed i=%d, rc=%d",
|
|
i, rc);
|
|
goto deinit_ctx;
|
|
}
|
|
}
|
|
|
|
rc = cam_node_init(node, &hw_mgr_intf, g_fd_dev.base_ctx, CAM_CTX_MAX,
|
|
CAM_FD_DEV_NAME);
|
|
if (rc) {
|
|
CAM_ERR(CAM_FD, "FD node init failed, rc=%d", rc);
|
|
goto deinit_ctx;
|
|
}
|
|
|
|
node->sd_handler = cam_fd_dev_close_internal;
|
|
mutex_init(&g_fd_dev.lock);
|
|
g_fd_dev.probe_done = true;
|
|
CAM_DBG(CAM_FD, "Component bound successfully");
|
|
|
|
return 0;
|
|
|
|
deinit_ctx:
|
|
for (--i; i >= 0; i--) {
|
|
if (cam_fd_context_deinit(&g_fd_dev.fd_ctx[i]))
|
|
CAM_ERR(CAM_FD, "FD context %d deinit failed", i);
|
|
}
|
|
unregister_subdev:
|
|
if (cam_subdev_remove(&g_fd_dev.sd))
|
|
CAM_ERR(CAM_FD, "Failed in subdev remove");
|
|
|
|
return rc;
|
|
}
|
|
|
|
static void cam_fd_dev_component_unbind(struct device *dev,
|
|
struct device *master_dev, void *data)
|
|
{
|
|
int i, rc;
|
|
struct platform_device *pdev = to_platform_device(dev);
|
|
|
|
for (i = 0; i < CAM_CTX_MAX; i++) {
|
|
rc = cam_fd_context_deinit(&g_fd_dev.fd_ctx[i]);
|
|
if (rc)
|
|
CAM_ERR(CAM_FD, "FD context %d deinit failed, rc=%d",
|
|
i, rc);
|
|
}
|
|
|
|
rc = cam_fd_hw_mgr_deinit(pdev->dev.of_node);
|
|
if (rc)
|
|
CAM_ERR(CAM_FD, "Failed in hw mgr deinit, rc=%d", rc);
|
|
|
|
rc = cam_subdev_remove(&g_fd_dev.sd);
|
|
if (rc)
|
|
CAM_ERR(CAM_FD, "Unregister failed, rc=%d", rc);
|
|
|
|
mutex_destroy(&g_fd_dev.lock);
|
|
g_fd_dev.probe_done = false;
|
|
}
|
|
|
|
const static struct component_ops cam_fd_dev_component_ops = {
|
|
.bind = cam_fd_dev_component_bind,
|
|
.unbind = cam_fd_dev_component_unbind,
|
|
};
|
|
|
|
static int cam_fd_dev_probe(struct platform_device *pdev)
|
|
{
|
|
int rc = 0;
|
|
|
|
CAM_DBG(CAM_FD, "Adding FD dev component");
|
|
rc = component_add(&pdev->dev, &cam_fd_dev_component_ops);
|
|
if (rc)
|
|
CAM_ERR(CAM_FD, "failed to add component rc: %d", rc);
|
|
|
|
return rc;
|
|
}
|
|
|
|
static int cam_fd_dev_remove(struct platform_device *pdev)
|
|
{
|
|
component_del(&pdev->dev, &cam_fd_dev_component_ops);
|
|
return 0;
|
|
}
|
|
|
|
static const struct of_device_id cam_fd_dt_match[] = {
|
|
{
|
|
.compatible = "qcom,cam-fd"
|
|
},
|
|
{}
|
|
};
|
|
|
|
struct platform_driver cam_fd_driver = {
|
|
.probe = cam_fd_dev_probe,
|
|
.remove = cam_fd_dev_remove,
|
|
.driver = {
|
|
.name = "cam_fd",
|
|
.owner = THIS_MODULE,
|
|
.of_match_table = cam_fd_dt_match,
|
|
.suppress_bind_attrs = true,
|
|
},
|
|
};
|
|
|
|
int cam_fd_dev_init_module(void)
|
|
{
|
|
return platform_driver_register(&cam_fd_driver);
|
|
}
|
|
|
|
void cam_fd_dev_exit_module(void)
|
|
{
|
|
platform_driver_unregister(&cam_fd_driver);
|
|
}
|
|
|
|
MODULE_DESCRIPTION("MSM FD driver");
|
|
MODULE_LICENSE("GPL v2");
|