dsi_drm.c 32 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109
  1. // SPDX-License-Identifier: GPL-2.0-only
  2. /*
  3. * Copyright (c) 2016-2020, The Linux Foundation. All rights reserved.
  4. */
  5. #include <drm/drm_atomic_helper.h>
  6. #include <drm/drm_atomic.h>
  7. #include "msm_kms.h"
  8. #include "sde_connector.h"
  9. #include "dsi_drm.h"
  10. #include "sde_trace.h"
  11. #define to_dsi_bridge(x) container_of((x), struct dsi_bridge, base)
  12. #define to_dsi_state(x) container_of((x), struct dsi_connector_state, base)
  13. #define DEFAULT_PANEL_JITTER_NUMERATOR 2
  14. #define DEFAULT_PANEL_JITTER_DENOMINATOR 1
  15. #define DEFAULT_PANEL_JITTER_ARRAY_SIZE 2
  16. #define DEFAULT_PANEL_PREFILL_LINES 25
  17. static struct dsi_display_mode_priv_info default_priv_info = {
  18. .panel_jitter_numer = DEFAULT_PANEL_JITTER_NUMERATOR,
  19. .panel_jitter_denom = DEFAULT_PANEL_JITTER_DENOMINATOR,
  20. .panel_prefill_lines = DEFAULT_PANEL_PREFILL_LINES,
  21. .dsc_enabled = false,
  22. };
  23. static void convert_to_dsi_mode(const struct drm_display_mode *drm_mode,
  24. struct dsi_display_mode *dsi_mode)
  25. {
  26. memset(dsi_mode, 0, sizeof(*dsi_mode));
  27. dsi_mode->timing.h_active = drm_mode->hdisplay;
  28. dsi_mode->timing.h_back_porch = drm_mode->htotal - drm_mode->hsync_end;
  29. dsi_mode->timing.h_sync_width = drm_mode->htotal -
  30. (drm_mode->hsync_start + dsi_mode->timing.h_back_porch);
  31. dsi_mode->timing.h_front_porch = drm_mode->hsync_start -
  32. drm_mode->hdisplay;
  33. dsi_mode->timing.h_skew = drm_mode->hskew;
  34. dsi_mode->timing.v_active = drm_mode->vdisplay;
  35. dsi_mode->timing.v_back_porch = drm_mode->vtotal - drm_mode->vsync_end;
  36. dsi_mode->timing.v_sync_width = drm_mode->vtotal -
  37. (drm_mode->vsync_start + dsi_mode->timing.v_back_porch);
  38. dsi_mode->timing.v_front_porch = drm_mode->vsync_start -
  39. drm_mode->vdisplay;
  40. dsi_mode->timing.refresh_rate = drm_mode->vrefresh;
  41. dsi_mode->pixel_clk_khz = drm_mode->clock;
  42. dsi_mode->priv_info =
  43. (struct dsi_display_mode_priv_info *)drm_mode->private;
  44. if (dsi_mode->priv_info) {
  45. dsi_mode->timing.dsc_enabled = dsi_mode->priv_info->dsc_enabled;
  46. dsi_mode->timing.dsc = &dsi_mode->priv_info->dsc;
  47. dsi_mode->timing.vdc_enabled = dsi_mode->priv_info->vdc_enabled;
  48. dsi_mode->timing.vdc = &dsi_mode->priv_info->vdc;
  49. dsi_mode->timing.pclk_scale = dsi_mode->priv_info->pclk_scale;
  50. }
  51. if (msm_is_mode_seamless(drm_mode))
  52. dsi_mode->dsi_mode_flags |= DSI_MODE_FLAG_SEAMLESS;
  53. if (msm_is_mode_dynamic_fps(drm_mode))
  54. dsi_mode->dsi_mode_flags |= DSI_MODE_FLAG_DFPS;
  55. if (msm_needs_vblank_pre_modeset(drm_mode))
  56. dsi_mode->dsi_mode_flags |= DSI_MODE_FLAG_VBLANK_PRE_MODESET;
  57. if (msm_is_mode_seamless_dms(drm_mode))
  58. dsi_mode->dsi_mode_flags |= DSI_MODE_FLAG_DMS;
  59. if (msm_is_mode_seamless_vrr(drm_mode))
  60. dsi_mode->dsi_mode_flags |= DSI_MODE_FLAG_VRR;
  61. if (msm_is_mode_seamless_poms(drm_mode))
  62. dsi_mode->dsi_mode_flags |= DSI_MODE_FLAG_POMS;
  63. if (msm_is_mode_seamless_dyn_clk(drm_mode))
  64. dsi_mode->dsi_mode_flags |= DSI_MODE_FLAG_DYN_CLK;
  65. dsi_mode->timing.h_sync_polarity =
  66. !!(drm_mode->flags & DRM_MODE_FLAG_PHSYNC);
  67. dsi_mode->timing.v_sync_polarity =
  68. !!(drm_mode->flags & DRM_MODE_FLAG_PVSYNC);
  69. if (drm_mode->flags & DRM_MODE_FLAG_VID_MODE_PANEL)
  70. dsi_mode->panel_mode = DSI_OP_VIDEO_MODE;
  71. if (drm_mode->flags & DRM_MODE_FLAG_CMD_MODE_PANEL)
  72. dsi_mode->panel_mode = DSI_OP_CMD_MODE;
  73. }
  74. void dsi_convert_to_drm_mode(const struct dsi_display_mode *dsi_mode,
  75. struct drm_display_mode *drm_mode)
  76. {
  77. bool video_mode = (dsi_mode->panel_mode == DSI_OP_VIDEO_MODE);
  78. memset(drm_mode, 0, sizeof(*drm_mode));
  79. drm_mode->hdisplay = dsi_mode->timing.h_active;
  80. drm_mode->hsync_start = drm_mode->hdisplay +
  81. dsi_mode->timing.h_front_porch;
  82. drm_mode->hsync_end = drm_mode->hsync_start +
  83. dsi_mode->timing.h_sync_width;
  84. drm_mode->htotal = drm_mode->hsync_end + dsi_mode->timing.h_back_porch;
  85. drm_mode->hskew = dsi_mode->timing.h_skew;
  86. drm_mode->vdisplay = dsi_mode->timing.v_active;
  87. drm_mode->vsync_start = drm_mode->vdisplay +
  88. dsi_mode->timing.v_front_porch;
  89. drm_mode->vsync_end = drm_mode->vsync_start +
  90. dsi_mode->timing.v_sync_width;
  91. drm_mode->vtotal = drm_mode->vsync_end + dsi_mode->timing.v_back_porch;
  92. drm_mode->vrefresh = dsi_mode->timing.refresh_rate;
  93. drm_mode->clock = dsi_mode->pixel_clk_khz;
  94. drm_mode->private = (int *)dsi_mode->priv_info;
  95. if (dsi_mode->dsi_mode_flags & DSI_MODE_FLAG_SEAMLESS)
  96. drm_mode->flags |= DRM_MODE_FLAG_SEAMLESS;
  97. if (dsi_mode->dsi_mode_flags & DSI_MODE_FLAG_DFPS)
  98. drm_mode->private_flags |= MSM_MODE_FLAG_SEAMLESS_DYNAMIC_FPS;
  99. if (dsi_mode->dsi_mode_flags & DSI_MODE_FLAG_VBLANK_PRE_MODESET)
  100. drm_mode->private_flags |= MSM_MODE_FLAG_VBLANK_PRE_MODESET;
  101. if (dsi_mode->dsi_mode_flags & DSI_MODE_FLAG_DMS)
  102. drm_mode->private_flags |= MSM_MODE_FLAG_SEAMLESS_DMS;
  103. if (dsi_mode->dsi_mode_flags & DSI_MODE_FLAG_VRR)
  104. drm_mode->private_flags |= MSM_MODE_FLAG_SEAMLESS_VRR;
  105. if (dsi_mode->dsi_mode_flags & DSI_MODE_FLAG_POMS)
  106. drm_mode->private_flags |= MSM_MODE_FLAG_SEAMLESS_POMS;
  107. if (dsi_mode->dsi_mode_flags & DSI_MODE_FLAG_DYN_CLK)
  108. drm_mode->private_flags |= MSM_MODE_FLAG_SEAMLESS_DYN_CLK;
  109. if (dsi_mode->timing.h_sync_polarity)
  110. drm_mode->flags |= DRM_MODE_FLAG_PHSYNC;
  111. if (dsi_mode->timing.v_sync_polarity)
  112. drm_mode->flags |= DRM_MODE_FLAG_PVSYNC;
  113. if (dsi_mode->panel_mode == DSI_OP_VIDEO_MODE)
  114. drm_mode->flags |= DRM_MODE_FLAG_VID_MODE_PANEL;
  115. if (dsi_mode->panel_mode == DSI_OP_CMD_MODE)
  116. drm_mode->flags |= DRM_MODE_FLAG_CMD_MODE_PANEL;
  117. /* set mode name */
  118. snprintf(drm_mode->name, DRM_DISPLAY_MODE_LEN, "%dx%dx%dx%d%s",
  119. drm_mode->hdisplay, drm_mode->vdisplay,
  120. drm_mode->vrefresh, drm_mode->clock,
  121. video_mode ? "vid" : "cmd");
  122. }
  123. static int dsi_bridge_attach(struct drm_bridge *bridge)
  124. {
  125. struct dsi_bridge *c_bridge = to_dsi_bridge(bridge);
  126. if (!bridge) {
  127. DSI_ERR("Invalid params\n");
  128. return -EINVAL;
  129. }
  130. DSI_DEBUG("[%d] attached\n", c_bridge->id);
  131. return 0;
  132. }
  133. static void dsi_bridge_pre_enable(struct drm_bridge *bridge)
  134. {
  135. int rc = 0;
  136. struct dsi_bridge *c_bridge = to_dsi_bridge(bridge);
  137. if (!bridge) {
  138. DSI_ERR("Invalid params\n");
  139. return;
  140. }
  141. if (!c_bridge || !c_bridge->display || !c_bridge->display->panel) {
  142. DSI_ERR("Incorrect bridge details\n");
  143. return;
  144. }
  145. atomic_set(&c_bridge->display->panel->esd_recovery_pending, 0);
  146. /* By this point mode should have been validated through mode_fixup */
  147. rc = dsi_display_set_mode(c_bridge->display,
  148. &(c_bridge->dsi_mode), 0x0);
  149. if (rc) {
  150. DSI_ERR("[%d] failed to perform a mode set, rc=%d\n",
  151. c_bridge->id, rc);
  152. return;
  153. }
  154. if (c_bridge->dsi_mode.dsi_mode_flags &
  155. (DSI_MODE_FLAG_SEAMLESS | DSI_MODE_FLAG_VRR |
  156. DSI_MODE_FLAG_DYN_CLK)) {
  157. DSI_DEBUG("[%d] seamless pre-enable\n", c_bridge->id);
  158. return;
  159. }
  160. SDE_ATRACE_BEGIN("dsi_display_prepare");
  161. rc = dsi_display_prepare(c_bridge->display);
  162. if (rc) {
  163. DSI_ERR("[%d] DSI display prepare failed, rc=%d\n",
  164. c_bridge->id, rc);
  165. SDE_ATRACE_END("dsi_display_prepare");
  166. return;
  167. }
  168. SDE_ATRACE_END("dsi_display_prepare");
  169. SDE_ATRACE_BEGIN("dsi_display_enable");
  170. rc = dsi_display_enable(c_bridge->display);
  171. if (rc) {
  172. DSI_ERR("[%d] DSI display enable failed, rc=%d\n",
  173. c_bridge->id, rc);
  174. (void)dsi_display_unprepare(c_bridge->display);
  175. }
  176. SDE_ATRACE_END("dsi_display_enable");
  177. rc = dsi_display_splash_res_cleanup(c_bridge->display);
  178. if (rc)
  179. DSI_ERR("Continuous splash pipeline cleanup failed, rc=%d\n",
  180. rc);
  181. }
  182. static void dsi_bridge_enable(struct drm_bridge *bridge)
  183. {
  184. int rc = 0;
  185. struct dsi_bridge *c_bridge = to_dsi_bridge(bridge);
  186. struct dsi_display *display;
  187. if (!bridge) {
  188. DSI_ERR("Invalid params\n");
  189. return;
  190. }
  191. if (c_bridge->dsi_mode.dsi_mode_flags &
  192. (DSI_MODE_FLAG_SEAMLESS | DSI_MODE_FLAG_VRR |
  193. DSI_MODE_FLAG_DYN_CLK)) {
  194. DSI_DEBUG("[%d] seamless enable\n", c_bridge->id);
  195. return;
  196. }
  197. display = c_bridge->display;
  198. rc = dsi_display_post_enable(display);
  199. if (rc)
  200. DSI_ERR("[%d] DSI display post enabled failed, rc=%d\n",
  201. c_bridge->id, rc);
  202. if (display && display->drm_conn) {
  203. sde_connector_helper_bridge_enable(display->drm_conn);
  204. if (c_bridge->dsi_mode.dsi_mode_flags & DSI_MODE_FLAG_POMS)
  205. sde_connector_schedule_status_work(display->drm_conn,
  206. true);
  207. }
  208. }
  209. static void dsi_bridge_disable(struct drm_bridge *bridge)
  210. {
  211. int rc = 0;
  212. int private_flags;
  213. struct dsi_display *display;
  214. struct dsi_bridge *c_bridge = to_dsi_bridge(bridge);
  215. if (!bridge) {
  216. DSI_ERR("Invalid params\n");
  217. return;
  218. }
  219. display = c_bridge->display;
  220. private_flags =
  221. bridge->encoder->crtc->state->adjusted_mode.private_flags;
  222. if (display && display->drm_conn) {
  223. display->poms_pending =
  224. private_flags & MSM_MODE_FLAG_SEAMLESS_POMS;
  225. sde_connector_helper_bridge_disable(display->drm_conn);
  226. }
  227. rc = dsi_display_pre_disable(c_bridge->display);
  228. if (rc) {
  229. DSI_ERR("[%d] DSI display pre disable failed, rc=%d\n",
  230. c_bridge->id, rc);
  231. }
  232. }
  233. static void dsi_bridge_post_disable(struct drm_bridge *bridge)
  234. {
  235. int rc = 0;
  236. struct dsi_bridge *c_bridge = to_dsi_bridge(bridge);
  237. if (!bridge) {
  238. DSI_ERR("Invalid params\n");
  239. return;
  240. }
  241. SDE_ATRACE_BEGIN("dsi_bridge_post_disable");
  242. SDE_ATRACE_BEGIN("dsi_display_disable");
  243. rc = dsi_display_disable(c_bridge->display);
  244. if (rc) {
  245. DSI_ERR("[%d] DSI display disable failed, rc=%d\n",
  246. c_bridge->id, rc);
  247. SDE_ATRACE_END("dsi_display_disable");
  248. return;
  249. }
  250. SDE_ATRACE_END("dsi_display_disable");
  251. rc = dsi_display_unprepare(c_bridge->display);
  252. if (rc) {
  253. DSI_ERR("[%d] DSI display unprepare failed, rc=%d\n",
  254. c_bridge->id, rc);
  255. SDE_ATRACE_END("dsi_bridge_post_disable");
  256. return;
  257. }
  258. SDE_ATRACE_END("dsi_bridge_post_disable");
  259. }
  260. static void dsi_bridge_mode_set(struct drm_bridge *bridge,
  261. const struct drm_display_mode *mode,
  262. const struct drm_display_mode *adjusted_mode)
  263. {
  264. struct dsi_bridge *c_bridge = to_dsi_bridge(bridge);
  265. if (!bridge || !mode || !adjusted_mode) {
  266. DSI_ERR("Invalid params\n");
  267. return;
  268. }
  269. memset(&(c_bridge->dsi_mode), 0x0, sizeof(struct dsi_display_mode));
  270. convert_to_dsi_mode(adjusted_mode, &(c_bridge->dsi_mode));
  271. /* restore bit_clk_rate also for dynamic clk use cases */
  272. c_bridge->dsi_mode.timing.clk_rate_hz =
  273. dsi_drm_find_bit_clk_rate(c_bridge->display, adjusted_mode);
  274. DSI_DEBUG("clk_rate: %llu\n", c_bridge->dsi_mode.timing.clk_rate_hz);
  275. }
  276. static bool dsi_bridge_mode_fixup(struct drm_bridge *bridge,
  277. const struct drm_display_mode *mode,
  278. struct drm_display_mode *adjusted_mode)
  279. {
  280. int rc = 0;
  281. struct dsi_bridge *c_bridge = to_dsi_bridge(bridge);
  282. struct dsi_display *display;
  283. struct dsi_display_mode dsi_mode, cur_dsi_mode, *panel_dsi_mode;
  284. struct drm_crtc_state *crtc_state;
  285. crtc_state = container_of(mode, struct drm_crtc_state, mode);
  286. if (!bridge || !mode || !adjusted_mode) {
  287. DSI_ERR("Invalid params\n");
  288. return false;
  289. }
  290. display = c_bridge->display;
  291. if (!display) {
  292. DSI_ERR("Invalid params\n");
  293. return false;
  294. }
  295. /*
  296. * if no timing defined in panel, it must be external mode
  297. * and we'll use empty priv info to populate the mode
  298. */
  299. if (display->panel && !display->panel->num_timing_nodes) {
  300. *adjusted_mode = *mode;
  301. adjusted_mode->private = (int *)&default_priv_info;
  302. adjusted_mode->private_flags = 0;
  303. return true;
  304. }
  305. convert_to_dsi_mode(mode, &dsi_mode);
  306. /*
  307. * retrieve dsi mode from dsi driver's cache since not safe to take
  308. * the drm mode config mutex in all paths
  309. */
  310. rc = dsi_display_find_mode(display, &dsi_mode, &panel_dsi_mode);
  311. if (rc)
  312. return rc;
  313. /* propagate the private info to the adjusted_mode derived dsi mode */
  314. dsi_mode.priv_info = panel_dsi_mode->priv_info;
  315. dsi_mode.dsi_mode_flags = panel_dsi_mode->dsi_mode_flags;
  316. dsi_mode.timing.dsc_enabled = dsi_mode.priv_info->dsc_enabled;
  317. dsi_mode.timing.dsc = &dsi_mode.priv_info->dsc;
  318. rc = dsi_display_validate_mode(c_bridge->display, &dsi_mode,
  319. DSI_VALIDATE_FLAG_ALLOW_ADJUST);
  320. if (rc) {
  321. DSI_ERR("[%d] mode is not valid, rc=%d\n", c_bridge->id, rc);
  322. return false;
  323. }
  324. if (bridge->encoder && bridge->encoder->crtc &&
  325. crtc_state->crtc) {
  326. const struct drm_display_mode *cur_mode =
  327. &crtc_state->crtc->state->mode;
  328. convert_to_dsi_mode(cur_mode, &cur_dsi_mode);
  329. cur_dsi_mode.timing.dsc_enabled =
  330. dsi_mode.priv_info->dsc_enabled;
  331. cur_dsi_mode.timing.dsc = &dsi_mode.priv_info->dsc;
  332. rc = dsi_display_validate_mode_change(c_bridge->display,
  333. &cur_dsi_mode, &dsi_mode);
  334. if (rc) {
  335. DSI_ERR("[%s] seamless mode mismatch failure rc=%d\n",
  336. c_bridge->display->name, rc);
  337. return false;
  338. }
  339. /* No panel mode switch when drm pipeline is changing */
  340. if ((dsi_mode.panel_mode != cur_dsi_mode.panel_mode) &&
  341. (!(dsi_mode.dsi_mode_flags & DSI_MODE_FLAG_VRR)) &&
  342. (crtc_state->enable ==
  343. crtc_state->crtc->state->enable))
  344. dsi_mode.dsi_mode_flags |= DSI_MODE_FLAG_POMS;
  345. /* No DMS/VRR when drm pipeline is changing */
  346. if (!drm_mode_equal(cur_mode, adjusted_mode) &&
  347. (!(dsi_mode.dsi_mode_flags & DSI_MODE_FLAG_VRR)) &&
  348. (!(dsi_mode.dsi_mode_flags & DSI_MODE_FLAG_POMS)) &&
  349. (!(dsi_mode.dsi_mode_flags & DSI_MODE_FLAG_DYN_CLK)) &&
  350. (!crtc_state->active_changed ||
  351. display->is_cont_splash_enabled))
  352. dsi_mode.dsi_mode_flags |= DSI_MODE_FLAG_DMS;
  353. }
  354. /* Reject seamless transition when active changed */
  355. if (crtc_state->active_changed &&
  356. ((dsi_mode.dsi_mode_flags & DSI_MODE_FLAG_VRR) ||
  357. (dsi_mode.dsi_mode_flags & DSI_MODE_FLAG_POMS) ||
  358. (dsi_mode.dsi_mode_flags & DSI_MODE_FLAG_DYN_CLK))) {
  359. DSI_INFO("seamless upon active changed 0x%x %d\n",
  360. dsi_mode.dsi_mode_flags, crtc_state->active_changed);
  361. return false;
  362. }
  363. /* convert back to drm mode, propagating the private info & flags */
  364. dsi_convert_to_drm_mode(&dsi_mode, adjusted_mode);
  365. return true;
  366. }
  367. u32 dsi_drm_get_dfps_maxfps(void *display)
  368. {
  369. u32 dfps_maxfps = 0;
  370. struct dsi_display *dsi_display = display;
  371. /*
  372. * The time of SDE transmitting one frame active data
  373. * will not be changed, if frame rate is adjusted with
  374. * VFP method.
  375. * So only return max fps of DFPS for UIDLE update, if DFPS
  376. * is enabled with VFP.
  377. */
  378. if (dsi_display && dsi_display->panel &&
  379. dsi_display->panel->panel_mode == DSI_OP_VIDEO_MODE &&
  380. dsi_display->panel->dfps_caps.type ==
  381. DSI_DFPS_IMMEDIATE_VFP)
  382. dfps_maxfps =
  383. dsi_display->panel->dfps_caps.max_refresh_rate;
  384. return dfps_maxfps;
  385. }
  386. u64 dsi_drm_find_bit_clk_rate(void *display,
  387. const struct drm_display_mode *drm_mode)
  388. {
  389. int i = 0, count = 0;
  390. struct dsi_display *dsi_display = display;
  391. struct dsi_display_mode *dsi_mode;
  392. u64 bit_clk_rate = 0;
  393. if (!dsi_display || !drm_mode)
  394. return 0;
  395. dsi_display_get_mode_count(dsi_display, &count);
  396. for (i = 0; i < count; i++) {
  397. dsi_mode = &dsi_display->modes[i];
  398. if ((dsi_mode->timing.v_active == drm_mode->vdisplay) &&
  399. (dsi_mode->timing.h_active == drm_mode->hdisplay) &&
  400. (dsi_mode->pixel_clk_khz == drm_mode->clock) &&
  401. (dsi_mode->timing.refresh_rate == drm_mode->vrefresh)) {
  402. bit_clk_rate = dsi_mode->timing.clk_rate_hz;
  403. break;
  404. }
  405. }
  406. return bit_clk_rate;
  407. }
  408. int dsi_conn_get_mode_info(struct drm_connector *connector,
  409. const struct drm_display_mode *drm_mode,
  410. struct msm_mode_info *mode_info,
  411. void *display, const struct msm_resource_caps_info *avail_res)
  412. {
  413. struct dsi_display_mode dsi_mode;
  414. struct dsi_mode_info *timing;
  415. int src_bpp, tar_bpp;
  416. if (!drm_mode || !mode_info)
  417. return -EINVAL;
  418. convert_to_dsi_mode(drm_mode, &dsi_mode);
  419. if (!dsi_mode.priv_info)
  420. return -EINVAL;
  421. memset(mode_info, 0, sizeof(*mode_info));
  422. timing = &dsi_mode.timing;
  423. mode_info->frame_rate = dsi_mode.timing.refresh_rate;
  424. mode_info->vtotal = DSI_V_TOTAL(timing);
  425. mode_info->prefill_lines = dsi_mode.priv_info->panel_prefill_lines;
  426. mode_info->jitter_numer = dsi_mode.priv_info->panel_jitter_numer;
  427. mode_info->jitter_denom = dsi_mode.priv_info->panel_jitter_denom;
  428. mode_info->clk_rate = dsi_drm_find_bit_clk_rate(display, drm_mode);
  429. mode_info->dfps_maxfps = dsi_drm_get_dfps_maxfps(display);
  430. mode_info->mdp_transfer_time_us =
  431. dsi_mode.priv_info->mdp_transfer_time_us;
  432. memcpy(&mode_info->topology, &dsi_mode.priv_info->topology,
  433. sizeof(struct msm_display_topology));
  434. if (dsi_mode.priv_info->dsc_enabled) {
  435. mode_info->comp_info.comp_type = MSM_DISPLAY_COMPRESSION_DSC;
  436. mode_info->topology.comp_type = MSM_DISPLAY_COMPRESSION_DSC;
  437. memcpy(&mode_info->comp_info.dsc_info, &dsi_mode.priv_info->dsc,
  438. sizeof(dsi_mode.priv_info->dsc));
  439. } else if (dsi_mode.priv_info->vdc_enabled) {
  440. mode_info->comp_info.comp_type = MSM_DISPLAY_COMPRESSION_VDC;
  441. mode_info->topology.comp_type = MSM_DISPLAY_COMPRESSION_VDC;
  442. memcpy(&mode_info->comp_info.vdc_info, &dsi_mode.priv_info->vdc,
  443. sizeof(dsi_mode.priv_info->vdc));
  444. }
  445. if (mode_info->comp_info.comp_type) {
  446. tar_bpp = dsi_mode.priv_info->pclk_scale.numer;
  447. src_bpp = dsi_mode.priv_info->pclk_scale.denom;
  448. mode_info->comp_info.comp_ratio = mult_frac(1, src_bpp,
  449. tar_bpp);
  450. mode_info->wide_bus_en = dsi_mode.priv_info->widebus_support;
  451. }
  452. if (dsi_mode.priv_info->roi_caps.enabled) {
  453. memcpy(&mode_info->roi_caps, &dsi_mode.priv_info->roi_caps,
  454. sizeof(dsi_mode.priv_info->roi_caps));
  455. }
  456. return 0;
  457. }
  458. static const struct drm_bridge_funcs dsi_bridge_ops = {
  459. .attach = dsi_bridge_attach,
  460. .mode_fixup = dsi_bridge_mode_fixup,
  461. .pre_enable = dsi_bridge_pre_enable,
  462. .enable = dsi_bridge_enable,
  463. .disable = dsi_bridge_disable,
  464. .post_disable = dsi_bridge_post_disable,
  465. .mode_set = dsi_bridge_mode_set,
  466. };
  467. int dsi_conn_set_info_blob(struct drm_connector *connector,
  468. void *info, void *display, struct msm_mode_info *mode_info)
  469. {
  470. struct dsi_display *dsi_display = display;
  471. struct dsi_panel *panel;
  472. enum dsi_pixel_format fmt;
  473. u32 bpp;
  474. if (!info || !dsi_display)
  475. return -EINVAL;
  476. dsi_display->drm_conn = connector;
  477. sde_kms_info_add_keystr(info,
  478. "display type", dsi_display->display_type);
  479. switch (dsi_display->type) {
  480. case DSI_DISPLAY_SINGLE:
  481. sde_kms_info_add_keystr(info, "display config",
  482. "single display");
  483. break;
  484. case DSI_DISPLAY_EXT_BRIDGE:
  485. sde_kms_info_add_keystr(info, "display config", "ext bridge");
  486. break;
  487. case DSI_DISPLAY_SPLIT:
  488. sde_kms_info_add_keystr(info, "display config",
  489. "split display");
  490. break;
  491. case DSI_DISPLAY_SPLIT_EXT_BRIDGE:
  492. sde_kms_info_add_keystr(info, "display config",
  493. "split ext bridge");
  494. break;
  495. default:
  496. DSI_DEBUG("invalid display type:%d\n", dsi_display->type);
  497. break;
  498. }
  499. if (!dsi_display->panel) {
  500. DSI_DEBUG("invalid panel data\n");
  501. goto end;
  502. }
  503. panel = dsi_display->panel;
  504. sde_kms_info_add_keystr(info, "panel name", panel->name);
  505. switch (panel->panel_mode) {
  506. case DSI_OP_VIDEO_MODE:
  507. sde_kms_info_add_keystr(info, "panel mode", "video");
  508. sde_kms_info_add_keystr(info, "qsync support",
  509. panel->qsync_min_fps ? "true" : "false");
  510. break;
  511. case DSI_OP_CMD_MODE:
  512. sde_kms_info_add_keystr(info, "panel mode", "command");
  513. sde_kms_info_add_keyint(info, "mdp_transfer_time_us",
  514. mode_info->mdp_transfer_time_us);
  515. sde_kms_info_add_keystr(info, "qsync support",
  516. panel->qsync_min_fps ? "true" : "false");
  517. break;
  518. default:
  519. DSI_DEBUG("invalid panel type:%d\n", panel->panel_mode);
  520. break;
  521. }
  522. sde_kms_info_add_keystr(info, "dfps support",
  523. panel->dfps_caps.dfps_support ? "true" : "false");
  524. if (panel->dfps_caps.dfps_support) {
  525. sde_kms_info_add_keyint(info, "min_fps",
  526. panel->dfps_caps.min_refresh_rate);
  527. sde_kms_info_add_keyint(info, "max_fps",
  528. panel->dfps_caps.max_refresh_rate);
  529. }
  530. sde_kms_info_add_keystr(info, "dyn bitclk support",
  531. panel->dyn_clk_caps.dyn_clk_support ? "true" : "false");
  532. switch (panel->phy_props.rotation) {
  533. case DSI_PANEL_ROTATE_NONE:
  534. sde_kms_info_add_keystr(info, "panel orientation", "none");
  535. break;
  536. case DSI_PANEL_ROTATE_H_FLIP:
  537. sde_kms_info_add_keystr(info, "panel orientation", "horz flip");
  538. break;
  539. case DSI_PANEL_ROTATE_V_FLIP:
  540. sde_kms_info_add_keystr(info, "panel orientation", "vert flip");
  541. break;
  542. case DSI_PANEL_ROTATE_HV_FLIP:
  543. sde_kms_info_add_keystr(info, "panel orientation",
  544. "horz & vert flip");
  545. break;
  546. default:
  547. DSI_DEBUG("invalid panel rotation:%d\n",
  548. panel->phy_props.rotation);
  549. break;
  550. }
  551. switch (panel->bl_config.type) {
  552. case DSI_BACKLIGHT_PWM:
  553. sde_kms_info_add_keystr(info, "backlight type", "pwm");
  554. break;
  555. case DSI_BACKLIGHT_WLED:
  556. sde_kms_info_add_keystr(info, "backlight type", "wled");
  557. break;
  558. case DSI_BACKLIGHT_DCS:
  559. sde_kms_info_add_keystr(info, "backlight type", "dcs");
  560. break;
  561. default:
  562. DSI_DEBUG("invalid panel backlight type:%d\n",
  563. panel->bl_config.type);
  564. break;
  565. }
  566. if (panel->spr_info.enable)
  567. sde_kms_info_add_keystr(info, "spr_pack_type",
  568. msm_spr_pack_type_str[panel->spr_info.pack_type]);
  569. if (mode_info && mode_info->roi_caps.enabled) {
  570. sde_kms_info_add_keyint(info, "partial_update_num_roi",
  571. mode_info->roi_caps.num_roi);
  572. sde_kms_info_add_keyint(info, "partial_update_xstart",
  573. mode_info->roi_caps.align.xstart_pix_align);
  574. sde_kms_info_add_keyint(info, "partial_update_walign",
  575. mode_info->roi_caps.align.width_pix_align);
  576. sde_kms_info_add_keyint(info, "partial_update_wmin",
  577. mode_info->roi_caps.align.min_width);
  578. sde_kms_info_add_keyint(info, "partial_update_ystart",
  579. mode_info->roi_caps.align.ystart_pix_align);
  580. sde_kms_info_add_keyint(info, "partial_update_halign",
  581. mode_info->roi_caps.align.height_pix_align);
  582. sde_kms_info_add_keyint(info, "partial_update_hmin",
  583. mode_info->roi_caps.align.min_height);
  584. sde_kms_info_add_keyint(info, "partial_update_roimerge",
  585. mode_info->roi_caps.merge_rois);
  586. }
  587. fmt = dsi_display->config.common_config.dst_format;
  588. bpp = dsi_ctrl_pixel_format_to_bpp(fmt);
  589. sde_kms_info_add_keyint(info, "bit_depth", bpp);
  590. end:
  591. return 0;
  592. }
  593. enum drm_connector_status dsi_conn_detect(struct drm_connector *conn,
  594. bool force,
  595. void *display)
  596. {
  597. enum drm_connector_status status = connector_status_unknown;
  598. struct msm_display_info info;
  599. int rc;
  600. if (!conn || !display)
  601. return status;
  602. /* get display dsi_info */
  603. memset(&info, 0x0, sizeof(info));
  604. rc = dsi_display_get_info(conn, &info, display);
  605. if (rc) {
  606. DSI_ERR("failed to get display info, rc=%d\n", rc);
  607. return connector_status_disconnected;
  608. }
  609. if (info.capabilities & MSM_DISPLAY_CAP_HOT_PLUG)
  610. status = (info.is_connected ? connector_status_connected :
  611. connector_status_disconnected);
  612. else
  613. status = connector_status_connected;
  614. conn->display_info.width_mm = info.width_mm;
  615. conn->display_info.height_mm = info.height_mm;
  616. return status;
  617. }
  618. void dsi_connector_put_modes(struct drm_connector *connector,
  619. void *display)
  620. {
  621. struct drm_display_mode *drm_mode;
  622. struct dsi_display_mode dsi_mode;
  623. struct dsi_display *dsi_display;
  624. if (!connector || !display)
  625. return;
  626. list_for_each_entry(drm_mode, &connector->modes, head) {
  627. convert_to_dsi_mode(drm_mode, &dsi_mode);
  628. dsi_display_put_mode(display, &dsi_mode);
  629. }
  630. /* free the display structure modes also */
  631. dsi_display = display;
  632. kfree(dsi_display->modes);
  633. dsi_display->modes = NULL;
  634. }
  635. static int dsi_drm_update_edid_name(struct edid *edid, const char *name)
  636. {
  637. u8 *dtd = (u8 *)&edid->detailed_timings[3];
  638. u8 standard_header[] = {0x00, 0x00, 0x00, 0xFE, 0x00};
  639. u32 dtd_size = 18;
  640. u32 header_size = sizeof(standard_header);
  641. if (!name)
  642. return -EINVAL;
  643. /* Fill standard header */
  644. memcpy(dtd, standard_header, header_size);
  645. dtd_size -= header_size;
  646. dtd_size = min_t(u32, dtd_size, strlen(name));
  647. memcpy(dtd + header_size, name, dtd_size);
  648. return 0;
  649. }
  650. static void dsi_drm_update_dtd(struct edid *edid,
  651. struct dsi_display_mode *modes, u32 modes_count)
  652. {
  653. u32 i;
  654. u32 count = min_t(u32, modes_count, 3);
  655. for (i = 0; i < count; i++) {
  656. struct detailed_timing *dtd = &edid->detailed_timings[i];
  657. struct dsi_display_mode *mode = &modes[i];
  658. struct dsi_mode_info *timing = &mode->timing;
  659. struct detailed_pixel_timing *pd = &dtd->data.pixel_data;
  660. u32 h_blank = timing->h_front_porch + timing->h_sync_width +
  661. timing->h_back_porch;
  662. u32 v_blank = timing->v_front_porch + timing->v_sync_width +
  663. timing->v_back_porch;
  664. u32 h_img = 0, v_img = 0;
  665. dtd->pixel_clock = mode->pixel_clk_khz / 10;
  666. pd->hactive_lo = timing->h_active & 0xFF;
  667. pd->hblank_lo = h_blank & 0xFF;
  668. pd->hactive_hblank_hi = ((h_blank >> 8) & 0xF) |
  669. ((timing->h_active >> 8) & 0xF) << 4;
  670. pd->vactive_lo = timing->v_active & 0xFF;
  671. pd->vblank_lo = v_blank & 0xFF;
  672. pd->vactive_vblank_hi = ((v_blank >> 8) & 0xF) |
  673. ((timing->v_active >> 8) & 0xF) << 4;
  674. pd->hsync_offset_lo = timing->h_front_porch & 0xFF;
  675. pd->hsync_pulse_width_lo = timing->h_sync_width & 0xFF;
  676. pd->vsync_offset_pulse_width_lo =
  677. ((timing->v_front_porch & 0xF) << 4) |
  678. (timing->v_sync_width & 0xF);
  679. pd->hsync_vsync_offset_pulse_width_hi =
  680. (((timing->h_front_porch >> 8) & 0x3) << 6) |
  681. (((timing->h_sync_width >> 8) & 0x3) << 4) |
  682. (((timing->v_front_porch >> 4) & 0x3) << 2) |
  683. (((timing->v_sync_width >> 4) & 0x3) << 0);
  684. pd->width_mm_lo = h_img & 0xFF;
  685. pd->height_mm_lo = v_img & 0xFF;
  686. pd->width_height_mm_hi = (((h_img >> 8) & 0xF) << 4) |
  687. ((v_img >> 8) & 0xF);
  688. pd->hborder = 0;
  689. pd->vborder = 0;
  690. pd->misc = 0;
  691. }
  692. }
  693. static void dsi_drm_update_checksum(struct edid *edid)
  694. {
  695. u8 *data = (u8 *)edid;
  696. u32 i, sum = 0;
  697. for (i = 0; i < EDID_LENGTH - 1; i++)
  698. sum += data[i];
  699. edid->checksum = 0x100 - (sum & 0xFF);
  700. }
  701. int dsi_connector_get_modes(struct drm_connector *connector, void *data,
  702. const struct msm_resource_caps_info *avail_res)
  703. {
  704. int rc, i;
  705. u32 count = 0, edid_size;
  706. struct dsi_display_mode *modes = NULL;
  707. struct drm_display_mode drm_mode;
  708. struct dsi_display *display = data;
  709. struct edid edid;
  710. unsigned int width_mm = connector->display_info.width_mm;
  711. unsigned int height_mm = connector->display_info.height_mm;
  712. const u8 edid_buf[EDID_LENGTH] = {
  713. 0x00, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0x00, 0x44, 0x6D,
  714. 0x01, 0x00, 0x01, 0x00, 0x00, 0x00, 0x1B, 0x10, 0x01, 0x03,
  715. 0x80, 0x00, 0x00, 0x78, 0x0A, 0x0D, 0xC9, 0xA0, 0x57, 0x47,
  716. 0x98, 0x27, 0x12, 0x48, 0x4C, 0x00, 0x00, 0x00, 0x01, 0x01,
  717. 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01,
  718. 0x01, 0x01, 0x01, 0x01,
  719. };
  720. edid_size = min_t(u32, sizeof(edid), EDID_LENGTH);
  721. memcpy(&edid, edid_buf, edid_size);
  722. rc = dsi_display_get_mode_count(display, &count);
  723. if (rc) {
  724. DSI_ERR("failed to get num of modes, rc=%d\n", rc);
  725. goto end;
  726. }
  727. rc = dsi_display_get_modes(display, &modes);
  728. if (rc) {
  729. DSI_ERR("failed to get modes, rc=%d\n", rc);
  730. count = 0;
  731. goto end;
  732. }
  733. for (i = 0; i < count; i++) {
  734. struct drm_display_mode *m;
  735. memset(&drm_mode, 0x0, sizeof(drm_mode));
  736. dsi_convert_to_drm_mode(&modes[i], &drm_mode);
  737. m = drm_mode_duplicate(connector->dev, &drm_mode);
  738. if (!m) {
  739. DSI_ERR("failed to add mode %ux%u\n",
  740. drm_mode.hdisplay,
  741. drm_mode.vdisplay);
  742. count = -ENOMEM;
  743. goto end;
  744. }
  745. m->width_mm = connector->display_info.width_mm;
  746. m->height_mm = connector->display_info.height_mm;
  747. if (display->cmdline_timing != NO_OVERRIDE) {
  748. /* get the preferred mode from dsi display mode */
  749. if (modes[i].is_preferred)
  750. m->type |= DRM_MODE_TYPE_PREFERRED;
  751. } else if (i == 0) {
  752. /* set the first mode in list as preferred */
  753. m->type |= DRM_MODE_TYPE_PREFERRED;
  754. }
  755. drm_mode_probed_add(connector, m);
  756. }
  757. rc = dsi_drm_update_edid_name(&edid, display->panel->name);
  758. if (rc) {
  759. count = 0;
  760. goto end;
  761. }
  762. edid.width_cm = (connector->display_info.width_mm) / 10;
  763. edid.height_cm = (connector->display_info.height_mm) / 10;
  764. dsi_drm_update_dtd(&edid, modes, count);
  765. dsi_drm_update_checksum(&edid);
  766. rc = drm_connector_update_edid_property(connector, &edid);
  767. if (rc)
  768. count = 0;
  769. /*
  770. * DRM EDID structure maintains panel physical dimensions in
  771. * centimeters, we will be losing the precision anything below cm.
  772. * Changing DRM framework will effect other clients at this
  773. * moment, overriding the values back to millimeter.
  774. */
  775. connector->display_info.width_mm = width_mm;
  776. connector->display_info.height_mm = height_mm;
  777. end:
  778. DSI_DEBUG("MODE COUNT =%d\n\n", count);
  779. return count;
  780. }
  781. enum drm_mode_status dsi_conn_mode_valid(struct drm_connector *connector,
  782. struct drm_display_mode *mode,
  783. void *display, const struct msm_resource_caps_info *avail_res)
  784. {
  785. struct dsi_display_mode dsi_mode;
  786. int rc;
  787. if (!connector || !mode) {
  788. DSI_ERR("Invalid params\n");
  789. return MODE_ERROR;
  790. }
  791. convert_to_dsi_mode(mode, &dsi_mode);
  792. rc = dsi_display_validate_mode(display, &dsi_mode,
  793. DSI_VALIDATE_FLAG_ALLOW_ADJUST);
  794. if (rc) {
  795. DSI_ERR("mode not supported, rc=%d\n", rc);
  796. return MODE_BAD;
  797. }
  798. return MODE_OK;
  799. }
  800. int dsi_conn_pre_kickoff(struct drm_connector *connector,
  801. void *display,
  802. struct msm_display_kickoff_params *params)
  803. {
  804. if (!connector || !display || !params) {
  805. DSI_ERR("Invalid params\n");
  806. return -EINVAL;
  807. }
  808. return dsi_display_pre_kickoff(connector, display, params);
  809. }
  810. int dsi_conn_prepare_commit(void *display,
  811. struct msm_display_conn_params *params)
  812. {
  813. if (!display || !params) {
  814. pr_err("Invalid params\n");
  815. return -EINVAL;
  816. }
  817. return dsi_display_pre_commit(display, params);
  818. }
  819. void dsi_conn_enable_event(struct drm_connector *connector,
  820. uint32_t event_idx, bool enable, void *display)
  821. {
  822. struct dsi_event_cb_info event_info;
  823. memset(&event_info, 0, sizeof(event_info));
  824. event_info.event_cb = sde_connector_trigger_event;
  825. event_info.event_usr_ptr = connector;
  826. dsi_display_enable_event(connector, display,
  827. event_idx, &event_info, enable);
  828. }
  829. int dsi_conn_post_kickoff(struct drm_connector *connector,
  830. struct msm_display_conn_params *params)
  831. {
  832. struct drm_encoder *encoder;
  833. struct dsi_bridge *c_bridge;
  834. struct dsi_display_mode adj_mode;
  835. struct dsi_display *display;
  836. struct dsi_display_ctrl *m_ctrl, *ctrl;
  837. int i, rc = 0, ctrl_version;
  838. bool enable;
  839. struct dsi_dyn_clk_caps *dyn_clk_caps;
  840. if (!connector || !connector->state) {
  841. DSI_ERR("invalid connector or connector state\n");
  842. return -EINVAL;
  843. }
  844. encoder = connector->state->best_encoder;
  845. if (!encoder) {
  846. DSI_DEBUG("best encoder is not available\n");
  847. return 0;
  848. }
  849. c_bridge = to_dsi_bridge(encoder->bridge);
  850. adj_mode = c_bridge->dsi_mode;
  851. display = c_bridge->display;
  852. dyn_clk_caps = &(display->panel->dyn_clk_caps);
  853. if (adj_mode.dsi_mode_flags & DSI_MODE_FLAG_VRR) {
  854. m_ctrl = &display->ctrl[display->clk_master_idx];
  855. ctrl_version = m_ctrl->ctrl->version;
  856. rc = dsi_ctrl_timing_db_update(m_ctrl->ctrl, false);
  857. if (rc) {
  858. DSI_ERR("[%s] failed to dfps update rc=%d\n",
  859. display->name, rc);
  860. return -EINVAL;
  861. }
  862. if ((ctrl_version >= DSI_CTRL_VERSION_2_5) &&
  863. (dyn_clk_caps->maintain_const_fps)) {
  864. display_for_each_ctrl(i, display) {
  865. ctrl = &display->ctrl[i];
  866. rc = dsi_ctrl_wait4dynamic_refresh_done(
  867. ctrl->ctrl);
  868. if (rc)
  869. DSI_ERR("wait4dfps refresh failed\n");
  870. }
  871. }
  872. /* Update the rest of the controllers */
  873. display_for_each_ctrl(i, display) {
  874. ctrl = &display->ctrl[i];
  875. if (!ctrl->ctrl || (ctrl == m_ctrl))
  876. continue;
  877. rc = dsi_ctrl_timing_db_update(ctrl->ctrl, false);
  878. if (rc) {
  879. DSI_ERR("[%s] failed to dfps update rc=%d\n",
  880. display->name, rc);
  881. return -EINVAL;
  882. }
  883. }
  884. c_bridge->dsi_mode.dsi_mode_flags &= ~DSI_MODE_FLAG_VRR;
  885. }
  886. /* ensure dynamic clk switch flag is reset */
  887. c_bridge->dsi_mode.dsi_mode_flags &= ~DSI_MODE_FLAG_DYN_CLK;
  888. if (params->qsync_update) {
  889. enable = (params->qsync_mode > 0) ? true : false;
  890. display_for_each_ctrl(i, display)
  891. dsi_ctrl_setup_avr(display->ctrl[i].ctrl, enable);
  892. }
  893. return 0;
  894. }
  895. struct dsi_bridge *dsi_drm_bridge_init(struct dsi_display *display,
  896. struct drm_device *dev,
  897. struct drm_encoder *encoder)
  898. {
  899. int rc = 0;
  900. struct dsi_bridge *bridge;
  901. bridge = kzalloc(sizeof(*bridge), GFP_KERNEL);
  902. if (!bridge) {
  903. rc = -ENOMEM;
  904. goto error;
  905. }
  906. bridge->display = display;
  907. bridge->base.funcs = &dsi_bridge_ops;
  908. bridge->base.encoder = encoder;
  909. rc = drm_bridge_attach(encoder, &bridge->base, NULL);
  910. if (rc) {
  911. DSI_ERR("failed to attach bridge, rc=%d\n", rc);
  912. goto error_free_bridge;
  913. }
  914. encoder->bridge = &bridge->base;
  915. return bridge;
  916. error_free_bridge:
  917. kfree(bridge);
  918. error:
  919. return ERR_PTR(rc);
  920. }
  921. void dsi_drm_bridge_cleanup(struct dsi_bridge *bridge)
  922. {
  923. if (bridge && bridge->base.encoder)
  924. bridge->base.encoder->bridge = NULL;
  925. kfree(bridge);
  926. }