dp_drm.c 17 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747
  1. // SPDX-License-Identifier: GPL-2.0-only
  2. /*
  3. * Copyright (c) 2017-2021, The Linux Foundation. All rights reserved.
  4. */
  5. #include <drm/drm_atomic_helper.h>
  6. #include <drm/drm_atomic.h>
  7. #include <drm/drm_crtc.h>
  8. #include "msm_drv.h"
  9. #include "msm_kms.h"
  10. #include "sde_connector.h"
  11. #include "dp_drm.h"
  12. #include "dp_mst_drm.h"
  13. #include "dp_debug.h"
  14. #define DP_MST_DEBUG(fmt, ...) DP_DEBUG(fmt, ##__VA_ARGS__)
  15. #define to_dp_bridge(x) container_of((x), struct dp_bridge, base)
  16. void convert_to_drm_mode(const struct dp_display_mode *dp_mode,
  17. struct drm_display_mode *drm_mode)
  18. {
  19. u32 flags = 0;
  20. memset(drm_mode, 0, sizeof(*drm_mode));
  21. drm_mode->hdisplay = dp_mode->timing.h_active;
  22. drm_mode->hsync_start = drm_mode->hdisplay +
  23. dp_mode->timing.h_front_porch;
  24. drm_mode->hsync_end = drm_mode->hsync_start +
  25. dp_mode->timing.h_sync_width;
  26. drm_mode->htotal = drm_mode->hsync_end + dp_mode->timing.h_back_porch;
  27. drm_mode->hskew = dp_mode->timing.h_skew;
  28. drm_mode->vdisplay = dp_mode->timing.v_active;
  29. drm_mode->vsync_start = drm_mode->vdisplay +
  30. dp_mode->timing.v_front_porch;
  31. drm_mode->vsync_end = drm_mode->vsync_start +
  32. dp_mode->timing.v_sync_width;
  33. drm_mode->vtotal = drm_mode->vsync_end + dp_mode->timing.v_back_porch;
  34. drm_mode->clock = drm_mode->htotal * drm_mode->vtotal * dp_mode->timing.refresh_rate;
  35. drm_mode->clock /= 1000;
  36. if (dp_mode->timing.h_active_low)
  37. flags |= DRM_MODE_FLAG_NHSYNC;
  38. else
  39. flags |= DRM_MODE_FLAG_PHSYNC;
  40. if (dp_mode->timing.v_active_low)
  41. flags |= DRM_MODE_FLAG_NVSYNC;
  42. else
  43. flags |= DRM_MODE_FLAG_PVSYNC;
  44. drm_mode->flags = flags;
  45. drm_mode->type = 0x48;
  46. drm_mode_set_name(drm_mode);
  47. }
  48. static int dp_bridge_attach(struct drm_bridge *dp_bridge,
  49. enum drm_bridge_attach_flags flags)
  50. {
  51. struct dp_bridge *bridge = to_dp_bridge(dp_bridge);
  52. if (!dp_bridge) {
  53. DP_ERR("Invalid params\n");
  54. return -EINVAL;
  55. }
  56. DP_DEBUG("[%d] attached\n", bridge->id);
  57. return 0;
  58. }
  59. static void dp_bridge_pre_enable(struct drm_bridge *drm_bridge)
  60. {
  61. int rc = 0;
  62. struct dp_bridge *bridge;
  63. struct dp_display *dp;
  64. if (!drm_bridge) {
  65. DP_ERR("Invalid params\n");
  66. return;
  67. }
  68. bridge = to_dp_bridge(drm_bridge);
  69. dp = bridge->display;
  70. if (!bridge->connector) {
  71. DP_ERR("Invalid connector\n");
  72. return;
  73. }
  74. if (!bridge->dp_panel) {
  75. DP_ERR("Invalid dp_panel\n");
  76. return;
  77. }
  78. /* By this point mode should have been validated through mode_fixup */
  79. rc = dp->set_mode(dp, bridge->dp_panel, &bridge->dp_mode);
  80. if (rc) {
  81. DP_ERR("[%d] failed to perform a mode set, rc=%d\n",
  82. bridge->id, rc);
  83. return;
  84. }
  85. rc = dp->prepare(dp, bridge->dp_panel);
  86. if (rc) {
  87. DP_ERR("[%d] DP display prepare failed, rc=%d\n",
  88. bridge->id, rc);
  89. return;
  90. }
  91. /* for SST force stream id, start slot and total slots to 0 */
  92. dp->set_stream_info(dp, bridge->dp_panel, 0, 0, 0, 0, 0);
  93. rc = dp->enable(dp, bridge->dp_panel);
  94. if (rc)
  95. DP_ERR("[%d] DP display enable failed, rc=%d\n",
  96. bridge->id, rc);
  97. }
  98. static void dp_bridge_enable(struct drm_bridge *drm_bridge)
  99. {
  100. int rc = 0;
  101. struct dp_bridge *bridge;
  102. struct dp_display *dp;
  103. if (!drm_bridge) {
  104. DP_ERR("Invalid params\n");
  105. return;
  106. }
  107. bridge = to_dp_bridge(drm_bridge);
  108. if (!bridge->connector) {
  109. DP_ERR("Invalid connector\n");
  110. return;
  111. }
  112. if (!bridge->dp_panel) {
  113. DP_ERR("Invalid dp_panel\n");
  114. return;
  115. }
  116. dp = bridge->display;
  117. rc = dp->post_enable(dp, bridge->dp_panel);
  118. if (rc)
  119. DP_ERR("[%d] DP display post enable failed, rc=%d\n",
  120. bridge->id, rc);
  121. }
  122. static void dp_bridge_disable(struct drm_bridge *drm_bridge)
  123. {
  124. int rc = 0;
  125. struct dp_bridge *bridge;
  126. struct dp_display *dp;
  127. if (!drm_bridge) {
  128. DP_ERR("Invalid params\n");
  129. return;
  130. }
  131. bridge = to_dp_bridge(drm_bridge);
  132. if (!bridge->connector) {
  133. DP_ERR("Invalid connector\n");
  134. return;
  135. }
  136. if (!bridge->dp_panel) {
  137. DP_ERR("Invalid dp_panel\n");
  138. return;
  139. }
  140. dp = bridge->display;
  141. if (!dp) {
  142. DP_ERR("dp is null\n");
  143. return;
  144. }
  145. if (dp)
  146. sde_connector_helper_bridge_disable(bridge->connector);
  147. rc = dp->pre_disable(dp, bridge->dp_panel);
  148. if (rc) {
  149. DP_ERR("[%d] DP display pre disable failed, rc=%d\n",
  150. bridge->id, rc);
  151. }
  152. }
  153. static void dp_bridge_post_disable(struct drm_bridge *drm_bridge)
  154. {
  155. int rc = 0;
  156. struct dp_bridge *bridge;
  157. struct dp_display *dp;
  158. if (!drm_bridge) {
  159. DP_ERR("Invalid params\n");
  160. return;
  161. }
  162. bridge = to_dp_bridge(drm_bridge);
  163. if (!bridge->connector) {
  164. DP_ERR("Invalid connector\n");
  165. return;
  166. }
  167. if (!bridge->dp_panel) {
  168. DP_ERR("Invalid dp_panel\n");
  169. return;
  170. }
  171. dp = bridge->display;
  172. rc = dp->disable(dp, bridge->dp_panel);
  173. if (rc) {
  174. DP_ERR("[%d] DP display disable failed, rc=%d\n",
  175. bridge->id, rc);
  176. return;
  177. }
  178. rc = dp->unprepare(dp, bridge->dp_panel);
  179. if (rc) {
  180. DP_ERR("[%d] DP display unprepare failed, rc=%d\n",
  181. bridge->id, rc);
  182. return;
  183. }
  184. }
  185. static void dp_bridge_mode_set(struct drm_bridge *drm_bridge,
  186. const struct drm_display_mode *mode,
  187. const struct drm_display_mode *adjusted_mode)
  188. {
  189. struct dp_bridge *bridge;
  190. struct dp_display *dp;
  191. if (!drm_bridge || !mode || !adjusted_mode) {
  192. DP_ERR("Invalid params\n");
  193. return;
  194. }
  195. bridge = to_dp_bridge(drm_bridge);
  196. if (!bridge->connector) {
  197. DP_ERR("Invalid connector\n");
  198. return;
  199. }
  200. if (!bridge->dp_panel) {
  201. DP_ERR("Invalid dp_panel\n");
  202. return;
  203. }
  204. dp = bridge->display;
  205. dp->convert_to_dp_mode(dp, bridge->dp_panel, adjusted_mode,
  206. &bridge->dp_mode);
  207. }
  208. static bool dp_bridge_mode_fixup(struct drm_bridge *drm_bridge,
  209. const struct drm_display_mode *mode,
  210. struct drm_display_mode *adjusted_mode)
  211. {
  212. bool ret = true;
  213. struct dp_display_mode dp_mode;
  214. struct dp_bridge *bridge;
  215. struct dp_display *dp;
  216. if (!drm_bridge || !mode || !adjusted_mode) {
  217. DP_ERR("Invalid params\n");
  218. ret = false;
  219. goto end;
  220. }
  221. bridge = to_dp_bridge(drm_bridge);
  222. if (!bridge->connector) {
  223. DP_ERR("Invalid connector\n");
  224. ret = false;
  225. goto end;
  226. }
  227. if (!bridge->dp_panel) {
  228. DP_ERR("Invalid dp_panel\n");
  229. ret = false;
  230. goto end;
  231. }
  232. dp = bridge->display;
  233. dp->convert_to_dp_mode(dp, bridge->dp_panel, mode, &dp_mode);
  234. convert_to_drm_mode(&dp_mode, adjusted_mode);
  235. end:
  236. return ret;
  237. }
  238. static const struct drm_bridge_funcs dp_bridge_ops = {
  239. .attach = dp_bridge_attach,
  240. .mode_fixup = dp_bridge_mode_fixup,
  241. .pre_enable = dp_bridge_pre_enable,
  242. .enable = dp_bridge_enable,
  243. .disable = dp_bridge_disable,
  244. .post_disable = dp_bridge_post_disable,
  245. .mode_set = dp_bridge_mode_set,
  246. };
  247. int dp_connector_config_hdr(struct drm_connector *connector, void *display,
  248. struct sde_connector_state *c_state)
  249. {
  250. struct dp_display *dp = display;
  251. struct sde_connector *sde_conn;
  252. if (!display || !c_state || !connector) {
  253. DP_ERR("invalid params\n");
  254. return -EINVAL;
  255. }
  256. sde_conn = to_sde_connector(connector);
  257. if (!sde_conn->drv_panel) {
  258. DP_ERR("invalid dp panel\n");
  259. return -EINVAL;
  260. }
  261. return dp->config_hdr(dp, sde_conn->drv_panel, &c_state->hdr_meta,
  262. c_state->dyn_hdr_meta.dynamic_hdr_update);
  263. }
  264. int dp_connector_set_colorspace(struct drm_connector *connector,
  265. void *display)
  266. {
  267. struct dp_display *dp_display = display;
  268. struct sde_connector *sde_conn;
  269. if (!dp_display || !connector)
  270. return -EINVAL;
  271. sde_conn = to_sde_connector(connector);
  272. if (!sde_conn->drv_panel) {
  273. pr_err("invalid dp panel\n");
  274. return -EINVAL;
  275. }
  276. return dp_display->set_colorspace(dp_display,
  277. sde_conn->drv_panel, connector->state->colorspace);
  278. }
  279. int dp_connector_post_init(struct drm_connector *connector, void *display)
  280. {
  281. int rc;
  282. struct dp_display *dp_display = display;
  283. struct sde_connector *sde_conn;
  284. if (!dp_display || !connector)
  285. return -EINVAL;
  286. dp_display->base_connector = connector;
  287. dp_display->bridge->connector = connector;
  288. if (dp_display->post_init) {
  289. rc = dp_display->post_init(dp_display);
  290. if (rc)
  291. goto end;
  292. }
  293. sde_conn = to_sde_connector(connector);
  294. dp_display->bridge->dp_panel = sde_conn->drv_panel;
  295. rc = dp_mst_init(dp_display);
  296. if (dp_display->dsc_cont_pps)
  297. sde_conn->ops.update_pps = NULL;
  298. end:
  299. return rc;
  300. }
  301. int dp_connector_get_mode_info(struct drm_connector *connector,
  302. const struct drm_display_mode *drm_mode,
  303. struct msm_sub_mode *sub_mode,
  304. struct msm_mode_info *mode_info,
  305. void *display, const struct msm_resource_caps_info *avail_res)
  306. {
  307. const u32 single_intf = 1;
  308. const u32 no_enc = 0;
  309. struct msm_display_topology *topology;
  310. struct sde_connector *sde_conn;
  311. struct dp_panel *dp_panel;
  312. struct dp_display_mode dp_mode;
  313. struct dp_display *dp_disp = display;
  314. struct msm_drm_private *priv;
  315. struct msm_resource_caps_info avail_dp_res;
  316. int rc = 0;
  317. if (!drm_mode || !mode_info || !avail_res ||
  318. !avail_res->max_mixer_width || !connector || !display ||
  319. !connector->dev || !connector->dev->dev_private) {
  320. DP_ERR("invalid params\n");
  321. return -EINVAL;
  322. }
  323. memset(mode_info, 0, sizeof(*mode_info));
  324. sde_conn = to_sde_connector(connector);
  325. dp_panel = sde_conn->drv_panel;
  326. priv = connector->dev->dev_private;
  327. topology = &mode_info->topology;
  328. rc = dp_disp->get_available_dp_resources(dp_disp, avail_res,
  329. &avail_dp_res);
  330. if (rc) {
  331. DP_ERR("error getting max dp resources. rc:%d\n", rc);
  332. return rc;
  333. }
  334. rc = msm_get_mixer_count(priv, drm_mode, &avail_dp_res,
  335. &topology->num_lm);
  336. if (rc) {
  337. DP_ERR("error getting mixer count. rc:%d\n", rc);
  338. return rc;
  339. }
  340. topology->num_enc = no_enc;
  341. topology->num_intf = single_intf;
  342. mode_info->frame_rate = drm_mode_vrefresh(drm_mode);
  343. mode_info->vtotal = drm_mode->vtotal;
  344. mode_info->wide_bus_en = dp_panel->widebus_en;
  345. dp_disp->convert_to_dp_mode(dp_disp, dp_panel, drm_mode, &dp_mode);
  346. if (dp_mode.timing.comp_info.enabled) {
  347. memcpy(&mode_info->comp_info,
  348. &dp_mode.timing.comp_info,
  349. sizeof(mode_info->comp_info));
  350. topology->num_enc = topology->num_lm;
  351. topology->comp_type = mode_info->comp_info.comp_type;
  352. }
  353. return 0;
  354. }
  355. int dp_connector_get_info(struct drm_connector *connector,
  356. struct msm_display_info *info, void *data)
  357. {
  358. struct dp_display *display = data;
  359. if (!info || !display || !display->drm_dev) {
  360. DP_ERR("invalid params\n");
  361. return -EINVAL;
  362. }
  363. info->intf_type = DRM_MODE_CONNECTOR_DisplayPort;
  364. info->num_of_h_tiles = 1;
  365. info->h_tile_instance[0] = 0;
  366. info->is_connected = display->is_sst_connected;
  367. info->curr_panel_mode = MSM_DISPLAY_VIDEO_MODE;
  368. info->capabilities = MSM_DISPLAY_CAP_VID_MODE | MSM_DISPLAY_CAP_EDID |
  369. MSM_DISPLAY_CAP_HOT_PLUG;
  370. return 0;
  371. }
  372. enum drm_connector_status dp_connector_detect(struct drm_connector *conn,
  373. bool force,
  374. void *display)
  375. {
  376. enum drm_connector_status status = connector_status_unknown;
  377. struct msm_display_info info;
  378. int rc;
  379. if (!conn || !display)
  380. return status;
  381. /* get display dp_info */
  382. memset(&info, 0x0, sizeof(info));
  383. rc = dp_connector_get_info(conn, &info, display);
  384. if (rc) {
  385. DP_ERR("failed to get display info, rc=%d\n", rc);
  386. return connector_status_disconnected;
  387. }
  388. if (info.capabilities & MSM_DISPLAY_CAP_HOT_PLUG)
  389. status = (info.is_connected ? connector_status_connected :
  390. connector_status_disconnected);
  391. else
  392. status = connector_status_connected;
  393. conn->display_info.width_mm = info.width_mm;
  394. conn->display_info.height_mm = info.height_mm;
  395. return status;
  396. }
  397. void dp_connector_post_open(struct drm_connector *connector, void *display)
  398. {
  399. struct dp_display *dp;
  400. if (!display) {
  401. DP_ERR("invalid input\n");
  402. return;
  403. }
  404. dp = display;
  405. if (dp->post_open)
  406. dp->post_open(dp);
  407. }
  408. int dp_connector_atomic_check(struct drm_connector *connector,
  409. void *display,
  410. struct drm_atomic_state *a_state)
  411. {
  412. struct sde_connector *sde_conn;
  413. struct drm_connector_state *old_state;
  414. struct drm_connector_state *c_state;
  415. if (!connector || !display || !a_state)
  416. return -EINVAL;
  417. c_state = drm_atomic_get_new_connector_state(a_state, connector);
  418. old_state =
  419. drm_atomic_get_old_connector_state(a_state, connector);
  420. if (!old_state || !c_state)
  421. return -EINVAL;
  422. sde_conn = to_sde_connector(connector);
  423. /*
  424. * Marking the colorspace has been changed
  425. * the flag shall be checked in the pre_kickoff
  426. * to configure the new colorspace in HW
  427. */
  428. if (c_state->colorspace != old_state->colorspace) {
  429. DP_DEBUG("colorspace has been updated\n");
  430. sde_conn->colorspace_updated = true;
  431. }
  432. return 0;
  433. }
  434. int dp_connector_get_modes(struct drm_connector *connector,
  435. void *display, const struct msm_resource_caps_info *avail_res)
  436. {
  437. int rc = 0;
  438. struct dp_display *dp;
  439. struct dp_display_mode *dp_mode = NULL;
  440. struct drm_display_mode *m, drm_mode;
  441. struct sde_connector *sde_conn;
  442. if (!connector || !display)
  443. return 0;
  444. sde_conn = to_sde_connector(connector);
  445. if (!sde_conn->drv_panel) {
  446. DP_ERR("invalid dp panel\n");
  447. return 0;
  448. }
  449. dp = display;
  450. dp_mode = kzalloc(sizeof(*dp_mode), GFP_KERNEL);
  451. if (!dp_mode)
  452. return 0;
  453. /* pluggable case assumes EDID is read when HPD */
  454. if (dp->is_sst_connected) {
  455. rc = dp->get_modes(dp, sde_conn->drv_panel, dp_mode);
  456. if (!rc)
  457. DP_ERR("failed to get DP sink modes, rc=%d\n", rc);
  458. if (dp_mode->timing.pixel_clk_khz) { /* valid DP mode */
  459. memset(&drm_mode, 0x0, sizeof(drm_mode));
  460. convert_to_drm_mode(dp_mode, &drm_mode);
  461. m = drm_mode_duplicate(connector->dev, &drm_mode);
  462. if (!m) {
  463. DP_ERR("failed to add mode %ux%u\n",
  464. drm_mode.hdisplay,
  465. drm_mode.vdisplay);
  466. kfree(dp_mode);
  467. return 0;
  468. }
  469. m->width_mm = connector->display_info.width_mm;
  470. m->height_mm = connector->display_info.height_mm;
  471. drm_mode_probed_add(connector, m);
  472. }
  473. } else {
  474. DP_ERR("No sink connected\n");
  475. }
  476. kfree(dp_mode);
  477. return rc;
  478. }
  479. int dp_drm_bridge_init(void *data, struct drm_encoder *encoder,
  480. u32 max_mixer_count, u32 max_dsc_count)
  481. {
  482. int rc = 0;
  483. struct dp_bridge *bridge;
  484. struct drm_device *dev;
  485. struct dp_display *display = data;
  486. struct msm_drm_private *priv = NULL;
  487. bridge = kzalloc(sizeof(*bridge), GFP_KERNEL);
  488. if (!bridge) {
  489. rc = -ENOMEM;
  490. goto error;
  491. }
  492. dev = display->drm_dev;
  493. bridge->display = display;
  494. bridge->base.funcs = &dp_bridge_ops;
  495. bridge->base.encoder = encoder;
  496. priv = dev->dev_private;
  497. rc = drm_bridge_attach(encoder, &bridge->base, NULL, 0);
  498. if (rc) {
  499. DP_ERR("failed to attach bridge, rc=%d\n", rc);
  500. goto error_free_bridge;
  501. }
  502. rc = display->request_irq(display);
  503. if (rc) {
  504. DP_ERR("request_irq failed, rc=%d\n", rc);
  505. goto error_free_bridge;
  506. }
  507. priv->bridges[priv->num_bridges++] = &bridge->base;
  508. display->bridge = bridge;
  509. display->max_mixer_count = max_mixer_count;
  510. display->max_dsc_count = max_dsc_count;
  511. return 0;
  512. error_free_bridge:
  513. kfree(bridge);
  514. error:
  515. return rc;
  516. }
  517. void dp_drm_bridge_deinit(void *data)
  518. {
  519. struct dp_display *display = data;
  520. struct dp_bridge *bridge = display->bridge;
  521. kfree(bridge);
  522. }
  523. enum drm_mode_status dp_connector_mode_valid(struct drm_connector *connector,
  524. struct drm_display_mode *mode, void *display,
  525. const struct msm_resource_caps_info *avail_res)
  526. {
  527. int rc = 0, vrefresh;
  528. struct dp_display *dp_disp;
  529. struct sde_connector *sde_conn;
  530. struct msm_resource_caps_info avail_dp_res;
  531. struct dp_panel *dp_panel;
  532. if (!mode || !display || !connector) {
  533. DP_ERR("invalid params\n");
  534. return MODE_ERROR;
  535. }
  536. sde_conn = to_sde_connector(connector);
  537. if (!sde_conn->drv_panel) {
  538. DP_ERR("invalid dp panel\n");
  539. return MODE_ERROR;
  540. }
  541. dp_disp = display;
  542. dp_panel = sde_conn->drv_panel;
  543. vrefresh = drm_mode_vrefresh(mode);
  544. rc = dp_disp->get_available_dp_resources(dp_disp, avail_res,
  545. &avail_dp_res);
  546. if (rc) {
  547. DP_ERR("error getting max dp resources. rc:%d\n", rc);
  548. return MODE_ERROR;
  549. }
  550. if (dp_panel->mode_override && (mode->hdisplay != dp_panel->hdisplay ||
  551. mode->vdisplay != dp_panel->vdisplay ||
  552. vrefresh != dp_panel->vrefresh ||
  553. mode->picture_aspect_ratio != dp_panel->aspect_ratio))
  554. return MODE_BAD;
  555. return dp_disp->validate_mode(dp_disp, sde_conn->drv_panel,
  556. mode, &avail_dp_res);
  557. }
  558. int dp_connector_update_pps(struct drm_connector *connector,
  559. char *pps_cmd, void *display)
  560. {
  561. struct dp_display *dp_disp;
  562. struct sde_connector *sde_conn;
  563. if (!display || !connector) {
  564. DP_ERR("invalid params\n");
  565. return -EINVAL;
  566. }
  567. sde_conn = to_sde_connector(connector);
  568. if (!sde_conn->drv_panel) {
  569. DP_ERR("invalid dp panel\n");
  570. return MODE_ERROR;
  571. }
  572. dp_disp = display;
  573. return dp_disp->update_pps(dp_disp, connector, pps_cmd);
  574. }
  575. int dp_connector_install_properties(void *display, struct drm_connector *conn)
  576. {
  577. struct dp_display *dp_display = display;
  578. struct drm_connector *base_conn;
  579. int rc;
  580. if (!display || !conn) {
  581. DP_ERR("invalid params\n");
  582. return -EINVAL;
  583. }
  584. base_conn = dp_display->base_connector;
  585. /*
  586. * Create the property on the base connector during probe time and then
  587. * attach the same property onto new connector objects created for MST
  588. */
  589. if (!base_conn->colorspace_property) {
  590. /* This is the base connector. create the drm property */
  591. rc = drm_mode_create_dp_colorspace_property(base_conn);
  592. if (rc)
  593. return rc;
  594. } else {
  595. conn->colorspace_property = base_conn->colorspace_property;
  596. }
  597. drm_object_attach_property(&conn->base, conn->colorspace_property, 0);
  598. return 0;
  599. }