The Linux Coding Style frowns upon mixed-case names so rename HDD
identifier STAMacAddress to be compliant.
Change-Id: I291905cd8202614c06dabcbb9ce7772a39cfdef5
CRs-Fixed: 2422201
The Linux Coding Style frowns upon mixed-case names so rename HDD
identifier Keys to be compliant.
Change-Id: Iec27be3927a7f71fe4ad58e836d80f6cc254bb0d
CRs-Fixed: 2422200
The Linux Coding Style frowns upon mixed-case names and so-called
Hungarian notation, so rename HDD identifier pKey to be compliant.
Change-Id: I62e6a952328ecca9a0071152b987294945d87c98
CRs-Fixed: 2422199
Function wlan_hdd_cfg80211_set_key_wapi() has a variety of issues:
- It uses mixed-case for parameter key_Len
- It has conditional logic based upon variable isConnected which is
always true
- It unnecessarily uses a mixed-case variable pKeyPtr when setting
the key
- It has comments which simply restate the code
Therefore refine the implementation to address these issues.
Change-Id: I41bca98de12775643198b810f7fe534f07fb1bfc
CRs-Fixed: 2422197
The Linux Coding Style frowns upon mixed-case names so rename HDD
identifier setKey to be compliant.
Change-Id: Id1c6abe0ec464f5a8163ad98acc82864db7bcccb
CRs-Fixed: 2422196
The Linux Coding Style frowns upon mixed-case names so rename HDD
identifier broadcastMacAddr to be compliant.
Change-Id: Ib4edff8bd0b78dc16605ac8bd129021b6923a7d2
CRs-Fixed: 2422195
The Linux Coding Style frowns upon mixed-case names so rename HDD
identifier macTable to be compliant.
Change-Id: Ibe516331e58967ee778f0d5098a0b269cae95c55
CRs-Fixed: 2422194
The prototype for hdd_register_tx_flow_control() does not exactly
match either the documentation or the implementation, so rename the
flowControl parameter to be consistent, as well as to be compliant
with the coding standard.
Change-Id: I2a65fc78febef5bd44b38e0b7ff3fa5968a6e214
CRs-Fixed: 2422193
The Linux Coding Style frowns upon mixed-case names so rename members
ctWindow and psSelection in struct p2p_app_set_ps to be compliant.
Change-Id: If5156a8dd6203fb530a164447d458ac3e55e233a
CRs-Fixed: 2422192
Per the Linux Kernel coding style, as enforced by the kernel
checkpatch script, pointers should not be explicitly compared to
NULL. Therefore within hdd replace any such comparisons with logical
operations performed on the pointer itself.
Change-Id: I69fc3065ee76a619b13b237c7800054468f839d0
CRs-Fixed: 2418393
The timer multiplier is currently controlled via ini configuration.
However, there are several timers which are started before the
configuration can be applied during SoC probe. Add a module parameter
that allows controlling the timer multiplier both at load time and at
run time.
Change-Id: I34a8511c1900a722030374b881a73adc9c5fee19
CRs-Fixed: 2421716
In 2x2 DBS mode once STA/SAP change channel from 2.4Ghz to 5Ghz,
policy_mgr_get_current_pref_hw_mode_ptr never return
PM_SINGLE_MAC_UPGRADE to start the opportunistic timer to switch to
single mac mode.
Fix is to check and start opportunistic timer once connection info are
updated. Also start opportunistic timer before
check for SAP to change channel as when SAP change channel it should
stop opportunistic timer and set required HW mode.
If single mac mode is required after channel switch it will start
opportunistic timer again in channel switch callback.
Change-Id: Id6bbc7ea51ba8147e517e7e7bf2b14931c95ea44
CRs-Fixed: 2419645
The Linux Coding Style frowns upon mixed-case names so rename HDD
identifier channelEnabledState to be compliant.
Change-Id: I26a676e216b2a8c5964f3e903cbda884769db284
CRs-Fixed: 2418191
The Linux Coding Style frowns upon mixed-case names and so-called
Hungarian notation, so rename HDD identifier fValidChannel to be
compliant.
Change-Id: Ic591e0e194b3444499518f7fd3c273adb6189423
CRs-Fixed: 2418190
The Linux Coding Style frowns upon mixed-case names and so-called
Hungarian notation, so rename HDD identifier fEnableSNRMonitoring to
be compliant.
Change-Id: Ic613f39d0d267ba7e8cb72cd0cc3bf261a029278
CRs-Fixed: 2418189
Currently in case of SAP, supported mode of station received
in assoc request is not getting cached.
Add support to cache the supported mode of station received
in assoc request request in sta_info.
Change-Id: I9820ae2d65fc529a1ab16424f6732fd273da3ae0
CRs-fixed: 2419957
hdd_init_deinit_lock has been obsoleted by the addition and integration
of the Driver Synchronization feature. Remove hdd_init_deinit_lock.
Change-Id: Ia1b9e4279f42023ba2c956224ceabd02d8b4c6d4
CRs-Fixed: 2420766
The bus bandwidth compute is a periodic activity that calculates the
required DDR bandwidth needed by the wlan driver. Currently it is
implemented using a spinlock, a flag, a timer, and a kernel work.
qdf_periodic_work effectively implements the same behavior, so use it
instead.
Change-Id: I1c71a1eb430317d2ac167b7c1ba94fb190deef4a
CRs-Fixed: 2410047
As a step towards removing qdf_ssr_protect, register for the
replacement APIs, qdf_op_protect/unprotect.
Change-Id: Ica5802082b3be51f47bdf4ae0eb132b80c29b08a
CRs-Fixed: 2418432
In function __wlan_hdd_cfg80211_get_tdls_capabilities,
If tdls_support is true then user is notified wrong values.
Change-Id: Id177f94a841f7d6676de8b26664955194cdb0c16
CRs-Fixed: 2417950
In QCA_NL80211_VENDOR_SUBCMD_SET_TRACE_LEVEL command handler
when nested attributes are getting parsed no NLA policy is
used, as no NLA policy is defined for MODULE_ID and TRACE_MASK,
these attributes will be treated as NLA_UNSPEC types and can
have a length of zero bytes. Later when these attributes
are accessed using nla_get_u32() this will result in OOB
read.
Change-Id: I7d4913feccb00877ac5f40bab8ff5e9e3891756f
CRs-Fixed: 2410900
Currently, hdd_parse_vendor_acs_chan_config does not do null validation for
tb[SET_CHAN_CHAN_LIST] which can lead to null pointer derefrence.
Add null pointer check for tb[SET_CHAN_CHAN_LIST] in
hdd_parse_vendor_acs_chan_config.
Change-Id: I8914e38a5d98536a816c80d484dec9878753966a
CRs-Fixed: 2410809
The HDD driver operation inactivity timer has been rendered obsolete by
the addition and integration of the Driver Synchronization feature.
Remove the HDD driver operation inactivity timer.
Change-Id: I9c4f555f02edd9350cf44477c3ba6c84b61b09f7
CRs-Fixed: 2419307
Currently the driver just start the vdev according to the ini
params, without consdering the tx, rx chainmask supported by the
FW per band, per mac, which can lead to connection in 2x2, even
though FW is not capable of 2 antennas on a particular band.
Fix is to intersect both the tx, rx chainmask for both bands,
and change the ini to minimum of the nss supported by ini, and
the BDF setting of the chains.
Change-Id: Ib0e9bac19959bbcf9bade7dbd78674be4099a23d
CRs-Fixed: 2414103
The Linux Coding Style frowns upon mixed-case names so rename HDD
identifier advertiseConcurrentOperation to be compliant.
Change-Id: I398a3a80caaafbb273a647b4c0b1f374db94d944
CRs-Fixed: 2418188
The Linux Coding Style frowns upon mixed-case names so rename HDD
identifier RSNMfpCapable to be compliant.
Change-Id: Ida5c11b7da71cd0f4b7a344ca5ddc1ab3975c840
CRs-Fixed: 2418185
The Linux Coding Style frowns upon mixed-case names so rename HDD
identifier RSNMfpRequired to be compliant.
Change-Id: I9e4843c6ac8914580be5da668080802bdc0ec3c1
CRs-Fixed: 2418187
The Linux Coding Style frowns upon mixed-case names and so-called
Hungarian notation, so rename HDD identifier pMfpCapable to be
compliant.
Change-Id: I8431089e225736249f6427da4a22277e8ae962b6
CRs-Fixed: 2418186
While processing vendor command acs_chan_config,
in hdd_parse_vendor_acs_chan_config() memory allocated for channel_list
is not de-allocated in error scenario. This leads to memory leak.
To address this, while returning error, free channel_list in
hdd_parse_vendor_acs_chan_config().
Change-Id: Icdd264cfaa2e4266c22bc87c234e4a21122618b6
CRs-Fixed: 2410875
While processing vendor command EXTERNAL_ACS,
in hdd_parse_vendor_acs_chan_config() total number of channels is
computed by parsing nested attribute ACS_CHANNEL_LIST.
Initially computed number of channels is stored in int data type and
later copied to u8 data type, this shall truncate if number of channels
is greater than 255.
Memory for channel list is allocated using truncated value but later
the same list is accessed using computed value which shall result in
buffer overflow.
To address this, validate computed value against MAX_CHANNELS.
Change-Id: Idbbf3b44fd238f7cff53bedd68f2c7627ecdfa9d
CRs-Fixed: 2410869
The Linux Coding Style frowns upon mixed-case names and so-called
Hungarian notation, so rename HDD identifier pMfpRequired to be
compliant.
Change-Id: I745e5773ce387744120081c8fa275e9255639152
CRs-Fixed: 2418184
Currently, there are some attributes that dont have any NLA policy
specified. The absence of policy results the attribute to default to
NLA_UNSPEC. When handling this case in validate_nla() there is no
minimum length guarantee, meaning that the attribute can have zero
length. This will result in a one byte overread when calling
nla_get_u8().
To avoid this potential security vulnerability, add policy entry for the
attribute.
Change-Id: I19e5a032ccb2083d5f204be6ff7ac2f53aebf130
CRs-Fixed: 2408072
While processing cfg80211 callback testmode_cmd(), size of vendor
attribute TM_ATTR_DATA is not validated against the maximum length
but type casted to the internally defined structure pmo_lphb_req.
This can lead to out of bounds access if the size of attr is less than
size of pmo_lphb_req.
To address this, validate size of TM_ATTR_DATA.
Change-Id: I83b18d0935ebc6139644c02a9e51ef25a12b9176
CRs-Fixed: 2411653
For FILS based authentication, KCK is not derived. Hence
when GTK Offload feature is enabled, supplicant will not
pass it to driver with gtk rekey data. Putting a check
to validate KCK before copying it to the gtk_req structure.
Change-Id: I7089011b4d3fdc4e4785adbe10de651a1b59a121
CRs-Fixed: 2414445
Currently, the scan is rejected if roaming in progress on STA or
if a client of SAP is in the middle of WPS/EAPOL exchange. And
it uses last_scan_reject_timestamp and reset scan_reject_cnt to
avoid scan stuck issue. last_scan_reject_timestamp and
scan_reject_cnt reset when the next scan issues successfully.
If:
1\ Scan happens and roaming is in progress on STA or client of SAP is
in the middle of the WPS/EAPOL exchange. Initialized
last_scan_reject_timestamp and reset scan_reject_cnt;
2\ Maybe no scan happens for a long time;
3\ scan happens but unfortunately, a connection is in progress again.
Then false alarm may happen because the time has already expired and
scan_reject_cnt >= 15.
Reset scan reject params after successful set key and successful roam.
Change-Id: I1197e66483e3bc8da38d6bcbc8b8c32b193ef6c9
CRs-Fixed: 2418658
The Linux Coding Style frowns upon mixed-case names and so-called
Hungarian notation, so rename HDD identifier pLinkSpeed to be
compliant.
Change-Id: I04db9da2cba615d9a216a9eab40d1a07c73c33fb
CRs-Fixed: 2417587
The Linux Coding Style frowns upon mixed-case names so rename HDD
identifier p2pNoA to be compliant.
Change-Id: Ia43f9794d94c37457c13fee5aafc7a7bd14de48f
CRs-Fixed: 2417586
The Linux Coding Style frowns upon mixed-case names so rename HDD
identifier updateIE to be compliant.
Change-Id: Id63bc75edf91d364de53eccc021917d597da400f
CRs-Fixed: 2417585
The Linux Coding Style frowns upon mixed-case names so rename HDD
identifier macAddr to be compliant.
Change-Id: I73573fced510fe2e4d6a30deacd2d3cef0187ee1
CRs-Fixed: 2417584
The Linux Coding Style frowns upon mixed-case names so rename HDD
identifier macAddress to be compliant.
Change-Id: Idc9e4bf34a29859a66ff559fdbe4f2d1c18d6d98
CRs-Fixed: 2417583
The Linux Coding Style frowns upon mixed-case names so rename HDD
identifier pmacAddress to be compliant.
Change-Id: I12040f02b81ae3430a31bb3ee0e1305300f0017b
CRs-Fixed: 2417582
The Linux Coding Style frowns upon mixed-case names so rename HDD
identifier customMacAddr to be compliant.
Change-Id: I374e45b5b2a0feb570e071ca54f13a97638628ae
CRs-Fixed: 2417581
