The function sap_check_and_process_go_force_ssc() deals with single
channel concurrency (SCC), so rename the function to match the usage.
Change-Id: I21af5d1b245ab979e5d6888966b843c7830f3735
CRs-Fixed: 3388966
Currently, CSA on an unsafe channel is not allowed.
Allow CSA even if it's unsafe channel when user tries to set
a fixed channel (i.e. reason = CSA_REASON_USER_INITIATED)
and firmware supports the capability
WMI_COEX_FIX_CHANNEL_CAPABILITIES.
Change-Id: I5ba26faabe05fbf1a79dc92360400ec2c6d71b2d
CRs-Fixed: 3381395
Currently, unsafe channels are avoided when SAP restart happens.
If WMI_COEX_FIX_CHANNEL_CAPABILITIES is advertised by firmware
and if the SAP is started in a fixed channel, don't restart even
if the current operating channel is unsafe.
Change-Id: I5f7d632bcc00a1b5351dad64aca0ce16f1057537
CRs-Fixed: 3381394
Currently, SAP start is aborted if the channel is marked as unsafe
due to COEX, irrespective of it's an ACS/fixed channel SAP.
There is a requirement to allow the SAP in a fixed channel even
if the channel is marked as unsafe. Firmware advertises
WMI_COEX_FIX_CHANNEL_CAPABILITIES in such targets.
Check for this capability and allow the SAP in fixed channel even
it it's unsafe.
Change-Id: Ie3947058d8854823a718b833ec788c5c8a14b903
CRs-Fixed: 3375254
ML STA connected on 2437 MHz and 5825 MHz (unsafe channel), GO started
on 5180 MHz. SAP was started on 5825 MHz for SCC with ML STA, but SAP
channel was changed from 5825 MHz to 5240 MHz after CSA.
At present after SAP start or CSA channel changed, the api
sap_fsm_handle_check_safe_channel will check the unsafe flag
for SAP operation channel. But it doesn't check the STA present
on the channel, SAP is allowed SCC with STA on unsafe channel
when g_sta_sap_scc_on_lte_coex_chan = 1.
Fix by use policy_mgr_is_sap_freq_allowed to check SAP channel unsafe
and wlansap_set_channel_change_with_csa to do more validation on
target channel.
Change-Id: I8ce56195c804156bd7c2a54c60144402636f5b06
CRs-Fixed: 3371880
When updating the phymode of SAP required from SON, do not change current
home channel. Currently hdd_restart_sap uses the channel information
from sap_config to do SAP restart. For SON, we need override the
sap_config channel information with desired channel information in vdev.
Change-Id: Ie01a5dc9c3cd6bbae1bbe246e6f17a329189be50
CRs-Fixed: 3371361
center_freq_diff may overflow int8 when channel width is 320 MHz.
Also clear acs_ch_params before pass it to regulatory API to avoid set
mhz_freq_seg1 which is uninitialized value.
Change-Id: I497ae02c7b53458537e706f2231c0ffef2439961
CRs-Fixed: 3371957
While processing START SAP req, Host calls wlan_sap_get_concurrent_bw
to calculate SAP BW based on the concurrent channel & STA DFS channel.
The below issues are present due to current logic to calculate SAP BW
in this API:
1. In the case of standalone SAP, this API returns SAP bandwidth as
80 MHz always, this results in standalone SAP will never come up in
other BWs.
2. In the case of non-DBS HW, the host is not considering the value of
INI "g_sta_sap_scc_on_dfs_chan", the value is defined by the enum
PM_AP_DFS_MASTER_MODE.
By considering the value of STA DFS channel, HW mode, and INI
g_sta_sap_scc_on_dfs_chan, modify the logic to calculate concurrent
as well as standalone SAP BW in API wlan_sap_get_concurrent_bw.
Change-Id: Id521893feb9b6173efc2704f37dfa59f405655e2
CRs-Fixed: 3363394
When g_sta_sap_scc_on_lte_coex_chan = 1, SAP is allowed SCC with
STA on unsafe channel.
Use API policy_mgr_is_sap_freq_allowed to check such condition
in wlansap_get_chan_band_restrict.
Change-Id: I62b3ad83ccdfc80b5e72cad733618326e4fed936
CRs-Fixed: 3368195
If some 20M sub channels are disabled for puncture, bonded freq state will
become CHANNEL_STATE_DISABLE, while CHANNEL_STATE_DFS is expected if
DFS freq is included to pass CHAN_DFS_CFREQ2 to F/W by vdev start wmi cmd.
the check also happens in several other places.
To fix it, use API wlan_reg_get_5g_bonded_channel_state_for_pwrmode to
replace wlan_reg_get_5g_bonded_channel_state_for_freq and
wlan_reg_get_bonded_channel_state_for_freq.
set is_create_punc_bitmap of ch param as true, then bonded freq
state will become CHANNEL_STATE_DFS after
reg_update_5g_bonded_channel_state_punc_for_pwrmode called.
Change-Id: I3e5214e9e09ac2a959f6fa7d641173a80a3980a7
CRs-Fixed: 3360820
While doing CAC for moving SAP to DFS channel, channel
avoid event can be received. While in CAC is going on,
the current sap channel is not updated and remains the
channel on which sap was before CAC. It is only updated
after CSA. So, when channel avoid event is received,
it is checked against the previous frequency and hence,
no action is taken as the previous frequency is part of
safe channel. This results in sap starting and remaining
in Unsafe channel.
As, a fix when sap starts after CSA, check for unsafe
channel and if the sap frequency is unsafe then restart
it to another channel.
Change-Id: I910b80fe87fc149f25e84383b128a5e5c9d269e4
CRs-Fixed: 3287239
Add channel tx max power factor to existing ACS channel weight logic,
so if AFC available can automatically select Standard Power channel
which has higher 6 GHz tx power and better performance.
Add SAP best channel selection callback when AFC triggered DCS,
DCS module will invoke this callback and dynamic switch to best
channel/bandwidth if possible.
Change-Id: I300057c2b11d0b818f4e20ba51d6ab9b82f6a3ff
CRs-Fixed: 3204199
After starting SAP on channel 6, then issuing setChanChange
command. Per the sniffer log, the rate list of extended
supported rate is wrong in the beacon and probe response.
It is happens because in wlansap_fill_channel_change_request,
when it copies the extended supported rate list, it uses
parameter sizeof(dot11_cfg.ext_rates.numRates) instead of
dot11_cfg.ext_rates.numRates, so it only copies the first rate.
Change-Id: I7f23254fbd6ce56be69dbea634d9d99f3b611448
CRs-Fixed: 3345554
In current design of sta+sap scc on indoor channels, the NO_IR
flag of all the indoor channels are removed during init.
Then, based on the operations on the SAP interface, the
SAP concurrency will be decided in host driver.
However, some userspace p2p applications, do not query the
pcl list from driver, therefore standalone P2P GO are sometimes
brought up in indoor channels.
To fix this:
1. Upon STA connect: Remove the NO_IR flags only from the
indoor channels to which the STA is connected.
2. Upon STA disconnect: Add the NO_IR flag back to the
disconnected channel.
3. Upon STA roam/csa:
a) Add the NO_IR to the new channel if it is indoor.
b) Remove the NO_IR of the previously connected channel
once the SAP/GO(if present) moves out of the indoor channel.
4. The NO_IR flags should be removed for all the bonded channels
on which the STA is active.
5. In indoor concurrency cases, add logic in the SAP start to
limit the channel width with the STA interface bandwidth. Since,
only the bonded channels are active channels.
Change-Id: Ib0b30e1f17d0eb944c72b26bb679bf7447b9032f
CRs-Fixed: 3296208
Fix sap_channel_sel() prototype so that it matches the documentation
as well as the implementation.
Change-Id: I99ef2ff6e867b2124bb534bb12ba0f5818f8e0a4
CRs-Fixed: 3330730
Replace all occurrences of
wlan_reg_set_channel_params_for_freq API with new API
wlan_reg_set_channel_params_for_pwrmode.
Change-Id: I7ae94a7004803a96caeb7a77d03065096afe5f0e
CRs-Fixed: 3144793
Currently, there is duplicate logic in function
wlansap_roam_process_ch_change_success to invoke
function wlansap_start_beacon_req.
a\ wlansap_roam_process_ch_change_success ->
wlansap_start_beacon_req(sap_ctx)
b\ wlansap_roam_process_ch_change_success ->
sap_fsm -> sap_fsm_state_starting ->
wlansap_start_beacon_req(sap_ctx)
This causes fw crash since it sends vdev up twice.
Also in SAP + SAP scenario, there is a race in updating global
variable mac_ctx->sap.SapDfsInfo.sap_radar_found_status. Move the
variable to sap_ctx per vdev to avoid such race.
Change-Id: Iaac9e5a649ea5fd6a8378f6da47c51112fbe8d18
CRs-Fixed: 3310317
With MACRO FEATURE_WLAN_CH_AVOID_EXT enabled,
"restriction_mask" can only be checked if
coex_unsafe_chan_nb_user_prefer = 1. If the INI
coex_unsafe_chan_nb_user_prefer = 0, do not need to check
"restriction_mask". It will remain uninitialized 0.
Change-Id: If7bd1223ee3779b72fadb40e622f682db03f4ea5
CRs-Fixed: 3287634
As part upgrading legacy APIs with 6 GHz power APIs
Replace all occurrences of
wlan_reg_is_passive_or_disable_for_freq API with new API
wlan_reg_is_passive_or_disable_for_pwrmode.
Change-Id: If8429146e3e4e4cb25505de9855671dca2eb6474
CRs-Fixed: 3306631
When driver receive auth request frame with FT algorithm,
offload it to hostapd.
When driver receive (re)assoc request whith FT-PSK in RSN IE.
offload it to hostapd.
Filter FT related IE from hostapd, and append it to the end
of the (re)assoc response frame
Change-Id: Id11cce6898615bb6b0cb361ea7b23ea2014f0bae
CRs-Fixed: 4202696
Replace all occurrences of
wlan_reg_get_channel_state_for_freq with
wlan_reg_get_channel_state_for_pwrmode and use extra
parameter as REG_CURRENT_PWR_MODE.
Change-Id: I7f7e4e700091918eeebc87ccbbc85ececdd9bf52
CRs-Fixed: 3145011
As part of upgrading legacy code
with 6 GHz power APIs, replace
all ocurrances of
wlan_reg_is_disable_for_freq with
wlan_reg_is_disable_for_pwrmode.
Change-Id: Id18e48e27eb118945d56205797882874eb552153
CRs-Fixed: 3145764
As part of SAP ACS optimization, the last ACS scan's result
can be reused in current ACS request if the last scan done
was not greater then last_scan_ageout_time provided as part
of do_acs command. So, do not clear channel stats after
ACS completion if SAP ACS optimization feature is enabled.
Change-Id: Idac6225f790d84ba90ebd740602d0c5d358ed2dc
CRs-Fixed: 3297868
To reduce the ACS time, there is an implementation wherein one
user space process creates sap interface and queues ACS request to driver,
meantime framework initializes various config and starts hostapd
to queue same ACS request to driver. In this scenario, there is a
race condition that hostapd tries to queue ACS request while there is
already one ACS request is in progress. With current implementation,
driver will reject second ACS request and return error to hostapd
leading to sap turn on failure.
This change allows subsequent ACS request if all the attributes
of do_acs vendor command matches with the ongoing ACS request and returns
success to userspace. There is no another ACS scan queued as part of
second ACS request which is same as ongoing ACS request because the result
of ongoing ACS request will act as result of second ACS request as well.
Change-Id: I67d10b09be922745e7ffb46192e00135dbdb9de4
CRs-Fixed: 3295786
If ACS scan is skipped, then ACS request is completed and vendor
event is sent to userspace in same context, so there is no need to set
acs_in_progress when ACS scan is skipped.
Change-Id: Id3d1235e405832ce66a1b8837dc04e94bb3c6b64
CRs-Fixed: 3296939
In default configure with sta_sap_scc_on_indoor_chan=1 and
gindoor_channel_support=0, we don't expect sap setup on indoor
channel only.
Change-Id: Ibea0eb41b20bcbdaa365bd3fa4f0a7be7b696493
CRs-Fixed: 3278223
SAP fails to get RSN IE from reassoc request frame body.
Assoc request and reassoc request have different fixed parameters.
IE should be retrieved based on frame subtype.
Change-Id: I72cfc4cc28cdfeb9a35269d6c1a8c638dea87631
CRs-Fixed: 3283683
If SAP+GO SCC on DFS channel and Radar event is detected, driver
should move out both SAP and GO to new channel. Add GO mode
check in wlansap_roam_process_dfs_chansw_update API.
Change-Id: I824553222be8a8f21ab6c4ac776a4b1e692ed3da
CRs-Fixed: 3280352
Single SAP is not allowed on the DFS channel with the
g_sta_sap_scc_on_dfs_chan value = 1.
If g_sta_sap_scc_on_dfs_chan = 1 and STA is present on the
dfs channel, allow the dfs channel to be added to ACS channel
selection list.
Change-Id: I19f799628febd495302547a3f223e8b2561d8b78
CRs-Fixed: 3271710
In STA+SAP concurrency, if the STA is connected in indoor
power, and if the country/channel supports VLP, then bringup
the SAP in VLP. Move the STA to VLP as well.
Restore the power of the STA, when the SAP is disconnected.
Add changes to:
a) Decide the power type for the concurrency during start bss,
stop bss, change channel request calls of the SAP interface.
b) Allow the 6 GHz SCC channel in ACS computation if the channel
supports VLP power or if the channel is indoor and enabled.
Change-Id: I151e2e3e8910a406bb5c1526f4f01715854d173f
CRs-Fixed: 3268100
CH_WIDTH_320MHZ definition is in 11BE define currently and it's
causing duplicate code in 11BE supported/unsupported cases.
Definition need not be in 11BE define as it doesn't cause any
impact on memory.
Change-Id: I9fa391474f513755000368cc2e41e004446353d0
CRs-Fixed: 3246578
If the acs scan is optimized based on last scan ageout time,
it can lead to either skip ACS scan fully or scan partial
ACS frequency list. If ACS scan is skipped or partially
done, use a scan filter based on last scan ageout time to
retrieve the scan entries for ACS algorithm.
Change-Id: Id1d3a3d4364163686f92c380e9f6d6dada033ff5
CRs-Fixed: 3239389
In GO+STA+SAP concurrency, if GO is MCC with STA, the new SAP
will not be allowed in same MAC. FW doesn't support MCC in same
MAC for 3 or more vdevs. Move GO to other band to avoid SAP
starting failed.
Change-Id: Ia19abd1b11f7416797af3e975ab8ffde9037c11f
CRs-Fixed: 3262185
Currently, ACS computation triggers when ACS scan complete event is
received after firmware has scanned all channels. This leads to
delay in selection on SAP channel.
As an optimization, this change selects the first clean channel
while scan is still in progress. The criteria for first clean channel
is that no beacon/probe response should be received on that channel.
If such channel is obtained while scan is in progress, then select this
channel as SAP channel and abort ongoing scan. Firmware sends
wma_chan_info_event per channel this change uses this event as an
indication that scan is completed on that channel.
To further increase the optimize the time to get clean channel, sort the
ACS frequency list in descending order in ACS SCAN request to
firmware. Firmware scans the channel in the order given by host
in scan request, as higher band channels are less occupied, the
probability of getting clean channel initially will increase, which
will lead to selecting the channel in less time and thereby reduce
the SAP turn on time.
Change-Id: I1a38556862b66943edea08783436f5e1e3a255f6
CRs-Fixed: 3245166
Currently channel info stats are stored in LIM. Refactor
code to store channel info stats in cp stats component.
Change-Id: I2e7219c112e96916d3b73f974dd9803b9c2821c3
CRs-Fixed: 3265722
If particular channel's last scan time is less than the last_scan_ageout
threshold, skip that channel from ACS scan frequency list.
This change optimises the ACS scan time by reducing the number of
channels in ACS scan request to firmware.
Change-Id: Id81815035a89039ef1f492a622c5d89cb4aa298e
CRs-Fixed: 3239387
Parse and store new ACS vendor attribute
QCA_WLAN_VENDOR_ATTR_ACS_LAST_SCAN_AGEOUT_TIME in SAP ACS
config.
Change-Id: If50224780192ed7b587505e973a8dabeab3459b2
CRs-Fixed: 3239372
Currently sap is not starting if all channels configured as coex
unsafe and if restriction mask is not set.
This change is to select unsafe channel if restriction mask is
not set and start the sap.
Change-Id: I4ccf887655066da6d6b50715f631dde6edfda598
CRs-Fixed: 3260305
If SAP is initially started on 40 MHz bandwidth, keep using it.
But still keep the old logic 20 MHz for internal CSA for SAP.
This is to fix the SAP can't bring up on 2.4 GHz 40 MHz bw if SAP
OBSS scan disabled and configured as HT40 in hostapd conf.
Change-Id: Ib01be7fe594130f1eee35e3bfb773b1e913ec9c1
CRs-Fixed: 3234564
Reject the SAP if the frequency is 6 GHz and
the security is non-WPA3 AKM suite.
Also, use the ini "check_6ghz_security" to
allow the 6 GHz SAP to be operational on an
open security mode for test purposes.
Change-Id: Ifc57656a556ef5b6829ed56bb1ec360b5b84379e
CRs-Fixed: 3176629
Currently, channel info event results are stored only if it is
received as part of SAP ACS scan. Channel info is used in
ACS algorithm to select best channel. There is a requirement to
reuse the STA's scan results for SAP to reduce the SAP bringup
time. So store the channel info event results received as part
of STA scan if WLAN_FEATURE_SAP_ACS_OPTIMIZE is enabled.
Change-Id: I99d4e8c13a9e4171c74c63907d29c585f89ecf9e
CRs-Fixed: 3239383
-Wimplicit-fallthrough is being enabled by default. Some compilers
such as clang require the attribute instead of just a fallthrough comment.
Change-Id: I34248b07875ea4b615be84aba26798f10e7773ec
CRs-Fixed: 3217419
Add validation of ACS scan frequency list ptr from sap_get_freq_list.
If Null then return failure for sap_channel_sel API.
Change-Id: I46db7a956f8f83ba9eceaa8e9e06fe3b44d1a767
CRs-Fixed: 3219747
