- Driver code gets the compression ratio(CR) from FW. This CR is used
to calculate the compression factor(CF) and used in BW calculations.
Perf. model code for BW calculations always assumes that CF will be in
fractional format. But, driver already converts the CR to integer format.
So, we need to remove the x100 multiplication in BW calculation code.
- As CF is used as division factor for BW calculations,
due to this x100 bump in CF values, we see very low calculated BW values.
Change-Id: Ifbddee68b6799b2fe0fc6d5ffa623514e1abd13f
Signed-off-by: Ashish Patil <quic_ashpat@quicinc.com>
fix copyright markings and have all markings in one
multiline comment.
Change-Id: I481c6213bb25e8c278956ad6a51df3fc5c1aabf2
Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
pineapple_technology.h contains multiple static array and it is
getting included from msm_vidc_bus.c & msm_vidc_clock.c files.
So in generated build is having 2 copies of static arrays in
code segment.
So added changes to avoid duplication in generated bin.
Change-Id: Ifcfa07331e868440d033d2c7d65555810ad4d1b3
Signed-off-by: Govindaraj Rajagopal <quic_grajagop@quicinc.com>
Residency print is not working for 2 cases-
1. when the prev session stopped in the middle without
setting clk->prev freq to 0, in next session
the residency stats
for the same clk freq will not come as the start time will be
reset to 0 during next session open.
2. when last session close and clk rate not changed to 0
but, before that print residency stats come,
then in residency print the residency for
the last clk freq will not come.
Change-Id: I63a59202ca145e83e0bc129105df0b0182d3cb1e
Signed-off-by: Ankush Mitra <quic_ankumitr@quicinc.com>
Treat NOC error (which is a result of pagefault) as
fatal error to and get more debug info to resolve the
pagefault issue.
Change-Id: I3a1cd99fea680a941788d1bc8ea586bf0ff29365
Signed-off-by: Maheshwar Ajja <quic_majja@quicinc.com>
There are many places in code where available helper
functions are not being used, fix it.
Change-Id: Id5b309837fd5847e280f7fab02820af1b08242a6
Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
MAX_NUM_REORDER_FRAMES is 32 packed with MSB 16 bits representing
reorder frame count. Instead, this has been used as integer with
all bits reprsenting reorder frame count. Fix this.
Change-Id: I275a0be71ecf89c44374782445f66ac7e709e2a7
Signed-off-by: Akshata Sahukar <quic_asahukar@quicinc.com>
From driver if we call streamoff without streamon
successful, the streamoff will be timed out and
it will invoke msm_vidc_inst_timeout, which will
change the core state to ERR and FW unload will
happen unneccessarly.
Change-Id: Iaec6c2de086df53c379d5ec991b22b393d3c9153
Signed-off-by: Ankush Mitra <quic_ankumitr@quicinc.com>
Remove core check from all the functions in video driver.
ore check is present in most of the functions in video
driver which is not required.
Keep check only at root level functions and remove
the check from rest all of the functions.
Change-Id: I5f6374b68dd739b7ab563f32f64bb90e368c4085
Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com>
There is no need to set allow_zero_bytesused any longer,
hence remove it.
Change-Id: Ic232d2bd38e0113af2c127fc7251a3dd8a3e0c03
Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
The current name is misleading as this file handler
doesn't only handles v4l2 event but used to provide
a way to easily keep file handle specific data
that is used by the V4L2 framework.
Change-Id: I902d86d69b1f3f2651521ef35aa2989a7b58051c
Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
This lock is not related to requests and used to serialize
IOCTL calls related to queues, hence change the name of the
lock to avoid any confusion.
Change-Id: I673a3331cbf67b3767b3ba75cfe203c4d45489cb
Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
There is a limit to the number of video instances which can be opened.
When the number of instances are exhausted, there is a possibility
that any ongoing instance is released. In such scenario, new instance
can be accepted. Hence keep the return type to suggest the client to
try opening the video instance again.
Change-Id: I2241a5458bbe55a2de1c58ad85440b2b920ae205
Signed-off-by: Vikash Garodia <quic_vgarodia@quicinc.com>
As part of default enablement of output tx type sw fence,
add this support in driver to disable fence based on
below conditions for INPUT_PSC propertities:
- If session is interlace type
- If OUTPUT_ORDER is 0 and HFI_PROP_MAX_NUM_REORDER_FRAMES > 0
Change-Id: If861129ba96329c0277a9c9698f67baf25e5d82e
Signed-off-by: Akshata Sahukar <quic_asahukar@quicinc.com>
Incase of split mode(either for linear color format
or AV1 film grain usecases), dpb and opb(output)
buffers are allocated in same context bank. In high
memory consumption usecases like 8k, it can lead to
OOM issues. To avoid this, for split mode, when both
dpb and opb buffers are used, honor fw min count for
dpb buffers, whereas for opb buffers choose an optimal
min count to ensure performance.
Change-Id: I287aff862d2fe36a690c1393d64f8095578baf34
Signed-off-by: Darshana Patil <quic_darshana@quicinc.com>
To follow the same nomenclature as the other function names
in driver, rename msm_vidc_suspend_locked to msm_vidc_suspend.
Change-Id: Iacdd6604c25f6efc61c5b6add939669f5bd26355
Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
Remove deinit sequence calls and register devm
managed callbacks, so that kernel can invoke
then, when dev scope ends and cleansup all
associated resources.
Change-Id: I729fd21fe32d9f39240d0b743f910409d93a00c5
Signed-off-by: Govindaraj Rajagopal <quic_grajagop@quicinc.com>
Bitrate is not a mandatory parameter for setting multi-slice encode configuration.
If the client not setting bitrate then default value can be used to
calculate slice count incase of byte mode multi slice encode,
and it's not needed for macro-block mode multi slice encode.
Currently, multi slice encode is enabled only when client set bitrate
explicitly otherwise it's configuring single slice encode mode.
So added change to remove the bitrate dependancy for configuring multi slice encode.
Change-Id: Ia9c541d693107b9eb57e530c6e44cad70216f1dc
Signed-off-by: Gaviraju Doddabettahalli Bettegowda <quic_gdoddabe@quicinc.com>
update or print the residency calc. only when high or stats logs
are enabled
Change-Id: Ie5e936a56865702417b4bb6a4657abf864510032
Signed-off-by: Ashish Patil <quic_ashpat@quicinc.com>
removed delayed unmap attribute from driver so
that buffers are immediately unmapped when unmap
request is sent.
Change-Id: I452199ba6e7f670ff2bdc3300df21d6e47011f90
Signed-off-by: Darshana Patil <quic_darshana@quicinc.com>
