Commit Graph

118 Commits

Author SHA1 Message Date
Megha Byahatti
9df60c1fa4 video: driver: Add pipes scalability for multi slice count
- Add pipes check to support different Tile sizes based on
number of VPP Pipes for HFI_IRIS3_ENC_TILE_SIZE_INFO,
HFI_IRIS3_ENC_MB_BASED_MULTI_SLICE_COUNT.

HFI review done with ccb id 3284017.

Change-Id: I2e403ac712143635fd9ff5167260e23d6b48c482
Signed-off-by: Megha Byahatti <quic_mbyahatt@quicinc.com>
2023-12-20 19:41:25 +05:30
qctecmdr
cf58e09805 Merge "video: driver: Read ctrl_init register value during FW bootup failure" 2023-11-30 20:03:51 -08:00
qctecmdr
f6104dbc28 Merge "video: driver: avoid array copy for freq and bitrate table" 2023-11-30 20:03:51 -08:00
qctecmdr
77e62fb38c Merge "Video: Driver: acquire xo_reset mutex for gdsc access" 2023-11-30 20:03:51 -08:00
qctecmdr
48804dda69 Merge "video: driver: fix inconsistency in clock calculation" 2023-11-20 02:38:13 -08:00
Vedang Nagar
726326d756 Video: Driver: acquire xo_reset mutex for gdsc access
[1] Acquire xo_reset mutex for gdsc access.
[2] Retry acquire_regulator for 1sec and BUG_ON if still fails.

Change-Id: Ie0ed4561a0c12b8526e2ede96a879f9d311aafab
Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com>
2023-11-15 19:05:34 +05:30
Vedang Nagar
236e1f55dd video: driver: Read ctrl_init register value during FW bootup failure
To debug FW bootup failure scenario, FW tries to update ctrl_init
register to know at what point failure is seen and driver can
read and print this register so as to know where FW bootup is
failing.

Change-Id: I26691a84ab2526dee8adb6b2a46b62a01bacede8
Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com>
2023-11-15 18:46:57 +05:30
Zhongbo Shi
14000cd9c6 video: driver: avoid array copy for freq and bitrate table
Using pointer instead of array copy for frequency
and bitrate table.

Change-Id: I1c4c10ed0708954a067e8b199e293a2169e68628
Signed-off-by: Zhongbo Shi <quic_zhongbos@quicinc.com>
2023-10-27 09:02:02 +08:00
Zhongbo Shi
f66a492476 video: driver: fix inconsistency in clock calculation
Fix inconsistency in clock and bandwidth calculation
compared with C model.

Change-Id: Ie3fbeb792a152de3a96687e96db7413fbf98c69b
Signed-off-by: Zhongbo Shi <quic_zhongbos@quicinc.com>
2023-10-10 15:15:30 +08:00
qctecmdr
b3060d2263 Merge "video-driver: frequency claculation for iris33_2p" 2023-10-03 21:59:21 -07:00
Megha Byahatti
edec2460ee video: driver: Add iris33_2p values for BW calculation
- iris3 2pipe uses 768 vertical tile width for IPP GoP.
Handle the values for iris33_2p for BW calculations.

Change-Id: I8b28e5037e62175479587550973af035f0ede044
Signed-off-by: Megha Byahatti <quic_mbyahatt@quicinc.com>
2023-09-28 15:56:15 +05:30
Megha Byahatti
bc8a2161c0 video-driver: frequency claculation for iris33_2p
-Add frequency, pipe penalty and bitrate table for
 iris33_2p to calculate vsp frequency.

Change-Id: I217fc587d534909fb72e5f5824ef4dc8df8da58c
Signed-off-by: Megha Byahatti <quic_mbyahatt@quicinc.com>
2023-09-26 10:29:51 +05:30
qctecmdr
716fca5e3d Merge "video: driver: fix AV1 resolution checking" 2023-09-24 22:47:31 -07:00
Roopangkumar Patel
aee794dd80 Revert "video-driver: frequency claculation for iris33_2p"
This reverts commit 21eb1ee93a.

Reason for revert: Causing Device crash issue.

Change-Id: If37a4b5c6b880ff9995f4213fa508ca4a9f544d6
Signed-off-by: Roopangkumar Patel <quic_rooppate@quicinc.com>
2023-09-19 17:59:45 +05:30
Zhongbo Shi
e8ac66ef98 video: driver: fix AV1 resolution checking
Fix AV1 resolution checking conditions for
input bus voting.

Change-Id: I24593ce425bd952fa9a053dfd08e6bfa880ca4fc
Signed-off-by: Zhongbo Shi <quic_zhongbos@quicinc.com>
2023-09-18 13:46:04 +08:00
qctecmdr
1e7e0a1a57 Merge "video-driver: frequency claculation for iris33_2p" 2023-09-13 23:18:00 -07:00
Megha Byahatti
21eb1ee93a video-driver: frequency claculation for iris33_2p
-Add frequency, pipe penalty and bitrate table for
 iris33_2p to calculate vsp frequency.

Change-Id: Ic8fb11ca93bc96d023020edac10a412995573dd4
Signed-off-by: Megha Byahatti <quic_mbyahatt@quicinc.com>
2023-09-06 08:36:57 +05:30
qctecmdr
d66466da79 Merge "video-drvier: update NOC register programming" 2023-09-05 12:31:11 -07:00
Manikanta Kanamarlapudi
3296a4dacb video-drvier: update NOC register programming
Update NOC register programming based on vpu
version like iris33 and iris3_2pipe.

Change-Id: I98e879cdd0f89584dfc2c6fad8345979403b2b3e
Signed-off-by: Manikanta Kanamarlapudi <quic_kmanikan@quicinc.com>
2023-08-18 17:30:38 +05:30
qctecmdr
9b62925502 Merge "video: driver: fix roi metadata size calculation" 2023-08-14 14:03:35 -07:00
qctecmdr
d361bf3acb Merge "video: driver: remove dead code of uneccessary setting VPP delay" 2023-08-10 14:02:16 -07:00
Jiajia Cong
d9fe02d49a video: driver: fix roi metadata size calculation
lcu_size shouldn't be changed by shift op, it is still
needed in alignment calculation.

Change-Id: I3c0ebfaee84389926ba3e191d901006065598182
Signed-off-by: Jiajia Cong <quic_jcong@quicinc.com>
2023-08-07 22:01:06 -07:00
qctecmdr
c43d43d95e Merge "video: driver: fix length of line exceeding max length warning" 2023-08-03 15:08:37 -07:00
Ankush Mitra
99c2355e85 video: driver: remove dead code of uneccessary setting VPP delay
In driver num_comv value is coming more than expected
due to assumtion of default VPP delay as 2, which
is not needed now.

Change-Id: Ie24b5b30034cbc465aaa5952d80b6c0811cfe1a2
Signed-off-by: Ankush Mitra <quic_ankumitr@quicinc.com>
2023-08-01 11:32:01 +05:30
Megha Byahatti
13cfd900b7 video: driver: fix length of line exceeding max length warning
Fix 'length of line exceeding 100 char' warning.

Change-Id: Ic40bb53a85273eee79a37ead1937702b96f4e979
Signed-off-by: Megha Byahatti <quic_mbyahatt@quicinc.com>
2023-07-31 20:05:09 +05:30
Ankush Mitra
a101cca5a9 video: driver: fix space requirement warning
Fix space and blank line required warning.

Change-Id: I2f754e52cdb36332a53b65ca248ae5d974a00ff4
Signed-off-by: Ankush Mitra <quic_ankumitr@quicinc.com>
2023-07-25 17:50:44 +05:30
qctecmdr
050aed5c35 Merge "video: driver: fix space around '|' warning" 2023-07-24 16:42:41 -07:00
Ankush Mitra
9d62fcdd3a video: driver: fix space around '|' warning
Fix some of the checker warning.

Change-Id: Ia9854b515185b41673d37bdbb861993badd7d130
Signed-off-by: Ankush Mitra <quic_ankumitr@quicinc.com>
2023-07-21 14:45:30 +05:30
Ankush Mitra
30b8ff5ce2 video: driver: fix few checker warning
Fix braces are not necessary warning and suspect code
indentation warning.

Change-Id: I6e599d94766cc34013a0ddd758cf5c6609798ea2
Signed-off-by: Ankush Mitra <quic_ankumitr@quicinc.com>
2023-07-19 18:38:09 +05:30
qctecmdr
b941cfd415 Merge "video-driver: kept blank line after declarations" 2023-07-18 17:22:50 -07:00
Manikanta Kanamarlapudi
4d2903e0d0 video-driver: kept blank line after declarations
Fix warning of 'Missing blank line after declarations'
in the checker.

Change-Id: I3db5717890db68096e5a035c536f0b6bcae7e28e
2023-07-17 15:18:27 +05:30
Anshul Agarwal
2576adf412 video: driver: fix some checker err
Fix some checker err

Change-Id: I3526a509f4cbb3d91284b21dad851b57bb43f57a
Signed-off-by: Anshul Agarwal <quic_anshagar@quicinc.com>
2023-07-14 15:03:37 +05:30
Ankush Mitra
50a257d310 video: driver: fix No space is necessary after a cast err
Fix this warning in checker.

Change-Id: I2f90b2f8b3fddb55a3b1dd9b0e4ca227e46ed42f
Signed-off-by: Ankush Mitra <quic_ankumitr@quicinc.com>
2023-07-12 18:15:31 +05:30
Ashish Patil
9fad8ef79e video: driver: update the bandwidth calculation logic
- Driver code gets the compression ratio(CR) from FW. This CR is used
  to calculate the compression factor(CF) and used in BW calculations.
  Perf. model code for BW calculations always assumes that CF will be in
  fractional format. But, driver already converts the CR to integer format.
  So, we need to remove the x100 multiplication in BW calculation code.
- As CF is used as division factor for BW calculations,
  due to this x100 bump in CF values, we see very low calculated BW values.

Change-Id: Ifbddee68b6799b2fe0fc6d5ffa623514e1abd13f
Signed-off-by: Ashish Patil <quic_ashpat@quicinc.com>
2023-07-10 16:35:36 -07:00
Dikshita Agarwal
2ae30091f4 video: driver: fix copyright markings
fix copyright markings and have all markings in one
multiline comment.

Change-Id: I481c6213bb25e8c278956ad6a51df3fc5c1aabf2
Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
2023-07-08 01:40:35 +05:30
Govindaraj Rajagopal
c484af4e69 video: driver: remove duplicate static array inclusion from header
pineapple_technology.h contains multiple static array and it is
getting included from msm_vidc_bus.c & msm_vidc_clock.c files.
So in generated build is having 2 copies of static arrays in
code segment.

So added changes to avoid duplication in generated bin.

Change-Id: Ifcfa07331e868440d033d2c7d65555810ad4d1b3
Signed-off-by: Govindaraj Rajagopal <quic_grajagop@quicinc.com>
2023-07-06 19:27:02 +05:30
qctecmdr
1923a9e61d Merge "video: driver: iris33: treat NOC error as fatal" 2023-07-05 11:27:06 -07:00
qctecmdr
75351f36a5 Merge "video: driver: use helper functions wherever applicable" 2023-06-30 10:08:21 -07:00
qctecmdr
0088ada36c Merge "video: driver: print all NOC Errlog registers" 2023-06-30 10:08:21 -07:00
Maheshwar Ajja
0d3b2165bd video: driver: iris33: treat NOC error as fatal
Treat NOC error (which is a result of pagefault) as
fatal error to and get more debug info to resolve the
pagefault issue.

Change-Id: I3a1cd99fea680a941788d1bc8ea586bf0ff29365
Signed-off-by: Maheshwar Ajja <quic_majja@quicinc.com>
2023-06-28 11:21:06 -07:00
Dikshita Agarwal
5d2eff1150 video: driver: use helper functions wherever applicable
There are many places in code where available helper
functions are not being used, fix it.

Change-Id: Id5b309837fd5847e280f7fab02820af1b08242a6
Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
2023-06-28 13:59:57 +05:30
Deepa Guthyappa Madivalara
62279d0b91 video: driver: print all NOC Errlog registers
- print all NOC Errlog registers

Change-Id: I9bfe9f3f63da0566d57de45201ec0a99a8c93a16
Signed-off-by: Deepa Guthyappa Madivalara <quic_dmadival@quicinc.com>
2023-06-26 11:47:20 -07:00
Vedang Nagar
e05b1f39c9 video: driver: Remove core check from video driver
Remove core check from all the functions in video driver.
ore check is present in most of the functions in video
driver which is not required.
Keep check only at root level functions and remove
the check from rest all of the functions.

Change-Id: I5f6374b68dd739b7ab563f32f64bb90e368c4085
Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com>
2023-06-22 20:53:42 +05:30
qctecmdr
2c5cd81fe8 Merge "video: driver: cleanup driver remove sequence" 2023-06-15 09:01:57 -07:00
Darshana Patil
dd06676471 video: driver: adjust opb buffers min count
Incase of split mode(either for linear color format
or AV1 film grain usecases), dpb and opb(output)
buffers are allocated in same context bank. In high
memory consumption usecases like 8k, it can lead to
OOM issues. To avoid this, for split mode, when both
dpb and opb buffers are used, honor fw min count for
dpb buffers, whereas for opb buffers choose an optimal
min count to ensure performance.

Change-Id: I287aff862d2fe36a690c1393d64f8095578baf34
Signed-off-by: Darshana Patil <quic_darshana@quicinc.com>
2023-06-14 12:54:10 -07:00
Govindaraj Rajagopal
29d10ac07b video: driver: cleanup driver remove sequence
Remove deinit sequence calls and register devm
managed callbacks, so that kernel can invoke
then, when dev scope ends and cleansup all
associated resources.

Change-Id: I729fd21fe32d9f39240d0b743f910409d93a00c5
Signed-off-by: Govindaraj Rajagopal <quic_grajagop@quicinc.com>
2023-06-13 13:17:23 +05:30
Akshata Sahukar
b6fba340c3 video: driver: fix hfi_buffer_iris3.h premerge failures
remove macro brackets in hfi_buffer_iris3.h to
fix premerge failures

Change-Id: I30f2cb656376cefc632cc3fd64dc979a903bfdc0
Signed-off-by: Akshata Sahukar <quic_asahukar@quicinc.com>
2023-06-09 19:19:26 -07:00
Anshul Agarwal
950306d1aa video: driver: fix some checker err
Fix some checker err

Change-Id: I357059999dd43b58d6c414868a8b4060b6b691da
Signed-off-by: Anshul Agarwal <quic_anshagar@quicinc.com>
2023-06-09 15:31:01 +05:30
Anshul Agarwal
65d28b3cab video: driver: fix some checker err
Fix some checker err.

Change-Id: I6704727abf49c8c55ac9c213dec180c93928961f
Signed-off-by: Anshul Agarwal <quic_anshagar@quicinc.com>
2023-06-08 12:00:19 +05:30
Ankush Mitra
e1cb32c5de video: driver: resolve some checker err
Resolve some static checker err.

Change-Id: I0aa1d8c905ac7fd1defa16dd28d4386465f09ff3
Signed-off-by: Ankush Mitra <quic_ankumitr@quicinc.com>
2023-06-06 11:57:20 +05:30