Commit grafiek

188 Commits

Auteur SHA1 Bericht Datum
qctecmdr
60195e2ad2 Merge "msm: ipa: Fix lan polling to use max budget" 2020-08-20 00:41:34 -07:00
qctecmdr
33b0fd1d1a Merge "msm: ipa4: fix the unclock gsi IPA register access" 2020-08-19 19:14:56 -07:00
qctecmdr
3d503d5b16 Merge "msm: ipa4: Disable uc monitoring stats for holi target" 2020-08-19 18:30:16 -07:00
qctecmdr
08bb775bb1 Merge "msm: ipa4: Configure the destination resource group for DRB-IP" 2020-08-19 17:58:54 -07:00
Ashok Vuyyuru
8cb85b52b3 msm: ipa4: Disable uc monitoring stats for holi target
In holi target due uC memory constraints uC monitoring stats
not support. So disabling the sending monitor command to uC.

Change-Id: I34e319118287fcd82876344bd85ab53c50cf5651
Signed-off-by: Ashok Vuyyuru <avuyyuru@codeaurora.org>
2020-08-19 22:02:20 +05:30
Ashok Vuyyuru
7c957296ab msm: ipa4: Configure the destination resource group for DRB-IP
Adding changes to configure the destination resource group for DRB-IP.

Change-Id: I41248e7e7e92a0e4635b8661d1f324be165bd2fa
Signed-off-by: Ashok Vuyyuru <avuyyuru@codeaurora.org>
2020-08-19 21:58:56 +05:30
qctecmdr
a32fd77448 Merge "msm: ipa: fix the endp_init_deaggr configuration" 2020-08-19 06:49:25 -07:00
Bojun Pan
72e7088c19 msm: ipa4: fix the unclock gsi IPA register access
The while loop in gsi_handle_irq will cause an extra register
read after handle last interrupt. This read can be the unclocked
read. The fix is to break on ch/evt control interrupt where
could potientially cause IPA clock off.

Change-Id: If4b3bb127ee66648d24b8ca7c16bd6fec42d9fcc
Signed-off-by: Bojun Pan <bojunp@codeaurora.org>
2020-08-18 23:43:53 -07:00
qctecmdr
2d19d4a5e6 Merge "msm: ipa3: Fix to use paired PM operation for IPA" 2020-08-18 18:52:32 -07:00
qctecmdr
15bdbefea5 Merge "msm: ipa: avoiding NULL pointer de-referencing" 2020-08-18 17:48:24 -07:00
qctecmdr
10afe9873b Merge "msm: gsi: cache last 20 gsi interrupt for interrupt storm debug" 2020-08-18 14:06:17 -07:00
Ashok Vuyyuru
7aa33aede2 msm: ipa3: Fix to use paired PM operation for IPA
Becauase of using wrong pair of PM operation device
was not resuming if suspend fails. Adding changes to
use correct set of PM operations.

Change-Id: Ib9fdea8f93f0a6dafbd5908dc8fc2bbf4f1e0904
Signed-off-by: Ashok Vuyyuru <avuyyuru@codeaurora.org>
2020-08-18 01:55:24 +05:30
Chaitanya Pratapa
37f6ed3720 msm: ipa: Fix lan polling to use max budget
Make changes to use the max budget of 64 for the LAN polling.
Otherwise we will switch between Polling and Interrupt mode
even when there is continuous data.

Change-Id: I6bbf49b77d258e88044c03a33fe20bb015a55019
Signed-off-by: Chaitanya Pratapa <cpratapa@codeaurora.org>
2020-08-14 16:50:43 -07:00
Bojun Pan
b1419bf968 msm: ipa: fix the endp_init_deaggr configuration
In IPA4.9, the wrong end_init_deaggr ipa hal implementation had
been chosen. The fix is to correc the setting.

Change-Id: I63e2c50bc42b13ef9213d4b75d5c22346170a0d3
2020-08-14 16:04:39 -07:00
qctecmdr
717e1ce2fb Merge "msm: ipa: enable drop stats for USB/WLAN and DPL pipes" 2020-08-14 13:45:31 -07:00
qctecmdr
afc5807ba0 Merge "msm: ipa: rate limitting error logs" 2020-08-14 13:05:27 -07:00
Chaitanya Pratapa
a5fbe3bdc5 msm: ipa: enable drop stats for USB/WLAN and DPL pipes
With HOLB monitoring, it is beneficial to enable drop
stats for USB and WLAN pipes. Also enable drop stats for
DPL pipe.

Change-Id: I24df7041a4056d2875f6b14d50ab52beb1459eeb
Signed-off-by: Chaitanya Pratapa <cpratapa@codeaurora.org>
2020-08-12 22:44:52 -07:00
Michael Adisumarta
c5ccae821e msm: ipa: rate limitting error logs
Rate limitting error logs in rndis_ipa file.

Change-Id: Iebd548df1a99553afdabb6375675576fe3776832
Signed-off-by: Michael Adisumarta <madisuma@codeaurora.org>
2020-08-12 19:13:35 -07:00
Michael Adisumarta
8c28530134 msm: ipa: avoiding NULL pointer de-referencing
Avoiding NULL pointer de-referencing for an internal variable.

Change-Id: I9fa3bc24c747c7c04d1d64b29fc63677206252e0
Signed-off-by: Michael Adisumarta <madisuma@codeaurora.org>
2020-08-12 14:33:52 -07:00
Ilia Lin
9d4ff10cc6 ipa: Cleanup after moving internal definitions
Removing the files copied from the kernel:
ipa.h
msm_gsi.h
ipa_fmwk.h
ipa_mhi.h
ipa_odu_bridge.h
ipa_uc_offload.h
ipa_usb.h
ipa_wdi3.h
ipa_wigig.h

and including the original files instead.

Depends-on: 3177533

Change-Id: I485f5545505bfbc4e775a75ae3d0809f9a977a97
Signed-off-by: Ilia Lin <ilial@codeaurora.org>
2020-08-12 10:37:35 +03:00
Sivakanth vaka
9d023aee86 msm: ipa3: Enable holb as part of usb suspend
When USB is suspended there are DL packets on consumer
channel leading to stall. to avoid the stall enabling
the holb as part of suspend and removing it in resume.

Change-Id: I08e2fe248ee675698da16b6df6aec8f109c73608
Signed-off-by: sivakanth vaka <svaka@codeaurora.org>
2020-08-06 10:38:31 +05:30
Sivakanth vaka
00100fbf02 MDM:IPA3: Fixes issue with RNDIS and ECM suspend path
PM resources are released even when there are outstanding
packets leading to data stall hence resources are released
only when there are no outstanding packets.

Change-Id: I630737edfc9cadea1d8a99bdb6bb6fcbe76615d8
Signed-off-by: sivakanth vaka <svaka@codeaurora.org>
2020-08-05 16:10:30 +05:30
qctecmdr
9b22e915ef Merge "msm: ipa: Endpoint configuration and IPA driver changes for mannar" 2020-08-04 03:54:50 -07:00
Amir Levy
e45ddd2b4e msm: ipa3: fixed a dependency between tx-napi and LAN rx-napi
Fixed the if condition for enabling the NAPI netdev to init the netdev
if at least one of both features is enabled.

Change-Id: I14d454bf6eaa070a9ba5bab9e0b2d2f3bd4a8cf7
Acked-by: Tal Gelbard <tgelbard@qti.qualcomm.com>
Signed-off-by: Amir Levy <alevy@codeaurora.org>
2020-08-03 02:51:33 -07:00
Armaan Siddiqui
9e91a1ef19 msm: ipa: Endpoint configuration and IPA driver changes for mannar
Added Endpoint configuration and IPA driver changes for mannar.

Change-Id: I7424faa1757e7cf81eb9387b63a153cd6b6e607b
2020-08-03 11:28:32 +05:30
qctecmdr
6234b61db8 Merge "msm: ipa: rate limit the error logs from IPA" 2020-08-02 05:29:30 -07:00
Michael Adisumarta
aeb5c38043 msm: ipa: rate limit the error logs from IPA
Reducing/Rate limitting the IPA error logs.

Change-Id: Ib664a252681ac10daf24b276a447f19bff01c982
Signed-off-by: Michael Adisumarta <madisuma@codeaurora.org>
2020-07-31 13:48:14 -07:00
Bojun Pan
2795bd907b msm: ipa: remove duplicated ready cb for rmnet_ctl
Duplicate code which is causing we call probe_cb twice to rmnet_ctl
module.
Remove the un-necessary return after pipe setup but rmnet_ctl not
registered yet.

Change-Id: I935ca6c09801ab2882a196d739f0de55a4ab3806
2020-07-31 09:35:41 -07:00
Amir Levy
644aae185c msm: ipa3: Remove ipa_api
ipa_api provided a wrapping layer for various functions in order to
mitigate between different ipa version. This mitigation is no longer
needed, hence ipa_api is obsolete.

Change-Id: I84c3fafef0f578b86080ac8457493ced4ec442e3
Acked-by: Eliad Ben Yishay <ebenyish@qti.qualcomm.com>
Signed-off-by: Amir Levy <alevy@codeaurora.org>
2020-07-30 15:51:45 +03:00
qctecmdr
a62933e710 Merge "gsi: Init rp_update_vaddr at event ring init" 2020-07-30 00:37:40 -07:00
qctecmdr
8d6f423aa0 Merge "msm: ipa: Fix deleting the routing entries" 2020-07-29 12:26:54 -07:00
Ilia Lin
f8bfa48848 gsi: Init rp_update_vaddr at event ring init
Leaving this field 0 may lead to a crash during
the first gsi_poll_n_channel() call.

Change-Id: I6c8e9e1e5bacdddd41023618881d761d730a1931
Signed-off-by: Ilia Lin <ilial@codeaurora.org>
2020-07-26 22:59:21 +03:00
Ashok Vuyyuru
8f3cb08e2c msm: ipa3: Configure correct aggeragtion byte limit
IPA HW will treat aggeragtion byte limit value 1 consider as 1K.
Adding changes to configuring the aggeragtion byte value w.r.t
IPA HW requirement.

Change-Id: Ibe9353a39971296f7e4b04f30039457c07c63033
Signed-off-by: Ashok Vuyyuru <avuyyuru@codeaurora.org>
2020-07-23 15:27:40 +05:30
Chaitanya Pratapa
ed74f973da msm: ipa: Fix holb event log handling
When we get a bad peripheral event from uC when there is a pending
HOLB ADD/DEL command response from uC we will run into a deadlock
if we try to acquire mutex as part of event log. Make a change
to remove mutex lock when logging the events.

Change-Id: I60ca3ecc4fe4d090278f745bdf2bb9e1bd09ca60
Signed-off-by: Chaitanya Pratapa <cpratapa@codeaurora.org>
2020-07-22 11:55:24 -07:00
qctecmdr
5d58e67d7c Merge "msm: ipa: removing explicit NAPI object delete" 2020-07-21 22:06:58 -07:00
qctecmdr
088286f329 Merge "msm: ipa: use detach/attach netif instead of stop/wakeup" 2020-07-21 16:55:26 -07:00
qctecmdr
27eabd049c Merge "techpack: ipa: Fixing compile errors" 2020-07-21 10:21:01 -07:00
Chaitanya Pratapa
376242c944 msm: ipa: Fix deleting the TX napi context
TX napi context is a mutable variable and so must be deleted
whenever the pipe is disconnected. Otherwise we will see a
memory leak.

Change-Id: I9309130c786e1092fd1a717359774fca9a37fcd1
Signed-off-by: Chaitanya Pratapa <cpratapa@codeaurora.org>
2020-07-18 23:10:16 -07:00
Rishabh Garg
e6060ecc44 msm: ipa: Fix compilation error
Change the syntax of condition to fix compilation error.

Signed-off-by: Rishabh Garg <rishgarg@codeaurora.org>
2020-07-17 23:18:38 +05:30
Chaitanya Pratapa
68623da41c msm: ipa: Fix deleting the routing entries
Make changes to delete the route entry even when the hdr/proc_ctx
handles are already freed. Otherwise the entry will be dangling.

Change-Id: Icbab6b96fa137c5214b37ea33c6203c5a54273ac
Signed-off-by: Chaitanya Pratapa <cpratapa@codeaurora.org>
2020-07-16 23:55:00 -07:00
qctecmdr
b8079886fd Merge "techpack: ipa: Move internal definitions to the techpack" 2020-07-16 21:00:24 -07:00
Ilia Lin
2b169b5f0e techpack: ipa: Move internal definitions to the techpack
Moving the defines used only internally to the local files:
ipa_i.h
ipa_common_i.h
gsi.h

Moving completely the following files from the kernel tree:
ecm_ipa.h
rndis_ipa.h

Adjusting the #include statements accordingly.

Temporary moving the following files to the techpack
as part of 3 stage internal definitions moving:
ipa.h
msm_gsi.h
ipa_uc_offload.h
ipa_mhi.h
ipa_wigig.h
ipa_wdi3.h
ipa_usb.h
ipa_odu_bridge.h
ipa_fmwk.h

On the second stage (after this change merge)
the kernel change will be merged independently.

On the third stage the local copies will be removed
from the techpack and the original files from the kernel
will be included instead.

Change-Id: If5eecc5f96a6a98075db5819f18acaec581b456e
Signed-off-by: Ilia Lin <ilial@codeaurora.org>
2020-07-16 21:16:28 +03:00
qctecmdr
16f70a69e3 Merge "msm: ipa: Fix using the right client enum" 2020-07-16 00:57:39 -07:00
qctecmdr
aef65700cc Merge "msm: ipa4: Add checks to prevent use-after-free errors" 2020-07-15 23:22:58 -07:00
Bojun Pan
a2f95e6aab msm: gsi: cache last 20 gsi interrupt for interrupt storm debug
GSI interrupt storm can happen due to un-clocked gsi isr.
If we enable clock and assert, there is a chance the gsi isr will
be already handled.
To debug it further, the change is to cache last 20 gsi isr with
timestamp.

Change-Id: I30be03a20df9f11be7f5d8c06b049591305940bb
Signed-off-by: Bojun Pan <bojunp@codeaurora.org>
2020-07-15 16:42:05 -07:00
Michael Adisumarta
963ea81558 msm: ipa: removing explicit NAPI object delete
NAPI object is deleted as part of free_netdev. No need
to free it seperately

Change-Id: I20a2b6a8f73f9341030188d00dadc6acc7671c30
Signed-off-by: Michael Adisumarta <madisuma@codeaurora.org>
2020-07-15 14:54:19 -07:00
Chaitanya Pratapa
5cffb57355 msm: ipa: Fix using the right client enum
Fix using the right client enum when trying to add
NAPI TX function.

Change-Id: Ie45b5b72efdd76c27da854f1a22ed7e8f5853592
Signed-off-by: Chaitanya Pratapa <cpratapa@codeaurora.org>
2020-07-15 14:31:03 -07:00
Praveen Kurapati
9fd0658d2d msm: ipa4: Add checks to prevent use-after-free errors
A dangling pointer in IPA IDR structure causes use-after-free
issue. Add changes to prevent this corruption.

Change-Id: I229266b05cf6dab0c2d19e5c1e3b0883c7efcc72
Signed-off-by: Ashok Vuyyuru <avuyyuru@codeaurora.org>
Signed-off-by: Praveen Kurapati <pkurapat@codeaurora.org>
2020-07-16 00:22:25 +05:30
qctecmdr
6adb226271 Merge "msm: ipa4: Fix to mask the global interrupt INT1" 2020-07-15 03:42:19 -07:00
qctecmdr
78ab233b35 Merge "gsi: Fix NULL pointer dereference on event-less channels" 2020-07-15 03:05:08 -07:00