Currently, mac address ptr is passed to print the mac address
but the macro that prints mac address has an expansion to
multiple(four for now) %x's. So, the argument should also have
corresponding expansion. Fix it by passing expansion macro
as argument.
Change-Id: Ib4ea415eac1bfb2b3ef5ffa041669b8d6ef59579
CRs-Fixed: 3717930
As per new requirement, host should send proper values
to get_channel request from upper layer for standby link.
Upper layer can use these information to fetch CU values
for standby link and print on console.
Change-Id: Iad3704d391058675e7d4ff6ffc419f74efa0c658
CRs-Fixed: 3715229
The SAP is not moved to the 6 GHz user configured
frequency in the following cases:
1. STA disconnected, SAP is standalone in 2.4 GHz
2. STA is VLP/PSC channel, but SAP is currently in
2.4 GHz(due to STA(DFS) + SAP)
Allow the SAP to restart in 6 GHz channels for the
above scenarios if the following criteria are met:
1. For standalone: The SAP user configured band is
superior than the current operating band.
2. For SCC: The 6 GHz STA should operate in PSC and
the channel should support VLP in DUT regdomain.
Change-Id: Iea292c94e579ccead2300f6e9b994c4b8e9a0a87
CRs-Fixed: 3713247
Check for DP drain status and prevent suspend if
we fail to drain txrx succefully.
Change-Id: I76c5587719cb162e3e7802586d5ddde24f18e755
CRs-Fixed: 3718937
Some solutions may not have HS-2.0 certification and there is
no need to forward the BTM frame to wpa_supplicant in such
solutions. Let firmware handle the frame in such cases by
enabling btm_offload so that it doesn't wakeup the host.
Firmware may roam to another AP upon BTM reception.
To enable/disable BTM offload add hs20_btm_offload_disable INI.
If this INI is enable BTM offload will be disable and if INI
is disable BTM offload will be enabled.
Change-Id: Id6e18404cc3a12a23b213c0f858c943715285932
CRs-Fixed: 3718776
On request of "get channel" from upper layer for standby link,
host fetches all required information (primary frequency,
central frequency and channel width are mandatory field here)
from "mlo_link_info->link_chan_info" structure and send same
values as a response to upper layer. Upper layer uses these
values to fetch survey info (like freq, CU value, noise,
RSSI value etc.).
If host fails to send proper values in response of
"get channel" response, host does not trigger "get survey info"
request and this results upper layer will not print CU values
on console for standby link on triggering driver command
DRIVER MEASURE_ML_CHANNEL_CONDITION.
Currently host does not update link_chan_info structure with
proper value of ch_width which results above issue.
Fix is to update proper value of ch_width to
"mlo_link_info->link_chan_info" structure.
Change-Id: Ibdc3086be38c9aace40ccd5abfd2eaa1582ecdb0
CRs-Fixed: 3715252
UL data delay is high when connect specific AP.
To fix it with OUI ini, limit Tx BW if vendor OUI is received in beacon.
Change-Id: I54a4ddb4f113baf1da0ba5490760f38f30159f2e
CRs-Fixed: 3695107
In lim_check_wpa_rsn_ie(), validate the RSN and WPA IE
only for SAP mode.
Regression cause is:
If2a0a59c6b4986b54a12d4bdc7372c38317b6ce2
CRs-Fixed: 3698880
Change-Id: I2429898ee91064d14e3ed4c267ac1e5575c058a5
FISA entry is updated by FISA RX and work queue, if the same
entry is hashed for different REO id, the lock may not work
as expected. Change is to hold the lock before work queue
waking up to prevent the race condition.
Change-Id: I16ba4439c1655bbb7bf83b13d9280cb3f7c56478
CRs-Fixed: 3674340
Disable the bss transition cap in the extended capabilities
IE, if the AP supports MBO without PMF.
Change-Id: Iaaacb95e74aa1d4f5f4a651eafe7370e6ed78627
CRs-Fixed: 3716299
Currently, sap mandatory channel list is not reset during
stop_ap. If selected band changes and gEnableSAPManadatoryChanList
is enabled then new band frequencies may be discarded via pcl
modification based on sap mandatory channels and sap may come
up on frequency which is not as per the selected band.
Fix is to reset sap mandatory channels when sap stops.
So that if sap starts again with different band previous
mandatory channels are not considered.
Change-Id: Ibb70acc921558ca48c6385950adf5e48a55d20ef
CRs-Fixed: 3708549
MLD address is mandatory for link VDEV connect request or
else the partner link will fail during candidate fetch from
scan DB because of MLD address mismatch.
For MLO OWE roaming, link VDEV connection starts after
completion of EAPOL-HS, and here MLD address is not filled
leading to link VDEV connect failure.
Use connect response to fill MLD address in link VDEV
connect for MLO OWE roaming
Change-Id: I9eae3b7ba3619a9ce62603efd0590aabce9c70f3
CRs-Fixed: 3715021
Currently, HS_20_AP param of cm_ext_obj->rso_config is set
to true when STA connects to a HS-2.0 AP. This is to disable
btm_offload as per HS-2.0 cert requirements.
But this flag is not cleared even when STA disconnects from
that AP and this disables btm_offload for next connections
as well even for non-HS-2.0 APs.
So, reset the flag as part of connect start to avoid this.
Change-Id: I3763544ecca0e4628b0c78633364fe70fd9b3094
CRs-Fixed: 3712758
FW sends "Center Frequency Index" as new center frequency.
via mlo sta standby csa event WMI_CSA_HANDLING_EVENTID.
Currently host uses value of Center Frequency Index (CFI)
directly to update center frequency for all links to
"mlo_link_info" structure. Due to this host maintains a
wrong value of center frequency throughout of connection
which leads to failure in calculation of bonded channel
in case of 6 GHz and 320 MHz connection.
Fix is to update center frequency in "mlo_link_info"
structure for all require link(s) as per CFI coming via
mlo sta standby csa event.
Change-Id: I73c919aa52ad2eaa822ff5d070223a2d383a0da7
CRs-Fixed: 3709824
Host tried to associate to AP, 6 GHz link is selected as
the assoc link and in the RNR there are two partner links 5 GHz, 2.4 GHz.
Only 6 GHz/2.4 GHz are beaconing and 5 GHz is not beaconing.
STA sent the ML-Probe request on 6 GHz link requesting the full profile
for the 5 GHz and 2.4 GHz links but AP responded with only one partner
link 2.4 GHz, from this we generated 2.4 GHz and added to scan cache,
AP didn't respond with 5 GHz link in per-sta.
STA sent the assoc request over 3-links and AP accepted the assoc,
and association is successful over 3-link and the same is intimated
to the firmware that 3link association is successful.
But while sending the connection information to the kernel 5 GHz link
is not found resulting in HDD/Kernel not being aware of the 5 GHz link.
Fix :- Use assoc response from the ML AP to generate ML probe resp
for the partner links to add to scan DB so that partner link
VDEV will have candidate to start connection.
Change-Id: I30176e58d9b02e7ed275b1c926cd1e119b66f8f3
CRs-Fixed: 3686809
Incase of Firmware crash during the bootup sequence of idle restart
the platform driver calls pld_uevent to indicate the firmware_down
and once the firmware comes back up idle restart callback is invoked
rather than shutdown/re_init. So in this case post idle_restart
the recovery inprogress flag which is set during the fw_down is not
reset, which results in blocking all the north bound operations.
To fix this scenario reset the recovery inprogress flag once
idle_restart is complete.
CRs-Fixed: 3709598
Change-Id: I9aa3e22be7fccc6baffc8fe5d4cdfd64b022bee0
When firmware roams to 2 link AP and sends roam synch key event,
then the pairwise keys are still copied to key_entries for all
the three links in extract_roam_synch_key_event_tlv(). But
since 3rd link is not valid, the pairwise key memory allocated
is not freed resulting in memory leak.
So free the allocated redundant memory for invalid link pairwise
key after roaming.
CRs-Fixed: 3697540
Change-Id: Idfdb53c918d8e684e6171b5e0917e722a2fc605a
This reverts change-Id I7ab2ade0f01ad5035f7b156ded7eb7af7c826b9e.
For CR-3698932, FW to make a change to program MLD address in addition to
link address for ROC request on MLO STA. for ROC scan req host will set
SCAN_FLAG_EXT_FILTER_PUBLIC_ACTION_FRAME.
Host to bring back logic (ROC on BSS channel) added in CR3069810 by
reverting CR3366671.
FW to make a change as replacement fix to CR3366671: allow ROC if requested
channel is same as ULL STA (active link in MLO case) BSS channel when scan
is suppressed due to ULL or other reason.
CRs-Fixed: 3704271
Change-Id: I5914bbd132ebfd9a7b1a852913fb16cdfb1fd8f7
Currently whenever the userspace is trying to reset the previously
configured max mlo links for association, set wifi config command
with "SET_NUM_ALLOWED_MLO_LINK 0" is issued, this always
resets the max mlo value to the ini default value which is 2
rather than defaulting to the firmware/ini intersected value.
Fix is to default to the firmware/ini intersected value rather than
the default value.
CRs-Fixed: 3707990
Change-Id: Iaa7cbe32613102ccffbcf92fcb7ef0a39f96a705
Currently on HO failure host posts disconnect with priority
set in serialization queue before dequeuing the dummy roam
command from serialization, as a result for 2 link ML STA
case when HO failure is received, assoc VDEV disconnect gets
priority over partner link VDEV in the serialization
queue. When assoc VDEV disconnect is complete, host updates this
info to userspace and userspace issues dynamic mac address
update command. While processing this command the DP assoc VDEV
is first detached then re attached. There is possibility of
race where link VDEV disconnect starts in parallel, as DP link
VDEV has the reference of DP assoc VDEV, in order to release the
reference it looks up for the DP assoc VDEV , but as part of mac
address update if DP assoc VDEV is detached and reattachment is
pending then the DP link VDEV doesn't get the DP assoc VDEV and
reference release fails.
To address this issue don't prioritize disconnect for
HO Fail case.
Change-Id: I74c7bce851423226d3aac2750fddd5e6c7e34fd1
CRs-Fixed: 3697528
The config CONFIG_CFG80211_MLD_AP_STA_CONNECT_UPSTREAM_SUPPORT
is need for backward compatibility of legacy STA connection
to OWE SAP.
Therefore enable the above config for MSL targets.
Change-Id: I43df2d72d657d9c9bb5bc4335daca3bc61b4d2ba
CRs-Fixed: 3692713
Add more validation for vendor command force active link bitmap:
1.If force inactive num is present due to MCC link(DBS RD) or
concurrency with legacy intf, don't allow force active if
left inactive link number doesn't meet concurrency requirement.
2.If force inactive bitmap is present due to link removal or
concurrency with legacy intf, don't allow force active if
it is conflict with existing concurrency requirement.
Change-Id: Ic7507c1797189c079f0032a39819e15467bd6bf3
CRs-Fixed: 3701323
Currently the dp_link address is provided to CDP vdev
as a part of vdev register. Also, as per the vdev deletion
sequence, it is possible that dp_link can be destroyed
before CDP vdev is detached. This can lead to use-after-free
scenario when CDP vdev uses the osif_vdev handle (which is
the dp_link handle).
In order to fix this, do not free the dp_link till the CDP
vdev has been detached.
Change-Id: Ie5a1140a0d256b6115fa62e30e6bfd61d1dfc898
CRs-Fixed: 3696641
