This change fixes prevent issues like incorrect
sizeof expression and incorrect format specifiers
in cam_isp.
CRs-Fixed: 3751374
Change-Id: Ia1383a655412176c4de30ef17412c2ff900f768e
Signed-off-by: Shivakumar Malke <quic_smalke@quicinc.com>
Fixes missing logging parameter in few of the logs.
CRs-Fixed: 3758192
Change-Id: Ic4d351fdf11213c515d975bda48a299e885e123d
Signed-off-by: Yash Upadhyay <quic_yupadhya@quicinc.com>
PP overflow, Pdaf violation issues were observed after
flush in stop sequence on crow. This change fixes csid
halt sequence for any usecase by correctly setting halt
mode and cmd while enabling and disabling ipp/ppp paths.
Here we are setting halt cmd to resume at frame boundary
at start and halt at frame boundary at stop.
CRs-Fixed: 3628412
Change-Id: I804e8077676e461376b49446ffbf74d0fb8c092e
Signed-off-by: Yash Upadhyay <quic_yupadhya@quicinc.com>
This change add support for EPD mode high data
rate sensors which send EPD instead of EOT. This
change is only for CPHY EPD sensors and not applicable
to DPHY EPD sensors. For CPHY EPD sensor, EOT error masked.
CRs-Fixed: 3736696
Signed-off-by: Alok Chauhan <quic_alokc@quicinc.com>
Change-Id: I5ef0dac8e590daa1c4f3bc217f7da81a7a193dfe
On checking IRQ status on cdm hang detection, if the
inline IRQ is set then the cdm has triggered IRQ, but
there could be workqueue scheduling delay causing cdm's
config timeout. To prevent the timeout due to scheduling
delay check both work record and irq status and return
true if its delay.
CRs-Fixed: 3433175
Change-Id: Iaa34f8ff9b57e7da9f80677a7da9b4f9a53dad14
Signed-off-by: Yash Upadhyay <quic_yupadhya@quicinc.com>
For shdr usecase, buffer alignment is not happening to
right resource due to wrong resource id mapping.
Correct the resource id mapping for shdr buffer alignment.
CRs-Fixed: 3696470
Signed-off-by: Alok Chauhan <quic_alokc@quicinc.com>
Change-Id: I9921add8a434cce04229cea5bdcd1c720a9b680a
TFE disable WM client logic is broken due to ISP common framework
changes and last consume address changes in ISP common framework.
Fixed the logic to disable WM dynamically. This change add the
fix for invalid pointer access in last consume address logic
as well.
CRs-Fixed: 3696470
Signed-off-by: Alok Chauhan <quic_alokc@quicinc.com>
Change-Id: I31d06e0dfe17ef660e7ff023b41ada1d713ff92f
During deinitialization of camif lite resources,
potential dereference of NULL pointer can cause
stability issues.
This commit adds validity checks
before accessing the camif lite resource pointers.
CRs-Fixed: 3715678
Change-Id: Id13b09d35f6602fbf97d835fe3b574d70f68dad4
Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
In init and deinit of a camera Hardware resources
parameters can be invalid/uninitialized which can
be NULL.
By adding NULL checks before dereferencing
will avoid error scenario.
CRs-Fixed: 3715918
Change-Id: I6dd28d5f27fc108b01a274aa2b6ea9988e612837
Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
Un-clocked access of registers during dumping the registers while
handling the start failure.
Reason for the issue is that handle_reg_dump trying to read the hw
registers when HW clocks are disabled.
This commits adds a check to validate if the hw is initialized before
accessing the registers.
CRs-Fixed: 3668129
Change-Id: I98039af2382df7acce767422689992388210004f
Signed-off-by: Dharmender Sharma <quic_dharshar@quicinc.com>
Null arguments in ISP and Sensor drivers during init
and deinit calls can result in invalid dereferences
impacting the stability.
This commit adds checks to
handle such invalid arguments.
CRs-Fixed: 3711570
Change-Id: I08727201f787af0d5bc5dbe85acea03bb4db247c
Signed-off-by: Sourabh Soni <quic_soursoni@quicinc.com>
Fix buf done handling in tfe bus driver due to missing
handling for multiple out resource.
CRs-Fixed: 3696470
Signed-off-by: Alok Chauhan <quic_alokc@quicinc.com>
Change-Id: Ie5597b83d21368f921d232d242c82be671ab8080
Output port map structure is not defined for TFE.
This is causing null pointer dereference in add io
buffer api.
Add support for outport map structure in TFE driver.
CRs-Fixed: 3696470
Signed-off-by: Alok Chauhan <quic_alokc@quicinc.com>
Change-Id: I35fa1f36a65bb0ba3dfd896567b47549b6bebf9d
Mutex unlock was missing in CSID driver in case the drv clk rate
call fails. This can result in recursive locking situations.
This commit handles the error scenario.
Change-Id: Ie1e60006713f0a96831ec1174bec1b40ab460a1f
CRs-Fixed: 3712878
Signed-off-by: Gaurav Jindal <quic_gjindal@quicinc.com>
Program WM mode based on mode flag for RDI resources..
CRs-Fixed: 3627088
Change-Id: Ie2918462fdfa8fe486983e63fcf66f9ec568c75f
Signed-off-by: Chandan Kumar Jha <quic_cjha@quicinc.com>
