In csr_roam_call_callback() there is a call to
csr_parse_bss_description_ies() where the MAC context is typecast to
tHalHandle as part of the function call. However this typecast is
incorrect since csr_parse_bss_description_ies() expects to get a MAC
context. Due to the manner in which tHalHandle is defined this does
not current cause a build issue, but an upcoming change will enforce
type checking so update this call to remove the inappropriate
typecasts.
Change-Id: I16e1f33e6f00ed1c610511a60f5974f0f0d71cd5
CRs-Fixed: 2268807
Currently sme_neighbor_report_request() passes a tHalHandle to
sme_rrm_neighbor_report_request(), but a tpAniSirGlobal is expected,
so correct the call to pass the correct parameter.
Change-Id: I4a9ba52ef0a6e345d784937f645cf926bebf8919
CRs-Fixed: 2268806
Currently csr passes a tpAniSirGlobal to sme_ft_open() and
sme_ft_close() but a tHalHandle is expected, so correct the calls to
pass the correct parameter.
Change-Id: I1b33aff2aa9f9ca09384e643aad4e36e79c52af3
CRs-Fixed: 2268804
Currently sme_scan_flush_p2p_result() passes a tHalHandle to
csr_scan_flush_selective_result(), but a tpAniSirGlobal is expected,
so correct the call to pass the correct parameter.
Change-Id: Ibee01bb0606fc3d8a294b455f09c76823b8043bc
CRs-Fixed: 2268803
Currently sme_scan_flush_result() passes a tHalHandle to
csr_scan_flush_result(), but a tpAniSirGlobal is expected,
so correct the call to pass the correct parameter.
Change-Id: I618ed5e16752eb6910060389f7c645b4e9ef5c83
CRs-Fixed: 2268802
Currently sme_scan_get_result_for_bssid() passes a tHalHandle to
csr_scan_get_result_for_bssid(), but a tpAniSirGlobal is expected, so
correct the call to pass the correct parameter.
Change-Id: I7fd7c06f320e14278cb621415bc4631d9c83b5d4
CRs-Fixed: 2268801
Before checking for other kinds of resources leaks, check to ensure all
objmgr pdevs have been properly freed.
Change-Id: I026a9e7497f593ba1d69fe220bbe0a33828811d3
CRs-Fixed: 2267144
When STA is already up on some 2.4Ghz channel and SAP needs to be started
on some 5Ghz channel through ACS, scan channel list contains only 5Ghz
channels. But scan results contains beacons on STA 2.4Ghz channel as well
which is getting parsed contributing to bsscount and rssi on that 2.4Ghz
channel which should not be the scenario as bsscount should be 0 and rssi
should be -100 on this 2.4Ghz channel as it is not present in the scan
channel list sent by HOST to fw.
Avoid beacon parsing on all the channels other than the channels present
in ACS scan channel list.
Change-Id: I85ab967386b19748c32e98a7e468d471e31f9b9a
CRs-Fixed: 2266170
When driver performs vdev delete operation, it changes vdev state
to logically deleted or physically deleted only after receiving vdev
delete command's response from FW. In between (sending vdev del req
and receiving vdev del rsp) if thread gets pre-empted and other thread
start posting command (like scan command) to process then it could
lead to use after free scenario.
Notify scan component when vdev delete is intiated and let scan
component record that in to vdev's scan private object as one of the
flags.
check this flag before processing the scan command.
CRs-Fixed: 2265542
Change-Id: Id884d6c42cd8766e70835808863632e096158487
WLAN logs are excessively filled with
IPA logs when IPA performance level
is set.
Remove unnecessary logging in
hdd_ipa_set_perf_level().
Change-Id: I07563c1a6e98981e2b074bce7a969c9cbd94ec24
CRs-Fixed: 2268632
Currently define flags CONFIG_PLD_SDIO_CNSS and
CONFIG_PLD_PCIE_CNSS are inferred by examining
two different configuration options in kbuild.
In order to configure it from defconfig files
create new configuration parameters
CONFIG_PLD_SDIO_CNSS_FLAG and
CONFIG_PLD_PCIE_CNSS_FLAG. Enable PCIE_CNSS_FLAG
only in case of PCIE build.
Change-Id: Ia1038f4aaf25f949005ec41c405232ec9981c988
CRs-Fixed: 2267172
Move destruction of blocked_scan_request_q and related lock
from __hdd_netdev_notifier_call to hdd_close_adapter
for the former one might be invoked for more than once and
could cause issues.
Change-Id: Ifb62750a09a2dcca381217a41280ad943942ee35
CRs-Fixed: 2267481
Change "qcacld-3.0: Introduce mac_handle_t" introduced a modern
name for what was previously called the tHalHandle. Transition
wlan_hdd_main to use the new naming.
Change-Id: If9ddbe0935d859d4c71dc11576cd7062a715b3e9
CRs-Fixed: 2267227
Change "qcacld-3.0: Introduce mac_handle_t" introduced a modern name
for what was previously called the tHalHandle. Subsequently change
"qcacld-3.0: Use mac_handle_t in wlan_hdd_he" transitioned wlan_hdd_he
to use the new naming. But subsequently a new instance of the old
naming was added by change "qcacld-3.0: separate HE caps per band" so
replace that new instance.
Change-Id: Id450debfd30f54df050be7d02543581ce46eb5a5
CRs-Fixed: 2268167
In sme_scan_get_result() when calling csr_scan_get_result() a
tHalHandle is currently being passed as the context parameter.
csr_scan_get_result() is expecting a tpAniSirGlobal so pass the
correct parameter.
Change-Id: I6b704f4e1074b15cfbe86a539ac2dee60789e9e0
CRs-Fixed: 2268183
Currently csr_is_mcc_channel() takes a tHalHandle context param.
However csr is internal to the UMAC, and hence it should be using the
"real" context pointer type tpAniSirGlobal instead of the opaque
reference tHalHandle, so update the API to expect tpAniSirGlobal.
Change-Id: I4feecd5dbc056929ee406e8794e2b284b0b40f21
CRs-Fixed: 2268182
On STA connection, mode change event is sent to
userspace after association is complete. This causes
delay in processing of M1 frame at supplicant due to
latency associated with nl80211_get_wiphy_index
function as part of processing mode change vendor event.
Fix is to send mode change event for STA after key
is added.
Change-Id: Id403bfdd26ed3a47449ba3f2967f4b4322ad5da6
CRs-Fixed: 2257117
Fix compilation error while enabling QCA_WIFI_3_0_ADRASTEA
and CONFIG_CNSS2 flag for Genoa.
Change-Id: Ic44da39377f722c19edcd291d1b35fac1fee9462
CRs-Fixed: 2267927
Currently csr_validate_any_default() takes a tHalHandle context param.
However this is a static function, and hence it should be using the
"real" context pointer type tpAniSirGlobal instead of the opaque
reference tHalHandle, so update the API to expect tpAniSirGlobal.
Change-Id: I6bbfe2329e776e1438dca06ad7642cb870796ff6
CRs-Fixed: 2268181
Currently csr_is_wapi_match() takes a tHalHandle context param.
However this is a static function, and hence it should be using the
"real" context pointer type tpAniSirGlobal instead of the opaque
reference tHalHandle, so update the API to expect tpAniSirGlobal.
Change-Id: I0befea1f804204bc5589d33cf2d5fe6fd5126bf1
CRs-Fixed: 2268180
Currently csr_get_wapi_information() takes a tHalHandle context param.
However this is a static function, and hence it should be using the
"real" context pointer type tpAniSirGlobal instead of the opaque
reference tHalHandle, so update the API to expect tpAniSirGlobal.
Change-Id: I54004093c729add183fc3e02033d78f829f47241
CRs-Fixed: 2268179
Currently csr_get_rsn_information() takes a tHalHandle context param.
However this is a static function, and hence it should be using the
"real" context pointer type tpAniSirGlobal instead of the opaque
reference tHalHandle. So update the API to expect tpAniSirGlobal.
Change-Id: I29ad553360eddcf2b990b83bb0d1418d744a85ec
CRs-Fixed: 2268178
Currently csr_is_rsn_match() takes a tHalHandle context param.
However this is a static function, and hence it should be using the
"real" context pointer type tpAniSirGlobal instead of the opaque
reference tHalHandle. So update the API to expect tpAniSirGlobal.
Change-Id: I33a73505039716a38ea94c19d12a0a3ce390b0b3
CRs-Fixed: 2268177
In both csr_create_roam_scan_offload_request() and
csr_neighbor_roam_indicate_disconnect() there is a call to
csr_neighbor_middle_of_roaming() where the MAC context is typecast to
tHalHandle as part of the function call. However these typecasts are
incorrect since csr_neighbor_middle_of_roaming() expects to get a MAC
context. Due to the manner in which tHalHandle is defined this does
not current cause a build issue, but an upcoming change will enforce
type checking so update these calls to remove the inappropriate
typecasts.
Change-Id: I7eeb3eb6b4502c1934a8cffdd1d7372f93ee8ccb
CRs-Fixed: 2268176
Currently csr_get_dot11_mode() takes a tHalHandle context param.
However this is a static function, and hence it should be using the
"real" context pointer type tpAniSirGlobal instead of the opaque
reference tHalHandle. In addition the only caller is already passing
the real context pointer type so update the API to expect
tpAniSirGlobal.
Change-Id: I4f57252f0c94949b3219b5c07143d2545c659871
CRs-Fixed: 2267444
lim_tx_complete() is currently defined to take a tHalHandle as the
first param. However the generic signature of a TX callback function
specifies that the first param should be a void *context. This
currently compiles because tHalHandle is defined to be a void *, but
this will soon be changed, so update lim_tx_complete() to explicitly
use a void *context.
Change-Id: I421e8acb25beed23d2f3803380a46db33b6f0964
CRs-Fixed: 2267443
The QoS callback is supposed to pass a mac_handle_t (aka tHalHandle)
to HDD, but in most cases what is actually passed is a tpAniSirGlobal.
Even though these ultimately reference the same structure, an upcoming
change will enforce type safety so update the bad callers to pass a
parameter of the correct type.
Change-Id: I5913c3cf577606f8c207b1e40897b8cbe681de48
CRs-Fixed: 2267442
Function sme_get_current_roam_state() takes a mac_handle_t (aka
tHalHandle) as the first parameter. However in some cases the caller
is actually passing a tpAniSirGlobal. Even though these ultimately
reference the same structure, an upcoming change will enforce type
safety so update the bad callers to pass a parameter of the correct
type.
Change-Id: I3e17de9656fd83598cfd35b63843dd3f7b25d072
CRs-Fixed: 2267441
Currently sme_process_ready_to_suspend() takes a tHalHandle context
param. However this is a static internal function, and hence it
should be using the "real" context pointer type tpAniSirGlobal instead
of the opaque reference tHalHandle, so update the API to expect
tpAniSirGlobal (which is what is already being passed by
sme_process_msg()).
Change-Id: Ic2f28613ce0f4df0a104aaa1ab23b311abe5e334
CRs-Fixed: 2267440
Currently sme_ibss_peer_info_response_handler() takes a tHalHandle
context param. However this is a static internal function, and hence
it should be using the "real" context pointer type tpAniSirGlobal
instead of the opaque reference tHalHandle, so update the API to
expect tpAniSirGlobal (which is what is already being passed by
sme_process_msg()).
Change-Id: I553b485f0e54f173d31e8931f3bda6bba8ede77d
CRs-Fixed: 2267439
Currently sme_tsm_ie_ind() takes a tHalHandle context param. However
this is a static internal function, and hence it should be using the
"real" context pointer type tpAniSirGlobal instead of the opaque
reference tHalHandle, so update the API to expect tpAniSirGlobal
(which is what is already being passed by sme_process_msg()).
Change-Id: Ica6add4b81ad7ffd664ee6e46f2e8b43a731771f
Crs-Fixed: 2267438
Currently sme_ft_send_update_key_ind() takes a tHalHandle context
param. However this is a static internal function, and hence it
should be using the "real" context pointer type tpAniSirGlobal instead
of the opaque reference tHalHandle, so update the API to expect
tpAniSirGlobal (which is what is already being passed by
sme_ft_update_key()).
Change-Id: I5309a6f9125684bc0d7766d5839f2296150b6834
CRs-Fixed: 2267437
Current driver keeps cmd_id as 0 for all non-scan commands which
makes serialization module's logic more complex in order to identify
between duplicate commands.
Add unique cmd_id and attach it to each legacy sme command to make
serialization module's logic easy to distinguish between duplicate
commands.
CRs-Fixed: 2267418
Change-Id: Id2ccb435137061c963120822326fe5b90f857eb7
In wlan_hdd_cfg80211_start_pending_acs() the result of calling
container_of() is NULL checked. The container of a work_struct is
always a valid pointer, so the NULL check is unnecessary. Remove this
resulting dead code.
Change-Id: Iac4d48037ee27bc5de4c5fbc7f91188d837c6d49
CRs-Fixed: 2267075
