Bladeren bron

qcacld-3.0: Properly export ol_tx_set_flow_control_parameters()

Currently the qcacld-3.0 driver does not build cleanly when compiled
with the gcc -Wmissing-prototypes switch. One set of warnings is due
to ol_tx_set_flow_control_parameters() not being exported properly.
Address the warnings by properly exporting this function.

Change-Id: Iec79c1684c74312fa121349c1d7f721666bf904a
CRs-Fixed: 1103127
Jeff Johnson 8 jaren geleden
bovenliggende
commit
ffa9afc941
3 gewijzigde bestanden met toevoegingen van 20 en 12 verwijderingen
  1. 18 0
      core/dp/ol/inc/ol_cfg.h
  2. 0 6
      core/dp/txrx/ol_cfg.c
  3. 2 6
      core/dp/txrx/ol_txrx.c

+ 18 - 0
core/dp/ol/inc/ol_cfg.h

@@ -96,6 +96,24 @@ struct txrx_pdev_cfg_t {
 	bool flow_steering_enabled;
 };
 
+/**
+ * ol_tx_set_flow_control_parameters() - set flow control parameters
+ * @cfg_ctx: cfg context
+ * @cfg_param: cfg parameters
+ *
+ * Return: none
+ */
+#ifdef QCA_LL_TX_FLOW_CONTROL_V2
+void ol_tx_set_flow_control_parameters(struct txrx_pdev_cfg_t *cfg_ctx,
+				       struct txrx_pdev_cfg_param_t *cfg_param);
+#else
+static inline
+void ol_tx_set_flow_control_parameters(struct txrx_pdev_cfg_t *cfg_ctx,
+				       struct txrx_pdev_cfg_param_t *cfg_param)
+{
+}
+#endif
+
 /**
  * @brief Specify whether the system is high-latency or low-latency.
  * @details

+ 0 - 6
core/dp/txrx/ol_cfg.c

@@ -47,12 +47,6 @@ void ol_tx_set_flow_control_parameters(struct txrx_pdev_cfg_t *cfg_ctx,
 	cfg_ctx->tx_flow_stop_queue_th =
 					cfg_param->tx_flow_stop_queue_th;
 }
-#else
-void ol_tx_set_flow_control_parameters(struct txrx_pdev_cfg_t *cfg_ctx,
-	struct txrx_pdev_cfg_param_t *cfg_param)
-{
-	return;
-}
 #endif
 
 #ifdef CONFIG_HL_SUPPORT

+ 2 - 6
core/dp/txrx/ol_txrx.c

@@ -114,10 +114,6 @@ extern void ol_set_cfg_packet_log_enabled(void *ppdev, uint8_t val);
 
 extern void *ol_pdev_cfg_attach(qdf_device_t osdev, void *cfg_param);
 
-extern void ol_tx_set_flow_control_parameters(
-		struct txrx_pdev_cfg_t *cfg_ctx,
-		struct txrx_pdev_cfg_param_t *cfg_param);
-
 extern qdf_nbuf_t ol_tx_send_ipa_data_frame(void *vdev,
 			qdf_nbuf_t skb);
 
@@ -5129,8 +5125,8 @@ void *ol_txrx_wrapper_find_peer_by_addr(void *pdev,
  *
  * Return: none
  */
-void ol_txrx_wrapper_set_flow_control_parameters(void *cfg_ctx,
-		void *cfg_param)
+static void
+ol_txrx_wrapper_set_flow_control_parameters(void *cfg_ctx, void *cfg_param)
 {
 	return ol_tx_set_flow_control_parameters(
 		(struct txrx_pdev_cfg_t *)cfg_ctx,