Răsfoiți Sursa

qcacld-3.0: Harmonize csr_validate_mcc_beacon_interval()

The parameter identifiers used in the implementation of
csr_validate_mcc_beacon_interval() differ from the ones used in the
prototype. Since this can be confusing for both humans and code
analysis tools, harmonize on the parameters used in the
implementation. In addition, relocate the documentation so that it is
the interface that is documented and not the implementation.

Change-Id: I817c836fe07a8add1e3588d9b5eeded027ee6f26
CRs-Fixed: 2375512
Jeff Johnson 6 ani în urmă
părinte
comite
fe774b2729
2 a modificat fișierele cu 22 adăugiri și 20 ștergeri
  1. 18 4
      core/sme/inc/csr_support.h
  2. 4 16
      core/sme/src/csr/csr_util.c

+ 18 - 4
core/sme/inc/csr_support.h

@@ -335,10 +335,24 @@ QDF_STATUS csr_reassoc(struct mac_context *mac, uint32_t sessionId,
 		tCsrRoamModifyProfileFields *pModProfileFields,
 		uint32_t *pRoamId, bool fForce);
 
-/* BeaconInterval validation for MCC support */
-QDF_STATUS csr_validate_mcc_beacon_interval(struct mac_context *mac, uint8_t channelId,
-		uint16_t *beaconInterval, uint32_t cursessionId,
-		enum QDF_OPMODE currBssPersona);
+/**
+ * csr_validate_mcc_beacon_interval() - to validate the mcc beacon interval
+ * @mac_ctx: pointer to mac context
+ * @chnl_id: channel number
+ * @bcn_interval: provided beacon interval
+ * @cur_session_id: current session id
+ * @cur_bss_persona: Current BSS persona
+ *
+ * This API will validate the mcc beacon interval
+ *
+ * Return: QDF_STATUS
+ */
+QDF_STATUS csr_validate_mcc_beacon_interval(struct mac_context *mac_ctx,
+					    uint8_t chnl_id,
+					    uint16_t *bcn_interval,
+					    uint32_t cur_session_id,
+					    enum QDF_OPMODE cur_bss_persona);
+
 bool csr_is_profile11r(struct mac_context *mac, struct csr_roam_profile *pProfile);
 bool csr_is_auth_type11r(struct mac_context *mac, eCsrAuthType AuthType,
 			 uint8_t mdiePresent);

+ 4 - 16
core/sme/src/csr/csr_util.c

@@ -2489,23 +2489,11 @@ static bool csr_validate_sta_bcn_intrvl(struct mac_context *mac_ctx,
 	return false;
 }
 
-/**
- * csr_validate_mcc_beacon_interval() - to validate the mcc beacon interval
- * @mac_ctx: pointer to mac context
- * @chnl_id: channel number
- * @bcn_interval: provided beacon interval
- * @cur_session_id: current session id
- * @cur_bss_persona: Current BSS persona
- *
- * This API will validate the mcc beacon interval
- *
- * Return: QDF_STATUS
- */
 QDF_STATUS csr_validate_mcc_beacon_interval(struct mac_context *mac_ctx,
-					uint8_t chnl_id,
-					uint16_t *bcn_interval,
-					uint32_t cur_session_id,
-					enum QDF_OPMODE cur_bss_persona)
+					    uint8_t chnl_id,
+					    uint16_t *bcn_interval,
+					    uint32_t cur_session_id,
+					    enum QDF_OPMODE cur_bss_persona)
 {
 	uint32_t session_id = 0;
 	QDF_STATUS status;