Browse Source

qcacmn: Update MLD mac address with ML dev ctx lock held

Currently MLD address is not being updated under lock. This may result
in unexpected behavior in racy scenarios.

To avoid this, update MLD address with ML dev ctx lock held.

Change-Id: I7c27edb0c02ebae0332f0498dfe1a1534d3d3379
CRs-Fixed: 3104028
Bapiraju Alla 3 năm trước cách đây
mục cha
commit
fdaf4235b8
1 tập tin đã thay đổi với 2 bổ sung0 xóa
  1. 2 0
      umac/mlo_mgr/src/wlan_mlo_mgr_main.c

+ 2 - 0
umac/mlo_mgr/src/wlan_mlo_mgr_main.c

@@ -464,7 +464,9 @@ QDF_STATUS wlan_mlo_mgr_update_mld_addr(struct qdf_mac_addr *old_mac,
 			QDF_MAC_ADDR_REF(old_mac->bytes));
 		return QDF_STATUS_E_INVAL;
 	}
+	mlo_dev_lock_acquire(ml_dev);
 	qdf_copy_macaddr(&ml_dev->mld_addr, new_mac);
+	mlo_dev_lock_release(ml_dev);
 
 	return QDF_STATUS_SUCCESS;
 }