samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacld-3.0: Don't send success status to user space

Browse Source 
Currently, If AP doesn't allow Prohibit to be set and user tries
to enable prohibit, host doesn't send command to FW to enable prohibit
but doesn't send failure status to user space.

Fix is to send failure status to userspace in case prohibit is not enabled.

Change-Id: Ic983b85d27e16314f63c02f88d3b1689d587d622
CRs-Fixed: 3344607
This commit is contained in:
Sheenam Monga
2022-11-28 12:31:51 +05:30
committed by Madan Koyyalamudi
parent 74652004c5
commit f6de97d19c
3 changed files with 27 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
components/spatial_reuse/dispatcher/inc/spatial_reuse_ucfg_api.h
View File

@@ -113,9 +113,10 @@ void ucfg_spatial_reuse_set_sr_enable(struct wlan_objmgr_vdev *vdev,
* @vdev: object manager vdev * @vdev: object manager vdev
* @enable_he_siga_val15_prohibit: enable/disable he_siga_val15_allowed * @enable_he_siga_val15_prohibit: enable/disable he_siga_val15_allowed
* *
* Return: void * Return: success/failure
*/ */
void ucfg_spatial_reuse_send_sr_prohibit(struct wlan_objmgr_vdev *vdev, QDF_STATUS
ucfg_spatial_reuse_send_sr_prohibit(struct wlan_objmgr_vdev *vdev,
bool enable_he_siga_val15_prohibit); bool enable_he_siga_val15_prohibit);
/** /**

13
components/spatial_reuse/dispatcher/src/spatial_reuse_ucfg_api.c
View File

@@ -90,10 +90,11 @@ void ucfg_spatial_reuse_set_sr_enable(struct wlan_objmgr_vdev *vdev,
wlan_vdev_mlme_set_he_spr_enabled(vdev, enable); wlan_vdev_mlme_set_he_spr_enabled(vdev, enable);
} }
void ucfg_spatial_reuse_send_sr_prohibit(struct wlan_objmgr_vdev *vdev, QDF_STATUS ucfg_spatial_reuse_send_sr_prohibit(
struct wlan_objmgr_vdev *vdev,
bool enable_he_siga_val15_prohibit) bool enable_he_siga_val15_prohibit)
{ {
QDF_STATUS status; QDF_STATUS status = QDF_STATUS_SUCCESS;
bool sr_enabled = wlan_vdev_mlme_get_he_spr_enabled(vdev); bool sr_enabled = wlan_vdev_mlme_get_he_spr_enabled(vdev);
bool sr_prohibited = wlan_vdev_mlme_is_sr_prohibit_en(vdev); bool sr_prohibited = wlan_vdev_mlme_is_sr_prohibit_en(vdev);
uint8_t sr_ctrl = wlan_vdev_mlme_get_sr_ctrl(vdev); uint8_t sr_ctrl = wlan_vdev_mlme_get_sr_ctrl(vdev);
@@ -111,7 +112,15 @@ void ucfg_spatial_reuse_send_sr_prohibit(struct wlan_objmgr_vdev *vdev,
wlan_vdev_mlme_set_sr_prohibit_en wlan_vdev_mlme_set_sr_prohibit_en
(vdev, (vdev,
enable_he_siga_val15_prohibit); enable_he_siga_val15_prohibit);
} else {
mlme_debug("Prohibit command can not be sent sr_enabled %d, sr_ctrl %d , sr_prohibited %d",
sr_enabled,
sr_ctrl,
sr_prohibited);
return QDF_STATUS_E_FAILURE;
} }
return status;
} }
QDF_STATUS QDF_STATUS

14
core/hdd/src/wlan_hdd_he.c
View File

@@ -823,11 +823,19 @@ static int __wlan_hdd_cfg80211_sr_operations(struct wiphy *wiphy,
hdd_err("invalid sr_he_siga_val15_enable param"); hdd_err("invalid sr_he_siga_val15_enable param");
return -EINVAL; return -EINVAL;
} }
ucfg_spatial_reuse_send_sr_prohibit(adapter->vdev, if (!QDF_IS_STATUS_SUCCESS(ucfg_spatial_reuse_send_sr_prohibit(
sr_he_siga_val15_allowed); adapter->vdev,
sr_he_siga_val15_allowed))) {
hdd_debug("Prohibit command can not be sent");
return -EINVAL;
}
break; break;
case QCA_WLAN_SR_OPERATION_PSR_AND_NON_SRG_OBSS_PD_ALLOW: case QCA_WLAN_SR_OPERATION_PSR_AND_NON_SRG_OBSS_PD_ALLOW:
ucfg_spatial_reuse_send_sr_prohibit(adapter->vdev, false); if (!QDF_IS_STATUS_SUCCESS(ucfg_spatial_reuse_send_sr_prohibit(
adapter->vdev, false))) {
hdd_debug("Prohibit command can not be sent");
return -EINVAL;
}
break; break;
case QCA_WLAN_SR_OPERATION_GET_PARAMS: case QCA_WLAN_SR_OPERATION_GET_PARAMS:
wlan_vdev_mlme_get_srg_pd_offset(adapter->vdev, wlan_vdev_mlme_get_srg_pd_offset(adapter->vdev,