qcacmn: Fix umac/cmn_services/serialization documentation

The kernel-doc script identified some documentation issues in the
umac/cmn_services/serialization folder, so fix most of them. However
one issue is due to kernel-doc being unable to parse the qdf_bitmap()
macro, so disable kernel-doc in that case.

Change-Id: I4b579891db315484b465322e9f9e5fe2564f8909
CRs-Fixed: 3390576

umac/cmn_services/serialization/inc/wlan_serialization_api.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2017-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -36,12 +36,13 @@
 
 /**
  * enum ser_queue_reason- reason for changes to serialization queue
- * @: SER_REQUEST: queue updated for serialization request
- * @: SER_REMOVE : queue updated for serialization remove request
- * @: SER_CANCEL : queue updated for serialization cancel request
- * @: SER_TIMEOUT : queue updated for command timeout
- * @: SER_ACTIVATION_FAILED : queue updated since command activation failed
- * @: SER_PENDING_TO_ACTIVE : queue updated for pending to active movement
+ * @SER_REQUEST: queue updated for serialization request
+ * @SER_REMOVE: queue updated for serialization remove request
+ * @SER_CANCEL: queue updated for serialization cancel request
+ * @SER_TIMEOUT: queue updated for command timeout
+ * @SER_ACTIVATION_FAILED: queue updated since command activation failed
+ * @SER_PENDING_TO_ACTIVE: queue updated for pending to active movement
+ * @SER_QUEUE_ACTION_MAX: max enumeration
  */
 enum ser_queue_reason {
 	SER_REQUEST,
@@ -63,9 +64,9 @@ enum ser_queue_reason {
 
 /**
  * enum wlan_serialization_cb_reason - reason for calling the callback
- * @WLAN_SERIALIZATION_REASON_ACTIVATE_CMD: activate the cmd by sending it to FW
- * @WLAN_SERIALIZATION_REASON_CANCEL_CMD: Cancel the cmd in the pending list
- * @WLAN_SERIALIZATION_REASON_RELEASE_MEM_CMD:cmd execution complete. Release
+ * @WLAN_SER_CB_ACTIVATE_CMD: activate the cmd by sending it to FW
+ * @WLAN_SER_CB_CANCEL_CMD: Cancel the cmd in the pending list
+ * @WLAN_SER_CB_RELEASE_MEM_CMD:cmd execution complete. Release
  *                                           the memory allocated while
  *                                           building the command
  * @WLAN_SER_CB_ACTIVE_CMD_TIMEOUT: active cmd has been timeout.
@@ -105,7 +106,8 @@ union wlan_serialization_rules_info {
 struct wlan_serialization_command;
 
 /**
- * wlan_serialization_cmd_callback() - Callback registered by the component
+ * typedef wlan_serialization_cmd_callback() - Callback registered by the
+ *                                             component
  * @wlan_cmd: Command passed by the component for serialization
  * @reason: Reason code for which the callback is being called
  *
@@ -121,9 +123,11 @@ typedef QDF_STATUS
 				   enum wlan_serialization_cb_reason reason);
 
 /**
- * wlan_serialization_comp_info_cb() - callback to fill the rules information
+ * typedef wlan_serialization_comp_info_cb() - callback to fill the rules
+ *                                             information
  * @vdev: VDEV object for which the command has been received
  * @comp_info: Information filled by the component
+ * @cmd: Command information
  *
  * This callback is registered dynamically by the component with the
  * serialization component. Serialization component invokes the callback
@@ -137,8 +141,10 @@ typedef void (*wlan_serialization_comp_info_cb)(struct wlan_objmgr_vdev *vdev,
 		struct wlan_serialization_command *cmd);
 
 /**
- * wlan_serialization_apply_rules_cb() - callback per command to apply rules
+ * typedef wlan_serialization_apply_rules_cb() - callback per command to apply
+ *                                               rules
  * @comp_info: information needed to apply the rules
+ * @comp_id: component id
  *
  * The rules are applied using this callback and decided whether to
  * allow or deny the command
@@ -151,7 +157,7 @@ typedef bool (*wlan_serialization_apply_rules_cb)(
 		uint8_t comp_id);
 
 /**
- * wlan_ser_umac_cmd_cb() - callback to validate umac_cmd
+ * typedef wlan_ser_umac_cmd_cb() - callback to validate umac_cmd
  * @umac_cmd: umac data associated with the serialization cmd
  *
  * This callback can be called at run time for a command in active queue to
@@ -163,7 +169,7 @@ typedef bool (*wlan_serialization_apply_rules_cb)(
 typedef QDF_STATUS (*wlan_ser_umac_cmd_cb)(void *umac_cmd);
 
 /**
- * enum wlan_umac_cmd_id - Command Type
+ * enum wlan_serialization_cmd_type - Command Type
  * @WLAN_SER_CMD_SCAN: Scan command
  * @WLAN_SER_CMD_NONSCAN: Non-scan command
  * @WLAN_SER_CMD_FORCE_DISASSOC_STA: Force diassoc for STA vap
@@ -193,6 +199,7 @@ typedef QDF_STATUS (*wlan_ser_umac_cmd_cb)(void *umac_cmd);
  * @WLAN_SER_CMD_PDEV_CSA_RESTART: Cmd to CSA restart all AP VDEVs of a PDEV
  * @WLAN_SER_CMD_VDEV_ROAM: Cmd to roam a STA VDEV
  * @WLAN_SER_CMD_SET_MLO_LINK: Cmd to force mlo link active/inactive
+ * @WLAN_SER_CMD_MAX: Max enumeration
  */
 enum wlan_serialization_cmd_type {
 	/* all scan command before non-scan */
@@ -242,6 +249,7 @@ enum wlan_serialization_cmd_type {
  * @WLAN_SER_CANCEL_VDEV_NON_SCAN_NB_CMD: Cancel all non-blocking,
  * non-scan commands of a given vdev
  * @WLAN_SER_CANCEL_NON_SCAN_CMD: Cancel the given non scan command
+ * @WLAN_SER_CANCEL_MAX: Max enumeration
  */
 enum wlan_serialization_cancel_type {
 	WLAN_SER_CANCEL_SINGLE_SCAN,
@@ -281,6 +289,7 @@ enum wlan_serialization_status {
  * @WLAN_SER_CMD_IN_PENDING_LIST: Command cancelled from pending list
  * @WLAN_SER_CMD_IN_ACTIVE_LIST: Command cancelled from active list
  * @WLAN_SER_CMDS_IN_ALL_LISTS: Command cancelled from all lists
+ * @WLAN_SER_CMD_MARKED_FOR_ACTIVATION:
  * @WLAN_SER_CMD_NOT_FOUND: Specified command to be cancelled
  *                                    not found in the lists
  */
@@ -294,9 +303,9 @@ enum wlan_serialization_cmd_status {
 
 /**
  * enum wlan_ser_cmd_attr - Serialization cmd attribute
- * @WLAN_SER_CMD_ATTR_NONE - No attribuate associated
- * @WLAN_SER_CMD_ATTR_BLOCK - Blocking attribute
- * @WLAN_SER_CMD_ATTR_NONBLOCK - Non-blocking attribute
+ * @WLAN_SER_CMD_ATTR_NONE: No attribuate associated
+ * @WLAN_SER_CMD_ATTR_BLOCK: Blocking attribute
+ * @WLAN_SER_CMD_ATTR_NONBLOCK: Non-blocking attribute
  */
 enum wlan_ser_cmd_attr {
 	WLAN_SER_CMD_ATTR_NONE,
@@ -306,7 +315,7 @@ enum wlan_ser_cmd_attr {
 
 /**
  * struct wlan_serialization_command - Command to be serialized
- * @wlan_serialization_cmd_type: Type of command
+ * @cmd_type: Type of command
  * @cmd_id: Command Identifier
  * @cmd_cb: Command callback
  * @source: component ID of the source of the command
@@ -445,7 +454,7 @@ wlan_serialization_deregister_comp_info_cb(
  *						callback
  * @psoc: PSOC object information
  * @cmd_type: Command Type
- * @cb: Callback
+ * @apply_rules_cb: Callback
  *
  * This is called from component during its initialization.It initializes
  * callback handler for given cmd_type in a 1-D array.
@@ -474,28 +483,30 @@ wlan_serialization_deregister_apply_rules_cb(
 		enum wlan_serialization_cmd_type cmd_type);
 
 /**
- * @wlan_serialization_init() - Serialization component initialization routine
+ * wlan_serialization_init() - Serialization component initialization routine
  *
  * Return - QDF Status
  */
 QDF_STATUS wlan_serialization_init(void);
 
 /**
- * @wlan_serialization_deinit() - Serialization component de-init routine
+ * wlan_serialization_deinit() - Serialization component de-init routine
  *
  * Return - QDF Status
  */
 QDF_STATUS wlan_serialization_deinit(void);
 
 /**
- * @wlan_serialization_psoc_enable() - Serialization component enable routine
+ * wlan_serialization_psoc_enable() - Serialization component enable routine
+ * @psoc: pointer to psoc
  *
  * Return - QDF Status
  */
 QDF_STATUS wlan_serialization_psoc_enable(struct wlan_objmgr_psoc *psoc);
 
 /**
- * @wlan_serialization_psoc_disable() - Serialization component disable routine
+ * wlan_serialization_psoc_disable() - Serialization component disable routine
+ * @psoc: pointer to psoc
  *
  * Return - QDF Status
  */
@@ -522,6 +533,7 @@ wlan_serialization_pdev_scan_status(struct wlan_objmgr_pdev *pdev);
 /**
  * wlan_serialization_is_cmd_present_in_pending_queue() - Return if the command
  *				is already present in pending queue
+ * @psoc: pointer to psoc
  * @cmd: pointer to serialization command to check
  *
  * This API will check if command is present in pending queue. If present
@@ -547,6 +559,7 @@ bool wlan_ser_is_non_scan_cmd_type_in_vdev_queue(struct wlan_objmgr_vdev *vdev,
 /**
  * wlan_serialization_is_cmd_present_in_active_queue() - Return if the command
  *			is already present in active queue
+ * @psoc: pointer to psoc
  * @cmd: pointer to serialization command to check
  *
  * This API will check if command is present in active queue. If present
@@ -577,6 +590,7 @@ wlan_serialization_get_scan_cmd_using_scan_id(
 		struct wlan_objmgr_psoc *psoc,
 		uint8_t vdev_id, uint16_t scan_id,
 		uint8_t is_scan_cmd_from_active_queue);
+
 /**
  * wlan_serialization_get_active_cmd() - Return active umac command which
  *  matches vdev and cmd type

umac/cmn_services/serialization/src/wlan_serialization_internal_i.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2017-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -91,11 +92,9 @@ wlan_serialization_activate_cmd(
  * wlan_serialization_move_pending_to_active() - Move a cmd from pending
  *			queue to active queue
  * @cmd_type: Type of command to be moved i.e scan or non scan
- * @pcmd_list: Pointer to command list containing the command
  * @ser_pdev_obj: Serialization private pdev object
  * @vdev: Pointer to vdev object manager
  * @blocking_cmd_removed: If a blocking cmd is removed from active queue
- * @blocking_cmd_waiting: If a blocking cmd is waiting in pending queue
  *
  * Return: Status of command request
  */

umac/cmn_services/serialization/src/wlan_serialization_main.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2017-2020 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -138,7 +138,7 @@ error:
 
 /**
  * wlan_serialization_destroy_cmd_pool() - Destroy the global cmd pool
- * @ser_pdev_obj: Serialization private pdev object
+ * @pdev_queue: Serialization pdev queue
  *
  * Return: None
  */
@@ -162,8 +162,8 @@ static void wlan_serialization_destroy_cmd_pool(
 
 /**
  * wlan_serialization_create_cmd_pool() - Create the global cmd pool
- * @pdev: PDEV Object
- * @ser_pdev_obj: Serialization private pdev object
+ * @pdev_queue: Serialization pdev queue
+ * @cmd_pool_size: Size of the command pool
  *
  * Global command pool of memory is created here.
  * It is safe to allocate memory individually for each command rather than

umac/cmn_services/serialization/src/wlan_serialization_non_scan.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2017-2020 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -56,15 +56,6 @@ error:
 	return status;
 }
 
-/**
- * wlan_serialization_is_active_nonscan_cmd_allowed() - find if cmd allowed
- * @pdev: pointer to pdev object
- *
- * This API will be called to find out if non scan cmd is allowed.
- *
- * Return: true or false
- */
-
 bool
 wlan_serialization_is_active_non_scan_cmd_allowed(
 		struct wlan_serialization_command *cmd)

umac/cmn_services/serialization/src/wlan_serialization_non_scan_i.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2017-2019 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -49,7 +50,7 @@ wlan_serialization_is_non_scan_pending_queue_empty(
 		struct wlan_serialization_command *cmd);
 
 /**
- * wlan_serialization_is_active_nonscan_cmd_allowed() - find if cmd allowed
+ * wlan_serialization_is_active_non_scan_cmd_allowed() - find if cmd allowed
  *			to be enqueued in active queue
  * @cmd: Serialization command information
  *
@@ -78,9 +79,9 @@ wlan_ser_add_non_scan_cmd(
 /**
  * wlan_ser_move_non_scan_pending_to_active() - Move a non-scan cmd from pending
  *			queue to active queue
- * @pcmd_list: Pointer to command list containing the command
  * @ser_pdev_obj: Serialization private pdev object
  * @vdev: Pointer to object manager vdev
+ * @blocking_cmd_removed: If a blocking cmd is removed from active queue
  *
  * Return: Status of the cmd's serialization request
  */

umac/cmn_services/serialization/src/wlan_serialization_scan_i.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2017-2018 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -53,7 +53,6 @@ wlan_serialization_active_scan_cmd_count_handler(struct wlan_objmgr_psoc *psoc,
 
 /**
  * wlan_serialization_is_scan_pending_queue_empty()
- *
  * @cmd: Serialization command information
  *
  * This API will be find out if scan cmd pending queue is empty.
@@ -66,7 +65,7 @@ wlan_serialization_is_scan_pending_queue_empty(
 
 /**
  * wlan_serialization_is_active_scan_cmd_allowed() - find if scan cmd allowed
- * @pdev: pointer to pdev object
+ * @cmd: Serialization command information
  *
  * This API will be called to find out if active scan cmd is allowed. It has
  * to iterate through all pdev to find out total number of active scan cmds.
@@ -82,6 +81,7 @@ wlan_serialization_is_active_scan_cmd_allowed(
 /**
  * wlan_ser_match_cmd_scan_id() - Compare the scan id and the vdev to the given
  *			command
+ * @nnode: Command list node
  * @cmd: Serialization command information
  * @scan_id: Scan id to be compared
  * @vdev: Pointer to object manager vdev that needs to compared

umac/cmn_services/serialization/src/wlan_serialization_utf_i.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -143,8 +144,8 @@ enum wlan_ser_utf_tc_id {
 
 /**
  * struct wlan_ser_utf_data - Test data
- * @id - Test variable
- * @str - String tag associated with the command
+ * @id: Test variable
+ * @str: String tag associated with the command
  */
 struct wlan_ser_utf_data {
 	uint8_t id;

umac/cmn_services/serialization/src/wlan_serialization_utils.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2017-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -135,14 +135,6 @@ error:
 	return qdf_status;
 }
 
-/**
- * wlan_serialization_stop_timer() - to stop particular timer
- * @ser_timer: pointer to serialization timer
- *
- * This API stops the particular timer
- *
- * Return: QDF_STATUS
- */
 QDF_STATUS
 wlan_serialization_stop_timer(struct wlan_serialization_timer *ser_timer)
 {
@@ -451,19 +443,6 @@ wlan_serialization_is_cmd_present_in_given_queue(
 	return found;
 }
 
-/**
- * wlan_serialization_remove_cmd_from_queue() - to remove command from
- *							given queue
- * @queue: queue from which command needs to be removed
- * @cmd: command to match in the queue
- * @ser_pdev_obj: pointer to private pdev serialization object
- *
- * This API takes the queue, it matches the provided command from this queue
- * and removes it. Before removing the command, it will notify the caller
- * that if it needs to remove any memory allocated by caller.
- *
- * Return: none
- */
 QDF_STATUS
 wlan_serialization_remove_cmd_from_queue(
 		qdf_list_t *queue,

umac/cmn_services/serialization/src/wlan_serialization_utils_i.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2017-2020 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -91,7 +91,7 @@ struct wlan_serialization_command_list {
 	unsigned long cmd_in_use;
 };
 
-/**
+/*
  * struct wlan_serialization_pdev_queue - queue data related to pdev
  * @active_list: list to hold the commands currently being executed
  * @pending_list: list to hold the commands currently pending
@@ -100,6 +100,10 @@ struct wlan_serialization_command_list {
  * @blocking_cmd_active: Indicate if a blocking cmd is in active execution
  * @blocking_cmd_waiting: Indicate if a blocking cmd is in pending queue
  * @pdev_queue_lock: pdev lock to protect concurrent operations on the queues
+ * @history: serialization history
+ *
+ * NB: not using kernel-doc format since the kernel-doc script doesn't
+ *     handle the qdf_bitmap() macro
  */
 struct wlan_serialization_pdev_queue {
 	qdf_list_t active_list;
@@ -117,7 +121,7 @@ struct wlan_serialization_pdev_queue {
 /**
  * struct wlan_serialization_vdev_queue - queue data related to vdev
  * @active_list: list to hold the commands currently being executed
- * @pending_list list: to hold the commands currently pending
+ * @pending_list: list: to hold the commands currently pending
  * @queue_disable: is the queue disabled
  */
 struct wlan_serialization_vdev_queue {
@@ -127,9 +131,10 @@ struct wlan_serialization_vdev_queue {
 };
 
 /**
- * enum wlan_serialization_pdev_queue_type - Types of available pdev queues
- * @QUEUE_COMP_SCAN: Scan queue
- * @QUEUE_COMP_NON_SCAN: Non Scan queue
+ * enum serialization_pdev_queue_type - Types of available pdev queues
+ * @SER_PDEV_QUEUE_COMP_SCAN: Scan queue
+ * @SER_PDEV_QUEUE_COMP_NON_SCAN: Non Scan queue
+ * @SER_PDEV_QUEUE_COMP_MAX: Max enumeration
  */
 enum serialization_pdev_queue_type {
 	SER_PDEV_QUEUE_COMP_SCAN,
@@ -138,8 +143,9 @@ enum serialization_pdev_queue_type {
 };
 
 /**
- * enum wlan_serialization_vdev_queue_type - Types of available vdev queues
- * @QUEUE_COMP_NON_SCAN: Non Scan queue
+ * enum serialization_vdev_queue_type - Types of available vdev queues
+ * @SER_VDEV_QUEUE_COMP_NON_SCAN: Non Scan queue
+ * @SER_VDEV_QUEUE_COMP_MAX: Max enumeration
  */
 enum serialization_vdev_queue_type {
 	SER_VDEV_QUEUE_COMP_NON_SCAN,
@@ -152,6 +158,7 @@ enum serialization_vdev_queue_type {
  * @WLAN_SER_MATCH_PDEV: Compare pdev
  * @WLAN_SER_MATCH_CMD_TYPE_VDEV: Compare command type and vdev
  * @WLAN_SER_MATCH_CMD_ID_VDEV: Compare command id and vdev
+ * @WLAN_SER_MATCH_MAX: Max enumeration
  */
 enum wlan_serialization_match_type {
 	WLAN_SER_MATCH_VDEV,
@@ -170,7 +177,7 @@ struct wlan_ser_pdev_obj {
 };
 
 /**
- * struct wlan_ser_vdev_priv_obj - Serialization private object of vdev
+ * struct wlan_ser_vdev_obj - Serialization private object of vdev
  * @vdev_q: Array of vdev queues
  */
 struct wlan_ser_vdev_obj {
@@ -179,10 +186,11 @@ struct wlan_ser_vdev_obj {
 
 /**
  * struct wlan_ser_psoc_obj - psoc obj data for serialization
- * @comp_info_cb - module level callback
- * @apply_rules_cb - pointer to apply rules on the cmd
- * @timers - Timers associated with the active commands
- * @max_axtive_cmds - Maximum active commands allowed
+ * @comp_info_cb: module level callback
+ * @apply_rules_cb: pointer to apply rules on the cmd
+ * @timers: Timers associated with the active commands
+ * @max_active_cmds: Maximum active commands allowed
+ * @timer_lock: lock for @timers
  *
  * Serialization component takes a command as input and checks whether to
  * allow/deny the command. It will use the module level callback registered
@@ -193,8 +201,7 @@ struct wlan_ser_vdev_obj {
  * pending list and each active command is associated with a timer.
  */
 struct wlan_ser_psoc_obj {
-	wlan_serialization_comp_info_cb comp_info_cb[
-		WLAN_SER_CMD_MAX][WLAN_UMAC_COMP_ID_MAX];
+	wlan_serialization_comp_info_cb comp_info_cb[WLAN_SER_CMD_MAX][WLAN_UMAC_COMP_ID_MAX];
 	wlan_serialization_apply_rules_cb apply_rules_cb[WLAN_SER_CMD_MAX];
 	struct wlan_serialization_timer *timers;
 	uint8_t max_active_cmds;
@@ -225,9 +232,8 @@ wlan_serialization_remove_cmd_from_queue(
 		enum wlan_serialization_node node_type);
 
 /**
- * wlan_serialization_add_cmd_from_queue() - Add a cmd to
- *							given queue
- * @queue: queue from which command needs to be removed
+ * wlan_serialization_add_cmd_to_queue() - Add a cmd to given queue
+ * @queue: queue to which command needs to be added
  * @cmd_list: Pointer to command list containing the command
  * @ser_pdev_obj: pointer to private pdev serialization object
  * @is_cmd_for_active_queue: Add cmd to active or pending queue
@@ -299,6 +305,7 @@ QDF_STATUS wlan_serialization_get_cmd_from_queue(
  */
 QDF_STATUS
 wlan_serialization_stop_timer(struct wlan_serialization_timer *ser_timer);
+
 /**
  * wlan_serialization_cleanup_vdev_timers() - clean-up all timers for a vdev
  *
@@ -388,7 +395,7 @@ struct wlan_ser_psoc_obj *wlan_serialization_get_psoc_obj(
 
 /**
  * wlan_serialization_get_pdev_obj() - Return the component private obj
- * @psoc: Pointer to the PDEV object
+ * @pdev: Pointer to the PDEV object
  *
  * Return: Serialization component's PDEV level private data object
  */
@@ -495,7 +502,7 @@ uint32_t wlan_serialization_list_size(qdf_list_t *queue);
  */
 bool wlan_serialization_match_cmd_type(
 			qdf_list_node_t *nnode,
-			enum wlan_serialization_cmd_type,
+			enum wlan_serialization_cmd_type cmd_type,
 			enum wlan_serialization_node node_type);
 
 /**
@@ -559,6 +566,8 @@ bool wlan_serialization_match_cmd_blocking(
 
 /**
  * wlan_serialization_find_cmd() - Find the cmd matching the given criteria
+ * @queue: Queue to search
+ * @match_type: Match criteria
  * @cmd: Serialization command information
  * @cmd_type: Command type to be matched
  * @pdev: pdev object that needs to be matched