disp: msm: sde: ctl hw flush ops clean up

Using individual flush functions for each active hw blk
is not scable-able for future use. Clean up the ops to merge
all flush functions into one and manage HW block id
with same API.

Change-Id: I62afbc51fa7d345b3a1f5721e5e09661a4215f7a
Signed-off-by: Nilaan Gunabalachandran <ngunabal@codeaurora.org>

msm/sde/sde_encoder.c

@@ -2731,9 +2731,10 @@ void sde_encoder_helper_phys_disable(struct sde_encoder_phys *phys_enc,
 			wb_enc->hw_wb->ops.bind_pingpong_blk(wb_enc->hw_wb,
 					false, phys_enc->hw_pp->idx);
 
-			if (phys_enc->hw_ctl->ops.update_bitmask_wb)
+			if (phys_enc->hw_ctl->ops.update_bitmask)
-				phys_enc->hw_ctl->ops.update_bitmask_wb(
+				phys_enc->hw_ctl->ops.update_bitmask(
 						phys_enc->hw_ctl,
+						SDE_HW_FLUSH_WB,
 						wb_enc->hw_wb->idx, true);
 		}
 	} else {
@@ -2742,9 +2743,10 @@ void sde_encoder_helper_phys_disable(struct sde_encoder_phys *phys_enc,
 					phys_enc->hw_intf, false,
 					phys_enc->hw_pp->idx);
 
-			if (phys_enc->hw_ctl->ops.update_bitmask_intf)
+			if (phys_enc->hw_ctl->ops.update_bitmask)
-				phys_enc->hw_ctl->ops.update_bitmask_intf(
+				phys_enc->hw_ctl->ops.update_bitmask(
 						phys_enc->hw_ctl,
+						SDE_HW_FLUSH_INTF,
 						phys_enc->hw_intf->idx, true);
 		}
 	}
@@ -2752,10 +2754,10 @@ void sde_encoder_helper_phys_disable(struct sde_encoder_phys *phys_enc,
 	if (phys_enc->hw_pp && phys_enc->hw_pp->ops.reset_3d_mode) {
 		phys_enc->hw_pp->ops.reset_3d_mode(phys_enc->hw_pp);
 
-		if (phys_enc->hw_ctl->ops.update_bitmask_merge3d &&
+		if (phys_enc->hw_ctl->ops.update_bitmask &&
 				phys_enc->hw_pp->merge_3d)
-			phys_enc->hw_ctl->ops.update_bitmask_merge3d(
+			phys_enc->hw_ctl->ops.update_bitmask(
-					phys_enc->hw_ctl,
+					phys_enc->hw_ctl, SDE_HW_FLUSH_MERGE_3D,
 					phys_enc->hw_pp->merge_3d->idx, true);
 	}
 
@@ -2764,9 +2766,9 @@ void sde_encoder_helper_phys_disable(struct sde_encoder_phys *phys_enc,
 		phys_enc->hw_cdm->ops.bind_pingpong_blk(phys_enc->hw_cdm,
 				false, phys_enc->hw_pp->idx);
 
-		if (phys_enc->hw_ctl->ops.update_bitmask_cdm)
+		if (phys_enc->hw_ctl->ops.update_bitmask)
-			phys_enc->hw_ctl->ops.update_bitmask_cdm(
+			phys_enc->hw_ctl->ops.update_bitmask(
-					phys_enc->hw_ctl,
+					phys_enc->hw_ctl, SDE_HW_FLUSH_CDM,
 					phys_enc->hw_cdm->idx, true);
 	}
 
@@ -3112,18 +3114,18 @@ static inline void _sde_encoder_trigger_flush(struct drm_encoder *drm_enc,
 	pend_ret_fence_cnt = atomic_read(&phys->pending_retire_fence_cnt);
 
 	if (phys->hw_intf && phys->hw_intf->cap->type == INTF_DP &&
-			ctl->ops.update_bitmask_periph) {
+			ctl->ops.update_bitmask) {
 		/* perform peripheral flush on every frame update for dp dsc */
 		if (phys->comp_type == MSM_DISPLAY_COMPRESSION_DSC &&
 				phys->comp_ratio && c_conn->ops.update_pps) {
 			c_conn->ops.update_pps(phys->connector, NULL,
 					c_conn->display);
-			ctl->ops.update_bitmask_periph(ctl,
+			ctl->ops.update_bitmask(ctl, SDE_HW_FLUSH_PERIPH,
 					phys->hw_intf->idx, 1);
 		}
 
 		if (sde_enc->dynamic_hdr_updated)
-			ctl->ops.update_bitmask_periph(ctl,
+			ctl->ops.update_bitmask(ctl, SDE_HW_FLUSH_PERIPH,
 					phys->hw_intf->idx, 1);
 	}
 
@@ -3816,9 +3818,10 @@ static int _helper_flush_qsync(struct sde_encoder_phys *phys_enc)
 			if (!hw_intf)
 				continue;
 
-			if (phys_enc->hw_ctl->ops.update_bitmask_intf)
+			if (phys_enc->hw_ctl->ops.update_bitmask)
-				phys_enc->hw_ctl->ops.update_bitmask_intf(
+				phys_enc->hw_ctl->ops.update_bitmask(
 						phys_enc->hw_ctl,
+						SDE_HW_FLUSH_INTF,
 						hw_intf->idx, 1);
 
 			intf_valid = true;

msm/sde/sde_encoder_dce.c

@@ -465,8 +465,9 @@ static int _dce_dsc_setup(struct sde_encoder_virt *sde_enc,
 					&cfg,
 					active);
 
-		if (hw_ctl->ops.update_bitmask_dsc)
+		if (hw_ctl->ops.update_bitmask)
-			hw_ctl->ops.update_bitmask_dsc(hw_ctl,
+			hw_ctl->ops.update_bitmask(hw_ctl,
+					SDE_HW_FLUSH_DSC,
 					hw_dsc[i]->idx, active);
 
 		SDE_DEBUG_DCE(sde_enc,
@@ -486,9 +487,9 @@ static int _dce_dsc_setup(struct sde_encoder_virt *sde_enc,
 						&cfg,
 						!disable_merge_3d);
 
-			if (hw_ctl->ops.update_bitmask_merge3d)
+			if (hw_ctl->ops.update_bitmask)
-				hw_ctl->ops.update_bitmask_merge3d(
+				hw_ctl->ops.update_bitmask(
-						hw_ctl,
+						hw_ctl, SDE_HW_FLUSH_MERGE_3D,
 						hw_pp[i]->merge_3d->idx, true);
 
 			SDE_DEBUG("mode_3d %s, on CTL_%d PP-%d merge3d:%d\n",
@@ -635,8 +636,9 @@ static int _dce_vdc_setup(struct sde_encoder_virt *sde_enc,
 					&cfg,
 					active);
 
-		if (hw_ctl->ops.update_bitmask_vdc)
+		if (hw_ctl->ops.update_bitmask)
-			hw_ctl->ops.update_bitmask_vdc(hw_ctl,
+			hw_ctl->ops.update_bitmask(hw_ctl,
+					SDE_HW_FLUSH_VDC,
 					hw_vdc[i]->idx, active);
 
 		SDE_DEBUG_DCE(sde_enc,
@@ -656,9 +658,9 @@ static int _dce_vdc_setup(struct sde_encoder_virt *sde_enc,
 						&cfg,
 						!disable_merge_3d);
 
-			if (hw_ctl->ops.update_bitmask_merge3d)
+			if (hw_ctl->ops.update_bitmask)
-				hw_ctl->ops.update_bitmask_merge3d(
+				hw_ctl->ops.update_bitmask(
-						hw_ctl,
+						hw_ctl, SDE_HW_FLUSH_MERGE_3D,
 						hw_pp[i]->merge_3d->idx, true);
 
 			SDE_DEBUG("mode_3d %s, on CTL_%d PP-%d merge3d:%d\n",
@@ -815,8 +817,9 @@ static void _dce_helper_flush_dsc(struct sde_encoder_virt *sde_enc)
 
 	for (i = 0; i < MAX_CHANNELS_PER_ENC; i++) {
 		dsc_idx = sde_enc->dirty_dsc_ids[i];
-		if (dsc_idx && hw_ctl && hw_ctl->ops.update_bitmask_dsc)
+		if (dsc_idx && hw_ctl && hw_ctl->ops.update_bitmask)
-			hw_ctl->ops.update_bitmask_dsc(hw_ctl, dsc_idx, 1);
+			hw_ctl->ops.update_bitmask(hw_ctl, SDE_HW_FLUSH_DSC,
+					dsc_idx, 1);
 
 		sde_enc->dirty_dsc_ids[i] = DSC_NONE;
 	}
@@ -833,8 +836,9 @@ void _dce_helper_flush_vdc(struct sde_encoder_virt *sde_enc)
 
 	for (i = 0; i < MAX_CHANNELS_PER_ENC; i++) {
 		vdc_idx = sde_enc->dirty_vdc_ids[i];
-		if (vdc_idx && hw_ctl && hw_ctl->ops.update_bitmask_vdc)
+		if (vdc_idx && hw_ctl && hw_ctl->ops.update_bitmask)
-			hw_ctl->ops.update_bitmask_vdc(hw_ctl, vdc_idx, 1);
+			hw_ctl->ops.update_bitmask(hw_ctl, SDE_HW_FLUSH_VDC,
+					vdc_idx, 1);
 
 		sde_enc->dirty_vdc_ids[i] = VDC_NONE;
 	}

msm/sde/sde_encoder_phys_cmd.c

@@ -126,17 +126,15 @@ static void _sde_encoder_phys_cmd_update_flush_mask(
 	if (!ctl)
 		return;
 
-	if (!ctl->ops.update_bitmask_intf ||
+	if (!ctl->ops.update_bitmask) {
-		(test_bit(SDE_CTL_ACTIVE_CFG, &ctl->caps->features) &&
-		!ctl->ops.update_bitmask_merge3d)) {
 		SDE_ERROR("invalid hw_ctl ops %d\n", ctl->idx);
 		return;
 	}
 
-	ctl->ops.update_bitmask_intf(ctl, phys_enc->intf_idx, 1);
+	ctl->ops.update_bitmask(ctl, SDE_HW_FLUSH_INTF, phys_enc->intf_idx, 1);
 
-	if (ctl->ops.update_bitmask_merge3d && phys_enc->hw_pp->merge_3d)
+	if (phys_enc->hw_pp->merge_3d)
-		ctl->ops.update_bitmask_merge3d(ctl,
+		ctl->ops.update_bitmask(ctl, SDE_HW_FLUSH_MERGE_3D,
 			phys_enc->hw_pp->merge_3d->idx, 1);
 
 	SDE_DEBUG_CMDENC(cmd_enc, "update pending flush ctl %d intf_idx %x\n",

msm/sde/sde_encoder_phys_vid.c

@@ -760,9 +760,7 @@ static void sde_encoder_phys_vid_enable(struct sde_encoder_phys *phys_enc)
 				!phys_enc->hw_intf, !phys_enc->hw_ctl);
 		return;
 	}
-	if (!ctl->ops.update_bitmask_intf ||
+	if (!ctl->ops.update_bitmask) {
-		(test_bit(SDE_CTL_ACTIVE_CFG, &ctl->caps->features) &&
-		!ctl->ops.update_bitmask_merge3d)) {
 		SDE_ERROR("invalid hw_ctl ops %d\n", ctl->idx);
 		return;
 	}
@@ -800,16 +798,16 @@ static void sde_encoder_phys_vid_enable(struct sde_encoder_phys *phys_enc)
 		goto skip_flush;
 	}
 
-	ctl->ops.update_bitmask_intf(ctl, intf->idx, 1);
+	ctl->ops.update_bitmask(ctl, SDE_HW_FLUSH_INTF, intf->idx, 1);
 
-	if (ctl->ops.update_bitmask_merge3d && phys_enc->hw_pp->merge_3d)
+	if (phys_enc->hw_pp->merge_3d)
-		ctl->ops.update_bitmask_merge3d(ctl,
+		ctl->ops.update_bitmask(ctl, SDE_HW_FLUSH_MERGE_3D,
 			phys_enc->hw_pp->merge_3d->idx, 1);
 
 	if (phys_enc->hw_intf->cap->type == INTF_DP &&
 		phys_enc->comp_type == MSM_DISPLAY_COMPRESSION_DSC &&
-		phys_enc->comp_ratio && ctl->ops.update_bitmask_periph)
+		phys_enc->comp_ratio)
-		ctl->ops.update_bitmask_periph(ctl, intf->idx, 1);
+		ctl->ops.update_bitmask(ctl, SDE_HW_FLUSH_PERIPH, intf->idx, 1);
 
 skip_flush:
 	SDE_DEBUG_VIDENC(vid_enc, "update pending flush ctl %d intf %d\n",

msm/sde/sde_encoder_phys_wb.c

@@ -866,11 +866,13 @@ static void _sde_encoder_phys_wb_update_cwb_flush(
 		return;
 	}
 
-	if (hw_ctl->ops.update_bitmask_wb)
+	if (hw_ctl->ops.update_bitmask)
-		hw_ctl->ops.update_bitmask_wb(hw_ctl, hw_wb->idx, 1);
+		hw_ctl->ops.update_bitmask(hw_ctl, SDE_HW_FLUSH_WB,
+				hw_wb->idx, 1);
 
-	if (hw_ctl->ops.update_bitmask_cdm && hw_cdm)
+	if (hw_ctl->ops.update_bitmask && hw_cdm)
-		hw_ctl->ops.update_bitmask_cdm(hw_ctl, hw_cdm->idx, 1);
+		hw_ctl->ops.update_bitmask(hw_ctl, SDE_HW_FLUSH_CDM,
+				hw_cdm->idx, 1);
 
 	if (test_bit(SDE_WB_CWB_CTRL, &hw_wb->caps->features)) {
 		for (i = 0; i < crtc->num_mixers; i++) {
@@ -881,14 +883,15 @@ static void _sde_encoder_phys_wb_update_cwb_flush(
 				hw_wb->ops.program_cwb_ctrl(hw_wb, cwb_idx,
 						src_pp_idx, dspp_out, enable);
 
-			if (hw_ctl->ops.update_bitmask_cwb)
+			if (hw_ctl->ops.update_bitmask)
-				hw_ctl->ops.update_bitmask_cwb(hw_ctl,
+				hw_ctl->ops.update_bitmask(hw_ctl,
-						cwb_idx, 1);
+						SDE_HW_FLUSH_CWB, cwb_idx, 1);
 		}
 
-		if (need_merge && hw_ctl->ops.update_bitmask_merge3d
+		if (need_merge && hw_ctl->ops.update_bitmask
 				&& hw_pp && hw_pp->merge_3d)
-			hw_ctl->ops.update_bitmask_merge3d(hw_ctl,
+			hw_ctl->ops.update_bitmask(hw_ctl,
+					SDE_HW_FLUSH_MERGE_3D,
 					hw_pp->merge_3d->idx, 1);
 	} else {
 		phys_enc->hw_mdptop->ops.set_cwb_ppb_cntl(phys_enc->hw_mdptop,
@@ -930,14 +933,16 @@ static void _sde_encoder_phys_wb_update_flush(struct sde_encoder_phys *phys_enc)
 		return;
 	}
 
-	if (hw_ctl->ops.update_bitmask_wb)
+	if (hw_ctl->ops.update_bitmask)
-		hw_ctl->ops.update_bitmask_wb(hw_ctl, hw_wb->idx, 1);
+		hw_ctl->ops.update_bitmask(hw_ctl, SDE_HW_FLUSH_WB,
+				hw_wb->idx, 1);
 
-	if (hw_ctl->ops.update_bitmask_cdm && hw_cdm)
+	if (hw_ctl->ops.update_bitmask && hw_cdm)
-		hw_ctl->ops.update_bitmask_cdm(hw_ctl, hw_cdm->idx, 1);
+		hw_ctl->ops.update_bitmask(hw_ctl, SDE_HW_FLUSH_CDM,
+				hw_cdm->idx, 1);
 
-	if (hw_ctl->ops.update_bitmask_merge3d && hw_pp && hw_pp->merge_3d)
+	if (hw_ctl->ops.update_bitmask && hw_pp && hw_pp->merge_3d)
-		hw_ctl->ops.update_bitmask_merge3d(hw_ctl,
+		hw_ctl->ops.update_bitmask(hw_ctl, SDE_HW_FLUSH_MERGE_3D,
 				hw_pp->merge_3d->idx, 1);
 
 	if (hw_ctl->ops.get_pending_flush)

msm/sde/sde_hw_ctl.c

@@ -229,6 +229,43 @@ sspp_reg_cfg_tbl[SSPP_MAX][CTL_SSPP_MAX_RECTS] = {
 #define PERIPH_IDX     30
 #define INTF_IDX       31
 
+/* struct ctl_hw_flush_cfg: Defines the active ctl hw flush config,
+ *     See enum ctl_hw_flush_type for types
+ * @blk_max: Maximum hw idx
+ * @flush_reg: Register with corresponding active ctl hw
+ * @flush_idx: Corresponding index in ctl flush
+ * @flush_mask_idx: Index of hw flush mask to use
+ * @flush_tbl: Pointer to flush table
+ */
+struct ctl_hw_flush_cfg {
+	u32 blk_max;
+	u32 flush_reg;
+	u32 flush_idx;
+	u32 flush_mask_idx;
+	const u32 *flush_tbl;
+};
+
+static const struct ctl_hw_flush_cfg
+		ctl_hw_flush_cfg_tbl_v1[SDE_HW_FLUSH_MAX] = {
+	{WB_MAX, CTL_WB_FLUSH, WB_IDX, SDE_HW_FLUSH_WB,
+			wb_flush_tbl}, /* SDE_HW_FLUSH_WB */
+	{DSC_MAX, CTL_DSC_FLUSH, DSC_IDX, SDE_HW_FLUSH_DSC,
+			dsc_flush_tbl}, /* SDE_HW_FLUSH_DSC */
+	/* VDC is flushed to dsc, flush_reg = 0 so flush is done only once */
+	{VDC_MAX, 0, DSC_IDX, SDE_HW_FLUSH_DSC,
+			vdc_flush_tbl}, /* SDE_HW_FLUSH_VDC */
+	{MERGE_3D_MAX, CTL_MERGE_3D_FLUSH, MERGE_3D_IDX, SDE_HW_FLUSH_MERGE_3D,
+			merge_3d_tbl}, /* SDE_HW_FLUSH_MERGE_3D */
+	{CDM_MAX, CTL_CDM_FLUSH, CDM_IDX, SDE_HW_FLUSH_CDM,
+			cdm_flush_tbl}, /* SDE_HW_FLUSH_CDM */
+	{CWB_MAX, CTL_CWB_FLUSH, CWB_IDX, SDE_HW_FLUSH_CWB,
+			cwb_flush_tbl}, /* SDE_HW_FLUSH_CWB */
+	{INTF_MAX, CTL_PERIPH_FLUSH, PERIPH_IDX, SDE_HW_FLUSH_PERIPH,
+			intf_flush_tbl }, /* SDE_HW_FLUSH_PERIPH */
+	{INTF_MAX, CTL_INTF_FLUSH, INTF_IDX, SDE_HW_FLUSH_INTF,
+			intf_flush_tbl } /* SDE_HW_FLUSH_INTF */
+};
+
 static struct sde_ctl_cfg *_ctl_offset(enum sde_ctl ctl,
 		struct sde_mdss_cfg *m,
 		void __iomem *addr,
@@ -485,162 +522,54 @@ static inline int sde_hw_ctl_update_bitmask_intf(struct sde_hw_ctl *ctx,
 	return 0;
 }
 
-static inline int sde_hw_ctl_update_bitmask_wb_v1(struct sde_hw_ctl *ctx,
+static inline int sde_hw_ctl_update_bitmask(struct sde_hw_ctl *ctx,
-		enum sde_wb wb, bool enable)
+		enum ctl_hw_flush_type type, u32 blk_idx, bool enable)
 {
+	int ret = 0;
+
 	if (!ctx)
 		return -EINVAL;
 
-	if (wb != WB_2) {
+	switch (type) {
-		SDE_ERROR("Unsupported wb %d\n", wb);
+	case SDE_HW_FLUSH_CDM:
-		return -EINVAL;
+		ret = sde_hw_ctl_update_bitmask_cdm(ctx, blk_idx, enable);
+		break;
+	case SDE_HW_FLUSH_WB:
+		ret = sde_hw_ctl_update_bitmask_wb(ctx, blk_idx, enable);
+		break;
+	case SDE_HW_FLUSH_INTF:
+		ret = sde_hw_ctl_update_bitmask_intf(ctx, blk_idx, enable);
+		break;
+	default:
+		break;
 	}
 
-	UPDATE_MASK(ctx->flush.pending_wb_flush_mask, wb_flush_tbl[wb], enable);
+	return ret;
-	if (ctx->flush.pending_wb_flush_mask)
-		UPDATE_MASK(ctx->flush.pending_flush_mask, WB_IDX, 1);
-	else
-		UPDATE_MASK(ctx->flush.pending_flush_mask, WB_IDX, 0);
-	return 0;
 }
 
-static inline int sde_hw_ctl_update_bitmask_intf_v1(struct sde_hw_ctl *ctx,
+static inline int sde_hw_ctl_update_bitmask_v1(struct sde_hw_ctl *ctx,
-		enum sde_intf intf, bool enable)
+		enum ctl_hw_flush_type type, u32 blk_idx, bool enable)
 {
-	if (!ctx)
+	const struct ctl_hw_flush_cfg *cfg;
+
+	if (!ctx || !(type < SDE_HW_FLUSH_MAX))
 		return -EINVAL;
 
-	if (!(intf > SDE_NONE) || !(intf < INTF_MAX)) {
+	cfg = &ctl_hw_flush_cfg_tbl_v1[type];
-		SDE_ERROR("Unsupported intf %d\n", intf);
+
+	if ((blk_idx <= SDE_NONE) || (blk_idx >= cfg->blk_max)) {
+		SDE_ERROR("Unsupported hw idx, type:%d, blk_idx:%d, blk_max:%d",
+				type, blk_idx, cfg->blk_max);
 		return -EINVAL;
 	}
 
-	UPDATE_MASK(ctx->flush.pending_intf_flush_mask, intf_flush_tbl[intf],
+	UPDATE_MASK(ctx->flush.pending_hw_flush_mask[cfg->flush_mask_idx],
-			enable);
+			cfg->flush_tbl[blk_idx], enable);
-	if (ctx->flush.pending_intf_flush_mask)
+	if (ctx->flush.pending_hw_flush_mask[cfg->flush_mask_idx])
-		UPDATE_MASK(ctx->flush.pending_flush_mask, INTF_IDX, 1);
+		UPDATE_MASK(ctx->flush.pending_flush_mask, cfg->flush_idx, 1);
 	else
-		UPDATE_MASK(ctx->flush.pending_flush_mask, INTF_IDX, 0);
+		UPDATE_MASK(ctx->flush.pending_flush_mask, cfg->flush_idx, 0);
-	return 0;
-}
 
-static inline int sde_hw_ctl_update_bitmask_periph_v1(struct sde_hw_ctl *ctx,
-		enum sde_intf intf, bool enable)
-{
-	if (!ctx)
-		return -EINVAL;
-
-	if (!(intf > SDE_NONE) || !(intf < INTF_MAX)) {
-		SDE_ERROR("Unsupported intf %d\n", intf);
-		return -EINVAL;
-	}
-
-	UPDATE_MASK(ctx->flush.pending_periph_flush_mask, intf_flush_tbl[intf],
-			enable);
-	if (ctx->flush.pending_periph_flush_mask)
-		UPDATE_MASK(ctx->flush.pending_flush_mask, PERIPH_IDX, 1);
-	else
-		UPDATE_MASK(ctx->flush.pending_flush_mask, PERIPH_IDX, 0);
-	return 0;
-}
-
-static inline int sde_hw_ctl_update_bitmask_dsc_v1(struct sde_hw_ctl *ctx,
-		enum sde_dsc dsc, bool enable)
-{
-	if (!ctx)
-		return -EINVAL;
-
-	if (!(dsc > SDE_NONE) || !(dsc < DSC_MAX)) {
-		SDE_ERROR("Unsupported dsc %d\n", dsc);
-		return -EINVAL;
-	}
-
-	UPDATE_MASK(ctx->flush.pending_dsc_flush_mask, dsc_flush_tbl[dsc],
-			enable);
-	if (ctx->flush.pending_dsc_flush_mask)
-		UPDATE_MASK(ctx->flush.pending_flush_mask, DSC_IDX, 1);
-	else
-		UPDATE_MASK(ctx->flush.pending_flush_mask, DSC_IDX, 0);
-	return 0;
-}
-
-static inline int sde_hw_ctl_update_bitmask_vdc(struct sde_hw_ctl *ctx,
-		enum sde_vdc vdc, bool enable)
-{
-	if (!ctx)
-		return -EINVAL;
-
-	if (!(vdc > SDE_NONE) || !(vdc < VDC_MAX)) {
-		SDE_ERROR("Unsupported vdc %d\n", vdc);
-		return -EINVAL;
-	}
-
-	UPDATE_MASK(ctx->flush.pending_dsc_flush_mask, vdc_flush_tbl[vdc],
-			enable);
-	if (ctx->flush.pending_dsc_flush_mask)
-		UPDATE_MASK(ctx->flush.pending_flush_mask, DSC_IDX, 1);
-	else
-		UPDATE_MASK(ctx->flush.pending_flush_mask, DSC_IDX, 0);
-	return 0;
-}
-
-static inline int sde_hw_ctl_update_bitmask_merge3d_v1(struct sde_hw_ctl *ctx,
-		enum sde_merge_3d merge_3d, bool enable)
-{
-	if (!ctx)
-		return -EINVAL;
-
-	if (!(merge_3d > SDE_NONE) || !(merge_3d < MERGE_3D_MAX)) {
-		SDE_ERROR("Unsupported merge_3d %d\n", merge_3d);
-		return -EINVAL;
-	}
-
-	UPDATE_MASK(ctx->flush.pending_merge_3d_flush_mask,
-			merge_3d_tbl[merge_3d], enable);
-	if (ctx->flush.pending_merge_3d_flush_mask)
-		UPDATE_MASK(ctx->flush.pending_flush_mask, MERGE_3D_IDX, 1);
-	else
-		UPDATE_MASK(ctx->flush.pending_flush_mask, MERGE_3D_IDX, 0);
-	return 0;
-}
-
-static inline int sde_hw_ctl_update_bitmask_cdm_v1(struct sde_hw_ctl *ctx,
-		enum sde_cdm cdm, bool enable)
-{
-	if (!ctx)
-		return -EINVAL;
-
-	if (cdm != CDM_0) {
-		SDE_ERROR("Unsupported cdm %d\n", cdm);
-		return -EINVAL;
-	}
-
-	UPDATE_MASK(ctx->flush.pending_cdm_flush_mask, cdm_flush_tbl[cdm],
-			enable);
-	if (ctx->flush.pending_cdm_flush_mask)
-		UPDATE_MASK(ctx->flush.pending_flush_mask, CDM_IDX, 1);
-	else
-		UPDATE_MASK(ctx->flush.pending_flush_mask, CDM_IDX, 0);
-	return 0;
-}
-
-static inline int sde_hw_ctl_update_bitmask_cwb_v1(struct sde_hw_ctl *ctx,
-		enum sde_cwb cwb, bool enable)
-{
-	if (!ctx)
-		return -EINVAL;
-
-	if ((cwb < CWB_1) || (cwb >= CWB_MAX)) {
-		SDE_ERROR("Unsupported cwb %d\n", cwb);
-		return -EINVAL;
-	}
-
-	UPDATE_MASK(ctx->flush.pending_cwb_flush_mask, cwb_flush_tbl[cwb],
-			enable);
-	if (ctx->flush.pending_cwb_flush_mask)
-		UPDATE_MASK(ctx->flush.pending_flush_mask, CWB_IDX, 1);
-	else
-		UPDATE_MASK(ctx->flush.pending_flush_mask, CWB_IDX, 0);
 	return 0;
 }
 
@@ -648,24 +577,21 @@ static inline int sde_hw_ctl_update_pending_flush_v1(
 		struct sde_hw_ctl *ctx,
 		struct sde_ctl_flush_cfg *cfg)
 {
-	int i;
+	int i = 0;
 
 	if (!ctx || !cfg)
 		return -EINVAL;
 
-	ctx->flush.pending_flush_mask |= cfg->pending_flush_mask;
+	for (i = 0; i < SDE_HW_FLUSH_MAX; i++)
-	ctx->flush.pending_intf_flush_mask |= cfg->pending_intf_flush_mask;
+		ctx->flush.pending_hw_flush_mask[i] |=
-	ctx->flush.pending_cdm_flush_mask |= cfg->pending_cdm_flush_mask;
+				cfg->pending_hw_flush_mask[i];
-	ctx->flush.pending_wb_flush_mask |= cfg->pending_wb_flush_mask;
+
-	ctx->flush.pending_dsc_flush_mask |= cfg->pending_dsc_flush_mask;
-	ctx->flush.pending_merge_3d_flush_mask |=
-		cfg->pending_merge_3d_flush_mask;
-	ctx->flush.pending_cwb_flush_mask |= cfg->pending_cwb_flush_mask;
-	ctx->flush.pending_periph_flush_mask |= cfg->pending_periph_flush_mask;
 	for (i = 0; i < CTL_MAX_DSPP_COUNT; i++)
 		ctx->flush.pending_dspp_flush_masks[i] |=
 				cfg->pending_dspp_flush_masks[i];
 
+	ctx->flush.pending_flush_mask |= cfg->pending_flush_mask;
+
 	return 0;
 }
 
@@ -708,34 +634,26 @@ static inline void _sde_hw_ctl_write_dspp_flushes(struct sde_hw_ctl *ctx) {
 
 static inline int sde_hw_ctl_trigger_flush_v1(struct sde_hw_ctl *ctx)
 {
+	int i = 0;
+
+	const struct ctl_hw_flush_cfg *cfg = &ctl_hw_flush_cfg_tbl_v1[0];
+
 	if (!ctx)
 		return -EINVAL;
 
-	if (ctx->flush.pending_flush_mask & BIT(WB_IDX))
-		SDE_REG_WRITE(&ctx->hw, CTL_WB_FLUSH,
-				ctx->flush.pending_wb_flush_mask);
-	if (ctx->flush.pending_flush_mask & BIT(DSC_IDX))
-		SDE_REG_WRITE(&ctx->hw, CTL_DSC_FLUSH,
-				ctx->flush.pending_dsc_flush_mask);
-	if (ctx->flush.pending_flush_mask & BIT(MERGE_3D_IDX))
-		SDE_REG_WRITE(&ctx->hw, CTL_MERGE_3D_FLUSH,
-				ctx->flush.pending_merge_3d_flush_mask);
-	if (ctx->flush.pending_flush_mask & BIT(CDM_IDX))
-		SDE_REG_WRITE(&ctx->hw, CTL_CDM_FLUSH,
-				ctx->flush.pending_cdm_flush_mask);
-	if (ctx->flush.pending_flush_mask & BIT(CWB_IDX))
-		SDE_REG_WRITE(&ctx->hw, CTL_CWB_FLUSH,
-				ctx->flush.pending_cwb_flush_mask);
-	if (ctx->flush.pending_flush_mask & BIT(INTF_IDX))
-		SDE_REG_WRITE(&ctx->hw, CTL_INTF_FLUSH,
-				ctx->flush.pending_intf_flush_mask);
-	if (ctx->flush.pending_flush_mask & BIT(PERIPH_IDX))
-		SDE_REG_WRITE(&ctx->hw, CTL_PERIPH_FLUSH,
-				ctx->flush.pending_periph_flush_mask);
 	if (ctx->flush.pending_flush_mask & BIT(DSPP_IDX))
 		_sde_hw_ctl_write_dspp_flushes(ctx);
 
+	for (i = 0; i < SDE_HW_FLUSH_MAX; i++)
+		if (cfg[i].flush_reg &&
+				ctx->flush.pending_flush_mask &
+				BIT(cfg[i].flush_idx))
+			SDE_REG_WRITE(&ctx->hw,
+					cfg[i].flush_reg,
+					ctx->flush.pending_hw_flush_mask[i]);
+
 	SDE_REG_WRITE(&ctx->hw, CTL_FLUSH, ctx->flush.pending_flush_mask);
+
 	return 0;
 }
 
@@ -1165,9 +1083,9 @@ static int sde_hw_ctl_reset_post_disable(struct sde_hw_ctl *ctx,
 
 	if (merge_3d_idx) {
 		/* disable and flush merge3d_blk */
-		ctx->flush.pending_merge_3d_flush_mask =
-			BIT(merge_3d_idx - MERGE_3D_0);
 		merge_3d_active &= ~BIT(merge_3d_idx - MERGE_3D_0);
+		ctx->flush.pending_hw_flush_mask[SDE_HW_FLUSH_MERGE_3D] =
+				BIT(merge_3d_idx - MERGE_3D_0);
 		UPDATE_MASK(ctx->flush.pending_flush_mask, MERGE_3D_IDX, 1);
 		SDE_REG_WRITE(c, CTL_MERGE_3D_ACTIVE, merge_3d_active);
 	}
@@ -1175,16 +1093,18 @@ static int sde_hw_ctl_reset_post_disable(struct sde_hw_ctl *ctx,
 	sde_hw_ctl_clear_all_blendstages(ctx);
 
 	if (cfg->intf_count) {
-		ctx->flush.pending_intf_flush_mask = intf_flush;
+		ctx->flush.pending_hw_flush_mask[SDE_HW_FLUSH_INTF] =
+				intf_flush;
 		UPDATE_MASK(ctx->flush.pending_flush_mask, INTF_IDX, 1);
 		SDE_REG_WRITE(c, CTL_INTF_ACTIVE, intf_active);
 	}
 
 	if (cfg->wb_count) {
-		ctx->flush.pending_wb_flush_mask = wb_flush;
+		ctx->flush.pending_hw_flush_mask[SDE_HW_FLUSH_WB] = wb_flush;
 		UPDATE_MASK(ctx->flush.pending_flush_mask, WB_IDX, 1);
 		SDE_REG_WRITE(c, CTL_WB_ACTIVE, wb_active);
 	}
+
 	return 0;
 }
 
@@ -1401,17 +1321,9 @@ static void _setup_ctl_ops(struct sde_hw_ctl_ops *ops,
 		ops->setup_intf_cfg_v1 = sde_hw_ctl_intf_cfg_v1;
 		ops->update_intf_cfg = sde_hw_ctl_update_intf_cfg;
 
-		ops->update_bitmask_cdm = sde_hw_ctl_update_bitmask_cdm_v1;
+		ops->update_bitmask = sde_hw_ctl_update_bitmask_v1;
-		ops->update_bitmask_wb = sde_hw_ctl_update_bitmask_wb_v1;
-		ops->update_bitmask_intf = sde_hw_ctl_update_bitmask_intf_v1;
-		ops->update_bitmask_dsc = sde_hw_ctl_update_bitmask_dsc_v1;
-		ops->update_bitmask_vdc = sde_hw_ctl_update_bitmask_vdc;
-		ops->update_bitmask_merge3d =
-			sde_hw_ctl_update_bitmask_merge3d_v1;
-		ops->update_bitmask_cwb = sde_hw_ctl_update_bitmask_cwb_v1;
-		ops->update_bitmask_periph =
-			sde_hw_ctl_update_bitmask_periph_v1;
 		ops->get_ctl_intf = sde_hw_ctl_get_intf_v1;
+
 		ops->reset_post_disable = sde_hw_ctl_reset_post_disable;
 		ops->get_scheduler_status = sde_hw_ctl_get_scheduler_status;
 		ops->read_active_status = sde_hw_ctl_read_active_status;
@@ -1421,9 +1333,7 @@ static void _setup_ctl_ops(struct sde_hw_ctl_ops *ops,
 
 		ops->setup_intf_cfg = sde_hw_ctl_intf_cfg;
 
-		ops->update_bitmask_cdm = sde_hw_ctl_update_bitmask_cdm;
+		ops->update_bitmask = sde_hw_ctl_update_bitmask;
-		ops->update_bitmask_wb = sde_hw_ctl_update_bitmask_wb;
-		ops->update_bitmask_intf = sde_hw_ctl_update_bitmask_intf;
 		ops->get_ctl_intf = sde_hw_ctl_get_intf;
 	}
 	ops->clear_pending_flush = sde_hw_ctl_clear_pending_flush;

msm/sde/sde_hw_ctl.h

@@ -39,6 +39,29 @@ enum sde_ctl_rot_op_mode {
 	SDE_CTL_ROT_OP_MODE_INLINE_ASYNC,
 };
 
+/**
+ * ctl_hw_flush_type - active ctl hw types
+ * SDE_HW_FLUSH_WB: WB block
+ * SDE_HW_FLUSH_DSC: DSC block
+ * SDE_HW_FLUSH_VDC: VDC bits of DSC block
+ * SDE_HW_FLUSH_MERGE_3D: Merge 3D block
+ * SDE_HW_FLUSH_CDM: CDM block
+ * SDE_HW_FLUSH_CWB: CWB block
+ * SDE_HW_FLUSH_PERIPH: Peripheral
+ * SDE_HW_FLUSH_INTF: Interface
+ */
+enum ctl_hw_flush_type {
+	SDE_HW_FLUSH_WB,
+	SDE_HW_FLUSH_DSC,
+	SDE_HW_FLUSH_VDC,
+	SDE_HW_FLUSH_MERGE_3D,
+	SDE_HW_FLUSH_CDM,
+	SDE_HW_FLUSH_CWB,
+	SDE_HW_FLUSH_PERIPH,
+	SDE_HW_FLUSH_INTF,
+	SDE_HW_FLUSH_MAX
+};
+
 struct sde_hw_ctl;
 /**
  * struct sde_hw_stage_cfg - blending stage cfg
@@ -128,24 +151,12 @@ struct sde_hw_intf_cfg_v1 {
  * CTL path version SDE_CTL_CFG_VERSION_1_0_0 has * two level flush mechanism
  * for lower pipe controls. individual control should be flushed before
  * exercising top level flush
- * @pending_intf_flush_mask: pending INTF flush
+ * @pending_hw_flush_mask: pending flush mask for each active HW blk
- * @pending_cdm_flush_mask: pending CDWN block flush
- * @pending_wb_flush_mask: pending writeback flush
- * @pending_dsc_flush_mask: pending dsc flush
- * @pending_merge_3d_flush_mask: pending 3d merge block flush
- * @pending_cwb_flush_mask: pending flush for concurrent writeback
- * @pending_periph_flush_mask: pending flush for peripheral module
  * @pending_dspp_flush_masks: pending flush masks for sub-blks of each DSPP
  */
 struct sde_ctl_flush_cfg {
 	u32 pending_flush_mask;
-	u32 pending_intf_flush_mask;
+	u32 pending_hw_flush_mask[SDE_HW_FLUSH_MAX];
-	u32 pending_cdm_flush_mask;
-	u32 pending_wb_flush_mask;
-	u32 pending_dsc_flush_mask;
-	u32 pending_merge_3d_flush_mask;
-	u32 pending_cwb_flush_mask;
-	u32 pending_periph_flush_mask;
 	u32 pending_dspp_flush_masks[CTL_MAX_DSPP_COUNT];
 };
 
@@ -352,30 +363,6 @@ struct sde_hw_ctl_ops {
 	int (*update_bitmask_dspp_subblk)(struct sde_hw_ctl *ctx,
 			enum sde_dspp dspp, u32 sub_blk, bool enable);
 
-	/**
-	 * update_bitmask_sspp: updates mask corresponding to sspp
-	 * @blk               : blk id
-	 * @enable            : true to enable, 0 to disable
-	 */
-	int (*update_bitmask_intf)(struct sde_hw_ctl *ctx,
-		enum sde_intf blk, bool enable);
-
-	/**
-	 * update_bitmask_sspp: updates mask corresponding to sspp
-	 * @blk               : blk id
-	 * @enable            : true to enable, 0 to disable
-	 */
-	int (*update_bitmask_cdm)(struct sde_hw_ctl *ctx,
-		enum sde_cdm blk, bool enable);
-
-	/**
-	 * update_bitmask_sspp: updates mask corresponding to sspp
-	 * @blk               : blk id
-	 * @enable            : true to enable, 0 to disable
-	 */
-	int (*update_bitmask_wb)(struct sde_hw_ctl *ctx,
-		enum sde_wb blk, bool enable);
-
 	/**
 	 * update_bitmask_sspp: updates mask corresponding to sspp
 	 * @blk               : blk id
@@ -385,44 +372,13 @@ struct sde_hw_ctl_ops {
 		enum sde_rot blk, bool enable);
 
 	/**
-	 * update_bitmask_dsc: updates mask corresponding to dsc
+	 * update_bitmask: updates flush mask
-	 * @blk               : blk id
+	 * @type              : blk type to flush
+	 * @blk_idx           : blk idx
 	 * @enable            : true to enable, 0 to disable
 	 */
-	int (*update_bitmask_dsc)(struct sde_hw_ctl *ctx,
+	int (*update_bitmask)(struct sde_hw_ctl *ctx,
-		enum sde_dsc blk, bool enable);
+			enum ctl_hw_flush_type type, u32 blk_idx, bool enable);
-
-	/**
-	 * update_bitmask_vdc: updates mask corresponding to vdc
-	 * @blk               : blk id
-	 * @enable            : true to enable, 0 to disable
-	 */
-	int (*update_bitmask_vdc)(struct sde_hw_ctl *ctx,
-		enum sde_vdc blk, bool enable);
-
-	/**
-	 * update_bitmask_merge3d: updates mask corresponding to merge_3d
-	 * @blk               : blk id
-	 * @enable            : true to enable, 0 to disable
-	 */
-	int (*update_bitmask_merge3d)(struct sde_hw_ctl *ctx,
-		enum sde_merge_3d blk, bool enable);
-
-	/**
-	 * update_bitmask_cwb: updates mask corresponding to cwb
-	 * @blk               : blk id
-	 * @enable            : true to enable, 0 to disable
-	 */
-	int (*update_bitmask_cwb)(struct sde_hw_ctl *ctx,
-		enum sde_cwb blk, bool enable);
-
-	/**
-	 * update_bitmask_periph: updates mask corresponding to peripheral
-	 * @blk               : blk id
-	 * @enable            : true to enable, 0 to disable
-	 */
-	int (*update_bitmask_periph)(struct sde_hw_ctl *ctx,
-		enum sde_intf blk, bool enable);
 
 	/**
 	 * read CTL_TOP register value and return