From f291b79d0d2c54b6611a13b8ca758b89bb82b934 Mon Sep 17 00:00:00 2001 From: Nagasai Bharat Gatkeshwar Sainoji Date: Tue, 3 Oct 2023 16:12:15 +0530 Subject: [PATCH] qcacmn: Fixes in assert cleanup in Spectral module Fix minor issues in assert cleanup and handle default case. Change-Id: Ib267c2df711d56875e4f2793096958d1c8e561c3 CRs-Fixed: 3615628 --- target_if/spectral/target_if_spectral_phyerr.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/target_if/spectral/target_if_spectral_phyerr.c b/target_if/spectral/target_if_spectral_phyerr.c index 9ccbb449ad..b4c9246ccf 100644 --- a/target_if/spectral/target_if_spectral_phyerr.c +++ b/target_if/spectral/target_if_spectral_phyerr.c @@ -2337,11 +2337,10 @@ target_if_spectral_get_bin_count_after_len_adj( fft_bin_count >>= 1; break; case SPECTRAL_FFTBIN_SIZE_NO_WAR: + fallthrough; + default: *fft_bin_size = 1; /* No length adjustment */ - break; - default: - return 0; } if (rpt_mode == 2 && swar->inband_fftbin_size_adj) @@ -2374,7 +2373,7 @@ target_if_process_sfft_report_gen3( if (!p_fft_report || !p_sfft || !rparams) { spectral_err("null params: p_fft_report %pK p_sfft %pK rparams %pK", p_fft_report, p_sfft, rparams); - return 1; + return -EINVAL; } /* @@ -2417,7 +2416,7 @@ target_if_process_sfft_report_gen3( default: spectral_err_rl("Invalid spectral report format: %d", rparams->version); - return 1; + return -EINVAL; } p_sfft->fft_peak_sidx = unsigned_to_signed(peak_sidx, 11);