Эх сурвалжийг харах

msm: camera: Correct the return logic for error case

Currently for the flush request error case, mutex unlock is
executed without mutex lock which result in instability of
system. This change returns with appropriate error code
if error occurs.

Change-Id: I2ff0056002c7d96a7100295f2ed6ba5cc0da2254
Signed-off-by: Jigarkumar Zala <[email protected]>
Jigarkumar Zala 6 жил өмнө
parent
commit
eedac0e21c

+ 2 - 4
drivers/cam_req_mgr/cam_req_mgr_core.c

@@ -3057,14 +3057,12 @@ int cam_req_mgr_flush_requests(
 
 
 	if (!flush_info) {
 	if (!flush_info) {
 		CAM_ERR(CAM_CRM, "flush req is NULL");
 		CAM_ERR(CAM_CRM, "flush req is NULL");
-		rc = -EFAULT;
-		goto end;
+		return -EFAULT;
 	}
 	}
 	if (flush_info->flush_type >= CAM_REQ_MGR_FLUSH_TYPE_MAX) {
 	if (flush_info->flush_type >= CAM_REQ_MGR_FLUSH_TYPE_MAX) {
 		CAM_ERR(CAM_CRM, "incorrect flush type %x",
 		CAM_ERR(CAM_CRM, "incorrect flush type %x",
 			flush_info->flush_type);
 			flush_info->flush_type);
-		rc = -EINVAL;
-		goto end;
+		return -EINVAL;
 	}
 	}
 
 
 	mutex_lock(&g_crm_core_dev->crm_lock);
 	mutex_lock(&g_crm_core_dev->crm_lock);