samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

msm: camera: common: Removing dead code from the camera driver

Browse Source 
Removing dead code from the camera driver code. While dumping camif reg
we were incorrectly updating register offset value, which is leading to
dead code. This change will fix those offset values.

CRs-Fixed: 3330567
Change-Id: I04b39bec05141f4dd194f73cc7423164817fec1d
Signed-off-by: Yash Upadhyay <quic_yupadhya@quicinc.com>
This commit is contained in:
Yash Upadhyay
2022-11-24 09:35:29 +05:30
committed by Camera Software Integration
parent 36601eebb9
commit ee6f0d4042
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/cam_isp/isp_hw_mgr/isp_hw/vfe_hw/vfe_bus/cam_vfe_bus_ver2.c
View File

@@ -3910,8 +3910,6 @@ int cam_vfe_bus_ver2_init(
return rc; return rc;
deinit_vfe_out: deinit_vfe_out:
if (i < 0)
i = CAM_VFE_BUS_VER2_VFE_OUT_MAX;
for (--i; i >= 0; i--) for (--i; i >= 0; i--)
cam_vfe_bus_deinit_vfe_out_resource(&bus_priv->vfe_out[i]); cam_vfe_bus_deinit_vfe_out_resource(&bus_priv->vfe_out[i]);

8
drivers/cam_isp/isp_hw_mgr/isp_hw/vfe_hw/vfe_top/cam_vfe_camif_lite_ver3.c
View File

@@ -498,10 +498,16 @@ dump_rdi_1:
camif_lite_priv->hw_intf->hw_idx); camif_lite_priv->hw_intf->hw_idx);
if (!soc_private->is_ife_lite) { if (!soc_private->is_ife_lite) {
for (offset = 0x9C00; offset <= 0x9DFC; offset += 0x4) { for (offset = 0x9C00; offset <= 0x9DFC; offset += 0x4) {
if (offset == 0x9C08)
offset = 0x9C60;
val = cam_soc_util_r(camif_lite_priv->soc_info, val = cam_soc_util_r(camif_lite_priv->soc_info,
0, offset); 0, offset);
CAM_INFO(CAM_ISP, "offset 0x%X value 0x%X", CAM_INFO(CAM_ISP, "offset 0x%X value 0x%X",
offset, val); offset, val);
if (offset == 0x9C60)
offset = 0x9C64;
else if (offset == 0x9C70)
offset = 0x9DEC;
} }
} else { } else {
for (offset = 0x1400; offset <= 0x15FC; offset += 0x4) { for (offset = 0x1400; offset <= 0x15FC; offset += 0x4) {
@@ -536,7 +542,7 @@ dump_rdi_2:
offset, val); offset, val);
if (offset == 0x9E60) if (offset == 0x9E60)
offset = 0x9E64; offset = 0x9E64;
else if (offset == 0x9E80) else if (offset == 0x9E70)
offset = 0x9FEC; offset = 0x9FEC;
} }
} else { } else {