Bladeren bron

qcacld-3.0: Replace typedef tSirSupChnl

The Linux Coding Style enumerates a few special cases where typedefs
are useful, but stresses "NEVER EVER use a typedef unless you can
clearly match one of those rules." The tSirSupChnl typedef does not
meet any of those criteria, so replace it (and the "tp" variant) with
a reference to the underlying struct.

Further note the Linux Coding Style frowns upon mixed-case names
and so-called Hungarian notation, so in conjunction rename the
underlying struct to be in compliance.

Change-Id: If9542312f3c12d03f05be3b364dba23c6509f9b0
CRs-Fixed: 2392450
Jeff Johnson 6 jaren geleden
bovenliggende
commit
ed4f4d52d9
2 gewijzigde bestanden met toevoegingen van 5 en 5 verwijderingen
  1. 4 4
      core/mac/inc/sir_api.h
  2. 1 1
      core/mac/src/pe/lim/lim_types.h

+ 4 - 4
core/mac/inc/sir_api.h

@@ -454,10 +454,10 @@ struct power_cap_info {
 };
 
 /* / Supported Channel info used in 11H */
-typedef struct sSirSupChnl {
+struct supported_channels {
 	uint8_t numChnl;
 	uint8_t channelList[SIR_MAX_SUPPORTED_CHANNEL_LIST];
-} tSirSupChnl, *tpSirSupChnl;
+};
 
 typedef enum eSirNwType {
 	eSIR_11A_NW_TYPE,
@@ -979,7 +979,7 @@ typedef struct sSirSmeJoinReq {
 	struct rrm_config_param rrm_config;
 	bool spectrumMgtIndicator;
 	struct power_cap_info powerCap;
-	tSirSupChnl supportedChannels;
+	struct supported_channels supportedChannels;
 	bool enable_bcast_probe_rsp;
 #ifdef WLAN_FEATURE_FILS_SK
 	struct cds_fils_connection_info fils_con_info;
@@ -1099,7 +1099,7 @@ typedef struct sSirSmeAssocInd {
 	/* spectrumMgtIndicator flag is set */
 	bool spectrumMgtIndicator;
 	struct power_cap_info powerCap;
-	tSirSupChnl supportedChannels;
+	struct supported_channels supportedChannels;
 	bool wmmEnabledSta; /* if present - STA is WMM enabled */
 	bool reassocReq;
 	/* Required for indicating the frames to upper layer */

+ 1 - 1
core/mac/src/pe/lim/lim_types.h

@@ -217,7 +217,7 @@ typedef struct sLimMlmAssocInd {
 	tSirMacCapabilityInfo capabilityInfo;
 	bool spectrumMgtIndicator;
 	struct power_cap_info powerCap;
-	tSirSupChnl supportedChannels;
+	struct supported_channels supportedChannels;
 	uint8_t sessionId;
 
 	bool WmmStaInfoPresent;