samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Fix KW Null dereferencing issues

Browse Source 
Fix static analysis KW issues related to
NULL dereferencing.
CRs-fixed: 2220248

Change-Id: Iecf37218782133eaf94f81d975478d71e308eca3
This commit is contained in:
sumedh baikady
2018-04-11 14:20:38 -07:00
committed by nshrivas
parent c6b4a7be50
commit eca2de6c6d
2 changed files with 19 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
dp/wifi3.0/dp_rx_mon_dest.c
View File

@@ -795,7 +795,13 @@ void dp_rx_mon_dest_process(struct dp_soc *soc, uint32_t mac_id, uint32_t quota)
ppdu_id, pdev->ppdu_info.com_info.ppdu_id); ppdu_id, pdev->ppdu_info.com_info.ppdu_id);
break; break;
} }
if (qdf_unlikely(head_msdu == NULL) ||
qdf_unlikely(tail_msdu == NULL)) {
QDF_TRACE(QDF_MODULE_ID_TXRX, QDF_TRACE_LEVEL_ERROR,
"%s %d : Head_msdu or Tail_msdu is NULL !!\n",
__func__, __LINE__);
break;
}
dp_rx_mon_deliver(soc, mac_id, head_msdu, tail_msdu); dp_rx_mon_deliver(soc, mac_id, head_msdu, tail_msdu);
rxdma_dst_ring_desc = hal_srng_dst_get_next(hal_soc, rxdma_dst_ring_desc = hal_srng_dst_get_next(hal_soc,

15
dp/wifi3.0/dp_rx_mon_status.c
View File

@@ -724,13 +724,22 @@ QDF_STATUS dp_rx_mon_status_buffers_replenish(struct dp_soc *dp_soc,
paddr = qdf_nbuf_get_frag_paddr(rx_netbuf, 0); paddr = qdf_nbuf_get_frag_paddr(rx_netbuf, 0);
next = (*desc_list)->next; next = (*desc_list)->next;
rxdma_ring_entry = hal_srng_src_get_next(dp_soc->hal_soc,
rxdma_srng);
if (qdf_unlikely(rxdma_ring_entry == NULL)) {
QDF_TRACE(QDF_MODULE_ID_DP, QDF_TRACE_LEVEL_ERROR,
"[%s][%d] rxdma_ring_entry is NULL, count - %d\n",
__func__, __LINE__, count);
qdf_nbuf_unmap_single(dp_soc->osdev, rx_netbuf,
QDF_DMA_BIDIRECTIONAL);
qdf_nbuf_free(rx_netbuf);
break;
}
(*desc_list)->rx_desc.nbuf = rx_netbuf; (*desc_list)->rx_desc.nbuf = rx_netbuf;
(*desc_list)->rx_desc.in_use = 1; (*desc_list)->rx_desc.in_use = 1;
count++; count++;
rxdma_ring_entry = hal_srng_src_get_next(dp_soc->hal_soc,
rxdma_srng);
hal_rxdma_buff_addr_info_set(rxdma_ring_entry, paddr, hal_rxdma_buff_addr_info_set(rxdma_ring_entry, paddr,
(*desc_list)->rx_desc.cookie, owner); (*desc_list)->rx_desc.cookie, owner);