Ver código fonte

qcacld-3.0: Do not log info on rx pkt deliver failure

Print is logged on rx packet deliver failure with
no relevant info since the skb is already freed.

Fix is to not log info on packet deliver to stack
failure.

Change-Id: I8f91a14030c76907d60e95ccbd19b600938ace90
CRs-Fixed: 2849093
Yeshwanth Sriram Guntuka 4 anos atrás
pai
commit
ebfe89570a

+ 3 - 7
core/hdd/src/wlan_hdd_ipa.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2013-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2013-2021 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -496,14 +496,10 @@ void hdd_ipa_send_nbuf_to_network(qdf_nbuf_t nbuf, qdf_netdev_t dev)
 	adapter->stats.rx_bytes += nbuf->len;
 
 	result = hdd_ipa_aggregated_rx_ind(nbuf);
-	if (result == NET_RX_SUCCESS) {
+	if (result == NET_RX_SUCCESS)
 		++adapter->hdd_stats.tx_rx_stats.rx_delivered[cpu_index];
-	} else {
+	else
 		++adapter->hdd_stats.tx_rx_stats.rx_refused[cpu_index];
-		DPTRACE(qdf_dp_log_proto_pkt_info(NULL, NULL, 0, 0, QDF_RX,
-						  QDF_TRACE_DEFAULT_MSDU_ID,
-						  QDF_TX_RX_STATUS_DROP));
-	}
 
 	/*
 	 * Restore PF_WAKE_UP_IDLE flag in the task structure

+ 2 - 7
core/hdd/src/wlan_hdd_softap_tx_rx.c

@@ -1174,15 +1174,10 @@ QDF_STATUS hdd_softap_rx_packet_cbk(void *adapter_context, qdf_nbuf_t rx_buf)
 
 		qdf_status = hdd_rx_deliver_to_stack(adapter, skb);
 
-		if (QDF_IS_STATUS_SUCCESS(qdf_status)) {
+		if (QDF_IS_STATUS_SUCCESS(qdf_status))
 			++adapter->hdd_stats.tx_rx_stats.rx_delivered[cpu_index];
-		} else {
+		else
 			++adapter->hdd_stats.tx_rx_stats.rx_refused[cpu_index];
-			DPTRACE(qdf_dp_log_proto_pkt_info(NULL, NULL, 0, 0,
-						      QDF_RX,
-						      QDF_TRACE_DEFAULT_MSDU_ID,
-						      QDF_TX_RX_STATUS_DROP));
-		}
 	}
 
 	return QDF_STATUS_SUCCESS;

+ 0 - 5
core/hdd/src/wlan_hdd_tx_rx.c

@@ -2673,11 +2673,6 @@ QDF_STATUS hdd_rx_packet_cbk(void *adapter_context,
 				hdd_tx_rx_collect_connectivity_stats_info(
 					skb, adapter,
 					PKT_TYPE_RX_REFUSED, &pkt_type);
-			DPTRACE(qdf_dp_log_proto_pkt_info(NULL, NULL, 0, 0,
-						      QDF_RX,
-						      QDF_TRACE_DEFAULT_MSDU_ID,
-						      QDF_TX_RX_STATUS_DROP));
-
 		}
 	}