samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacld-3.0: Remove hif_claim_device

Browse Source 
hif_claim_device does not serve a purpose in copy engine.
The usage and implementation of hif_claim_device need to be
reexamined for sdio and usb. It should not store the device
in a ce specific data structure.

Change-Id: I0847e152ae3a1ca57d5c6937d6929918063cc362
CRs-Fixed: 967244
This commit is contained in:
Houston Hoffman
2016-01-18 15:38:27 -08:00
committed by Akash Patel
parent ef86da0a95
commit ebc68145ac
5 changed files with 3 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
core/bmi/src/bmi.c
View File

@@ -1,5 +1,5 @@
/*
* copyright (c) 2014-2015 The Linux Foundation. All rights reserved.
* copyright (c) 2014-2016 The Linux Foundation. All rights reserved.
*
* Previously licensed under the ISC license by Qualcomm Atheros, Inc.
*
@@ -110,7 +110,6 @@ void bmi_cleanup(struct ol_softc *scn)
CDF_STATUS bmi_done(struct ol_softc *scn)
{
CDF_STATUS status = CDF_STATUS_SUCCESS;
hif_claim_device(scn, scn);
if (NO_BMI)
return status;

10
core/hif/inc/hif.h
View File

@@ -1,5 +1,5 @@
/*
* Copyright (c) 2013-2015 The Linux Foundation. All rights reserved.
* Copyright (c) 2013-2016 The Linux Foundation. All rights reserved.
*
* Previously licensed under the ISC license by Qualcomm Atheros, Inc.
*
@@ -394,14 +394,6 @@ typedef struct osdrv_callbacks {
*/
int hif_init(OSDRV_CALLBACKS *callbacks);
/*
* This API claims the HIF device and provides a context for handling removal.
* The device removal callback is only called when the OSDRV layer claims
* a device. The claimed context must be non-NULL */
void hif_claim_device(struct ol_softc *scn, void *claimedContext);
/* release the claimed device */
void hif_release_device(struct ol_softc *scn);
/* This API detaches the HTC layer from the HIF device */
void hif_detach_htc(struct ol_softc *scn);

14
core/hif/src/ce/ce_main.c
View File

@@ -872,20 +872,6 @@ static void hif_msg_callbacks_install(struct ol_softc *scn)
sizeof(hif_state->msg_callbacks_pending));
}
void hif_claim_device(struct ol_softc *scn, void *claimedContext)
{
struct HIF_CE_state *hif_state = (struct HIF_CE_state *)scn->hif_hdl;
hif_state->claimedContext = claimedContext;
}
void hif_release_device(struct ol_softc *scn)
{
struct HIF_CE_state *hif_state = (struct HIF_CE_state *)scn->hif_hdl;
hif_state->claimedContext = NULL;
}
void
hif_get_default_pipe(struct ol_softc *scn, uint8_t *ULPipe, uint8_t *DLPipe)
{

4
core/hif/src/ce/ce_main.h
View File

@@ -1,5 +1,5 @@
/*
* Copyright (c) 2015 The Linux Foundation. All rights reserved.
* Copyright (c) 2015-2016 The Linux Foundation. All rights reserved.
*
* Previously licensed under the ISC license by Qualcomm Atheros, Inc.
*
@@ -123,8 +123,6 @@ struct HIF_CE_state {
/* current msg callbacks in use */
struct hif_msg_callbacks msg_callbacks_current;
void *claimedContext;
/* Target address used to signal a pending firmware event */
uint32_t fw_indicator_address;

2
core/utils/epping/src/epping_main.c
View File

@@ -251,8 +251,6 @@ int epping_enable(struct device *parent_dev)
}
scn->htc_handle = pEpping_ctx->HTCHandle;
hif_claim_device(scn->hif_hdl, scn);
if (bmi_done(scn)) {
EPPING_LOG(CDF_TRACE_LEVEL_FATAL,
"%s: Failed to complete BMI phase", __func__);