samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Fix static analysis issue in ML AID free

Browse Source 
This change handles the scenario,if the caller passes invalid
link ix during AID free

Change-Id: I494cb55573ea5d8ecd351aac454d3395710273c1
CRs-Fixed: 3127458
This commit is contained in:
Srinivas Pitla
2022-02-10 09:28:44 -08:00
committed by Madan Koyyalamudi
parent 24c089c678
commit e8ea09fe28
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
umac/mlo_mgr/src/wlan_mlo_mgr_aid.c
View File

@@ -1,6 +1,6 @@
/* /*
* Copyright (c) 2021, The Linux Foundation. All rights reserved. * Copyright (c) 2021, The Linux Foundation. All rights reserved.
* Copyright (c) 2021 Qualcomm Innovation Center, Inc. All rights reserved. * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
* *
* Permission to use, copy, modify, and/or distribute this software for any * Permission to use, copy, modify, and/or distribute this software for any
* purpose with or without fee is hereby granted, provided that the above * purpose with or without fee is hereby granted, provided that the above
@@ -277,9 +277,15 @@ QDF_STATUS wlan_mlo_peer_free_aid(
} }
} }
} else { } else {
if ((link_ix != 0xff) && (link_ix < WLAN_UMAC_MLO_MAX_VDEVS)) {
vdev_aid_mgr = ml_aid_mgr->aid_mgr[link_ix]; vdev_aid_mgr = ml_aid_mgr->aid_mgr[link_ix];
if (vdev_aid_mgr) if (vdev_aid_mgr)
qdf_clear_bit(assoc_id_ix, vdev_aid_mgr->aid_bitmap); qdf_clear_bit(assoc_id_ix,
vdev_aid_mgr->aid_bitmap);
} else {
mlo_err("AID free failed, link ix(%d) is invalid for assoc_id %d",
link_ix, assoc_id);
}
} }
ml_aid_lock_release(mlo_mgr_ctx); ml_aid_lock_release(mlo_mgr_ctx);