From e79b8799c1eacfe80fd8e6def239dc707edba683 Mon Sep 17 00:00:00 2001 From: Karthik Kantamneni Date: Mon, 6 Dec 2021 15:41:24 +0530 Subject: [PATCH] qcacmn: Fix compilation error in flow control switch case logic In flow control code switch logic break statements are not used intentionally, but compiler is treating this as error. So to avoid compilation error add fall through comment. Change-Id: Ic79b75c48554182fba7c4c0f3885e3a44347e2e7 CRs-Fixed: 3090182 --- dp/wifi3.0/dp_tx_desc.h | 3 +++ dp/wifi3.0/dp_tx_flow_control.c | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/dp/wifi3.0/dp_tx_desc.h b/dp/wifi3.0/dp_tx_desc.h index 86fcdf79ac..1eaf8d506a 100644 --- a/dp/wifi3.0/dp_tx_desc.h +++ b/dp/wifi3.0/dp_tx_desc.h @@ -251,16 +251,19 @@ dp_tx_adjust_flow_pool_state(struct dp_soc *soc, soc->pause_cb(pool->flow_pool_id, WLAN_NETIF_PRIORITY_QUEUE_OFF, WLAN_DATA_FLOW_CTRL_PRI); + /* fallthrough */ case FLOW_POOL_VO_PAUSED: soc->pause_cb(pool->flow_pool_id, WLAN_NETIF_VO_QUEUE_OFF, WLAN_DATA_FLOW_CTRL_VO); + /* fallthrough */ case FLOW_POOL_VI_PAUSED: soc->pause_cb(pool->flow_pool_id, WLAN_NETIF_VI_QUEUE_OFF, WLAN_DATA_FLOW_CTRL_VI); + /* fallthrough */ case FLOW_POOL_BE_BK_PAUSED: soc->pause_cb(pool->flow_pool_id, diff --git a/dp/wifi3.0/dp_tx_flow_control.c b/dp/wifi3.0/dp_tx_flow_control.c index d12a82e013..341e794590 100644 --- a/dp/wifi3.0/dp_tx_flow_control.c +++ b/dp/wifi3.0/dp_tx_flow_control.c @@ -137,21 +137,25 @@ dp_tx_flow_ctrl_reset_subqueues(struct dp_soc *soc, soc->pause_cb(pool->flow_pool_id, WLAN_NETIF_PRIORITY_QUEUE_ON, WLAN_DATA_FLOW_CTRL_PRI); + /* fallthrough */ case FLOW_POOL_VO_PAUSED: soc->pause_cb(pool->flow_pool_id, WLAN_NETIF_VO_QUEUE_ON, WLAN_DATA_FLOW_CTRL_VO); + /* fallthrough */ case FLOW_POOL_VI_PAUSED: soc->pause_cb(pool->flow_pool_id, WLAN_NETIF_VI_QUEUE_ON, WLAN_DATA_FLOW_CTRL_VI); + /* fallthrough */ case FLOW_POOL_BE_BK_PAUSED: soc->pause_cb(pool->flow_pool_id, WLAN_NETIF_BE_BK_QUEUE_ON, WLAN_DATA_FLOW_CTRL_BE_BK); + /* fallthrough */ default: break; }