samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Set FIXUP_NBUF flag only on successful nbuf map

Browse Source 
In the scenario where nbuf_map fails during packet
send in htc_issue_packets, restore_tx_packet done
as part of cleanup, does nbuf unmap even though map
failed.

Fix is to set the fixup_netbuf flag only if nbuf map
is successful.

Change-Id: I642eff15792a7e374434e5a7a05ad546af376b3a
CRs-Fixed: 2625765
This commit is contained in:
Yeshwanth Sriram Guntuka
2020-02-19 18:05:22 +05:30
committed by nshrivas
parent e6d0730c6b
commit e71aeae1bd
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
htc/htc_send.c
View File

@@ -795,9 +795,6 @@ static QDF_STATUS htc_issue_packets(HTC_TARGET *target,
* frames, since data frames were already mapped as they * frames, since data frames were already mapped as they
* entered into the driver. * entered into the driver.
*/ */
pPacket->PktInfo.AsTx.Flags |=
HTC_TX_PACKET_FLAG_FIXUP_NETBUF;
ret = qdf_nbuf_map(target->osdev, ret = qdf_nbuf_map(target->osdev,
GET_HTC_PACKET_NET_BUF_CONTEXT(pPacket), GET_HTC_PACKET_NET_BUF_CONTEXT(pPacket),
QDF_DMA_TO_DEVICE); QDF_DMA_TO_DEVICE);
@@ -809,6 +806,8 @@ static QDF_STATUS htc_issue_packets(HTC_TARGET *target,
status = QDF_STATUS_E_FAILURE; status = QDF_STATUS_E_FAILURE;
break; break;
} }
pPacket->PktInfo.AsTx.Flags |=
HTC_TX_PACKET_FLAG_FIXUP_NETBUF;
} }
if (!pEndpoint->async_update) { if (!pEndpoint->async_update) {