samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacld-3.0: Free channel-list memory from Sap_context

Browse Source 
The driver allocates memory to channelist in the API
sap_get_channel_list, and stores the pointer to channel
list in sap_context, and frees the memory allocated for
the same in scan request callback.
But it may happen that before the callback, stop adapter
calls wlansap_context_put and frees the memory allocated
to sap context, without the mem free of channellist, which
results in a mem leak

Fix is to add a NULL check to sap context and free the memory
allocated to the sap context channel list in
sap_cleanup_channel_list.

Change-Id: I7030ca8325ae4c968db654bf14062e332f409b87
CRs-Fixed: 2254767
This commit is contained in:
gaurank kathpalia
2018-06-12 12:01:50 +05:30
committed by nshrivas
parent 2e28af52fc
commit e4a628f2d6
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
core/sap/src/sap_module.c
View File

@@ -228,6 +228,11 @@ void wlansap_context_put(struct sap_context *ctx)
for (i = 0; i < SAP_MAX_NUM_SESSION; i++) { for (i = 0; i < SAP_MAX_NUM_SESSION; i++) {
if (gp_sap_ctx[i] == ctx) { if (gp_sap_ctx[i] == ctx) {
if (qdf_atomic_dec_and_test(&sap_ctx_ref_count[i])) { if (qdf_atomic_dec_and_test(&sap_ctx_ref_count[i])) {
if (ctx->channelList) {
qdf_mem_free(ctx->channelList);
ctx->channelList = NULL;
ctx->num_of_channel = 0;
}
qdf_mem_free(ctx); qdf_mem_free(ctx);
gp_sap_ctx[i] = NULL; gp_sap_ctx[i] = NULL;
QDF_TRACE(QDF_MODULE_ID_SAP, QDF_TRACE(QDF_MODULE_ID_SAP,