samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Set osif priv to NULL when vdev comp object create fails

Browse Source 
In the normal execution osif priv is freed when the object manager
is freed. Whenever there is a error w.r.t to creation of vdev,
osifpriv is deleted as part of vdev destroy. When this error
propagated to caller. Caller tries to again free the osif_priv
in the error path.

Hence set osif priv to NULL in error case to prevent any double
free by caller.

Change-Id: Iaa074ad39aa473e99ab2fd7b14194422f19c168d
CRs-Fixed: 2467327
This commit is contained in:
Jeevan Kukkalli
2019-06-06 18:28:43 +05:30
committed by nshrivas
parent 6a2601a26c
commit e454174cf6
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
umac/cmn_services/obj_mgr/src/wlan_objmgr_vdev_obj.c
View File

@@ -249,6 +249,11 @@ struct wlan_objmgr_vdev *wlan_objmgr_vdev_obj_create(
wlan_objmgr_vdev_obj_delete(vdev); wlan_objmgr_vdev_obj_delete(vdev);
obj_mgr_err("VDEV comp objects creation failed for vdev-id:%d", obj_mgr_err("VDEV comp objects creation failed for vdev-id:%d",
vdev->vdev_objmgr.vdev_id); vdev->vdev_objmgr.vdev_id);
/*
* Set params osifp to NULL as it is freed during vdev obj
* delete, This prevents caller from performing double free.
*/
params->osifp = NULL;
return NULL; return NULL;
} }