samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

disp: msm: avoid using #ifdef for configurations

Browse Source 
Use #if IS_ENABLED() instead of #ifdef for configurations as vendor module
guidelines.

Use #if IS_ENABLED(CONFIG_XXX) instead of #ifdef CONFIG_XXX to ensure that
the code inside the #if block continues to compile if the config changes
to a tristate config in the future.

The differences are as follows:
	1.#if IS_ENABLED(CONFIG_XXX) evaluates to true when CONFIG_XXX is set to
		module (=m) or built-in (=y).
	2.#ifdef CONFIG_XXX evaluates to true when CONFIG_XXX is set to
		built-in(=y) , but doesn't when CONFIG_XXX is set to module(=m).
		Use this only when you're certain you want to do the same thing
		when the config is set to module or is disabled.

Change-Id: Ia806b9b01ad8414d0e4de027a382cb68e7fb4a6a
Signed-off-by: GG Hou <quic_renjhou@quicinc.com>
This commit is contained in:
GG Hou
2021-12-07 16:10:51 +08:00
parent f42f39e4f8
commit e29493c71d
29 changed files with 97 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
msm/sde/sde_rm.c
View File

@@ -1,5 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
* Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
* Copyright (c) 2016-2021, The Linux Foundation. All rights reserved.
*/
@@ -807,7 +808,7 @@ fail:
return rc;
}
#ifdef CONFIG_DEBUG_FS
#if IS_ENABLED(CONFIG_DEBUG_FS)
static int _sde_rm_status_show(struct seq_file *s, void *data)
{
struct sde_rm *rm;
@@ -853,7 +854,7 @@ void sde_rm_debugfs_init(struct sde_rm *sde_rm, struct dentry *parent)
void sde_rm_debugfs_init(struct sde_rm *rm, struct dentry *parent)
{
}
#endif
#endif /* CONFIG_DEBUG_FS */
int sde_rm_init(struct sde_rm *rm,
struct sde_mdss_cfg *cat,