samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacld-3.0: Replace typedef tSirSmeTsmIEInd

Browse Source 
The Linux Coding Style enumerates a few special cases where typedefs
are useful, but stresses "NEVER EVER use a typedef unless you can
clearly match one of those rules." The tSirSmeTsmIEInd typedef does
not meet any of those criteria, so replace it (and the "tp" variant)
with a reference to the underlying struct.

Further note the Linux Coding Style frowns upon mixed-case names
and so-called Hungarian notation, so in conjunction rename the
underlying struct to be in compliance.

Change-Id: I41b8b340fa3f781973d78edde3b54b7a5f0bd30d
CRs-Fixed: 2394254
This commit is contained in:
Jeff Johnson
2019-02-02 19:31:54 -08:00
committed by nshrivas
parent 35b68aae49
commit e21b0ebb12
3 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
core/mac/inc/sir_api.h
View File

@@ -784,10 +784,11 @@ struct tsm_ie {
uint16_t msmt_interval;
};
typedef struct sSirSmeTsmIEInd {
struct tsm_ie_ind {
struct tsm_ie tsm_ie;
uint8_t sessionId;
} tSirSmeTsmIEInd, *tpSirSmeTsmIEInd;
};
typedef struct sAniTrafStrmMetrics {
uint16_t UplinkPktQueueDly;
uint16_t UplinkPktQueueDlyHist[4];

7
core/mac/src/pe/lim/lim_assoc_utils.c
View File

@@ -4743,16 +4743,17 @@ void lim_send_sme_unprotected_mgmt_frame_ind(struct mac_context *mac, uint8_t fr
\param measurementInterval - measurement interval
\return none
-------------------------------------------------------------*/
void lim_send_sme_tsm_ie_ind(struct mac_context *mac, struct pe_session *pe_session,
void lim_send_sme_tsm_ie_ind(struct mac_context *mac,
struct pe_session *pe_session,
uint8_t tid, uint8_t state, uint16_t measInterval)
{
struct scheduler_msg mmhMsg = {0};
tpSirSmeTsmIEInd pSirSmeTsmIeInd = NULL;
struct tsm_ie_ind *pSirSmeTsmIeInd = NULL;
if (!mac || !pe_session)
return;
pSirSmeTsmIeInd = qdf_mem_malloc(sizeof(tSirSmeTsmIEInd));
pSirSmeTsmIeInd = qdf_mem_malloc(sizeof(*pSirSmeTsmIeInd));
if (!pSirSmeTsmIeInd)
return;

2
core/sme/src/common/sme_api.c
View File

@@ -1550,7 +1550,7 @@ send_plm_start:
* Return: QDF_STATUS enumeration
*/
static QDF_STATUS sme_tsm_ie_ind(struct mac_context *mac,
tSirSmeTsmIEInd *pSmeTsmIeInd)
struct tsm_ie_ind *pSmeTsmIeInd)
{
QDF_STATUS status = QDF_STATUS_SUCCESS;
struct csr_roam_info roam_info = { 0 };