Browse Source

qcacmn: Fix mem issue in reo desc shared table free

Fix use after free in detach path of REO shared table.

Change-Id: I9bba8f16e19f2e6a5217c78a633bbb57d1609edf
CRs-Fixed: 3184481
sumedh baikady 3 năm trước cách đây
mục cha
commit
e10617683d
1 tập tin đã thay đổi với 1 bổ sung2 xóa
  1. 1 2
      hal/wifi3.0/hal_srng.c

+ 1 - 2
hal/wifi3.0/hal_srng.c

@@ -1144,6 +1144,7 @@ extern void hal_detach(void *hal_soc)
 	struct hal_soc *hal = (struct hal_soc *)hal_soc;
 
 	hal_delayed_reg_write_deinit(hal);
+	hal_reo_shared_qaddr_detach((hal_soc_handle_t)hal);
 	qdf_mem_free(hal->ops);
 
 	qdf_mem_free_consistent(hal->qdf_dev, hal->qdf_dev->dev,
@@ -1154,8 +1155,6 @@ extern void hal_detach(void *hal_soc)
 		hal->shadow_wrptr_mem_vaddr, hal->shadow_wrptr_mem_paddr, 0);
 	qdf_minidump_remove(hal, sizeof(*hal), "hal_soc");
 
-	hal_reo_shared_qaddr_detach((hal_soc_handle_t)hal);
-
 	qdf_mem_free(hal);
 
 	return;